)]}'
{"README.rst":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"1c5ed10fd270523ea6d7938bde23a5dbaf838f07","unresolved":false,"context_lines":[{"line_number":55,"context_line":"``export OS_REGION_NAME``). It defaults to the first in the list returned."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Argument ``--profile`` will be availalbe only when osprofiler lib is installed"},{"line_number":58,"context_line":"on the client sdie."},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"You\u0027ll find complete documentation on the shell by running"},{"line_number":61,"context_line":"``trove help``::"}],"source_content_type":"text/x-rst","patch_set":10,"id":"5a890539_dc0f5dde","line":58,"updated":"2014-12-04 10:37:47.000000000","message":"availalbe \u003d\u003e available\nsdie \u003d\u003e side\n\nWhat is \"client side\" supposed to mean? This is the client codebase, so it\u0027s probably sufficient to just say:\n\n\"Argument ``--profile`` is available only when the osprofiler lib is installed.\"","commit_id":"cd802ff8106e5ed72e15328f883767f22c53f53d"}],"troveclient/client.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"cb7224f41b27a357da89d47dad7243e2daa31df4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from keystoneclient import adapter"},{"line_number":29,"context_line":"from troveclient.openstack.common.apiclient import client"},{"line_number":30,"context_line":"from troveclient.openstack.common.apiclient import exceptions"},{"line_number":31,"context_line":"from troveclient.openstack.common import importutils"},{"line_number":32,"context_line":"from troveclient import service_catalog"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_9fdd5573","line":31,"updated":"2014-12-09 19:19:14.000000000","message":"This should be added to openstack-common.conf","commit_id":"c6109305c98cb372fc3a01dd37e10ccc3bfb686f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"bbaeef91d11019870684724d8c75948894858c4b","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from keystoneclient import adapter"},{"line_number":29,"context_line":"from troveclient.openstack.common.apiclient import client"},{"line_number":30,"context_line":"from troveclient.openstack.common.apiclient import exceptions"},{"line_number":31,"context_line":"from troveclient.openstack.common import importutils"},{"line_number":32,"context_line":"from troveclient import service_catalog"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"try:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a961159_ea15b9e5","line":31,"in_reply_to":"3a961159_9fdd5573","updated":"2014-12-09 19:46:02.000000000","message":"Done.","commit_id":"c6109305c98cb372fc3a01dd37e10ccc3bfb686f"}],"troveclient/shell.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"63c11618d61e99698077611e90e50ae76b234cd8","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":233,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":234,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":235,"context_line":"                                \u0027trove, it specified in paste configuration \u0027"},{"line_number":236,"context_line":"                                \u0027file at /etc/trove/api-paste.ini. \u0027"},{"line_number":237,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":238,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_2b75fa97","line":235,"updated":"2014-11-12 20:19:39.000000000","message":"Just a minor nit in the wording here. For consistency sake, I think its better to call this \u0027Trove\u0027 instead of trove. Also.\n\nMissing \u0027is\u0027 from the sentence .\"This key should be the value of the HMAC key configured in osprofiler middleware in Trove. It is specified in the paste configuration file at /etc/trove/api-paste.ini\"\n\n\nThanks.","commit_id":"fb2f4a55e7ae83f2945f02755e03ee57acda7e1f"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"267b1ea498ddab998254159d74b3b08a715f37f6","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":233,"context_line":"                                \u0027This key should be the value of HMAC key \u0027"},{"line_number":234,"context_line":"                                \u0027configured in osprofiler middleware in \u0027"},{"line_number":235,"context_line":"                                \u0027trove, it specified in paste configuration \u0027"},{"line_number":236,"context_line":"                                \u0027file at /etc/trove/api-paste.ini. \u0027"},{"line_number":237,"context_line":"                                \u0027Without key the profiling will not be \u0027"},{"line_number":238,"context_line":"                                \u0027triggered even if osprofiler is enabled \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_07cfc156","line":235,"in_reply_to":"5a890539_2b75fa97","updated":"2014-11-18 12:01:02.000000000","message":"Done","commit_id":"fb2f4a55e7ae83f2945f02755e03ee57acda7e1f"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"2e3e111896644ba971b158dbd7cc7bcb1570406e","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                 \u0027Defaults to env[OS_JSON_OUTPUT].\u0027)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if osprofiler_profiler:"},{"line_number":229,"context_line":"            parser.add_argument(\u0027--profile\u0027,"},{"line_number":230,"context_line":"                                metavar\u003d\u0027HMAC_KEY\u0027,"},{"line_number":231,"context_line":"                                help\u003d\u0027HMAC key to use for encrypting context \u0027"},{"line_number":232,"context_line":"                                \u0027data for performance profiling of operation. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_a35d77ee","line":229,"updated":"2014-12-02 09:48:00.000000000","message":"A couple of quick comments:\n\n1. --profile sounds like a boolean (i.e. turn profiling on or off), but you\u0027re expecting a HMAC_KEY to be passed as an arg. Can we call this --profile-hmac-key, or --profile-key to better convey this?\n\n2. It might be useful to set up a default ENV variable for this so that one doesn\u0027t have to keep passing the value in from the commandline every single time.","commit_id":"2dbf7df7ae59d8c5afe99ace1f399685ba7a151b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"4e2b6e44d15f21c3358f876b8068efd023ea808a","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                 \u0027Defaults to env[OS_JSON_OUTPUT].\u0027)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if osprofiler_profiler:"},{"line_number":229,"context_line":"            parser.add_argument(\u0027--profile\u0027,"},{"line_number":230,"context_line":"                                metavar\u003d\u0027HMAC_KEY\u0027,"},{"line_number":231,"context_line":"                                help\u003d\u0027HMAC key to use for encrypting context \u0027"},{"line_number":232,"context_line":"                                \u0027data for performance profiling of operation. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_c7dc2677","line":229,"in_reply_to":"5a890539_59acc48c","updated":"2014-12-03 08:16:40.000000000","message":"Sounds good. Thanks!","commit_id":"2dbf7df7ae59d8c5afe99ace1f399685ba7a151b"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"3c698726380d153e63dd83d037262a2d9ade69d9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                                 \u0027Defaults to env[OS_JSON_OUTPUT].\u0027)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        if osprofiler_profiler:"},{"line_number":229,"context_line":"            parser.add_argument(\u0027--profile\u0027,"},{"line_number":230,"context_line":"                                metavar\u003d\u0027HMAC_KEY\u0027,"},{"line_number":231,"context_line":"                                help\u003d\u0027HMAC key to use for encrypting context \u0027"},{"line_number":232,"context_line":"                                \u0027data for performance profiling of operation. \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a890539_59acc48c","line":229,"in_reply_to":"5a890539_a35d77ee","updated":"2014-12-02 10:50:06.000000000","message":"\u003e\u003e point #1.\n\nimho, it\u0027d be better if we keep this argument be consistent from cross-project\u0027s perspective. [0][1].\n\n[0] https://github.com/openstack/python-glanceclient/blob/master/glanceclient/shell.py#L265\n\n[1] https://github.com/openstack/python-cinderclient/blob/master/cinderclient/shell.py#L203\n\n\u003e\u003e point #2\n\nOK, it seems good, will do.\n\nThanks for review and input!","commit_id":"2dbf7df7ae59d8c5afe99ace1f399685ba7a151b"}]}
