)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"9447e8f6ab793af050216ea78eb5a34028a793ef","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anna Philips \u003cms.annaphilips@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-12-29 16:29:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add datastore version and type to backup-list and backup-show"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7ca912fa04df94126f509e85e9631d1be1ccaf13"},{"line_number":10,"context_line":"Closes-Bug: 1340367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_e6f19b02","line":7,"updated":"2014-12-29 16:57:35.000000000","message":"hey anna you will need a description.\n\nHere are some guidelines to commit messages - https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"068b1d7e66917a65f398061e165c1c63e0665602"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bec34f6fa1fafce2a0b2df71c214b0e1f53c78f2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add datastore version and type to backup-list and backup-show"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7ca912fa04df94126f509e85e9631d1be1ccaf13"},{"line_number":10,"context_line":"Closes-Bug: 1340367"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a961159_dc6c6ed3","line":10,"updated":"2014-12-29 18:35:49.000000000","message":"The guidelines are also to include the bug number preceded with a \u0027#\u0027.\n\nSome tools parse based on that. A description of this is in the document that Iccha referenced.","commit_id":"068b1d7e66917a65f398061e165c1c63e0665602"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bec34f6fa1fafce2a0b2df71c214b0e1f53c78f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3a961159_fc7f6a64","line":11,"updated":"2014-12-29 18:35:49.000000000","message":"Does this have a doc-impact?","commit_id":"068b1d7e66917a65f398061e165c1c63e0665602"}],"troveclient/v1/shell.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bec34f6fa1fafce2a0b2df71c214b0e1f53c78f2","unresolved":false,"context_lines":[{"line_number":489,"context_line":"def do_backup_show(cs, args):"},{"line_number":490,"context_line":"    \"\"\"Shows details of a backup.\"\"\""},{"line_number":491,"context_line":"    backup \u003d _find_backup(cs, args.backup)"},{"line_number":492,"context_line":"    backup._info[\u0027datastore\u0027] \u003d backup.datastore[\u0027type\u0027]"},{"line_number":493,"context_line":"    backup._info[\u0027datastore_version\u0027] \u003d backup.datastore[\u0027version\u0027]"},{"line_number":494,"context_line":"    _print_object(backup)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_dca38efe","line":492,"updated":"2014-12-29 18:35:49.000000000","message":"minor thing but for consistency would you rename this to \u0027datastore_type\u0027 instead of \u0027datastore\u0027.","commit_id":"068b1d7e66917a65f398061e165c1c63e0665602"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"bec34f6fa1fafce2a0b2df71c214b0e1f53c78f2","unresolved":false,"context_lines":[{"line_number":529,"context_line":"        if hasattr(backup, \u0027datastore\u0027):"},{"line_number":530,"context_line":"            setattr(backup, \u0027datastore_version\u0027,"},{"line_number":531,"context_line":"                    backup.datastore[\u0027version\u0027])"},{"line_number":532,"context_line":"            setattr(backup, \u0027datastore\u0027, backup.datastore[\u0027type\u0027])"},{"line_number":533,"context_line":"    utils.print_list(backups, [\u0027id\u0027, \u0027instance_id\u0027, \u0027name\u0027, \u0027datastore\u0027, \u0027datastore_version\u0027,"},{"line_number":534,"context_line":"                               \u0027status\u0027, \u0027parent_id\u0027, \u0027updated\u0027],"},{"line_number":535,"context_line":"                     order_by\u003d\u0027updated\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3caad2d2","line":532,"updated":"2014-12-29 18:35:49.000000000","message":"would you please rename to datastore_type for consistency with the other change you are making for datastore_version.","commit_id":"068b1d7e66917a65f398061e165c1c63e0665602"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"b01ee7efef759b36c5907032c4c64a4425e7760d","unresolved":false,"context_lines":[{"line_number":489,"context_line":"def do_backup_show(cs, args):"},{"line_number":490,"context_line":"    \"\"\"Shows details of a backup.\"\"\""},{"line_number":491,"context_line":"    backup \u003d _find_backup(cs, args.backup)"},{"line_number":492,"context_line":"    backup._info[\u0027datastore_type\u0027] \u003d backup.datastore[\u0027type\u0027]"},{"line_number":493,"context_line":"    backup._info[\u0027datastore_version\u0027] \u003d backup.datastore[\u0027version\u0027]"},{"line_number":494,"context_line":"    _print_object(backup)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_97217cb6","line":492,"updated":"2015-01-14 22:42:16.000000000","message":"I\u0027m going to question the consistency thing - when I do a \u0027trove show\u0027 or \u0027trove list\u0027 the heading is \u0027Datastore\u0027 not \u0027Datastore Type\u0027\n\nWhere else is \u0027Datastore Type\u0027 used?\n\nMy vote is to go back to just using \u0027Datastore\u0027 :) If that doesn\u0027t happen, then at least null out the existing datastore attribute in the show command (which is now printed out as a dictionary)\n\nOtherwise it looks good and works.","commit_id":"84f4343c7e3bb6291de399b48dfed5d448b64305"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b23ac2c58cac2d532dd52f8f2acbd5c73aac1e69","unresolved":false,"context_lines":[{"line_number":489,"context_line":"def do_backup_show(cs, args):"},{"line_number":490,"context_line":"    \"\"\"Shows details of a backup.\"\"\""},{"line_number":491,"context_line":"    backup \u003d _find_backup(cs, args.backup)"},{"line_number":492,"context_line":"    backup._info[\u0027datastore_type\u0027] \u003d backup.datastore[\u0027type\u0027]"},{"line_number":493,"context_line":"    backup._info[\u0027datastore_version\u0027] \u003d backup.datastore[\u0027version\u0027]"},{"line_number":494,"context_line":"    _print_object(backup)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_62ff2e68","line":492,"in_reply_to":"3a961159_97217cb6","updated":"2015-02-03 01:21:18.000000000","message":"Needs to be consistent, I would +1 for Datastore, something similar to trove list/show","commit_id":"84f4343c7e3bb6291de399b48dfed5d448b64305"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d016583c769dee1d1a5409b6e3c49648ff1eb293","unresolved":false,"context_lines":[{"line_number":489,"context_line":"def do_backup_show(cs, args):"},{"line_number":490,"context_line":"    \"\"\"Shows details of a backup.\"\"\""},{"line_number":491,"context_line":"    backup \u003d _find_backup(cs, args.backup)"},{"line_number":492,"context_line":"    backup._info[\u0027datastore_type\u0027] \u003d backup.datastore[\u0027type\u0027]"},{"line_number":493,"context_line":"    backup._info[\u0027datastore_version\u0027] \u003d backup.datastore[\u0027version\u0027]"},{"line_number":494,"context_line":"    _print_object(backup)"},{"line_number":495,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_694a3bae","line":492,"in_reply_to":"3a961159_97217cb6","updated":"2015-01-16 10:24:37.000000000","message":"sounds like the second option would make the output and the variables consistent, no?","commit_id":"84f4343c7e3bb6291de399b48dfed5d448b64305"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5a76e919601a834088bcc4e8b1c164c619eacb8c","unresolved":false,"context_lines":[{"line_number":526,"context_line":"        wrapper \u003d cs.backups.list(marker\u003dwrapper.next)"},{"line_number":527,"context_line":"        backups +\u003d wrapper.items"},{"line_number":528,"context_line":"    for backup in backups:"},{"line_number":529,"context_line":"        if hasattr(backup, \u0027datastore\u0027):"},{"line_number":530,"context_line":"            setattr(backup, \u0027datastore_version\u0027,"},{"line_number":531,"context_line":"                    backup.datastore[\u0027version\u0027])"},{"line_number":532,"context_line":"            setattr(backup, \u0027datastore_type\u0027, backup.datastore[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_676410b3","line":529,"updated":"2015-01-08 15:21:59.000000000","message":"i wonder in which cases backup response object would not contain datastore and its version?\n\nIIRC datastore and version are now parts of backup response object, see https://github.com/openstack/trove/blob/master/trove/backup/views.py#L37-L42","commit_id":"84f4343c7e3bb6291de399b48dfed5d448b64305"}]}