)]}'
{"troveclient/tests/fakes.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"920bad9efcfdd3e4b7c3ccf56ffa82a812df45a1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright [2015] Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_c60862dc","line":1,"updated":"2015-05-25 14:17:01.000000000","message":"I don\u0027t know about HP\u0027s format for a copyright but I believe it does not include putting the year in [ ]","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a38e82dd038e5e1c24b96b868311af25d5c5c53a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    keys \u003d dict.keys()"},{"line_number":29,"context_line":"    for k in required:"},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            assert k in keys"},{"line_number":32,"context_line":"        except AssertionError:"},{"line_number":33,"context_line":"            extra_keys \u003d set(keys).difference(set(required + optional))"},{"line_number":34,"context_line":"            raise AssertionError(\"found unexpected keys: %s\" %"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_76d3bc60","line":31,"updated":"2015-05-22 21:12:19.000000000","message":"What exactly is this doing? It iterates over \u0027required\u0027 keys and fails if a required key is not in the dict. It however fails with exception saying that an unexpected keys were found.\n\nIs the logic here really ok?","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"920bad9efcfdd3e4b7c3ccf56ffa82a812df45a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            assert k in keys"},{"line_number":32,"context_line":"        except AssertionError:"},{"line_number":33,"context_line":"            extra_keys \u003d set(keys).difference(set(required + optional))"},{"line_number":34,"context_line":"            raise AssertionError(\"found unexpected keys: %s\" %"},{"line_number":35,"context_line":"                                 list(extra_keys))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_260296b5","line":34,"updated":"2015-05-25 14:17:01.000000000","message":"I am puzzled by this logic because the error you are raising seems to imply just the opposite of what the code seems to be checking for.\n\ni.e. the error I\u0027d have expected would have been k not found in dict.","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"a38e82dd038e5e1c24b96b868311af25d5c5c53a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            \"Expected %s %s but no calls were made.\" % expected"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        found \u003d False"},{"line_number":70,"context_line":"        for entry in self.client.callstack:"},{"line_number":71,"context_line":"            if expected \u003d\u003d entry[0:2]:"},{"line_number":72,"context_line":"                found \u003d True"},{"line_number":73,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_36dc2445","line":70,"updated":"2015-05-22 21:12:19.000000000","message":"Could not we just check that \u0027[entry for entry in self.client.callstack if expected \u003d\u003d entry[0:2]]\u0027 is empty? \n\nAlternatively, it could be like \u0027any([expected \u003d\u003d entry[0:2] for entry in self.client.callstack])\u0027, but I personally prefer the former.","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"}],"troveclient/tests/test_v1_shell.py":[{"author":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"change_message_id":"8c37c1977fc027bdb597265ee02d056c114e92b3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import troveclient.client"},{"line_number":21,"context_line":"from troveclient import exceptions"},{"line_number":22,"context_line":"import troveclient.shell"},{"line_number":23,"context_line":"from troveclient.tests import fakes"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_d5329f5d","line":20,"updated":"2015-05-22 19:06:51.000000000","message":"I think this should go troveclient then troveclient.client","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"920bad9efcfdd3e4b7c3ccf56ffa82a812df45a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.shell \u003d troveclient.shell.OpenStackTroveShell()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def tearDown(self):"},{"line_number":34,"context_line":"        # For some method like test_image_meta_bad_action we are"},{"line_number":35,"context_line":"        # testing a SystemExit to be thrown and object self.shell has"},{"line_number":36,"context_line":"        # no time to get instantatiated which is OK in this case, so"},{"line_number":37,"context_line":"        # we make sure the method is there before launching it."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a016987_66cd2e86","line":34,"updated":"2015-05-25 14:17:01.000000000","message":"Is this comment relevant?","commit_id":"065a315cf5310238fe16b55b876ca745848b0d86"}]}