)]}'
{"id":"openstack%2Fpython-troveclient~187906","triplet_id":"openstack%2Fpython-troveclient~master~Ib040b69d31956231f1f6de57775d613fa8fdda7f","project":"openstack/python-troveclient","branch":"master","topic":"master","hashtags":[],"change_id":"Ib040b69d31956231f1f6de57775d613fa8fdda7f","subject":"Added more unit-tests to improve code coverage","status":"ABANDONED","created":"2015-06-03 08:35:04.000000000","updated":"2015-06-08 10:52:15.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2809b07a963d4fc7382cc36795906cfbc116ae92","_number":187906,"virtual_id_number":187906,"owner":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":-1,"date":"2015-06-08 09:09:40.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-04 18:21:52.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2015-06-04 18:24:08.000000000","updated_by":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"reviewer":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"state":"REVIEWER"},{"updated":"2015-06-04 20:26:45.000000000","updated_by":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"reviewer":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"state":"REVIEWER"},{"updated":"2015-06-04 23:03:52.000000000","updated_by":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"reviewer":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"state":"REVIEWER"},{"updated":"2015-06-05 17:44:32.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2015-06-05 18:34:44.000000000","updated_by":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"reviewer":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"state":"REVIEWER"},{"updated":"2015-06-08 09:09:40.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b974d2c920fc39e3f2f73352b9f5c4347f4e36e8","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-06-03 08:35:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"189d42dd98534c12e0645c6b80a397b69d37e396","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-03 10:46:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-python26 http://logs.openstack.org/06/187906/1/check/gate-python-troveclient-python26/cf77356/ : SUCCESS in 1m 35s\n- gate-python-troveclient-pep8 http://logs.openstack.org/06/187906/1/check/gate-python-troveclient-pep8/07b7605/ : SUCCESS in 1m 00s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/06/187906/1/check/gate-python-troveclient-docs/39f88fa//doc/build/html/ : SUCCESS in 57s\n- gate-python-troveclient-python27 http://logs.openstack.org/06/187906/1/check/gate-python-troveclient-python27/20b1f02/ : SUCCESS in 1m 22s\n- gate-python-troveclient-python34 http://logs.openstack.org/06/187906/1/check/gate-python-troveclient-python34/0aae4dd/ : SUCCESS in 1m 14s\n- gate-python-troveclient-pypy http://logs.openstack.org/06/187906/1/check/gate-python-troveclient-pypy/7993ae5/ : SUCCESS in 3m 19s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/06/187906/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/ca22bb5/ : SUCCESS in 51m 26s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/06/187906/1/check/gate-trove-functional-dsvm-mysql/8dcb2e8/ : SUCCESS in 1h 17m 59s","accounts_in_message":[],"_revision_number":1},{"id":"932adeb33e7a3725804ae437a482859a052b3333","author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"date":"2015-06-04 18:21:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"0fe0d1ec8c4522b56f772e4c2064b54ccebf94f6","author":{"_account_id":1870,"name":"Anna Shen","email":"ruiyuan.shen@hp.com","username":"ruiyuan-shen"},"date":"2015-06-04 18:24:08.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f60ad976d19f6b5015a2a58c31e5705d75c6e8d4","author":{"_account_id":14991,"name":"Mayuri Ganguly","email":"mayuri.ganguly@hpe.com","username":"gangulma"},"date":"2015-06-04 20:26:45.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"9554a55855e5c8135e13a79e658bd8fa11ab86ff","author":{"_account_id":13355,"name":"Edmond Kotowski","email":"ekotowski@gmail.com","username":"ekotowski"},"date":"2015-06-04 23:03:52.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"da662c7444c06a34ae936b4f4413b8c84c8a2b17","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2015-06-05 17:44:32.000000000","message":"Patch Set 1: Code-Review+1\n\nI get it that we\u0027re adding more unit tests but this review and https://review.openstack.org/#/c/183822/ are both about unit tests for the client.\n\nWould it make sense to try and reduce the proliferation of reviews and consolidate these changes. I\u0027m sure the CI system would appreciate it as well.","accounts_in_message":[],"_revision_number":1},{"id":"95a83f97e0b9cde651c1f0a84167fa446eb54645","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-06-05 17:47:49.000000000","message":"Patch Set 1:\n\nI can merge the two changes but still it would be take two runs on ci-gates as it would now take one run for each of two commits, Kindly confirm.","accounts_in_message":[],"_revision_number":1},{"id":"49d0eb839fe6ba56fe8591da063e12e5640c64f0","author":{"_account_id":14912,"name":"Ashleigh Farnham","email":"ashleighfarnham@gmail.com"},"date":"2015-06-05 18:34:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"0a1ea24eca8377a7ff87dad7b88730c11fe327e1","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-06-08 07:31:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"1137060f4d25e468da731b5938f46e8ca90b5731","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-06-08 09:09:40.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-requirements http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-requirements/cd02138/ : SUCCESS in 15s\n- gate-python-troveclient-python26 http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-python26/89029cb/ : SUCCESS in 1m 04s\n- gate-python-troveclient-pep8 http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-pep8/7eccec4/ : SUCCESS in 52s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/06/187906/2/check/gate-python-troveclient-docs/6e0bb32//doc/build/html/ : SUCCESS in 1m 03s\n- gate-python-troveclient-python27 http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-python27/290fd94/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python34 http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-python34/50d528b/ : SUCCESS in 1m 11s\n- gate-python-troveclient-pypy http://logs.openstack.org/06/187906/2/check/gate-python-troveclient-pypy/a25e1c7/ : SUCCESS in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/06/187906/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/fe9be98/ : SUCCESS in 51m 15s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/06/187906/2/check/gate-trove-functional-dsvm-mysql/b9583b9/ : FAILURE in 1h 33m 50s","accounts_in_message":[],"_revision_number":2},{"id":"f23a3d3adf6419dea994064a918fc066a5b4eead","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-06-08 10:52:15.000000000","message":"Abandoned\n\nmerged to https://review.openstack.org/#/c/183822/ as suggested by reviewers","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f22ce3d8616ff4db8f45e512b024d10ee93a1aca","revisions":{"6636add3ab4aa09aa351e23c2e96254f9542f7e7":{"kind":"REWORK","_number":1,"created":"2015-06-03 08:35:04.000000000","uploader":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"ref":"refs/changes/06/187906/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/06/187906/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/1"}}},"commit":{"parents":[{"commit":"ad68fb2897f7fa376bfbcf04b2698a46f2186ac3","subject":"Fixes the non-existent exception NoTokenLookupException","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ad68fb2897f7fa376bfbcf04b2698a46f2186ac3"}]}],"author":{"name":"Sushil Kumar","email":"sushil.kumar3@hp.com","date":"2015-06-03 08:34:05.000000000","tz":0},"committer":{"name":"Sushil Kumar","email":"sushil.kumar3@hp.com","date":"2015-06-03 08:34:05.000000000","tz":0},"subject":"Added more unit-tests for troveclient/client.py","message":"Added more unit-tests for troveclient/client.py\n\ntroveclient/client.py was very low on coverage,\nadded more tests to increase the code-coverage.\n\nChange-Id: Ib040b69d31956231f1f6de57775d613fa8fdda7f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/6636add3ab4aa09aa351e23c2e96254f9542f7e7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/6636add3ab4aa09aa351e23c2e96254f9542f7e7"}]},"branch":"refs/heads/master"},"f22ce3d8616ff4db8f45e512b024d10ee93a1aca":{"kind":"REWORK","_number":2,"created":"2015-06-08 07:31:36.000000000","uploader":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"ref":"refs/changes/06/187906/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/06/187906/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/06/187906/2"}}},"commit":{"parents":[{"commit":"8c8c0d2d57ded73ecbf14063ff36fefd1467de58","subject":"Fixes the unmocked entry in secgroup tests","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/8c8c0d2d57ded73ecbf14063ff36fefd1467de58"}]}],"author":{"name":"Sushil Kumar","email":"sushil.kumar3@hp.com","date":"2015-06-08 07:31:08.000000000","tz":0},"committer":{"name":"Sushil Kumar","email":"sushil.kumar3@hp.com","date":"2015-06-08 07:31:08.000000000","tz":0},"subject":"Added more unit-tests to improve code coverage","message":"Added more unit-tests to improve code coverage\n\nFollowing files were too low on code coverage,\nso the coverage has been enhanced with addition of more unit-tests.\n- troveclient/client.py\n- troveclient/v1/shell.py\n\nThe methodology to test shell has been motivated from the\none used by python-novaclient to test novaclient/v2/shell.py\n\nChange-Id: Ib040b69d31956231f1f6de57775d613fa8fdda7f\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/f22ce3d8616ff4db8f45e512b024d10ee93a1aca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/f22ce3d8616ff4db8f45e512b024d10ee93a1aca"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}