)]}'
{"troveclient/tests/test_v1_shell.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8ec2a0839567180426f25d25cf4aead14903b23d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def test_instance_update(self):"},{"line_number":85,"context_line":"        self.run_command(\u0027update 1234\u0027)"},{"line_number":86,"context_line":"        self.assert_called(\u0027PATCH\u0027, \u0027/instances/1234\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_resize_volume(self):"},{"line_number":89,"context_line":"        self.run_command(\u0027resize-volume 1234 3\u0027)"},{"line_number":90,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/instances/1234/action\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_a3d400bd","line":87,"updated":"2015-07-07 14:51:33.000000000","message":"This should be put back, but be renamed test_resize_instance (which calls the resize-instance command).  I guess when the command was originally renamed the test wasn\u0027t corrected, but we shouldn\u0027t just delete it now ;)","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"9970cf7ed0b818bfe4be2a0dd690ec0b1b77a345","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def test_instance_update(self):"},{"line_number":85,"context_line":"        self.run_command(\u0027update 1234\u0027)"},{"line_number":86,"context_line":"        self.assert_called(\u0027PATCH\u0027, \u0027/instances/1234\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_resize_volume(self):"},{"line_number":89,"context_line":"        self.run_command(\u0027resize-volume 1234 3\u0027)"},{"line_number":90,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/instances/1234/action\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_44371e4d","line":87,"in_reply_to":"ba3cc151_11c5ef8c","updated":"2015-07-08 02:37:06.000000000","message":"will do.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5cf2b766772b81334952e416560a4d5b07bae6bb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def test_instance_update(self):"},{"line_number":85,"context_line":"        self.run_command(\u0027update 1234\u0027)"},{"line_number":86,"context_line":"        self.assert_called(\u0027PATCH\u0027, \u0027/instances/1234\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_resize_volume(self):"},{"line_number":89,"context_line":"        self.run_command(\u0027resize-volume 1234 3\u0027)"},{"line_number":90,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/instances/1234/action\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_11c5ef8c","line":87,"in_reply_to":"ba3cc151_a3d400bd","updated":"2015-07-07 15:43:20.000000000","message":"+1, the test needs to exist to track resize of flavor via resize-instance","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8ec2a0839567180426f25d25cf4aead14903b23d","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_cluster_create_error(self):"},{"line_number":225,"context_line":"        cmd \u003d (\u0027cluster-create test-clstr vertica 7.1 --instance volume\u003d2 \u0027"},{"line_number":226,"context_line":"               \u0027--instance flavor_id\u003d2,volume\u003d1\u0027)"},{"line_number":227,"context_line":"        self.assertRaisesRegexp("},{"line_number":228,"context_line":"            exceptions.CommandError, \u0027flavor is required\u0027,"},{"line_number":229,"context_line":"            self.run_command, cmd)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_ee02ef08","line":226,"updated":"2015-07-07 14:51:33.000000000","message":"This should be flavor\u003d2 in the second --instance (since it\u0027s testing the missing flavor in the first instance).  It\u0027s effectively missing in the second one now too, which can be confusing.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5cf2b766772b81334952e416560a4d5b07bae6bb","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_cluster_create_error(self):"},{"line_number":225,"context_line":"        cmd \u003d (\u0027cluster-create test-clstr vertica 7.1 --instance volume\u003d2 \u0027"},{"line_number":226,"context_line":"               \u0027--instance flavor_id\u003d2,volume\u003d1\u0027)"},{"line_number":227,"context_line":"        self.assertRaisesRegexp("},{"line_number":228,"context_line":"            exceptions.CommandError, \u0027flavor is required\u0027,"},{"line_number":229,"context_line":"            self.run_command, cmd)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_f444f9b7","line":226,"in_reply_to":"ba3cc151_ee02ef08","updated":"2015-07-07 15:43:20.000000000","message":"yup, gud catch Peter","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"9970cf7ed0b818bfe4be2a0dd690ec0b1b77a345","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_cluster_create_error(self):"},{"line_number":225,"context_line":"        cmd \u003d (\u0027cluster-create test-clstr vertica 7.1 --instance volume\u003d2 \u0027"},{"line_number":226,"context_line":"               \u0027--instance flavor_id\u003d2,volume\u003d1\u0027)"},{"line_number":227,"context_line":"        self.assertRaisesRegexp("},{"line_number":228,"context_line":"            exceptions.CommandError, \u0027flavor is required\u0027,"},{"line_number":229,"context_line":"            self.run_command, cmd)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_043ef627","line":226,"in_reply_to":"ba3cc151_f444f9b7","updated":"2015-07-08 02:37:06.000000000","message":"Exactly. I forgot to fix this.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"}],"troveclient/v1/shell.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"9fdb768f750357ee52489211e7850782addacc2f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":442,"context_line":"            err_msg \u003d (\"flavor is required. Instance arguments \""},{"line_number":443,"context_line":"                       \"must be of the form --instance \u003cflavor\u003dflavor_name,\","},{"line_number":444,"context_line":"                       \"volume\u003dvolume\u003e or \u003cflavor_id\u003dflavor_id,\""},{"line_number":445,"context_line":"                       \"volume\u003dvolume\u003e.\")"},{"line_number":446,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":447,"context_line":"        instances.append(instance_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_01e861b3","line":444,"updated":"2015-06-15 21:31:27.000000000","message":"Why is this handled differently here than it is for create?","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"a417fae4cc2868288401b9453ac884775c45fd7f","unresolved":false,"context_lines":[{"line_number":441,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":442,"context_line":"            err_msg \u003d (\"flavor is required. Instance arguments \""},{"line_number":443,"context_line":"                       \"must be of the form --instance \u003cflavor\u003dflavor_name,\","},{"line_number":444,"context_line":"                       \"volume\u003dvolume\u003e or \u003cflavor_id\u003dflavor_id,\""},{"line_number":445,"context_line":"                       \"volume\u003dvolume\u003e.\")"},{"line_number":446,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":447,"context_line":"        instances.append(instance_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_e882f951","line":444,"in_reply_to":"fa32b979_01e861b3","updated":"2015-06-16 01:48:56.000000000","message":"For backward compatibility.","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"9fdb768f750357ee52489211e7850782addacc2f","unresolved":false,"context_lines":[{"line_number":482,"context_line":"def do_resize_instance(cs, args):"},{"line_number":483,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":484,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":485,"context_line":"    if args.flavor_id:"},{"line_number":486,"context_line":"        flavor_id \u003d args.flavor_id"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        flavor_id \u003d _find_flavor(cs, args.flavor).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_01362152","line":485,"updated":"2015-06-15 21:31:27.000000000","message":"Where does flavor_id come from?  And why?","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"a417fae4cc2868288401b9453ac884775c45fd7f","unresolved":false,"context_lines":[{"line_number":482,"context_line":"def do_resize_instance(cs, args):"},{"line_number":483,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":484,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":485,"context_line":"    if args.flavor_id:"},{"line_number":486,"context_line":"        flavor_id \u003d args.flavor_id"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        flavor_id \u003d _find_flavor(cs, args.flavor).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_a8cab19f","line":485,"in_reply_to":"fa32b979_01362152","updated":"2015-06-16 01:48:56.000000000","message":"do_resize_flavor() calls do_resize_instance() with args including flavor_id in line 471.","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"0f7b30b0958dae6312f414443cb696d8f25d4672","unresolved":false,"context_lines":[{"line_number":482,"context_line":"def do_resize_instance(cs, args):"},{"line_number":483,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":484,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":485,"context_line":"    if args.flavor_id:"},{"line_number":486,"context_line":"        flavor_id \u003d args.flavor_id"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        flavor_id \u003d _find_flavor(cs, args.flavor).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_1c3191ec","line":485,"in_reply_to":"fa32b979_129c23bf","updated":"2015-06-16 10:47:13.000000000","message":"I see. I will revise the implementation.","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5ba506d6428a3642a4fec5d2ad8e51e8cdd27910","unresolved":false,"context_lines":[{"line_number":482,"context_line":"def do_resize_instance(cs, args):"},{"line_number":483,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":484,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":485,"context_line":"    if args.flavor_id:"},{"line_number":486,"context_line":"        flavor_id \u003d args.flavor_id"},{"line_number":487,"context_line":"    else:"},{"line_number":488,"context_line":"        flavor_id \u003d _find_flavor(cs, args.flavor).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_129c23bf","line":485,"in_reply_to":"fa32b979_a8cab19f","updated":"2015-06-16 07:44:20.000000000","message":"This would raise an error when resize-instance is called directly which is without a flavor_id as the argument","commit_id":"7fcaa1bd48be2dbe3c55f25e186e447d665502a1"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"ee02569a1cb3d3ea58d6356218cbbb8043a51532","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_1f55031c","line":472,"updated":"2015-06-16 11:33:37.000000000","message":"Why is this being changed? The API is deprecated and the call is being redirected to the one that isn\u0027t deprecated - \"do_resize_instance\". The idea in doing that was that we wouldn\u0027t have a need to do any maintenance on this call up to the point we get rid of it.\n\nI don\u0027t believe the previous review comments meant that this method required change. It should be able to stay the same and just path through the args to do_resize_instance. The way you now have do_resize_instance coded, I believe do_resize_flavor will still work as is.","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"5caec3abfa5f9fb59a1d1716bb813ddccf3fd3b6","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_470ad222","line":472,"in_reply_to":"fa32b979_0a57ffce","updated":"2015-06-16 15:31:44.000000000","message":"What should probably be done here is to change the decorations to have do_resize_flavor take the same arguments as resize_instance.  Then it would be backwards compatible, and resize_instnace would not need special cases.","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"943014f8b96e5f7134a1d8d7b5f002a1589b3478","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_0a57ffce","line":472,"in_reply_to":"fa32b979_1f55031c","updated":"2015-06-16 11:34:45.000000000","message":"it should say \"...just PASS through...\"","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"7f6b960444449f31cb5ef5edf85255841117f0b8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_eabacd09","line":472,"in_reply_to":"fa32b979_470ad222","updated":"2015-06-16 15:53:39.000000000","message":"My vote is that we take this opportunity to remove do_resize_flavor entirely.  It\u0027s been deprecated for quite some time now ...","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"c47943e0b0962903d0aa10002cd84e1b4c7071a2","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_f609ba85","line":472,"in_reply_to":"fa32b979_bf687e88","updated":"2015-06-26 05:13:10.000000000","message":"Getting rid of do_resize_flavor sounds great.\nHowever, it is out of scope of this change.\nWe should create another bug ticket for that.\nAt this time, this change is reasonable, I think.","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b628504aec691642172a64f26a60759adf642712","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_cae6e9b3","line":472,"in_reply_to":"fa32b979_eabacd09","updated":"2015-06-16 15:59:08.000000000","message":"I would vote +1 for removal of deprecated method.\n\nSeems to me the better solution.","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"183df82efce64f63a265cd4166b413f12727a7cb","unresolved":false,"context_lines":[{"line_number":469,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":470,"context_line":"    \"\"\"[DEPRECATED] Please use resize-instance instead.\"\"\""},{"line_number":471,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":472,"context_line":"    cs.instances.resize_instance(instance, args.flavor_id)"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"@utils.arg(\u0027instance\u0027,"},{"line_number":475,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa32b979_bf687e88","line":472,"in_reply_to":"fa32b979_eabacd09","updated":"2015-06-16 19:20:52.000000000","message":"The method has been deprecated since June 2, 2014. I think this may be the right time to get rid of it.","commit_id":"99ff8819f3e3384834fd14a3075d3b6a05951522"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"cc43ed9cc37f43a7a5aef57612774d784366e0f1","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        instance_info \u003d {}"},{"line_number":429,"context_line":"        for z in instance_str.split(\",\"):"},{"line_number":430,"context_line":"            for (k, v) in [z.split(\"\u003d\", 1)[:2]]:"},{"line_number":431,"context_line":"                if k \u003d\u003d \"flavor_id\":"},{"line_number":432,"context_line":"                    instance_info[\"flavorRef\"] \u003d v"},{"line_number":433,"context_line":"                elif k \u003d\u003d \"flavor\":"},{"line_number":434,"context_line":"                    flavor_id \u003d _find_flavor(cs, v).id"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_aa5709c9","line":431,"updated":"2015-07-07 06:52:53.000000000","message":"why should we try to find flavor_id in args if we expected user to send \u003cflavor\u003dname_or_id\u003e","commit_id":"0ea8ec623c2cf1e31ada00087aac9f1e987ced49"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"2abc26715cc59cefd11a821772ff993a25df8d77","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        instance_info \u003d {}"},{"line_number":429,"context_line":"        for z in instance_str.split(\",\"):"},{"line_number":430,"context_line":"            for (k, v) in [z.split(\"\u003d\", 1)[:2]]:"},{"line_number":431,"context_line":"                if k \u003d\u003d \"flavor_id\":"},{"line_number":432,"context_line":"                    instance_info[\"flavorRef\"] \u003d v"},{"line_number":433,"context_line":"                elif k \u003d\u003d \"flavor\":"},{"line_number":434,"context_line":"                    flavor_id \u003d _find_flavor(cs, v).id"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba3cc151_0af1556a","line":431,"in_reply_to":"ba3cc151_aa5709c9","updated":"2015-07-07 07:09:17.000000000","message":"Exactly.\nIt\u0027s dead code and I will remove it.","commit_id":"0ea8ec623c2cf1e31ada00087aac9f1e987ced49"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"8ec2a0839567180426f25d25cf4aead14903b23d","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":439,"context_line":"            err_msg \u003d (\"flavor is required. Instance arguments \""},{"line_number":440,"context_line":"                       \"must be of the form --instance \u003cflavor\u003dflavor_name,\","},{"line_number":441,"context_line":"                       \"volume\u003dvolume\u003e or \u003cflavor_id\u003dflavor_id,\""},{"line_number":442,"context_line":"                       \"volume\u003dvolume\u003e.\")"},{"line_number":443,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":444,"context_line":"        instances.append(instance_info)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_bb3ae496","line":441,"updated":"2015-07-07 14:51:33.000000000","message":"If I\u0027m reading the code right, flavor_id\u003d will no longer be supported, but it\u0027s still referenced in the help.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5cf2b766772b81334952e416560a4d5b07bae6bb","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":439,"context_line":"            err_msg \u003d (\"flavor is required. Instance arguments \""},{"line_number":440,"context_line":"                       \"must be of the form --instance \u003cflavor\u003dflavor_name,\","},{"line_number":441,"context_line":"                       \"volume\u003dvolume\u003e or \u003cflavor_id\u003dflavor_id,\""},{"line_number":442,"context_line":"                       \"volume\u003dvolume\u003e.\")"},{"line_number":443,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":444,"context_line":"        instances.append(instance_info)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_1414fd41","line":441,"in_reply_to":"ba3cc151_bb3ae496","updated":"2015-07-07 15:43:20.000000000","message":"now, either id or name both have to go with the argument name flavor.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"5cf2b766772b81334952e416560a4d5b07bae6bb","unresolved":false,"context_lines":[{"line_number":466,"context_line":"def do_resize_instance(cs, args):"},{"line_number":467,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":468,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":469,"context_line":"    flavor_id \u003d _find_flavor(cs, args.flavor).id"},{"line_number":470,"context_line":"    cs.instances.resize_instance(instance, flavor_id)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_3447c11e","line":469,"updated":"2015-07-07 15:43:20.000000000","message":"Is there a reason behind using flavor_id as str(_find_flavor(cs, v).id) as you have used in instance/cluster create but not here.","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"9970cf7ed0b818bfe4be2a0dd690ec0b1b77a345","unresolved":false,"context_lines":[{"line_number":466,"context_line":"def do_resize_instance(cs, args):"},{"line_number":467,"context_line":"    \"\"\"Resizes an instance with a new flavor.\"\"\""},{"line_number":468,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":469,"context_line":"    flavor_id \u003d _find_flavor(cs, args.flavor).id"},{"line_number":470,"context_line":"    cs.instances.resize_instance(instance, flavor_id)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba3cc151_5f836756","line":469,"in_reply_to":"ba3cc151_3447c11e","updated":"2015-07-08 02:37:06.000000000","message":"Actually, I found str() isn\u0027t needed in do_create().","commit_id":"8b6bbcf2b48786ff6fbf1704d03a74dae679f128"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e619efb7917ac6afcf03557903ef09cdb656f43c","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                    instance_info[k] \u003d v"},{"line_number":438,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":439,"context_line":"            err_msg \u003d (\"flavor is required. Instance arguments \""},{"line_number":440,"context_line":"                       \"must be of the form --instance \u003cflavor\u003dflavor_name,\","},{"line_number":441,"context_line":"                       \"volume\u003dvolume\u003e.\")"},{"line_number":442,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":443,"context_line":"        instances.append(instance_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba3cc151_4b94ff41","line":440,"updated":"2015-07-08 10:12:45.000000000","message":"You again have the typo flavor could be name or id both","commit_id":"0f5f3e85eabf18831c6c2223462aa4e4121e939c"}]}