)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"98c874f5adcb15379f810c9da5e1fbb96bf74598","unresolved":false,"context_lines":[{"line_number":7,"context_line":"User management for Vertica clusters and instances"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the spec specifies, changes were made to enable user"},{"line_number":10,"context_line":"CRUD operations for Vertica clusters and instances.n the trove"},{"line_number":11,"context_line":"client. Depending on whether its an instance or a cluster, the"},{"line_number":12,"context_line":"user operations are performed. Unit tests for the user"},{"line_number":13,"context_line":"operations for clusters are also added."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_77f120cd","line":10,"updated":"2015-07-20 06:09:01.000000000","message":"sentence fragment?","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"98c874f5adcb15379f810c9da5e1fbb96bf74598","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the spec specifies, changes were made to enable user"},{"line_number":10,"context_line":"CRUD operations for Vertica clusters and instances.n the trove"},{"line_number":11,"context_line":"client. Depending on whether its an instance or a cluster, the"},{"line_number":12,"context_line":"user operations are performed. Unit tests for the user"},{"line_number":13,"context_line":"operations for clusters are also added."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a50d1a3_57bf44d0","line":11,"updated":"2015-07-20 06:09:01.000000000","message":"it\u0027s","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"}],"troveclient/v1/shell.py":[{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"9cb464fafc04cea2cfaab6eb9505851e1594f21d","unresolved":false,"context_lines":[{"line_number":687,"context_line":"# User related actions"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"@utils.arg(\u0027instance\u0027, metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":690,"context_line":"           help\u003d\u0027ID or name  of the instance or the cluster.\u0027)"},{"line_number":691,"context_line":"@utils.arg(\u0027name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027Name of user.\u0027)"},{"line_number":692,"context_line":"@utils.arg(\u0027password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, help\u003d\u0027Password of user.\u0027)"},{"line_number":693,"context_line":"@utils.arg(\u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_56f2e99b","line":690,"updated":"2015-06-29 09:21:11.000000000","message":"I think it is better to rename this arg to \"instance_or_cluster\".","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"a3e4415515c0fbf7c684089652c8c5e7be40f433","unresolved":false,"context_lines":[{"line_number":687,"context_line":"# User related actions"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"@utils.arg(\u0027instance\u0027, metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":690,"context_line":"           help\u003d\u0027ID or name  of the instance or the cluster.\u0027)"},{"line_number":691,"context_line":"@utils.arg(\u0027name\u0027, metavar\u003d\u0027\u003cname\u003e\u0027, help\u003d\u0027Name of user.\u0027)"},{"line_number":692,"context_line":"@utils.arg(\u0027password\u0027, metavar\u003d\u0027\u003cpassword\u003e\u0027, help\u003d\u0027Password of user.\u0027)"},{"line_number":693,"context_line":"@utils.arg(\u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ee345adf","line":690,"in_reply_to":"ba3cc151_56f2e99b","updated":"2015-06-30 06:31:11.000000000","message":"+1","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"98c874f5adcb15379f810c9da5e1fbb96bf74598","unresolved":false,"context_lines":[{"line_number":698,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":699,"context_line":"def do_user_create(cs, args):"},{"line_number":700,"context_line":"    \"\"\"Creates a user on an instance or a cluster depending on the input.\"\"\""},{"line_number":701,"context_line":"    try:"},{"line_number":702,"context_line":"        instance \u003d _find_instance(cs, args.instance)"},{"line_number":703,"context_line":"        is_cluster \u003d False"},{"line_number":704,"context_line":"    except exceptions.CommandError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_d7cb5471","line":701,"updated":"2015-07-20 06:09:01.000000000","message":"this abstraction of find cluster or instance appears to be a common block of code and worthy of refactoring.","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"5e86382db2067d3e09a31ea578da24cfe5ce8849","unresolved":false,"context_lines":[{"line_number":698,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":699,"context_line":"def do_user_create(cs, args):"},{"line_number":700,"context_line":"    \"\"\"Creates a user on an instance or a cluster depending on the input.\"\"\""},{"line_number":701,"context_line":"    try:"},{"line_number":702,"context_line":"        instance \u003d _find_instance(cs, args.instance)"},{"line_number":703,"context_line":"        is_cluster \u003d False"},{"line_number":704,"context_line":"    except exceptions.CommandError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_44ff8901","line":701,"in_reply_to":"3a50d1a3_d7cb5471","updated":"2015-07-20 10:41:29.000000000","message":"+1","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"}],"troveclient/v1/users.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"98c874f5adcb15379f810c9da5e1fbb96bf74598","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def create(self, is_cluster, instance, users):"},{"line_number":33,"context_line":"        \"\"\"Create users with permissions to the specified databases.\"\"\""},{"line_number":34,"context_line":"        body \u003d {\"users\": users}"},{"line_number":35,"context_line":"        if is_cluster:"},{"line_number":36,"context_line":"            url \u003d \"/clusters/%s/users\" % base.getid(instance)"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            url \u003d \"/instances/%s/users\" % base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_f7aa1085","line":35,"updated":"2015-07-20 06:09:01.000000000","message":"this isn\u0027t the pythonic way of making this assignment.\n\nIt is also something that is worthy of refactoring.","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"},{"author":{"_account_id":12758,"name":"Masaki Matsushita","email":"glass.saga@gmail.com","username":"masaki"},"change_message_id":"5e86382db2067d3e09a31ea578da24cfe5ce8849","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def create(self, is_cluster, instance, users):"},{"line_number":33,"context_line":"        \"\"\"Create users with permissions to the specified databases.\"\"\""},{"line_number":34,"context_line":"        body \u003d {\"users\": users}"},{"line_number":35,"context_line":"        if is_cluster:"},{"line_number":36,"context_line":"            url \u003d \"/clusters/%s/users\" % base.getid(instance)"},{"line_number":37,"context_line":"        else:"},{"line_number":38,"context_line":"            url \u003d \"/instances/%s/users\" % base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_846cb19d","line":35,"in_reply_to":"3a50d1a3_f7aa1085","updated":"2015-07-20 10:41:29.000000000","message":"How about this?\n\nresource \u003d \"clusters\" if is_cluster else \"instances\"\nurl \u003d \"/%s/%s/users\" % (resource, base.getid(instance))","commit_id":"f4acb3b1cf9b8667388511a04b64cc21e65de43f"}]}
