)]}'
{"troveclient/tests/test_v1_shell.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"72b401d205c7bef0abdf7644f22153813f798ef9","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assert_called(\u0027DELETE\u0027,"},{"line_number":430,"context_line":"                           \u0027/instances/1234/users/jacob/databases/db1\u0027)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_root_enable_instance(self):"},{"line_number":433,"context_line":"        self.run_command(\u0027root-enable 1234\u0027)"},{"line_number":434,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/instances/1234/root\u0027)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_719296f8","line":432,"updated":"2015-07-16 19:07:50.000000000","message":"are these tests even running? b/c the signature of the run_command method was changed...","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"887e9f52986f16b9d44663042b0ed8cca2da8599","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assert_called(\u0027DELETE\u0027,"},{"line_number":430,"context_line":"                           \u0027/instances/1234/users/jacob/databases/db1\u0027)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_root_enable_instance(self):"},{"line_number":433,"context_line":"        self.run_command(\u0027root-enable 1234\u0027)"},{"line_number":434,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/instances/1234/root\u0027)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_95e85018","line":432,"in_reply_to":"9a41bdd9_0acadf4f","updated":"2015-07-17 06:50:57.000000000","message":":)","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"7cb1ccab7c323773210e2ec3d84974ba28c01ca7","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assert_called(\u0027DELETE\u0027,"},{"line_number":430,"context_line":"                           \u0027/instances/1234/users/jacob/databases/db1\u0027)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_root_enable_instance(self):"},{"line_number":433,"context_line":"        self.run_command(\u0027root-enable 1234\u0027)"},{"line_number":434,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/instances/1234/root\u0027)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_b4948c44","line":432,"in_reply_to":"9a41bdd9_719296f8","updated":"2015-07-16 19:24:40.000000000","message":"yes, i added a new run_command_clusters that has different patch decorators. You cal also check in the test results of py27 that these tests are passing","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"9dd5007a2454ea4be9f24db1a271c96640f4b0bf","unresolved":false,"context_lines":[{"line_number":429,"context_line":"        self.assert_called(\u0027DELETE\u0027,"},{"line_number":430,"context_line":"                           \u0027/instances/1234/users/jacob/databases/db1\u0027)"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"    def test_root_enable_instance(self):"},{"line_number":433,"context_line":"        self.run_command(\u0027root-enable 1234\u0027)"},{"line_number":434,"context_line":"        self.assert_called_anytime(\u0027POST\u0027, \u0027/instances/1234/root\u0027)"},{"line_number":435,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a41bdd9_0acadf4f","line":432,"in_reply_to":"9a41bdd9_b4948c44","updated":"2015-07-17 06:31:09.000000000","message":"ahh ok cool i must have missed that when i looked.","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"}],"troveclient/v1/root.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"867b3603b3153d3fa9a65266e9cb67519bc988d7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    instances_url \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    clusters_url \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Implements root-enable for instances.\"\"\""},{"line_number":30,"context_line":"        return self._enable_root(self.instances_url % base.getid(instance),"},{"line_number":31,"context_line":"                                 root_password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_9047a4bb","line":28,"updated":"2015-07-01 10:55:20.000000000","message":"I do not see any calls coming to these newmethod in current patchset, am I missing something.","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"684331685c2df8c0a818391b6ecd5a51bc232ebc","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    instances_url \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    clusters_url \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Implements root-enable for instances.\"\"\""},{"line_number":30,"context_line":"        return self._enable_root(self.instances_url % base.getid(instance),"},{"line_number":31,"context_line":"                                 root_password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_e9bdd8b7","line":28,"in_reply_to":"ba3cc151_9047a4bb","updated":"2015-07-01 17:42:03.000000000","message":"It is called from the do_root_enable function in shell.py","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b5a850809879b01fd0ea108a06916c738144dbe6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    instances_url \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    clusters_url \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"},{"line_number":29,"context_line":"        \"\"\"Implements root-enable for instances.\"\"\""},{"line_number":30,"context_line":"        return self._enable_root(self.instances_url % base.getid(instance),"},{"line_number":31,"context_line":"                                 root_password)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_cc07c2c8","line":28,"in_reply_to":"ba3cc151_e9bdd8b7","updated":"2015-07-01 17:59:35.000000000","message":"Fine","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"867b3603b3153d3fa9a65266e9cb67519bc988d7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Appease the abc gods"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_108154c3","line":59,"updated":"2015-07-01 10:55:20.000000000","message":"Do not we need to use clusters_url for Clusters","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"684331685c2df8c0a818391b6ecd5a51bc232ebc","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Appease the abc gods"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_a9859007","line":59,"in_reply_to":"ba3cc151_108154c3","updated":"2015-07-01 17:42:03.000000000","message":"Yes, otherwise clusters_id will be looked up in instances and a \"instance NOT found\" error will be thrown","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b5a850809879b01fd0ea108a06916c738144dbe6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Appease the abc gods"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_ac5b5ef5","line":59,"in_reply_to":"ba3cc151_a9859007","updated":"2015-07-01 17:59:35.000000000","message":"but then how does is_cluster_root_enabled works","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"f396d0fab1d7f26820ee86b389bdb88aa88d2f00","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Appease the abc gods"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_5ff912c6","line":59,"in_reply_to":"ba3cc151_ac5b5ef5","updated":"2015-07-01 18:20:25.000000000","message":"So in shell.py, \"do_root_show\" will call either is_cluster_root_enabled or is_instance_root_enabled based on resource type. Both of these functions will then call \"_is_root_enabled\" same as before. This is needed because we need to know where to look for the resource (either in clusters or instances)","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"dc0855799e0d7b332f4521678886ea98e7031d17","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Root(base.ManagerWithFind):"},{"line_number":23,"context_line":"    \"\"\"Manager class for Root resource.\"\"\""},{"line_number":24,"context_line":"    resource_class \u003d users.User"},{"line_number":25,"context_line":"    instances_url \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    clusters_url \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_f76d30cd","line":25,"updated":"2015-07-20 05:52:02.000000000","message":"shouldn\u0027t constants like this be upper-cased?","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"9da43c57ee5aa3bf56848576a3d855f02b8c1fb6","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Root(base.ManagerWithFind):"},{"line_number":23,"context_line":"    \"\"\"Manager class for Root resource.\"\"\""},{"line_number":24,"context_line":"    resource_class \u003d users.User"},{"line_number":25,"context_line":"    instances_url \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    clusters_url \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_aa50f332","line":25,"in_reply_to":"3a50d1a3_f76d30cd","updated":"2015-07-28 21:01:55.000000000","message":"maybe not needed for class level constants?","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e73e83ca784de80d66b185081f655012d39c587c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        body \u003d {\"password\": root_password} if root_password else {}"},{"line_number":44,"context_line":"        resp, body \u003d self.api.client.post(uri, body\u003dbody)"},{"line_number":45,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":46,"context_line":"        return body[\u0027user\u0027][\u0027name\u0027], body[\u0027user\u0027][\u0027password\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_instance_root_enabled(self, instance):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_b1afb8e2","line":45,"updated":"2015-07-20 04:16:53.000000000","message":"shouldn\u0027t this be the uri passed in as a parameter? after all, if this is invoked for a cluster action, why would you invoke check_for_exception with the instance URI?","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"e73e83ca784de80d66b185081f655012d39c587c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, self.instances_url)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    # Appease the abc gods"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_d1acc4ef","line":59,"updated":"2015-07-20 04:16:53.000000000","message":"shouldn\u0027t this be the uri passed in as a parameter? after all, if this is invoked for a cluster action, why would you invoke check_for_exception with the instance URI?","commit_id":"9c25ab4d0b1fe34c38350528c589d0ad42271693"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"70f4615fbdf1b6beee098a5000ef1388d449269d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"class Root(base.ManagerWithFind):"},{"line_number":23,"context_line":"    \"\"\"Manager class for Root resource.\"\"\""},{"line_number":24,"context_line":"    resource_class \u003d users.User"},{"line_number":25,"context_line":"    INSTANCES_UL \u003d \"/instances/%s/root\""},{"line_number":26,"context_line":"    CLUSTERS_URL \u003d \"/clusters/%s/root\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create_instance_root(self, instance, root_password\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a50d1a3_493e288d","line":25,"updated":"2015-07-22 18:54:48.000000000","message":"These should either be upper cased constants defined at module level, or they should be lower cased properties at the class level.  Also, did you mean \"instances_url\"?","commit_id":"be9e5aa168e35a2f2678880f55f1076b5d12b0ec"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e7d37731a77fb3eff4244199ba6c783821256914","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return body[\u0027user\u0027][\u0027name\u0027], body[\u0027user\u0027][\u0027password\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_instance_root_enabled(self, instance):"},{"line_number":49,"context_line":"        \"\"\"Returns whether root is enabled for the cluster\"\"\""},{"line_number":50,"context_line":"        return self._is_root_enabled(self.instances_url % base.getid(instance))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def is_cluster_root_enabled(self, cluster):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_3df07dc8","line":49,"updated":"2015-07-23 15:12:24.000000000","message":"docstring correction this method is for instance, the docstring suggests cluster.","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"8d5d1862b69484a786eff38fdd0d9d99d62f58bc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        return body[\u0027user\u0027][\u0027name\u0027], body[\u0027user\u0027][\u0027password\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def is_instance_root_enabled(self, instance):"},{"line_number":49,"context_line":"        \"\"\"Returns whether root is enabled for the cluster\"\"\""},{"line_number":50,"context_line":"        return self._is_root_enabled(self.instances_url % base.getid(instance))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def is_cluster_root_enabled(self, cluster):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_ba580832","line":49,"in_reply_to":"3a50d1a3_3df07dc8","updated":"2015-07-28 21:00:00.000000000","message":"Done","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e7d37731a77fb3eff4244199ba6c783821256914","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self._is_root_enabled(self.clusters_url % base.getid(cluster))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, uri)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_1d3d818e","line":57,"updated":"2015-07-23 15:12:24.000000000","message":"This method works for both instance as well as cluster, thus docstring needs to be corrected.","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"8d5d1862b69484a786eff38fdd0d9d99d62f58bc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        return self._is_root_enabled(self.clusters_url % base.getid(cluster))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def _is_root_enabled(self, uri):"},{"line_number":57,"context_line":"        \"\"\"Return whether root is enabled for the instance.\"\"\""},{"line_number":58,"context_line":"        resp, body \u003d self.api.client.get(uri)"},{"line_number":59,"context_line":"        common.check_for_exceptions(resp, body, uri)"},{"line_number":60,"context_line":"        return self.resource_class(self, body, loaded\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_1a4a5c55","line":57,"in_reply_to":"3a50d1a3_1d3d818e","updated":"2015-07-28 21:00:00.000000000","message":"Done","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"}],"troveclient/v1/shell.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"867b3603b3153d3fa9a65266e9cb67519bc988d7","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    utils.print_dict(obj._info)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_7096a040","line":99,"updated":"2015-07-01 10:55:20.000000000","message":"but there are no calls to this method.","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"f396d0fab1d7f26820ee86b389bdb88aa88d2f00","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    utils.print_dict(obj._info)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_8c39baf4","line":99,"in_reply_to":"ba3cc151_2ce3ce34","updated":"2015-07-01 18:20:25.000000000","message":"No problem :)","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"684331685c2df8c0a818391b6ecd5a51bc232ebc","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    utils.print_dict(obj._info)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_89e52cdd","line":99,"in_reply_to":"ba3cc151_7096a040","updated":"2015-07-01 17:42:03.000000000","message":"It is called in the first line of both the do_root_enable function and the do_root_show function below","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"b5a850809879b01fd0ea108a06916c738144dbe6","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    utils.print_dict(obj._info)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."}],"source_content_type":"text/x-python","patch_set":1,"id":"ba3cc151_2ce3ce34","line":99,"in_reply_to":"ba3cc151_89e52cdd","updated":"2015-07-01 17:59:35.000000000","message":"My mistake, I don\u0027t know but for some reason the other changes were not visible to me earlier.\n\nThanks for the reply","commit_id":"3df29c4d83f5f3f912dede79bea68ac50f7c50ce"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e7d37731a77fb3eff4244199ba6c783821256914","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    utils.print_dict(obj._info)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_1d8ee12d","line":99,"updated":"2015-07-23 15:12:24.000000000","message":"can we add some test for this method too, as this is used as mocked method only in tests, thus degrading the coverage.","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"e7d37731a77fb3eff4244199ba6c783821256914","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    except exceptions.CommandError:"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return _find_cluster(cs, instance_or_cluster), \u0027cluster\u0027"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            raise exceptions.CommandError("},{"line_number":111,"context_line":"                \"No instance or cluster with a name or ID of \u0027%s\u0027 exists.\""},{"line_number":112,"context_line":"                % instance_or_cluster)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a50d1a3_3dc39d39","line":109,"updated":"2015-07-23 15:12:24.000000000","message":"Exception looks to be too broad.","commit_id":"9551904f38dd2b6d9b09011c1a70c6491823b5dd"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2e852c3841f98ba551c8f6ab7b181da7929f7887","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."},{"line_number":103,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_dc273bc8","line":100,"updated":"2015-07-29 07:10:47.000000000","message":"can we add some test for this method too, as this is used as mocked method only in tests, thus degrading the coverage.","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"234aa2ba5f327144c7ad3f602e6e51ab266e5d83","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."},{"line_number":103,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_3dbcfd04","line":100,"in_reply_to":"3a50d1a3_9aad1733","updated":"2015-07-29 17:31:22.000000000","message":"oh yes, my bad, i missed those.","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"4668ec6ea88b823f4c7b825554afdce77997cccc","unresolved":false,"context_lines":[{"line_number":97,"context_line":""},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"def _find_instance_or_cluster(cs, instance_or_cluster):"},{"line_number":100,"context_line":"    \"\"\"Returns an instance or cluster, found by id, along with the type of"},{"line_number":101,"context_line":"    resource, instance or cluster, that was found."},{"line_number":102,"context_line":"    Raises CommandError if none is found."},{"line_number":103,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_9aad1733","line":100,"in_reply_to":"3a50d1a3_dc273bc8","updated":"2015-07-29 17:24:46.000000000","message":"i added two tests in the test shell.py file. One is  test_find_instance_or_cluster_find_cluster and the other is test_find_instance_or_cluster.","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"2e852c3841f98ba551c8f6ab7b181da7929f7887","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    except exceptions.CommandError:"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return _find_cluster(cs, instance_or_cluster), \u0027cluster\u0027"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            raise exceptions.CommandError("},{"line_number":111,"context_line":"                \"No instance or cluster with a name or ID of \u0027%s\u0027 exists.\""},{"line_number":112,"context_line":"                % instance_or_cluster)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_7c1dc771","line":109,"updated":"2015-07-29 07:10:47.000000000","message":"Exception looks to be too broad.","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"234aa2ba5f327144c7ad3f602e6e51ab266e5d83","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    except exceptions.CommandError:"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return _find_cluster(cs, instance_or_cluster), \u0027cluster\u0027"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            raise exceptions.CommandError("},{"line_number":111,"context_line":"                \"No instance or cluster with a name or ID of \u0027%s\u0027 exists.\""},{"line_number":112,"context_line":"                % instance_or_cluster)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_dd41590b","line":109,"in_reply_to":"3a50d1a3_3d1b9d74","updated":"2015-07-29 17:31:22.000000000","message":"it wud be good to go ahead.","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"},{"author":{"_account_id":16132,"name":"Sharika Pongubala","email":"sharika.pongubala@hp.com","username":"sharika"},"change_message_id":"4d5a00be9943bdc2c9204d4bfc59c4ef64d32687","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    except exceptions.CommandError:"},{"line_number":107,"context_line":"        try:"},{"line_number":108,"context_line":"            return _find_cluster(cs, instance_or_cluster), \u0027cluster\u0027"},{"line_number":109,"context_line":"        except Exception:"},{"line_number":110,"context_line":"            raise exceptions.CommandError("},{"line_number":111,"context_line":"                \"No instance or cluster with a name or ID of \u0027%s\u0027 exists.\""},{"line_number":112,"context_line":"                % instance_or_cluster)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a50d1a3_3d1b9d74","line":109,"in_reply_to":"3a50d1a3_7c1dc771","updated":"2015-07-29 17:27:19.000000000","message":"this can be changed","commit_id":"56979297c05600e0242e727e2f4692b0fc31d62e"}]}