)]}'
{"troveclient/v1/clusters.py":[{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"93e34df983b2f8f329a8c3f0632e19f06bd0e902","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        body \u003d {\"add_shard\": {}}"},{"line_number":88,"context_line":"        return body"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def grow(self, cluster, instances\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_8e94f98a","line":87,"updated":"2015-07-23 15:58:24.000000000","message":"So this method is not doing anything, should it not be removed now.","commit_id":"b56baa7a924e4b023b0e86f801f28d1214014e9b"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"cb0551970eb26d99abe8be281110970a2fd878b2","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"},{"line_number":86,"context_line":"        \"\"\""},{"line_number":87,"context_line":"        body \u003d {\"add_shard\": {}}"},{"line_number":88,"context_line":"        return body"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def grow(self, cluster, instances\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_7c08392e","line":87,"in_reply_to":"3a50d1a3_8e94f98a","updated":"2015-07-23 19:56:54.000000000","message":"I believe we agreed to leave it in for EBay.","commit_id":"b56baa7a924e4b023b0e86f801f28d1214014e9b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"ae3e323a76e72f6caa3d2278524a51dcd9b76386","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self.resource_class(self, body[\u0027cluster\u0027], loaded\u003dTrue)"},{"line_number":80,"context_line":"        return body"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_shard(self, cluster):"},{"line_number":83,"context_line":"        \"\"\"Adds a shard to the specified cluster."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_36f2a107","line":82,"updated":"2015-07-24 15:15:44.000000000","message":"So, if we are leaving this method for someone, should not this function do something.\n\nCurrently, this function looks paralyzed, this would just return {\"add_shard\": {}}\n\nI do not understand what could one do with such a method in client.","commit_id":"b160157f718554e55ce11adb1fbe5766c39e46ab"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"b7ce05f26e806952c9d7f567c7c1af03a0cbe915","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self.resource_class(self, body[\u0027cluster\u0027], loaded\u003dTrue)"},{"line_number":80,"context_line":"        return body"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_shard(self, cluster):"},{"line_number":83,"context_line":"        \"\"\"Adds a shard to the specified cluster."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_76626918","line":82,"in_reply_to":"3a50d1a3_36f2a107","updated":"2015-07-24 15:27:26.000000000","message":"This method is never called by anything anyway, so it doesn\u0027t matter if the code is removed. Doesn\u0027t deserve a -1","commit_id":"b160157f718554e55ce11adb1fbe5766c39e46ab"},{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"34f25449e218dfdb89bee107e05dc72d79d019ef","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self.resource_class(self, body[\u0027cluster\u0027], loaded\u003dTrue)"},{"line_number":80,"context_line":"        return body"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_shard(self, cluster):"},{"line_number":83,"context_line":"        \"\"\"Adds a shard to the specified cluster."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_11f52f82","line":82,"in_reply_to":"3a50d1a3_76626918","updated":"2015-07-24 15:41:00.000000000","message":"I have been told this can be called from Horizon. Undo the change then.","commit_id":"b160157f718554e55ce11adb1fbe5766c39e46ab"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"56957500e5911161f7155547bb3b2df4ac154833","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            return self.resource_class(self, body[\u0027cluster\u0027], loaded\u003dTrue)"},{"line_number":80,"context_line":"        return body"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def add_shard(self, cluster):"},{"line_number":83,"context_line":"        \"\"\"Adds a shard to the specified cluster."},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        :param cluster: The cluster to add a shard to"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a50d1a3_f1d0c3f9","line":82,"in_reply_to":"3a50d1a3_76626918","updated":"2015-07-24 15:40:33.000000000","message":"if thats the case(it never gets called anyway), why have to leave it.\nThere does not seems to be any reason for keeping it in that case.","commit_id":"b160157f718554e55ce11adb1fbe5766c39e46ab"}],"troveclient/v1/shell.py":[{"author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"change_message_id":"c3c948c74d25cb90ef3ed828e36e0536b4682a24","unresolved":false,"context_lines":[{"line_number":284,"context_line":"                \u0027--instance \u003cflavor_id\u003dflavor_id,volume\u003dvolume,data\u003ddata\u003e\u0027"},{"line_number":285,"context_line":"            )"},{"line_number":286,"context_line":"        if data:"},{"line_number":287,"context_line":"            instance_info[\u0027data\u0027] \u003d str(data)"},{"line_number":288,"context_line":"        instances.append(instance_info)"},{"line_number":289,"context_line":"    cs.clusters.grow(cluster, instances\u003dinstances)"},{"line_number":290,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a50d1a3_0c5627ce","line":287,"updated":"2015-07-22 13:59:56.000000000","message":"Don\u0027t make data a string, as it forces the datastore\u0027s strategy to parse the string into a dictionary. Keep it as dict here so the apischema can parse it as an object.","commit_id":"3fe78538a9c4e48120e394296d127e3d1402a93d"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"93e34df983b2f8f329a8c3f0632e19f06bd0e902","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"@utils.arg(\u0027--instance\u0027,"},{"line_number":254,"context_line":"           metavar\u003d\"\u003cflavor_id\u003dflavor_id,volume\u003dvolume,data\u003ddata\u003e\","},{"line_number":255,"context_line":"           action\u003d\u0027append\u0027,"},{"line_number":256,"context_line":"           dest\u003d\u0027instances\u0027,"},{"line_number":257,"context_line":"           default\u003d[],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_aee535dc","line":254,"updated":"2015-07-23 15:58:24.000000000","message":"this should be flavor-id_or_name as recently updated in do_cluster_create","commit_id":"b56baa7a924e4b023b0e86f801f28d1214014e9b"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"cb0551970eb26d99abe8be281110970a2fd878b2","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"@utils.arg(\u0027--instance\u0027,"},{"line_number":254,"context_line":"           metavar\u003d\"\u003cflavor_id\u003dflavor_id,volume\u003dvolume,data\u003ddata\u003e\","},{"line_number":255,"context_line":"           action\u003d\u0027append\u0027,"},{"line_number":256,"context_line":"           dest\u003d\u0027instances\u0027,"},{"line_number":257,"context_line":"           default\u003d[],"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_1f1c8769","line":254,"in_reply_to":"3a50d1a3_aee535dc","updated":"2015-07-23 19:56:54.000000000","message":"It didn\u0027t make me rebase so I didn\u0027t see that change, but I\u0027ll have a look.  Thanks.","commit_id":"b56baa7a924e4b023b0e86f801f28d1214014e9b"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"dc6457df839fcbfc5a6a32d3a5f8def41174b79e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"                    instance_info[k] \u003d v"},{"line_number":280,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":281,"context_line":"            raise exceptions.CommandError("},{"line_number":282,"context_line":"                \u0027flavor_id is required. \u0027"},{"line_number":283,"context_line":"                \u0027Instance arguments must be of the form \u0027"},{"line_number":284,"context_line":"                \u0027--instance \u003cflavor_id\u003dflavor_id,volume\u003dvolume,data\u003ddata\u003e\u0027"},{"line_number":285,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_4c800047","line":282,"updated":"2015-07-24 15:53:17.000000000","message":"flavor_id_or_name","commit_id":"300e75bba3819b65935ad465f86f2b7df19423f7"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"dc6457df839fcbfc5a6a32d3a5f8def41174b79e","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            raise exceptions.CommandError("},{"line_number":282,"context_line":"                \u0027flavor_id is required. \u0027"},{"line_number":283,"context_line":"                \u0027Instance arguments must be of the form \u0027"},{"line_number":284,"context_line":"                \u0027--instance \u003cflavor_id\u003dflavor_id,volume\u003dvolume,data\u003ddata\u003e\u0027"},{"line_number":285,"context_line":"            )"},{"line_number":286,"context_line":"        instances.append(instance_info)"},{"line_number":287,"context_line":"    cs.clusters.grow(cluster, instances\u003dinstances)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a50d1a3_8ceda827","line":284,"updated":"2015-07-24 15:53:17.000000000","message":"flavor_id is wrong usage since we are now supporting name/id both","commit_id":"300e75bba3819b65935ad465f86f2b7df19423f7"},{"author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"change_message_id":"612759a2aa5b3b855ff8d4b28a4aec6d9799564c","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                else:"},{"line_number":279,"context_line":"                    instance_info[k] \u003d v"},{"line_number":280,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":281,"context_line":"            raise exceptions.CommandError("},{"line_number":282,"context_line":"                \u0027flavor is required. \u0027"},{"line_number":283,"context_line":"                \u0027Instance arguments must be of the form \u0027"},{"line_number":284,"context_line":"                \u0027--instance \u003cflavor\u003dflavor_name_or_id,volume\u003dvolume,data\u003ddata\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a4dcd0f_f08421b2","line":281,"updated":"2015-08-10 16:29:49.000000000","message":"This probably should be a ValidationError","commit_id":"d3540012c41555a0bca062687fb6c3431df8ac33"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"8a1e73165f96f2b3f2d13f7ba97a8a0394562a9a","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                else:"},{"line_number":279,"context_line":"                    instance_info[k] \u003d v"},{"line_number":280,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":281,"context_line":"            raise exceptions.CommandError("},{"line_number":282,"context_line":"                \u0027flavor is required. \u0027"},{"line_number":283,"context_line":"                \u0027Instance arguments must be of the form \u0027"},{"line_number":284,"context_line":"                \u0027--instance \u003cflavor\u003dflavor_name_or_id,volume\u003dvolume,data\u003ddata\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa1b9901_8249d7d2","line":281,"in_reply_to":"1a4dcd0f_f08421b2","updated":"2015-08-24 15:24:07.000000000","message":"Perhaps, but CommandError is what cluster_create uses, and grow should be the same.  You might want to subsmit a bug to change CommandError usages to ValidationError.","commit_id":"d3540012c41555a0bca062687fb6c3431df8ac33"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"ee1b9c9e2a2bc4f2aecd611957176f949e619f78","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                else:"},{"line_number":279,"context_line":"                    instance_info[k] \u003d v"},{"line_number":280,"context_line":"        if not instance_info.get(\u0027flavorRef\u0027):"},{"line_number":281,"context_line":"            raise exceptions.CommandError("},{"line_number":282,"context_line":"                \u0027flavor is required. \u0027"},{"line_number":283,"context_line":"                \u0027Instance arguments must be of the form \u0027"},{"line_number":284,"context_line":"                \u0027--instance \u003cflavor\u003dflavor_name_or_id,volume\u003dvolume,data\u003ddata\u003e\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_9406f51e","line":281,"in_reply_to":"fa1b9901_8249d7d2","updated":"2015-09-02 20:49:44.000000000","message":"agree with morgan","commit_id":"d3540012c41555a0bca062687fb6c3431df8ac33"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0b3d6a40143eb818782edb4fd1cd939b20c7209d","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        instance_info \u003d {}"},{"line_number":269,"context_line":"        for z in instance_str.split(\",\"):"},{"line_number":270,"context_line":"            for (k, v) in [z.split(\"\u003d\", 1)[:2]]:"},{"line_number":271,"context_line":"                if k \u003d\u003d \"name\":"},{"line_number":272,"context_line":"                    instance_info[k] \u003d v"},{"line_number":273,"context_line":"                elif k \u003d\u003d \"flavor\":"},{"line_number":274,"context_line":"                    flavor_id \u003d _find_flavor(cs, v).id"}],"source_content_type":"text/x-python","patch_set":7,"id":"da20952f_4c897f25","line":271,"updated":"2015-09-03 18:43:50.000000000","message":"please fix the metavar and help to match this.","commit_id":"9222207c8ebbe7df295fcbe7e526cc7b8a36643c"}]}