)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0a2bacf0567571d3760521d759a3cc7a4290d377","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Also added the unit-tests for these APIs."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ieea4f055a491a838367da7b50bceb0171b3890c5"},{"line_number":17,"context_line":"Implements: blueprint datastore-registration-api"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a7e1126_9ab318e9","line":17,"updated":"2015-12-19 01:04:13.000000000","message":"I will assume that this relates to the spec merged in Liberty called https://github.com/openstack/trove-specs/blob/master/specs/liberty/datastore-registration-api.rst\n\nMany of my comments now come after reviewing the code and should/could well have been caught during the review of the spec if I had been astute enough.\n\nBut I\u0027m not; I was not.\n\nI realize that the spec says some of these things should be implemented, in reviewing the code now I\u0027m realizing this is a bad thing.","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"}],"troveclient/v1/shell.py":[{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c6982e751765af372b2f7b00e2c189d186058dcc","unresolved":false,"context_lines":[{"line_number":1338,"context_line":"           metavar\u003d\u0027\u003cdatastore_version\u003e\u0027,"},{"line_number":1339,"context_line":"           help\u003d\u0027Datastore version name or UUID assigned to the \u0027"},{"line_number":1340,"context_line":"                \u0027configuration group.\u0027)"},{"line_number":1341,"context_line":"@utils.arg(\u0027--datastore_manager\u0027,"},{"line_number":1342,"context_line":"           metavar\u003d\u0027\u003cdatastore_manager\u003e\u0027,"},{"line_number":1343,"context_line":"           help\u003d\u0027Name of the manager that will \u0027"},{"line_number":1344,"context_line":"                \u0027administer the datastore version.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_0b760406","line":1341,"updated":"2015-12-18 21:44:33.000000000","message":"Is this option meaningful?  Why would a datastore version be switched to a different manager?","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0a2bacf0567571d3760521d759a3cc7a4290d377","unresolved":false,"context_lines":[{"line_number":1338,"context_line":"           metavar\u003d\u0027\u003cdatastore_version\u003e\u0027,"},{"line_number":1339,"context_line":"           help\u003d\u0027Datastore version name or UUID assigned to the \u0027"},{"line_number":1340,"context_line":"                \u0027configuration group.\u0027)"},{"line_number":1341,"context_line":"@utils.arg(\u0027--datastore_manager\u0027,"},{"line_number":1342,"context_line":"           metavar\u003d\u0027\u003cdatastore_manager\u003e\u0027,"},{"line_number":1343,"context_line":"           help\u003d\u0027Name of the manager that will \u0027"},{"line_number":1344,"context_line":"                \u0027administer the datastore version.\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_7afc2c72","line":1341,"in_reply_to":"3a7e1126_0b760406","updated":"2015-12-19 01:04:13.000000000","message":"From an operational perspective, any changes to a datastore are problematic. Consider this, I create an instance, then someone updates the datastore, then I create a new instance.\n\nssh access is disabled (this isn\u0027t devstack).\n\nHow does one know which version of the datastore/guest image is being run?\n\nif you say \"rely on the instance launch time\" the issue is that there\u0027s no audit trail of these changes.","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c6982e751765af372b2f7b00e2c189d186058dcc","unresolved":false,"context_lines":[{"line_number":1342,"context_line":"           metavar\u003d\u0027\u003cdatastore_manager\u003e\u0027,"},{"line_number":1343,"context_line":"           help\u003d\u0027Name of the manager that will \u0027"},{"line_number":1344,"context_line":"                \u0027administer the datastore version.\u0027)"},{"line_number":1345,"context_line":"@utils.arg(\u0027--image_id\u0027, metavar\u003d\u0027\u003cimage_id\u003e\u0027,"},{"line_number":1346,"context_line":"           help\u003d\u0027ID of the image to be used to create an instance \u0027"},{"line_number":1347,"context_line":"                \u0027of the datastore version.\u0027)"},{"line_number":1348,"context_line":"@utils.arg(\u0027--packages\u0027, metavar\u003d\u0027\u003cpackages\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_abeb3077","line":1345,"updated":"2015-12-18 21:44:33.000000000","message":"I don\u0027t think we should allow the user to change the image for a datastore version.  In a configuration where a user didn\u0027t have access to the nova instance, if the image was changed there would be no way for the user to know which instance was using which image.","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"0a2bacf0567571d3760521d759a3cc7a4290d377","unresolved":false,"context_lines":[{"line_number":1342,"context_line":"           metavar\u003d\u0027\u003cdatastore_manager\u003e\u0027,"},{"line_number":1343,"context_line":"           help\u003d\u0027Name of the manager that will \u0027"},{"line_number":1344,"context_line":"                \u0027administer the datastore version.\u0027)"},{"line_number":1345,"context_line":"@utils.arg(\u0027--image_id\u0027, metavar\u003d\u0027\u003cimage_id\u003e\u0027,"},{"line_number":1346,"context_line":"           help\u003d\u0027ID of the image to be used to create an instance \u0027"},{"line_number":1347,"context_line":"                \u0027of the datastore version.\u0027)"},{"line_number":1348,"context_line":"@utils.arg(\u0027--packages\u0027, metavar\u003d\u0027\u003cpackages\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_3a4224af","line":1345,"in_reply_to":"3a7e1126_abeb3077","updated":"2015-12-19 01:04:13.000000000","message":"Yes, this is a major fly in the ointment. I agree with Morgan, this kind of change to a datastore is problematic.","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c6982e751765af372b2f7b00e2c189d186058dcc","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"           default\u003dNone,"},{"line_number":1355,"context_line":"           help\u003d\u0027Whether the datastore version is active. \u0027"},{"line_number":1356,"context_line":"                \u0027Accepted values are true or false.\u0027)"},{"line_number":1357,"context_line":"@utils.arg(\u0027--default\u0027,"},{"line_number":1358,"context_line":"           metavar\u003d\u0027\u003cdefault\u003e\u0027,"},{"line_number":1359,"context_line":"           default\u003dNone,"},{"line_number":1360,"context_line":"           help\u003d\u0027Whether this datastore version would be default for \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_cb655c1e","line":1357,"updated":"2015-12-18 21:44:33.000000000","message":"If the datastore version is default, then the user says --default\u003dfalse, what happens?  Is it OK to have a datastore to not have a default version?  If not, we should make this a switch (i.e., just \"--default\" with no boolean, so implicitly true).","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"},{"author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"change_message_id":"c6982e751765af372b2f7b00e2c189d186058dcc","unresolved":false,"context_lines":[{"line_number":1361,"context_line":"                \u0027datastore. Accepted values are true or false.\u0027)"},{"line_number":1362,"context_line":"def do_datastore_version_update(cs, args):"},{"line_number":1363,"context_line":"    \"\"\"Updates a given datastore version."},{"line_number":1364,"context_line":"    Edits datastore manager, image, packages,"},{"line_number":1365,"context_line":"    active, or default source."},{"line_number":1366,"context_line":"    At least one optional argument must be provided."},{"line_number":1367,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a7e1126_4b288c9a","line":1364,"updated":"2015-12-18 21:44:33.000000000","message":"Suggest removing this sentence - it\u0027s obvious from the rest of the generated help.","commit_id":"f42887216451fec6346528a57f497afa4e5f6c9f"}]}