)]}'
{"id":"openstack%2Fpython-troveclient~222482","triplet_id":"openstack%2Fpython-troveclient~master~Ieea4f055a491a838367da7b50bceb0171b3890c5","project":"openstack/python-troveclient","branch":"master","hashtags":[],"change_id":"Ieea4f055a491a838367da7b50bceb0171b3890c5","subject":"Adds shell commands for datastore-version-api","status":"ABANDONED","created":"2015-09-11 06:20:41.000000000","updated":"2016-04-04 13:17:42.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c6a544cee1d706722227279b80524b81de3f5730","_number":222482,"virtual_id_number":222482,"owner":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},{"value":-1,"date":"2016-01-27 23:06:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},{"date":"2015-12-18 08:55:54.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"all":[{"value":-1,"date":"2015-12-19 01:04:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-12-18 21:44:33.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-11 12:30:03.000000000","updated_by":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"reviewer":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"state":"REVIEWER"},{"updated":"2015-12-18 08:55:54.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2015-12-18 21:44:33.000000000","updated_by":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"reviewer":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"state":"REVIEWER"},{"updated":"2015-12-19 01:04:13.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-01-27 23:06:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"7b95cb0ec467b3ddedbb0bb2ba75244b26e3aa77","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-09-11 06:20:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"c1ebc7ee18fd06caa3316c7719b6f0412c69e438","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-09-11 06:26:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2218cfe81fdec118182ae42b93dbca6168608d5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 07:42:41.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-python26 http://logs.openstack.org/82/222482/2/check/gate-python-troveclient-python26/d3a5d34/ : SUCCESS in 47s\n- gate-python-troveclient-pep8 http://logs.openstack.org/82/222482/2/check/gate-python-troveclient-pep8/a7cc0b2/ : SUCCESS in 48s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/82/222482/2/check/gate-python-troveclient-docs/f7f78b1//doc/build/html/ : SUCCESS in 57s\n- gate-python-troveclient-python27 http://logs.openstack.org/82/222482/2/check/gate-python-troveclient-python27/1f2e4eb/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python34 http://logs.openstack.org/82/222482/2/check/gate-python-troveclient-python34/1d90158/ : SUCCESS in 1m 15s\n- gate-python-troveclient-pypy http://logs.openstack.org/82/222482/2/check/gate-python-troveclient-pypy/f0814b4/ : SUCCESS in 2m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/82/222482/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/08d3afa/ : SUCCESS in 1h 15m 03s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/82/222482/2/check/gate-trove-functional-dsvm-mysql/8abde0a/ : SUCCESS in 37m 40s","accounts_in_message":[],"_revision_number":2},{"id":"7bb60a6ce1336fbb18fca601cae13c0c56e5404c","author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"date":"2015-09-11 12:30:03.000000000","message":"Patch Set 2:\n\nAdding these commands to the client makes sense but I\u0027m now confused as to why this was put in the datastore-registration-api spec? It seems like this follows on from that work and should either have a new spec or be added to the existing spec. It would be useful to see the new CLI commands described in a spec.\n\nAlso, seems odd that there is no BP reference on this change.","accounts_in_message":[],"_revision_number":2},{"id":"0fb1dcfe840f13605aef1f477e7c3ef9fbedc804","author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"date":"2015-09-11 15:19:48.000000000","message":"Patch Set 3: Commit message was updated","accounts_in_message":[],"_revision_number":3},{"id":"6d36d32b7e77e3a8eda48ab1e0a58c2f1be28c8e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 16:16:12.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-python26 http://logs.openstack.org/82/222482/3/check/gate-python-troveclient-python26/e581881/ : SUCCESS in 52s\n- gate-python-troveclient-pep8 http://logs.openstack.org/82/222482/3/check/gate-python-troveclient-pep8/d224136/ : SUCCESS in 54s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/82/222482/3/check/gate-python-troveclient-docs/bc062ba//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python27 http://logs.openstack.org/82/222482/3/check/gate-python-troveclient-python27/b65c9e3/ : SUCCESS in 1m 00s\n- gate-python-troveclient-python34 http://logs.openstack.org/82/222482/3/check/gate-python-troveclient-python34/d46ee06/ : SUCCESS in 1m 12s\n- gate-python-troveclient-pypy http://logs.openstack.org/82/222482/3/check/gate-python-troveclient-pypy/a5fb3c0/ : SUCCESS in 1m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/82/222482/3/check/gate-tempest-dsvm-neutron-src-python-troveclient/103feec/ : SUCCESS in 54m 43s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/82/222482/3/check/gate-trove-functional-dsvm-mysql/f7ff783/ : SUCCESS in 24m 08s","accounts_in_message":[],"_revision_number":3},{"id":"8d01ee79e28b2ad5ab7466ea46b29b51eb3927f9","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2015-12-18 08:55:54.000000000","message":"Patch Set 3:\n\nHmm, I can\u0027t seem to find the blueprint - is the name wrong or is it just launchpad is really bad at this?","accounts_in_message":[],"_revision_number":3},{"id":"c6982e751765af372b2f7b00e2c189d186058dcc","author":{"_account_id":9782,"name":"Morgan Jones","email":"morgan@tesora.com","username":"vgnbkr"},"date":"2015-12-18 21:44:33.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"0a2bacf0567571d3760521d759a3cc7a4290d377","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2015-12-19 01:04:13.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)\n\nMy comments are not about the code in this patch, but about the concept itself. i.e. I\u0027m not commenting on the \u0027code\u0027 but rather the motivation for the change and the consequences.\n\nAs stated in one of the inline comments, I will assume that this relates to the spec merged in Liberty called https://github.com/openstack/trove-specs/blob/master/specs/liberty/datastore-registration-api.rst\n\nMany of my comments now come after reviewing the code and should/could well have been caught during the review of the spec if I had been astute enough.\n\nBut I\u0027m not; I was not.\n\nI realize that the spec says some of these things should be implemented, in reviewing the code now I\u0027m realizing this is a bad thing.","accounts_in_message":[],"_revision_number":3},{"id":"a3c8c52f367acea1dd88625105006fb0d70a0fae","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-27 23:06:07.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"c6a544cee1d706722227279b80524b81de3f5730","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-04-04 13:17:42.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f42887216451fec6346528a57f497afa4e5f6c9f","revisions":{"dbc4378e688deea29266da55ef0873cbefe0119b":{"kind":"REWORK","_number":1,"created":"2015-09-11 06:20:41.000000000","uploader":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"ref":"refs/changes/82/222482/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/82/222482/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/1"}}},"commit":{"parents":[{"commit":"7132f5ff78af75645c3430d35094b3c9aba49200","subject":"Merge \"Root enablement for Vertica clusters/instances\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/7132f5ff78af75645c3430d35094b3c9aba49200"}]}],"author":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 06:15:57.000000000","tz":0},"committer":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 06:18:25.000000000","tz":0},"subject":"Adds shell commands for datastore-version-api","message":"Adds shell commands for datastore-version-api\n\nAdded following shell commands\n- datastore-version-create\n- datastore-version-update\n- datastore-version-delete\n\nAlso added the unit-tests for these APIs.\n\nChange-Id: Ieea4f055a491a838367da7b50bceb0171b3890c5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/dbc4378e688deea29266da55ef0873cbefe0119b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/dbc4378e688deea29266da55ef0873cbefe0119b"}]},"branch":"refs/heads/master"},"d3353b867b2b1f0e4e5cdc3fecbebf6b4b7c7d3c":{"kind":"REWORK","_number":2,"created":"2015-09-11 06:26:56.000000000","uploader":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"ref":"refs/changes/82/222482/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/82/222482/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/2"}}},"commit":{"parents":[{"commit":"7132f5ff78af75645c3430d35094b3c9aba49200","subject":"Merge \"Root enablement for Vertica clusters/instances\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/7132f5ff78af75645c3430d35094b3c9aba49200"}]}],"author":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 06:15:57.000000000","tz":0},"committer":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 06:24:31.000000000","tz":0},"subject":"Adds shell commands for datastore-version-api","message":"Adds shell commands for datastore-version-api\n\nAdded following shell commands\n- datastore-version-create\n- datastore-version-update\n- datastore-version-delete\n\nAlso added the unit-tests for these APIs.\n\nChange-Id: Ieea4f055a491a838367da7b50bceb0171b3890c5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/d3353b867b2b1f0e4e5cdc3fecbebf6b4b7c7d3c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/d3353b867b2b1f0e4e5cdc3fecbebf6b4b7c7d3c"}]},"branch":"refs/heads/master"},"f42887216451fec6346528a57f497afa4e5f6c9f":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2015-09-11 15:19:48.000000000","uploader":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"ref":"refs/changes/82/222482/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/82/222482/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/82/222482/3"}}},"commit":{"parents":[{"commit":"7132f5ff78af75645c3430d35094b3c9aba49200","subject":"Merge \"Root enablement for Vertica clusters/instances\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/7132f5ff78af75645c3430d35094b3c9aba49200"}]}],"author":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 06:15:57.000000000","tz":0},"committer":{"name":"Sushil Kumar","email":"skm.net@gmail.com","date":"2015-09-11 15:19:48.000000000","tz":0},"subject":"Adds shell commands for datastore-version-api","message":"Adds shell commands for datastore-version-api\n\nAdded following shell commands\n- datastore-version-create\n- datastore-version-update\n- datastore-version-delete\n\nAlso added the unit-tests for these APIs.\n\nChange-Id: Ieea4f055a491a838367da7b50bceb0171b3890c5\nImplements: blueprint datastore-registration-api\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/f42887216451fec6346528a57f497afa4e5f6c9f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/f42887216451fec6346528a57f497afa4e5f6c9f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}