)]}'
{"id":"openstack%2Fpython-troveclient~264093","triplet_id":"openstack%2Fpython-troveclient~master~I718b86e83b93a4e778710b9de895f2796a9b6d61","project":"openstack/python-troveclient","branch":"master","topic":"assertIsInstance","hashtags":[],"change_id":"I718b86e83b93a4e778710b9de895f2796a9b6d61","subject":"Change assertTrue(isinstance()) by optimal assert","status":"MERGED","created":"2016-01-06 09:39:33.000000000","updated":"2016-01-08 20:28:16.000000000","submitted":"2016-01-08 20:28:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"915ba05defdedb09a93d6f88c235383fb9176e23","_number":264093,"virtual_id_number":264093,"owner":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":2,"date":"2016-01-08 20:28:16.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"all":[{"value":2,"date":"2016-01-08 07:11:40.000000000","_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},{"value":1,"date":"2016-01-08 15:59:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-01-08 16:44:27.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":1,"date":"2016-01-08 07:13:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"all":[{"value":0,"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-01-08 16:44:27.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-08 07:11:40.000000000","updated_by":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"reviewer":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"state":"REVIEWER"},{"updated":"2016-01-08 07:13:25.000000000","updated_by":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"reviewer":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"state":"REVIEWER"},{"updated":"2016-01-08 15:59:25.000000000","updated_by":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"reviewer":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"state":"REVIEWER"},{"updated":"2016-01-08 16:44:27.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2016-01-08 20:28:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"1f26f4ff212b2d8f0a6bba678731b76395676de0","author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"date":"2016-01-06 09:39:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f3bf71c55f6e6612b4d528cf75744a9b5f1499c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-06 11:26:27.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/93/264093/1/check/gate-python-troveclient-pep8/e9277b1/ : SUCCESS in 49s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/93/264093/1/check/gate-python-troveclient-docs/502fbb4//doc/build/html/ : SUCCESS in 57s\n- gate-python-troveclient-python27 http://logs.openstack.org/93/264093/1/check/gate-python-troveclient-python27/1335777/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python34 http://logs.openstack.org/93/264093/1/check/gate-python-troveclient-python34/a96a761/ : SUCCESS in 1m 07s\n- gate-python-troveclient-pypy http://logs.openstack.org/93/264093/1/check/gate-python-troveclient-pypy/cd7ab24/ : SUCCESS in 1m 38s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/93/264093/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/9130929/ : SUCCESS in 1h 10m 51s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/93/264093/1/check/gate-trove-functional-dsvm-mysql/59568a8/ : SUCCESS in 1h 29m 50s","accounts_in_message":[],"_revision_number":1},{"id":"1a3319f2f2389f04c860044546e9a77cf902090f","author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"date":"2016-01-08 07:08:05.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"220444c8e110e4eef7cf4f1ab2ddd4f06244b1af","author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"date":"2016-01-08 07:11:15.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"07fc2094ec1e5cdbbe2c4d25f3433a4f644a45d4","author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"date":"2016-01-08 07:11:40.000000000","message":"Patch Set 2: Code-Review+2\n\ni linked this to the existing bug","accounts_in_message":[],"_revision_number":2},{"id":"992c3d57ae0305a2c2c5daf5ecc9eddad28c2bbe","author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"date":"2016-01-08 07:13:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"70fa009aee3fb1e2c9d98c1ceedde1fd616db0a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 08:36:40.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/93/264093/2/check/gate-python-troveclient-pep8/cd0e0f2/ : SUCCESS in 56s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/93/264093/2/check/gate-python-troveclient-docs/d05347d//doc/build/html/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python27 http://logs.openstack.org/93/264093/2/check/gate-python-troveclient-python27/4a871db/ : SUCCESS in 56s\n- gate-python-troveclient-python34 http://logs.openstack.org/93/264093/2/check/gate-python-troveclient-python34/3d40d46/ : SUCCESS in 59s\n- gate-python-troveclient-pypy http://logs.openstack.org/93/264093/2/check/gate-python-troveclient-pypy/0ab267d/ : SUCCESS in 1m 50s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/93/264093/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/8f1c84d/ : SUCCESS in 1h 08m 52s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/93/264093/2/check/gate-trove-functional-dsvm-mysql/a69b00a/ : SUCCESS in 1h 18m 18s","accounts_in_message":[],"_revision_number":2},{"id":"8f295ae69482e4872e7347d9bff12118d7f9c863","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-01-08 15:59:25.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"f2599e3b4651f7df32eef851290f07573de12a88","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2016-01-08 16:44:27.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"e93229d36a7c11ce0f491501daf02452503c62ac","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 16:44:32.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2853767c50d56d8393653dd830a9065db2ce3673","date":"2016-01-08 20:28:16.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"c6a9a0e9237f8adbc4992122537d50178cad8adf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-08 20:28:16.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs http://docs-draft.openstack.org/93/264093/2/gate/gate-python-troveclient-docs/1a059f4//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-troveclient-pep8 http://logs.openstack.org/93/264093/2/gate/gate-python-troveclient-pep8/759d16e/ : SUCCESS in 1m 03s\n- gate-python-troveclient-python27 http://logs.openstack.org/93/264093/2/gate/gate-python-troveclient-python27/578d2ed/ : SUCCESS in 1m 09s\n- gate-python-troveclient-python34 http://logs.openstack.org/93/264093/2/gate/gate-python-troveclient-python34/979924a/ : SUCCESS in 1m 12s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/93/264093/2/gate/gate-tempest-dsvm-neutron-src-python-troveclient/7ddae62/ : SUCCESS in 1h 19m 07s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/93/264093/2/gate/gate-trove-functional-dsvm-mysql/d36dad4/ : SUCCESS in 1h 36m 24s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6b02886348673f57442a469518d30a1d289fa0d4","revisions":{"e470c264c0244345a53899d57c1fe8ba12d316dd":{"kind":"REWORK","_number":1,"created":"2016-01-06 09:39:33.000000000","uploader":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"ref":"refs/changes/93/264093/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/93/264093/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/1"}}},"commit":{"parents":[{"commit":"5a22620144f6a2b95f20ea79409bf6869207ea9d","subject":"Merge \"Drop py33 support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5a22620144f6a2b95f20ea79409bf6869207ea9d"}]}],"author":{"name":"yangyapeng","email":"yang.yapeng@99cloud.net","date":"2016-01-04 22:31:58.000000000","tz":-300},"committer":{"name":"yangyapeng","email":"yang.yapeng@99cloud.net","date":"2016-01-04 22:31:58.000000000","tz":-300},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of assertTrue(isinstance(A, B)),\nThe correct way is to use assertIsInstance(A,B) provided by testtools\n\nChange-Id: I718b86e83b93a4e778710b9de895f2796a9b6d61\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e470c264c0244345a53899d57c1fe8ba12d316dd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e470c264c0244345a53899d57c1fe8ba12d316dd"}]},"branch":"refs/heads/master"},"6b02886348673f57442a469518d30a1d289fa0d4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-01-08 07:11:15.000000000","uploader":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"ref":"refs/changes/93/264093/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/93/264093/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/93/264093/2"}}},"commit":{"parents":[{"commit":"5a22620144f6a2b95f20ea79409bf6869207ea9d","subject":"Merge \"Drop py33 support\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5a22620144f6a2b95f20ea79409bf6869207ea9d"}]}],"author":{"name":"yangyapeng","email":"yang.yapeng@99cloud.net","date":"2016-01-04 22:31:58.000000000","tz":-300},"committer":{"name":"Craig Vyvial","email":"cp16net@gmail.com","date":"2016-01-08 07:10:56.000000000","tz":0},"subject":"Change assertTrue(isinstance()) by optimal assert","message":"Change assertTrue(isinstance()) by optimal assert\n\nSome of tests use different method of assertTrue(isinstance(A, B)),\nThe correct way is to use assertIsInstance(A,B) provided by testtools\n\nCloses-bug: #1268480\nChange-Id: I718b86e83b93a4e778710b9de895f2796a9b6d61\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/6b02886348673f57442a469518d30a1d289fa0d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/6b02886348673f57442a469518d30a1d289fa0d4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}