)]}'
{"id":"openstack%2Fpython-troveclient~276658","triplet_id":"openstack%2Fpython-troveclient~master~Ic77c2db6efe498e59c1e6364509d8915912c8d77","project":"openstack/python-troveclient","branch":"master","topic":"invalid_import_order_troveclient","hashtags":[],"change_id":"Ic77c2db6efe498e59c1e6364509d8915912c8d77","subject":"Fix module\u0027s import order","status":"ABANDONED","created":"2016-02-05 10:01:22.000000000","updated":"2016-03-13 16:05:38.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"925a3d49d46884fdc2e7ed77f5ea3244e0065d41","_number":276658,"virtual_id_number":276658,"owner":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":-1,"date":"2016-03-03 17:19:29.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-02-08 06:50:22.000000000","_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"date":"2016-02-08 12:40:04.000000000","_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"date":"2016-02-09 11:19:39.000000000","_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":-1,"date":"2016-02-05 16:25:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":-1,"date":"2016-02-05 16:03:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"value":-1,"date":"2016-02-17 16:13:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"value":-1,"date":"2016-02-09 16:20:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-05 16:03:13.000000000","updated_by":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"reviewer":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"state":"REVIEWER"},{"updated":"2016-02-05 16:25:03.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-02-08 12:40:04.000000000","updated_by":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"reviewer":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"state":"REVIEWER"},{"updated":"2016-02-09 11:19:39.000000000","updated_by":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"reviewer":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"state":"REVIEWER"},{"updated":"2016-02-09 16:20:24.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"},{"updated":"2016-02-17 16:13:38.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2016-03-03 17:19:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d670394119b56e07c162e848a5f63e0b393085fa","author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"date":"2016-02-05 10:01:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"9522bce1ed557dbb4933b39115d9054d1aa15699","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-05 11:55:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-pep8/b8d0537/ : SUCCESS in 1m 09s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/58/276658/1/check/gate-python-troveclient-docs/50f1ebf//doc/build/html/ : SUCCESS in 2m 08s\n- gate-python-troveclient-python27 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-python27/dc6854a/ : SUCCESS in 1m 18s\n- gate-python-troveclient-python34 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-python34/4283247/ : SUCCESS in 1m 16s\n- gate-python-troveclient-pypy http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-pypy/47a8291/ : SUCCESS in 1m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/58/276658/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/c31a892/ : FAILURE in 1h 10m 41s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/58/276658/1/check/gate-trove-functional-dsvm-mysql/3e67af0/ : SUCCESS in 1h 20m 01s","accounts_in_message":[],"_revision_number":1},{"id":"8108a1ed6e8ea68e787240617414b9f0e645bf94","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-05 16:03:13.000000000","message":"Patch Set 1: Code-Review-1\n\nOverall looks good but you should also enable the appropriate hacking rule (see the tox.ini file from the Trove project) to verify you got it right and also to ensure we don\u0027t need to worry about it any more.","accounts_in_message":[],"_revision_number":1},{"id":"7cb51025b400564c97c334686a81c21385222a1e","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-02-05 16:25:03.000000000","message":"Patch Set 1: Code-Review-1\n\n-1 unless the hacking rule is enabled.","accounts_in_message":[],"_revision_number":1},{"id":"771dc62ea8cfdb077fd3be2c421699fcc598f16c","author":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"date":"2016-02-08 06:50:22.000000000","message":"Patch Set 1:\n\nHi Petr, amrith,\n\nI have verified tox.ini from trove, but not found any hacking checks are enabled in trove as well as troveclient. Pep8 error is given if imports are not in alphabetical orders.\n\nPlease let me know if I am missing something.","accounts_in_message":[],"_revision_number":1},{"id":"6a37ee95b33cb039043118904e7e9c0cbc94139e","author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"date":"2016-02-08 12:40:04.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"06cb588cc364a401b7c0d16d13a89012b690f28f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-08 14:06:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-pep8/eda06d7/ : SUCCESS in 41s\n- gate-python-troveclient-docs http://docs-draft.openstack.org/58/276658/1/check/gate-python-troveclient-docs/aeb7f20//doc/build/html/ : SUCCESS in 1m 51s\n- gate-python-troveclient-python27 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-python27/1a2499c/ : SUCCESS in 1m 02s\n- gate-python-troveclient-python34 http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-python34/6e603e8/ : SUCCESS in 1m 18s\n- gate-python-troveclient-pypy http://logs.openstack.org/58/276658/1/check/gate-python-troveclient-pypy/b10ba7e/ : SUCCESS in 1m 28s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/58/276658/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/425611c/ : SUCCESS in 1h 03m 53s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/58/276658/1/check/gate-trove-functional-dsvm-mysql/ca57790/ : SUCCESS in 1h 22m 44s","accounts_in_message":[],"_revision_number":1},{"id":"9fc1783d3a2c11521234b5bd3bd70422543b0cd7","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-08 16:29:10.000000000","message":"Patch Set 1:\n\n\u003e I have verified tox.ini from trove, but not found any hacking\n \u003e checks are enabled in trove as well as troveclient. Pep8 error is\n \u003e given if imports are not in alphabetical orders.\n\nI cannot reproduce the error on the current master.","accounts_in_message":[],"_revision_number":1},{"id":"11580863090fedf3dbd4704c7b879d201da31959","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-08 16:35:29.000000000","message":"Patch Set 1:\n\n\u003e \u003e I have verified tox.ini from trove, but not found any hacking\n \u003e \u003e checks are enabled in trove as well as troveclient. Pep8 error is\n \u003e \u003e given if imports are not in alphabetical orders.\n \u003e \n \u003e I cannot reproduce the error on the current master.\n\nI cannot even reproduce the failure after shuffling the imports on this patch set.","accounts_in_message":[],"_revision_number":1},{"id":"71337b1978e6a8ba4389f61a7f43d44e05df3387","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-08 16:49:33.000000000","message":"Patch Set 1:\n\nIt does not seem like the hacking rule gets invoked...","accounts_in_message":[],"_revision_number":1},{"id":"9f9a15c99cd87fff4af8ffb1e4ab4204a38df990","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2016-02-09 11:19:39.000000000","message":"Patch Set 1:\n\nProblem: Why pep8 is not giving error on master branch?\n\nOpenStack follows custom import standards as defined in import order template [1].\n\n{{stdlib imports in human alphabetical order}} \\n {{third-party lib imports in human alphabetical order}} \\n {{project imports in human alphabetical order}} \\n \\n {{begin your code}}\n\nYou can see each import section (standard, third-party and project imports) is separated by new line. pep8 will only check for the order of imports in each block separately and not all 3 blocks together. Also it will not check whether a particular module is kept in the wrong block i.e. standard module is imported in third-party module block.\n\nLet\u0027s take the example of https://github.com/openstack/python-troveclient/blob/master/troveclient/compat/common.py#L15\n\nHere pep8/flake8 will check whether each import block is in alphabetical order or not. That\u0027s it. As we can see each import block is in alphabetical order pep8 will not raise any error, but even if all imports in the block are in alphabetical order, some modules are in the wrong block(sys module) according to OpenStack import standards. This needs to be corrected  manually.\n\nNOTE:\nSome files contain invalid import orders but they are ignored because the directories to which they belong are a part flake8 \u0027exclude\u0027 list.\nFor example https://github.com/openstack/python-troveclient/blob/master/doc/source/conf.py#L21 has invalid import order but the file is not check because \u0027doc\u0027 is in the exclude list: https://github.com/openstack/python-troveclient/blob/master/tox.ini#L55\n\n[1] http://docs.openstack.org/developer/hacking/#import-order-template","accounts_in_message":[],"_revision_number":1},{"id":"48397eef5526d68389d4de656bdf6c664e79a3f4","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-02-09 12:26:58.000000000","message":"Patch Set 1:\n\nYes we understand the problem. That notwithstanding, the issue is this ...\n\nYour change fixes the situation now and fixes the import order. However, nothing in your change prevents new code and other changes from messing up the order again.\n\nTo prevent this, you have to enable a tox rule to enable the appropriate pep8 test.\n\nWithout that change, I believe that this change is incomplete.","accounts_in_message":[],"_revision_number":1},{"id":"8dc8ab0b84ceee7f2ca2f3765ece70d8daadd20d","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2016-02-09 13:17:10.000000000","message":"Patch Set 1:\n\n@Amrith the checks are already enabled for alphabetical order check. What we do not have is the ability to identify whether a module import is placed\nin the correct group or not. The check for latter case existed but was then removed from the hacking [1] project due to complications [2].\n\nIMO checking suitable group for the import should be the responsibility of the reviewer and this is how it is done in other projects.\nIf you have any idea how to add such a rule please suggest.\n\n[1] https://github.com/openstack-dev/hacking\n[2] http://lists.openstack.org/pipermail/openstack-dev/2014-December/052519.html","accounts_in_message":[],"_revision_number":1},{"id":"79258f60add55e02bc1701acd3dbc4d06bb214ce","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-09 14:00:50.000000000","message":"Patch Set 1:\n\n\u003e IMO checking suitable group for the import should be the\n \u003e responsibility of the reviewer.\n\nFrankly, I don\u0027t think ppl will check this on a regular basis. The whole ordering schema is just too convoluted.\nAs Python itself does not enforce any particular import order it\u0027s only going to lead to arguments and more review \u0027noise\u0027 (I think we have already been there...).\n\nI really think we should have a hacking rule first or it\u0027s going to diverge almost instantly. I also don\u0027t think this would be a kind of check that should be offloaded on ppl. I believe, ppl are better at things other than enforcing an import order...","accounts_in_message":[],"_revision_number":1},{"id":"7b4af39334de4fad88549c20d04f2903e0679e05","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2016-02-09 16:20:24.000000000","message":"Patch Set 1: Code-Review-1\n\nUnless H306 is enabled, I don\u0027t see the point of having this patch set.","accounts_in_message":[],"_revision_number":1},{"id":"da0c3e21f1e182cd7140ba7a8b539b1b7519846f","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-02-09 20:40:49.000000000","message":"Patch Set 1:\n\n\u003e Unless H306 is enabled, I don\u0027t see the point of having this patch\n \u003e set.\n\nH306 is enabled, but it currently only validates the alphabetical ordering of imports not the library grouping (i.e. system, 3rd-party, trove).","accounts_in_message":[],"_revision_number":1},{"id":"1b93af3bbd7fed5b307afdd1e55e17b5376ce496","author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"date":"2016-02-17 12:41:59.000000000","message":"Patch Set 1:\n\nH306 is partially enabled already.\n\nTo enable it completetly we need to add code something like: https://github.com/openstack/sahara/blob/5240195f4be8544ec61f595ba8c235ff4a86201b/sahara/utils/hacking/import_checks.py#L406\n\nAs can be seen from the information in this commit message : https://github.com/openstack/sahara/commit/16b05b8b547f8c34a465d90a4ba008271503861c the above code is only maintained in sahara. It has been removed from upstream and it works only for py27(because the module list maintained are py27 specific). Still if this is what we want then we can work on this. Kindly suggest.","accounts_in_message":[],"_revision_number":1},{"id":"8059b6b0b365e157e2745030c2684d8adf9bc4d2","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2016-02-17 16:13:38.000000000","message":"Patch Set 1: Code-Review-1\n\nWe typically try to make these kind of changes at the beginning of a cycle to avoid unnecessary merge conflicts.  Unfortunately, we also have plans to move to Python 3 at the beginning of the Newton cycle so it\u0027s unlikely this change will provide us with any benefit whatsoever.","accounts_in_message":[],"_revision_number":1},{"id":"ad035fc5b78ac8e609ceb24cea8ce96768de8707","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-03 17:19:29.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"6f0fe95ed68851bc984cc97d84578545be76e2cb","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-03-13 16:04:45.000000000","message":"Patch Set 1:\n\nThe changes proposed here seem to be incomplete as they fix the order for now and don\u0027t really ensure that the order is preserved. Furthermore, there\u0027s no way to programmatically ensure that this remains the case. I agree, this should be left up to the reviewer. While H306 is enabled, the doc directory is ignored so the change to doc/source/conf.py seems to be pointless.\n\nOn the whole, I don\u0027t see how this change moves the project forward. Given the number of people who have -1\u0027ed it, and the fact that it hasn\u0027t seen any activity in a couple of week, I suspect it is heading for abandonment.","accounts_in_message":[],"_revision_number":1},{"id":"d99f721440cb520a9224f3bc8163a4d51c2e07ad","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-03-13 16:05:38.000000000","message":"Abandoned\n\nIt has been 3 weeks since this patch set got any updates from the author. If you still wish to proceed with this change, please restore it.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8b28b30bd1c12bb7ecf89ad5563601a23901a92c","revisions":{"8b28b30bd1c12bb7ecf89ad5563601a23901a92c":{"kind":"REWORK","_number":1,"created":"2016-02-05 10:01:22.000000000","uploader":{"_account_id":20182,"name":"Bhagyashri Shewale","email":"bshewale@redhat.com","username":"bhagyashris"},"ref":"refs/changes/58/276658/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/58/276658/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/58/276658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/58/276658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/58/276658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/58/276658/1"}}},"commit":{"parents":[{"commit":"634dd615e65a9c77afe8cba8c68f5217cc756f27","subject":"Merge \"remove unnecessary message when running unit test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/634dd615e65a9c77afe8cba8c68f5217cc756f27"}]}],"author":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2016-02-05 09:13:30.000000000","tz":-480},"committer":{"name":"bhagyashris","email":"bhagyashri.shewale@nttdata.com","date":"2016-02-05 10:00:41.000000000","tz":-480},"subject":"Fix module\u0027s import order","message":"Fix module\u0027s import order\n\nMade corrections in import order for built-in, third party and\nproject specific modules as per OpenStack import standards [1].\n\n[1] http://docs.openstack.org/developer/hacking/#import-order-template\n\nChange-Id: Ic77c2db6efe498e59c1e6364509d8915912c8d77\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/8b28b30bd1c12bb7ecf89ad5563601a23901a92c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/8b28b30bd1c12bb7ecf89ad5563601a23901a92c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}