)]}'
{"troveclient/v1/instances.py":[{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"863e1901c99fcafe171fca2dee92ad854d3284b3","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            body[\"instance\"][\"name\"] \u003d name"},{"line_number":155,"context_line":"        if detach_replica_source:"},{"line_number":156,"context_line":"            # NOTE(mriedem): We don\u0027t send slave_of since it was removed from"},{"line_number":157,"context_line":"            # the trove API in mitaka."},{"line_number":158,"context_line":"            body[\"instance\"][\"replica_of\"] \u003d None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        url \u003d \"/instances/%s\" % base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_7efb76c1","line":157,"range":{"start_line":157,"start_character":37,"end_line":157,"end_character":38},"updated":"2016-03-10 00:18:00.000000000","message":"but aren\u0027t we using the slave_of in this changeset: https://review.openstack.org/#/c/290871/2/trove/instance/service.py.","commit_id":"3c71e52b408bbd6c33fca85188db2c8f156fb341"},{"author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"change_message_id":"2e79beaea20b5516a3da19a1dfb5da02b01aa9b5","unresolved":false,"context_lines":[{"line_number":154,"context_line":"            body[\"instance\"][\"name\"] \u003d name"},{"line_number":155,"context_line":"        if detach_replica_source:"},{"line_number":156,"context_line":"            # NOTE(mriedem): We don\u0027t send slave_of since it was removed from"},{"line_number":157,"context_line":"            # the trove API in mitaka."},{"line_number":158,"context_line":"            body[\"instance\"][\"replica_of\"] \u003d None"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        url \u003d \"/instances/%s\" % base.getid(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1c205ef6","line":157,"range":{"start_line":157,"start_character":37,"end_line":157,"end_character":38},"in_reply_to":"5aef4532_7efb76c1","updated":"2016-03-10 13:35:20.000000000","message":"I see why this question really didn\u0027t make sense. So I was looking at the version of this file in the liberty release and it was setting body[\"instance\"][\"slave_of\"] \u003d None and that line was not added here while reverting. And the comment above confused me a bit since we reverted the changes on the server as well, so the slave_of was back in the server side as well.","commit_id":"3c71e52b408bbd6c33fca85188db2c8f156fb341"}]}