)]}'
{"id":"openstack%2Fpython-troveclient~304910","triplet_id":"openstack%2Fpython-troveclient~master~Ic6486570d4beb138fdcd0c4e700ccc8d734d3e5e","project":"openstack/python-troveclient","branch":"master","topic":"bug/1530195","hashtags":[],"change_id":"Ic6486570d4beb138fdcd0c4e700ccc8d734d3e5e","subject":"Added check to prevent adding argument without help string","status":"MERGED","created":"2016-04-13 00:09:22.000000000","updated":"2016-04-19 23:54:48.000000000","submitted":"2016-04-19 23:54:48.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"29bc83306243c9576be69af29020d7a0e20fcf6f","_number":304910,"virtual_id_number":304910,"owner":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":2,"date":"2016-04-19 23:54:48.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":2,"date":"2016-04-13 10:04:00.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":1,"date":"2016-04-13 14:49:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-15 19:38:36.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":2,"date":"2016-04-19 22:10:30.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":1,"date":"2016-04-19 22:10:30.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-13 10:04:00.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-04-13 14:49:30.000000000","updated_by":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"reviewer":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"state":"REVIEWER"},{"updated":"2016-04-15 19:38:36.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2016-04-19 22:10:30.000000000","updated_by":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"reviewer":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"state":"REVIEWER"},{"updated":"2016-04-19 23:54:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a4348c7cc7eee22857b3987a597e1cc79a644df6","author":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"date":"2016-04-13 00:09:22.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"43f4499bd4fbc80264a385358ad55b0fb1d26495","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-13 01:25:02.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs http://docs-draft.openstack.org/10/304910/1/check/gate-python-troveclient-docs/bcafdeb//doc/build/html/ : SUCCESS in 4m 34s\n- gate-python-troveclient-pep8 http://logs.openstack.org/10/304910/1/check/gate-python-troveclient-pep8/468d1fd/ : SUCCESS in 3m 36s\n- gate-python-troveclient-python27 http://logs.openstack.org/10/304910/1/check/gate-python-troveclient-python27/8444b2c/ : SUCCESS in 4m 10s\n- gate-python-troveclient-python34 http://logs.openstack.org/10/304910/1/check/gate-python-troveclient-python34/3f538d5/ : SUCCESS in 4m 51s\n- gate-python-troveclient-pypy http://logs.openstack.org/10/304910/1/check/gate-python-troveclient-pypy/164f548/ : SUCCESS in 4m 51s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/10/304910/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/63d05c8/ : SUCCESS in 56m 01s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/10/304910/1/check/gate-trove-functional-dsvm-mysql/9ec374c/ : SUCCESS in 1h 12m 21s","accounts_in_message":[],"_revision_number":1},{"id":"6273e228caba37f77e6af8d05ccb3728269189c7","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-04-13 10:04:00.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"841f05417468625fca892229b33c90420fb711fa","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-04-13 14:49:30.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"2f53c926f14bc927d9e871d8a42b76eeecafd734","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2016-04-15 19:38:36.000000000","message":"Patch Set 1: Code-Review+2\n\nTested and works","accounts_in_message":[],"_revision_number":1},{"id":"284e9891606095c321ce0edff02f9524a832a9d0","author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"date":"2016-04-19 22:10:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"6e32b64cb43e5146569da5dcdbe7a01bc44b1c64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-19 22:10:39.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ad71007801cf6b335d48db73547ca38a29b58492","date":"2016-04-19 23:54:48.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"5312b3f5678e439be964261d0ae9c2d99f724bd5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-19 23:54:48.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs http://docs-draft.openstack.org/10/304910/1/gate/gate-python-troveclient-docs/83366b3//doc/build/html/ : SUCCESS in 3m 43s\n- gate-python-troveclient-pep8 http://logs.openstack.org/10/304910/1/gate/gate-python-troveclient-pep8/9c64c2c/ : SUCCESS in 2m 18s\n- gate-python-troveclient-python27 http://logs.openstack.org/10/304910/1/gate/gate-python-troveclient-python27/e38a065/ : SUCCESS in 2m 15s\n- gate-python-troveclient-python34 http://logs.openstack.org/10/304910/1/gate/gate-python-troveclient-python34/1f67957/ : SUCCESS in 3m 22s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/10/304910/1/gate/gate-tempest-dsvm-neutron-src-python-troveclient/3539c29/ : SUCCESS in 53m 24s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/10/304910/1/gate/gate-trove-functional-dsvm-mysql/dc47cce/ : SUCCESS in 1h 31m 48s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5d8412432b999b4d96c4f63825c84338cdd34d35","revisions":{"5d8412432b999b4d96c4f63825c84338cdd34d35":{"kind":"REWORK","_number":1,"created":"2016-04-13 00:09:22.000000000","uploader":{"_account_id":20466,"name":"Tin Lam","email":"tin@lam.wtf","username":"tinlam"},"ref":"refs/changes/10/304910/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/10/304910/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/304910/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/304910/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/304910/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/10/304910/1"}}},"commit":{"parents":[{"commit":"4955d07f036de6c0d31988c4cd14afab72054c3c","subject":"Merge \"Fix inadvertent generation of file during tox test\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/4955d07f036de6c0d31988c4cd14afab72054c3c"}]}],"author":{"name":"Tin Lam","email":"tl3438@att.com","date":"2016-04-13 00:03:04.000000000","tz":-300},"committer":{"name":"Tin Lam","email":"tl3438@att.com","date":"2016-04-13 00:09:21.000000000","tz":-300},"subject":"Added check to prevent adding argument without help string","message":"Added check to prevent adding argument without help string\n\nAdded addition check in add_argument() to ensure it has help\nmessage is always present per Amrith\u0027s suggestion in this review:\nhttps://review.openstack.org/#/c/261425/\n\nChange-Id: Ic6486570d4beb138fdcd0c4e700ccc8d734d3e5e\nCloses-Bug: #1530195\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5d8412432b999b4d96c4f63825c84338cdd34d35"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5d8412432b999b4d96c4f63825c84338cdd34d35"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}