)]}'
{"id":"openstack%2Fpython-troveclient~375911","triplet_id":"openstack%2Fpython-troveclient~master~Ia89b9741731c07d8bf08691a1c6544742625cad6","project":"openstack/python-troveclient","branch":"master","topic":"avoid-some-problem","hashtags":[],"change_id":"Ia89b9741731c07d8bf08691a1c6544742625cad6","subject":"Avoid use xx\u003d[]  for parameter initial value","status":"MERGED","created":"2016-09-25 02:28:16.000000000","updated":"2016-10-05 19:47:59.000000000","submitted":"2016-10-05 19:47:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"399c5fe162cff859f71ab50d4e21f024a2842e76","_number":375911,"virtual_id_number":375911,"owner":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":2,"date":"2016-10-05 19:47:59.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":2,"date":"2016-10-04 12:42:20.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":2,"date":"2016-10-05 17:51:10.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":1,"date":"2016-10-05 17:51:10.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-25 05:51:48.000000000","updated_by":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"reviewer":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"state":"REVIEWER"},{"updated":"2016-10-04 12:42:20.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-10-05 17:51:10.000000000","updated_by":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"reviewer":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"state":"REVIEWER"},{"updated":"2016-10-05 19:47:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"075d92f124a48e492d5ec557fc927bdf96df8dd0","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-25 02:28:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"447cb2af0d1a6f4c2ade7e52661b0865df67bdd7","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-25 02:55:16.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"c7ef4d7547284d2e77999906247c86edd975a82b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-25 04:14:49.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/375911/2/check/gate-python-troveclient-docs-ubuntu-xenial/a8ca178//doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/11/375911/2/check/gate-python-troveclient-pep8-ubuntu-xenial/e9f9a05/ : SUCCESS in 2m 38s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/11/375911/2/check/gate-python-troveclient-python27-ubuntu-xenial/c64d7ce/ : SUCCESS in 2m 04s\n- gate-python-troveclient-python34 http://logs.openstack.org/11/375911/2/check/gate-python-troveclient-python34/a7e4937/ : SUCCESS in 2m 03s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/11/375911/2/check/gate-python-troveclient-python35-nv/78b7ed2/ : SUCCESS in 3m 28s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/11/375911/2/check/gate-python-troveclient-pypy/9fa53ca/ : FAILURE in 2m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/11/375911/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/bd26473/ : SUCCESS in 39m 10s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/11/375911/2/check/gate-trove-functional-dsvm-mysql/8baac8b/ : SUCCESS in 1h 19m 21s","accounts_in_message":[],"_revision_number":2},{"id":"41f99ee6a08fcaac170fd3e08126f0ab53864626","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-09-25 05:51:48.000000000","message":"Patch Set 2:\n\nThis really is issue only if the args get changed (values appended to the list) in the function. Although it\u0027s a recommended practice to use None, I don\u0027t think it would be that important in this case (list intender just for reading).","accounts_in_message":[],"_revision_number":2},{"id":"c97fb683b981d5c491cd608da16b8689238b7566","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-25 06:21:24.000000000","message":"Patch Set 2:\n\n\u003e This really is issue only if the args get changed (values appended\n \u003e to the list) in the function. Although it\u0027s a recommended practice\n \u003e to use None, I don\u0027t think it would be that important in this case\n \u003e (list intender just for reading).\n\nI feel under the specification would be better... Although the innocuous... and I think avoid problem may happen in the future is all we have to do...","accounts_in_message":[],"_revision_number":2},{"id":"d905aaa5d8faa136bb5f28e871877b3e92cf9e26","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-30 09:34:01.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"69bd4d1dfd606979899afaeafc3e0452893e4a66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 10:33:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/375911/3/check/gate-python-troveclient-docs-ubuntu-xenial/018b140//doc/build/html/ : SUCCESS in 6m 02s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/11/375911/3/check/gate-python-troveclient-pep8-ubuntu-xenial/c85a6d4/ : SUCCESS in 3m 18s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/11/375911/3/check/gate-python-troveclient-python27-ubuntu-xenial/5141306/ : SUCCESS in 3m 51s\n- gate-python-troveclient-python34 http://logs.openstack.org/11/375911/3/check/gate-python-troveclient-python34/a1dba82/ : SUCCESS in 3m 01s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/11/375911/3/check/gate-python-troveclient-python35-nv/3015153/ : SUCCESS in 4m 12s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/11/375911/3/check/gate-python-troveclient-pypy/2799147/ : FAILURE in 3m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/11/375911/3/check/gate-tempest-dsvm-neutron-src-python-troveclient/07946c9/ : SUCCESS in 43m 48s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/11/375911/3/check/gate-trove-functional-dsvm-mysql/d39b7e5/ : SUCCESS in 58m 13s","accounts_in_message":[],"_revision_number":3},{"id":"68611597cc801ae0ea4e8dc8d270682506d6737a","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-10-04 12:42:20.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"4c960e92c2789e56a624a67826035d108a4d02b7","author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"date":"2016-10-05 17:51:10.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"18865b555eaa4bbfd64c56d617c2bbbdc43485a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 17:51:20.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"dc049a2307d1c8a19fb25088846b7e1814163a6a","date":"2016-10-05 19:47:59.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"7f171be75c14fbf17c391a65e070e4d4f3e7aa60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-05 19:47:59.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/11/375911/3/gate/gate-python-troveclient-docs-ubuntu-xenial/30e1554//doc/build/html/ : SUCCESS in 3m 14s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/11/375911/3/gate/gate-python-troveclient-pep8-ubuntu-xenial/2026306/ : SUCCESS in 2m 48s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/11/375911/3/gate/gate-python-troveclient-python27-ubuntu-xenial/fcb8ecc/ : SUCCESS in 3m 10s\n- gate-python-troveclient-python34 http://logs.openstack.org/11/375911/3/gate/gate-python-troveclient-python34/9496780/ : SUCCESS in 2m 21s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/11/375911/3/gate/gate-tempest-dsvm-neutron-src-python-troveclient/677bfc0/ : SUCCESS in 43m 50s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/11/375911/3/gate/gate-trove-functional-dsvm-mysql/040c28f/ : SUCCESS in 1h 03m 32s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"12be3210eb2bd0ab3385f2a4216958cade126add","revisions":{"e7b1debeef4ca8f40c0fc6062f2e09e937ff1f16":{"kind":"REWORK","_number":1,"created":"2016-09-25 02:28:16.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/11/375911/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/11/375911/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/1"}}},"commit":{"parents":[{"commit":"c519fb4ed17e87840aa4ce2fecfd3eb82aee90b6","subject":"Merge \"Use strutils.to_slug() instead of utils.slugify()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c519fb4ed17e87840aa4ce2fecfd3eb82aee90b6"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-25 02:24:33.000000000","tz":-420},"committer":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-25 02:24:33.000000000","tz":-420},"subject":"Avoid use xx\u003d[]  for parameter initial value","message":"Avoid use xx\u003d[]  for parameter initial value\n\nUse xx \u003d [] for the parameter initial value, this parameter will\nonly be initialized at the first call, this is should be avoided.\nBetter choice is to set the initial value to None, then the initialization\ntime use xx\u003d xx or None\n\nmore information:http://effbot.org/zone/default-values.htm\n\nChange-Id: Ia89b9741731c07d8bf08691a1c6544742625cad6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e7b1debeef4ca8f40c0fc6062f2e09e937ff1f16"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e7b1debeef4ca8f40c0fc6062f2e09e937ff1f16"}]},"branch":"refs/heads/master"},"685b272e208b1909e8dbd644846615b48012a032":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-09-25 02:55:16.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/11/375911/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/11/375911/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/2"}}},"commit":{"parents":[{"commit":"c519fb4ed17e87840aa4ce2fecfd3eb82aee90b6","subject":"Merge \"Use strutils.to_slug() instead of utils.slugify()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c519fb4ed17e87840aa4ce2fecfd3eb82aee90b6"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-25 02:24:33.000000000","tz":-420},"committer":{"name":"jian.song","email":"jian.song@easystack.cn","date":"2016-09-25 02:55:13.000000000","tz":0},"subject":"Avoid use xx\u003d[]  for parameter initial value","message":"Avoid use xx\u003d[]  for parameter initial value\n\nUse xx \u003d [] for the parameter initial value, this parameter will\nonly be initialized at the first call, this is should be avoided.\nBetter choice is to set the initial value to None, then the initialization\ntime use xx\u003d xx or []\n\nmore information:http://effbot.org/zone/default-values.htm\n\nChange-Id: Ia89b9741731c07d8bf08691a1c6544742625cad6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/685b272e208b1909e8dbd644846615b48012a032"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/685b272e208b1909e8dbd644846615b48012a032"}]},"branch":"refs/heads/master"},"12be3210eb2bd0ab3385f2a4216958cade126add":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-09-30 09:34:01.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/11/375911/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/11/375911/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/11/375911/3"}}},"commit":{"parents":[{"commit":"c22d37b51cfe812b37562a8560e8ed6387fbc748","subject":"Merge \"Add a new command in the readme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c22d37b51cfe812b37562a8560e8ed6387fbc748"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-25 02:24:33.000000000","tz":-420},"committer":{"name":"jian.song","email":"jian.song@easystack.cn","date":"2016-09-30 09:34:01.000000000","tz":0},"subject":"Avoid use xx\u003d[]  for parameter initial value","message":"Avoid use xx\u003d[]  for parameter initial value\n\nUse xx \u003d [] for the parameter initial value, this parameter will\nonly be initialized at the first call, this is should be avoided.\nBetter choice is to set the initial value to None, then the initialization\ntime use xx\u003d xx or []\n\nmore information:http://effbot.org/zone/default-values.htm\n\nChange-Id: Ia89b9741731c07d8bf08691a1c6544742625cad6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/12be3210eb2bd0ab3385f2a4216958cade126add"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/12be3210eb2bd0ab3385f2a4216958cade126add"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}