)]}'
{"troveclient/v1/shell.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"105adde66554574052a7f2494c8d0a153afc68c8","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"Creates a new instance.\"\"\""},{"line_number":521,"context_line":"    flavor_id \u003d _find_flavor(cs, args.flavor).id"},{"line_number":522,"context_line":"    volume \u003d None"},{"line_number":523,"context_line":"    if args.size is not None:"},{"line_number":524,"context_line":"        volume \u003d {\"size\": args.size,"},{"line_number":525,"context_line":"                  \"type\": args.volume_type}"},{"line_number":526,"context_line":"    restore_point \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a8bc5a2_ce5d9d16","line":523,"updated":"2016-09-26 16:15:39.000000000","message":"while this makes sense from a programming perspective, what does specifying --size 0 mean?\n\nIf you believe that there is a rational reason why a person typing at a command line would actually type \n\ntrove create --size 0\n\n(and I don\u0027t posit that there is one), then the right thing would be to print an error and say that a size of 0 is not valid, correct?\n\nThe code as existed said you didn\u0027t provide a size which you assert is wrong, now the user provides a size and you quietly ignore it.\n\nHow is that better?","commit_id":"9e18d6f51f99bdcb4ebeea28122c2497152a0d11"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"d62fc908402b7b97a62a72efd002ee625ea6a4a9","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"Creates a new instance.\"\"\""},{"line_number":521,"context_line":"    flavor_id \u003d _find_flavor(cs, args.flavor).id"},{"line_number":522,"context_line":"    volume \u003d None"},{"line_number":523,"context_line":"    if args.size \u003c\u003d 0:"},{"line_number":524,"context_line":"        raise exceptions.ValidationError("},{"line_number":525,"context_line":"            \"Volume size \u0027%s\u0027 must be an integer and greater than 0.\""},{"line_number":526,"context_line":"            % args.size)"},{"line_number":527,"context_line":"    else:"},{"line_number":528,"context_line":"        volume \u003d {\"size\": args.size,"},{"line_number":529,"context_line":"                  \"type\": args.volume_type}"},{"line_number":530,"context_line":"    restore_point \u003d None"},{"line_number":531,"context_line":"    if args.backup:"},{"line_number":532,"context_line":"        restore_point \u003d {\"backupRef\": _find_backup(cs, args.backup).id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_bb21c7a1","line":529,"range":{"start_line":523,"start_character":4,"end_line":529,"end_character":43},"updated":"2016-09-29 19:55:15.000000000","message":"This won\u0027t work in python3 if size isn\u0027t given - it\u0027ll raise an error:\n\n  \u003e python3\n  Python 3.4.3 (default, Oct 14 2015, 20:28:29)\n  [GCC 4.8.4] on linux\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n  \u003e\u003e\u003e None \u003c\u003d 0\n  Traceback (most recent call last):\n    File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  TypeError: unorderable types: NoneType() \u003c int()\n\nSee: http://stackoverflow.com/questions/2214194/is-everything-greater-than-none\n\nYou\u0027ll need to do something like:\n\n  if args.size is not None and args.size \u003c\u003d 0:\n      raise exceptions.ValidationError(\n          \"Volume size \u0027%s\u0027 must be an integer and greater than 0.\" %\n          args.size)\n  elif args.size:\n    volume \u003d {\"size\": args.size,\n              \"type\": args.volume_type}","commit_id":"b00bf362e9aefe85a7c214fdc8514b55c63740ec"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"e49419f5f73b2599a80c6f34991a8a8cb85a2680","unresolved":false,"context_lines":[{"line_number":520,"context_line":"    \"\"\"Creates a new instance.\"\"\""},{"line_number":521,"context_line":"    flavor_id \u003d _find_flavor(cs, args.flavor).id"},{"line_number":522,"context_line":"    volume \u003d None"},{"line_number":523,"context_line":"    if args.size \u003c\u003d 0:"},{"line_number":524,"context_line":"        raise exceptions.ValidationError("},{"line_number":525,"context_line":"            \"Volume size \u0027%s\u0027 must be an integer and greater than 0.\""},{"line_number":526,"context_line":"            % args.size)"},{"line_number":527,"context_line":"    else:"},{"line_number":528,"context_line":"        volume \u003d {\"size\": args.size,"},{"line_number":529,"context_line":"                  \"type\": args.volume_type}"},{"line_number":530,"context_line":"    restore_point \u003d None"},{"line_number":531,"context_line":"    if args.backup:"},{"line_number":532,"context_line":"        restore_point \u003d {\"backupRef\": _find_backup(cs, args.backup).id}"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_bb6e27ff","line":529,"range":{"start_line":523,"start_character":4,"end_line":529,"end_character":43},"in_reply_to":"3a98d1f4_bb21c7a1","updated":"2016-09-29 20:17:14.000000000","message":"Done","commit_id":"b00bf362e9aefe85a7c214fdc8514b55c63740ec"}]}