)]}'
{"id":"openstack%2Fpython-troveclient~376590","triplet_id":"openstack%2Fpython-troveclient~master~If00e83ccd919429dcfac7621dbbd9daa49f8b416","project":"openstack/python-troveclient","branch":"master","hashtags":[],"change_id":"If00e83ccd919429dcfac7621dbbd9daa49f8b416","subject":"Throw correct error on creation of size 0","status":"MERGED","created":"2016-09-26 15:37:47.000000000","updated":"2016-10-04 16:25:55.000000000","submitted":"2016-10-04 16:25:55.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c566e31424f4939716debe773983f969fabec511","_number":376590,"virtual_id_number":376590,"owner":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":2,"date":"2016-10-04 16:25:55.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":2,"date":"2016-09-30 14:27:07.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-04 14:37:18.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-04 14:37:18.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-29 19:55:15.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2016-09-29 20:01:46.000000000","updated_by":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"reviewer":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"state":"REVIEWER"},{"updated":"2016-09-30 14:27:07.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-10-04 14:37:18.000000000","updated_by":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"reviewer":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"state":"REVIEWER"},{"updated":"2016-10-04 16:25:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"21024f1e4d11122fac19c27c2f23584e9fc7004f","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-26 15:37:47.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"105adde66554574052a7f2494c8d0a153afc68c8","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-26 16:15:39.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"7510a744d2b8de3b37f96cbebfe119472740084b","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-26 16:39:19.000000000","message":"Patch Set 1:\n\nSo I knew this point would be raised, I just didn\u0027t know if it would be better to output the message in the console or leave it in the \"trove show \u003cname\u003e\" fault_details field.\n\nSee paste for an example http://paste.openstack.org/show/582976/","accounts_in_message":[],"_revision_number":1},{"id":"4e99601aaf02729f66dcdebfc06d5539f948df85","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-26 16:58:15.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/1/check/gate-python-troveclient-docs-ubuntu-xenial/7517d4c//doc/build/html/ : SUCCESS in 3m 56s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/1/check/gate-python-troveclient-pep8-ubuntu-xenial/d056c0a/ : SUCCESS in 2m 17s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/1/check/gate-python-troveclient-python27-ubuntu-xenial/bd82f9e/ : SUCCESS in 2m 12s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/1/check/gate-python-troveclient-python34/d6485ba/ : SUCCESS in 3m 03s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/90/376590/1/check/gate-python-troveclient-python35-nv/8ab2d8b/ : SUCCESS in 2m 39s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/90/376590/1/check/gate-python-troveclient-pypy/000e694/ : FAILURE in 2m 47s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/b2e9c43/ : SUCCESS in 41m 30s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/1/check/gate-trove-functional-dsvm-mysql/0eb0991/ : SUCCESS in 58m 15s","accounts_in_message":[],"_revision_number":1},{"id":"918064262c3cd3c2270da084f61d1665067d014e","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-29 09:58:05.000000000","message":"Patch Set 1:\n\nsorry, is that a question or a statement? I see no \"?\" at the end of the line so I interpreted it as a statement.","accounts_in_message":[],"_revision_number":1},{"id":"28f1bf62cf0e2e36af53435c8592294b5e025b58","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 15:13:57.000000000","message":"Patch Set 1:\n\n\u003e sorry, is that a question or a statement? I see no \"?\" at the end\n \u003e of the line so I interpreted it as a statement.\n\nIt was a statement expressing a concern. I thought about this more and it makes sense to escalate the error message in the fault details. The one where it says, \"size must be greater than 0\" or something like that.","accounts_in_message":[],"_revision_number":1},{"id":"cd1606c53f5378410d5ce3cb809bd88f5ef113eb","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-29 15:29:11.000000000","message":"Patch Set 1:\n\n\u003e \u003e sorry, is that a question or a statement? I see no \"?\" at the end\n \u003e \u003e of the line so I interpreted it as a statement.\n \u003e \n \u003e It was a statement expressing a concern. I thought about this more\n \u003e and it makes sense to escalate the error message in the fault\n \u003e details. The one where it says, \"size must be greater than 0\" or\n \u003e something like that.\n\nI am curious abut that. Why would you not just flag the error right in the client?\n\nif args \u003d\u003d 0:\n   # do some kind of error thing\nelse:\n   # do some other kind of thing","accounts_in_message":[],"_revision_number":1},{"id":"d55aedc2e44a05ee61818a24b6b51df6129477a8","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 17:48:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"106e83af30528dc80162dc65afab0b38f64b3b1f","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 17:49:19.000000000","message":"Patch Set 2:\n\n\u003e \u003e \u003e sorry, is that a question or a statement? I see no \"?\" at the\n \u003e end\n \u003e \u003e \u003e of the line so I interpreted it as a statement.\n \u003e \u003e\n \u003e \u003e It was a statement expressing a concern. I thought about this\n \u003e more\n \u003e \u003e and it makes sense to escalate the error message in the fault\n \u003e \u003e details. The one where it says, \"size must be greater than 0\" or\n \u003e \u003e something like that.\n \u003e \n \u003e I am curious abut that. Why would you not just flag the error right\n \u003e in the client?\n \u003e \n \u003e if args \u003d\u003d 0:\n \u003e # do some kind of error thing\n \u003e else:\n \u003e # do some other kind of thing\n\ndone","accounts_in_message":[],"_revision_number":2},{"id":"3b1255263c360a47cdd8cde7da3111462dad6b69","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 17:51:12.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"685ee3f09b8c494295363942ccc9d4828da5e711","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 18:49:26.000000000","message":"Patch Set 4: Published edit on patch set 3","accounts_in_message":[],"_revision_number":4},{"id":"bd257726ced5f5e27db547f50170d8be4193a4b0","author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"date":"2016-09-29 19:45:50.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"d62fc908402b7b97a62a72efd002ee625ea6a4a9","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2016-09-29 19:55:15.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"ef3bb55a38cfe8ad76a8e838596ae059036a3c92","author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"date":"2016-09-29 20:01:46.000000000","message":"Patch Set 4: Code-Review-1\n\nGood catch peterstac. Damn python3...","accounts_in_message":[],"_revision_number":4},{"id":"564a629af653f599e17166e5bf2c8efbc4d4d45c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-29 20:02:36.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/4/check/gate-python-troveclient-docs-ubuntu-xenial/e114a23//doc/build/html/ : SUCCESS in 6m 09s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/4/check/gate-python-troveclient-pep8-ubuntu-xenial/262176f/ : SUCCESS in 3m 25s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/4/check/gate-python-troveclient-python27-ubuntu-xenial/a31c8ae/ : SUCCESS in 3m 05s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/4/check/gate-python-troveclient-python34/7d4360b/ : SUCCESS in 3m 31s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/90/376590/4/check/gate-python-troveclient-python35-nv/5bb5ca0/ : SUCCESS in 4m 13s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/90/376590/4/check/gate-python-troveclient-pypy/d2a6b6b/ : FAILURE in 2m 39s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/4/check/gate-tempest-dsvm-neutron-src-python-troveclient/ba9108c/ : SUCCESS in 43m 23s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/4/check/gate-trove-functional-dsvm-mysql/7f2c4d0/ : SUCCESS in 58m 53s","accounts_in_message":[],"_revision_number":4},{"id":"e49419f5f73b2599a80c6f34991a8a8cb85a2680","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 20:17:14.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nYeah I should\u0027ve known better than to compare with None. Something else I noticed is when I type --size -1 a seperate error is thrown from service/configuration.py so this case is really just to catch size 0.","accounts_in_message":[],"_revision_number":4},{"id":"096596c114cd7096582b1f8a4a1b4f70370d348a","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 20:18:02.000000000","message":"Patch Set 5: Published edit on patch set 4","accounts_in_message":[],"_revision_number":5},{"id":"8f2283352f551c50a50c7c9626d1fbb73b6c90cd","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 21:35:47.000000000","message":"Patch Set 5: Workflow-1\n\nI\u0027m going to catch the args.size \u003e flavor.disk error too.","accounts_in_message":[],"_revision_number":5},{"id":"2c09a4be04ff8413e1df513293a28a373bf07ae6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-29 22:20:51.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/5/check/gate-python-troveclient-docs-ubuntu-xenial/d5b51b5//doc/build/html/ : SUCCESS in 4m 31s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/5/check/gate-python-troveclient-pep8-ubuntu-xenial/14d42ff/ : SUCCESS in 3m 25s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/5/check/gate-python-troveclient-python27-ubuntu-xenial/269dee1/ : SUCCESS in 3m 32s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/5/check/gate-python-troveclient-python34/f88d336/ : SUCCESS in 2m 25s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/90/376590/5/check/gate-python-troveclient-python35-nv/bd5275e/ : SUCCESS in 4m 44s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/90/376590/5/check/gate-python-troveclient-pypy/1d99851/ : FAILURE in 4m 25s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/5/check/gate-tempest-dsvm-neutron-src-python-troveclient/cf50ee9/ : SUCCESS in 47m 02s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/5/check/gate-trove-functional-dsvm-mysql/81ea852/ : SUCCESS in 1h 11m 14s","accounts_in_message":[],"_revision_number":5},{"id":"377c24bf2ea576bd818b61074733698a8d906217","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 23:04:23.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"9b08c55bee47f64c1ed82a6f2413462b6b25bcfc","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-29 23:07:37.000000000","message":"Patch Set 6:\n\nI marked this patch set as work in progress because I\u0027m looking for suggestions on two things. One how to retrieve the requested image\u0027s size and secondly why is the size greater than flavor test failing? I suspect it has something to do with the way the tests are setup.","accounts_in_message":[],"_revision_number":6},{"id":"0ce03ba15fe1af10c95bdd4258bf06087a219546","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 00:04:36.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/6/check/gate-python-troveclient-docs-ubuntu-xenial/72d57b9//doc/build/html/ : SUCCESS in 3m 03s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/6/check/gate-python-troveclient-pep8-ubuntu-xenial/788f19b/ : SUCCESS in 1m 59s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/6/check/gate-python-troveclient-python27-ubuntu-xenial/6710a6a/ : FAILURE in 2m 10s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/6/check/gate-python-troveclient-python34/38a39ce/ : FAILURE in 3m 10s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/90/376590/6/check/gate-python-troveclient-python35-nv/807679c/ : FAILURE in 3m 25s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/90/376590/6/check/gate-python-troveclient-pypy/7c58844/ : FAILURE in 3m 13s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/6/check/gate-tempest-dsvm-neutron-src-python-troveclient/9f8b1c6/ : SUCCESS in 43m 14s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/6/check/gate-trove-functional-dsvm-mysql/46a1470/ : SUCCESS in 58m 44s","accounts_in_message":[],"_revision_number":6},{"id":"d0b89776aabf8ee944925d1059341ca89ae707dd","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-30 10:37:00.000000000","message":"Patch Set 6:\n\ntrevor, why not focus this change on the immediate validation for size 0 and not attempt to solve all possible size related issues in one go?\n\njust the size \u003d 0 change is, I think, complete and worth doing.","accounts_in_message":[],"_revision_number":6},{"id":"853dbcfb5dacdbc1b3b99c11a540e39d20620f2b","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-30 14:09:42.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"29995d253f36e435e9a9ee6649479746939f8283","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-30 14:09:56.000000000","message":"Patch Set 5:\n\n\u003e trevor, why not focus this change on the immediate validation for\n \u003e size 0 and not attempt to solve all possible size related issues in\n \u003e one go?\n \u003e \n \u003e just the size \u003d 0 change is, I think, complete and worth doing.\n\ndone","accounts_in_message":[],"_revision_number":5},{"id":"03b5daa27ac3fcfbc682509fb6203919df7a0275","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-30 14:27:07.000000000","message":"Patch Set 7: Code-Review+2\n\nlooks good, the elif will be necessarily \u003e\u003d 0 ... ok!","accounts_in_message":[],"_revision_number":7},{"id":"b6636e241619d2cc60849ab3729d5d0bcd2fe19e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-30 15:46:07.000000000","message":"Patch Set 7: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/7/check/gate-python-troveclient-docs-ubuntu-xenial/772f575//doc/build/html/ : SUCCESS in 3m 08s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/7/check/gate-python-troveclient-pep8-ubuntu-xenial/cf7a7cd/ : SUCCESS in 2m 07s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/7/check/gate-python-troveclient-python27-ubuntu-xenial/1c56d52/ : SUCCESS in 2m 09s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/7/check/gate-python-troveclient-python34/3cf8308/ : SUCCESS in 2m 15s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/90/376590/7/check/gate-python-troveclient-python35-nv/bb51737/ : SUCCESS in 3m 40s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/90/376590/7/check/gate-python-troveclient-pypy/a47c4d7/ : FAILURE in 4m 01s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/7/check/gate-tempest-dsvm-neutron-src-python-troveclient/9b2bd3b/ : SUCCESS in 43m 35s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/7/check/gate-trove-functional-dsvm-mysql/29a1b7d/ : SUCCESS in 1h 36m 12s","accounts_in_message":[],"_revision_number":7},{"id":"b16fe401b580e676b985c936a5e6cec741ba5961","author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"date":"2016-10-04 14:37:18.000000000","message":"Patch Set 7: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":7},{"id":"2509e1d21ef0850da87f121836632081d094b21d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 14:37:33.000000000","message":"Patch Set 7: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":7},{"id":"ee98f3e328e87fc60392c2b4c778cc8fb8e84e3f","date":"2016-10-04 16:25:55.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":7},{"id":"c566e31424f4939716debe773983f969fabec511","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 16:25:55.000000000","message":"Patch Set 7: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/90/376590/7/gate/gate-python-troveclient-docs-ubuntu-xenial/e1929a7//doc/build/html/ : SUCCESS in 3m 48s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/90/376590/7/gate/gate-python-troveclient-pep8-ubuntu-xenial/baa86f0/ : SUCCESS in 2m 19s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/90/376590/7/gate/gate-python-troveclient-python27-ubuntu-xenial/b1f6d6b/ : SUCCESS in 2m 49s\n- gate-python-troveclient-python34 http://logs.openstack.org/90/376590/7/gate/gate-python-troveclient-python34/81e8c93/ : SUCCESS in 2m 53s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/90/376590/7/gate/gate-tempest-dsvm-neutron-src-python-troveclient/15ff356/ : SUCCESS in 44m 04s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/90/376590/7/gate/gate-trove-functional-dsvm-mysql/495e734/ : SUCCESS in 58m 59s","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"ca9be53870529f7098b7e63415395c5551d0e605","revisions":{"9e18d6f51f99bdcb4ebeea28122c2497152a0d11":{"kind":"REWORK","_number":1,"created":"2016-09-26 15:37:47.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/1"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"subject":"Allow creation of size 0","message":"Allow creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being None instead of evaluating it\nas a bool. I also modified the unit test to avoid regression.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/9e18d6f51f99bdcb4ebeea28122c2497152a0d11"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/9e18d6f51f99bdcb4ebeea28122c2497152a0d11"}]},"branch":"refs/heads/master"},"190f74fd0c0e324de244a11b23731ac2117eeb6f":{"kind":"REWORK","_number":2,"created":"2016-09-29 17:48:17.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/2"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-29 17:46:33.000000000","tz":-300},"subject":"Allow creation of size 0","message":"Allow creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/190f74fd0c0e324de244a11b23731ac2117eeb6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/190f74fd0c0e324de244a11b23731ac2117eeb6f"}]},"branch":"refs/heads/master"},"4608c8ff143b873c126c3b0c8d943e4e811a0f85":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-09-29 17:51:12.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/3"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-29 17:50:38.000000000","tz":0},"subject":"Throw correct error on creation of size 0","message":"Throw correct error on creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/4608c8ff143b873c126c3b0c8d943e4e811a0f85"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/4608c8ff143b873c126c3b0c8d943e4e811a0f85"}]},"branch":"refs/heads/master"},"b00bf362e9aefe85a7c214fdc8514b55c63740ec":{"kind":"REWORK","_number":4,"created":"2016-09-29 18:49:26.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/4"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-29 18:49:11.000000000","tz":0},"subject":"Throw correct error on creation of size 0","message":"Throw correct error on creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b00bf362e9aefe85a7c214fdc8514b55c63740ec"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b00bf362e9aefe85a7c214fdc8514b55c63740ec"}]},"branch":"refs/heads/master"},"18b1cd2248650879ce5c50387a06928db4788fc1":{"kind":"REWORK","_number":5,"created":"2016-09-29 20:18:02.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/5"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-29 20:15:16.000000000","tz":0},"subject":"Throw correct error on creation of size 0","message":"Throw correct error on creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/18b1cd2248650879ce5c50387a06928db4788fc1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/18b1cd2248650879ce5c50387a06928db4788fc1"}]},"branch":"refs/heads/master"},"cfd6180e684df89e802fd9c7edea67c762a2a184":{"kind":"REWORK","_number":6,"created":"2016-09-29 23:04:23.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/6"}}},"commit":{"parents":[{"commit":"e4036597992cd9a747258699c5365915a6231d59","subject":"Update reno for stable/newton","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e4036597992cd9a747258699c5365915a6231d59"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-29 23:04:11.000000000","tz":-300},"subject":"WIP: improve args.size validation","message":"WIP: improve args.size validation\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nWhen trying to create an instnace of size greater than  flavor.disk\nthe client fails silently and the error is stored in the instance\u0027s\nfault_details.\n\nThis patch checks for size being less than or equal to flavor disk\u0027s\nsize. The test fails, I think it has something to do with how the\nfake responses are generated?\n\nTODO: A third case is when size of volume or flavor is smaller than the\nrequested image\u0027s size, not sure how to do this one.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/cfd6180e684df89e802fd9c7edea67c762a2a184"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/cfd6180e684df89e802fd9c7edea67c762a2a184"}]},"branch":"refs/heads/master"},"ca9be53870529f7098b7e63415395c5551d0e605":{"kind":"REWORK","_number":7,"created":"2016-09-30 14:09:42.000000000","uploader":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"ref":"refs/changes/90/376590/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/90/376590/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/90/376590/7"}}},"commit":{"parents":[{"commit":"e8b4f6c15b1a3f81d775c5e5e547b6aa872db01d","subject":"Merge \"Use i18n for shell.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/e8b4f6c15b1a3f81d775c5e5e547b6aa872db01d"}]}],"author":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-26 15:19:45.000000000","tz":-300},"committer":{"name":"Trevor McCasland","email":"TM2086@att.com","date":"2016-09-30 14:08:04.000000000","tz":-300},"subject":"Throw correct error on creation of size 0","message":"Throw correct error on creation of size 0\n\nWhen trying to create an instance of size 0 an error is thrown\nstating that the size was not specified, this is not correct\nbecause I did specify it. The problem is that args.size evaluates\nto False because size is 0.\n\nThis patch checks for size being zero instead and throws the correct\nerror message.\n\nChange-Id: If00e83ccd919429dcfac7621dbbd9daa49f8b416\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ca9be53870529f7098b7e63415395c5551d0e605"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ca9be53870529f7098b7e63415395c5551d0e605"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}