)]}'
{"id":"openstack%2Fpython-troveclient~377131","triplet_id":"openstack%2Fpython-troveclient~master~I17043b382cf3499f1dea0f27ed7a95555968f7a5","project":"openstack/python-troveclient","branch":"master","topic":"mkdir-common","hashtags":[],"change_id":"I17043b382cf3499f1dea0f27ed7a95555968f7a5","subject":"Create a common directory and put some modules in","status":"ABANDONED","created":"2016-09-27 00:18:43.000000000","updated":"2016-09-28 02:20:22.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"18675e862c2262bd9dfc61c65cb6cd50c4f292a1","_number":377131,"virtual_id_number":377131,"owner":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":1,"date":"2016-09-27 01:36:36.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-09-28 02:20:15.000000000","_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":-1,"date":"2016-09-27 12:47:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-27 01:36:36.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-27 12:47:55.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"}],"messages":[{"id":"ca05a83a87e253ee56dd699e62cbd01ec9a8e5d7","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-27 00:18:43.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"93634564df248c4e3bcd26696e0b9d72907ad2e5","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-27 00:23:08.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"f6b1b342d3166d451b91831037a1313711dbd2da","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-27 00:35:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"311db1af5de6978db18b45d249e1408c66ff2d38","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 01:36:36.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/31/377131/2/check/gate-python-troveclient-docs-ubuntu-xenial/d176f8a//doc/build/html/ : SUCCESS in 3m 37s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/31/377131/2/check/gate-python-troveclient-pep8-ubuntu-xenial/9b0ace4/ : SUCCESS in 3m 59s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/31/377131/2/check/gate-python-troveclient-python27-ubuntu-xenial/32d3ff2/ : SUCCESS in 3m 03s\n- gate-python-troveclient-python34 http://logs.openstack.org/31/377131/2/check/gate-python-troveclient-python34/4ea1e5e/ : SUCCESS in 2m 06s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/31/377131/2/check/gate-python-troveclient-python35-nv/e382a2b/ : SUCCESS in 2m 36s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/31/377131/2/check/gate-python-troveclient-pypy/6205d0a/ : FAILURE in 2m 14s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/31/377131/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/3d8bc83/ : SUCCESS in 1h 00m 47s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/31/377131/2/check/gate-trove-functional-dsvm-mysql/39686c4/ : SUCCESS in 58m 01s","accounts_in_message":[],"_revision_number":2},{"id":"a3a7d9e7b587ed9a396c7f6a43c1636d463bae6b","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-09-27 12:47:55.000000000","message":"Patch Set 2: Code-Review-1\n\nBut the current troveclient/ location is where all the common modules are. Is it really necessary to create a new common directory?\n\nOn the server side, common was the place where we put things that were shared by server and guest. \n\nAs a further reference, see \n\nhttp://git.openstack.org/cgit/openstack/python-novaclient/tree/novaclient\n\nhttp://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient\n\nhttp://git.openstack.org/cgit/openstack/python-glanceclient/tree/glanceclient\n\n...\n\nWhat we have is the \"standard\" way in which all openstack projects do this, and for consistency (if nothing else), I don\u0027t believe it makes any sense to accept this change.","accounts_in_message":[],"_revision_number":2},{"id":"fd76b823613c31105f47b2c34405d3cdc00dc8ca","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-28 02:20:15.000000000","message":"Patch Set 2:\n\n\u003e But the current troveclient/ location is where all the common\n \u003e modules are. Is it really necessary to create a new common\n \u003e directory?\n \u003e \n \u003e On the server side, common was the place where we put things that\n \u003e were shared by server and guest.\n \u003e \n \u003e As a further reference, see\n \u003e \n \u003e http://git.openstack.org/cgit/openstack/python-novaclient/tree/novaclient\n \u003e \n \u003e http://git.openstack.org/cgit/openstack/python-cinderclient/tree/cinderclient\n \u003e \n \u003e http://git.openstack.org/cgit/openstack/python-glanceclient/tree/glanceclient\n \u003e \n \u003e ...\n \u003e \n \u003e What we have is the \"standard\" way in which all openstack projects\n \u003e do this, and for consistency (if nothing else), I don\u0027t believe it\n \u003e makes any sense to accept this change.\n\nWell, makes sense","accounts_in_message":[],"_revision_number":2},{"id":"826d96f7a64502aa420b00907c5a7312c6b46467","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-09-28 02:20:22.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fb82d4fd0f47a9d6fa0cc23a7880b7c57ffe03da","revisions":{"80b32bf8946ece13d82d68d3469ba1b0733d7e2d":{"kind":"REWORK","_number":1,"created":"2016-09-27 00:18:43.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/31/377131/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/31/377131/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/1"}}},"commit":{"parents":[{"commit":"010cf7b93f101d517e5b4fd63b5d1b2b6f9837df","subject":"Merge \"Display flavor-ephemeral in trove flavor-list command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/010cf7b93f101d517e5b4fd63b5d1b2b6f9837df"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-27 00:16:34.000000000","tz":-420},"committer":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-27 00:16:34.000000000","tz":-420},"subject":"Create a common directory and put some modules in","message":"Create a common directory and put some modules in\n\nLooks like the latest directory structure should be to Create a\ncommon directory and put some modules, in like i18n, exceptions...\nSo I do so, in order to perfect our directory\n\nChange-Id: I17043b382cf3499f1dea0f27ed7a95555968f7a5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/80b32bf8946ece13d82d68d3469ba1b0733d7e2d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/80b32bf8946ece13d82d68d3469ba1b0733d7e2d"}]},"branch":"refs/heads/master"},"fb82d4fd0f47a9d6fa0cc23a7880b7c57ffe03da":{"kind":"REWORK","_number":2,"created":"2016-09-27 00:35:35.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/31/377131/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/31/377131/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/31/377131/2"}}},"commit":{"parents":[{"commit":"010cf7b93f101d517e5b4fd63b5d1b2b6f9837df","subject":"Merge \"Display flavor-ephemeral in trove flavor-list command\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/010cf7b93f101d517e5b4fd63b5d1b2b6f9837df"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-27 00:16:34.000000000","tz":-420},"committer":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-09-27 00:35:23.000000000","tz":-420},"subject":"Create a common directory and put some modules in","message":"Create a common directory and put some modules in\n\nLooks like the latest directory structure should be to Create a\ncommon directory and put some modules, in like i18n, exceptions...\nSo I do so, in order to perfect our directory\n\nChange-Id: I17043b382cf3499f1dea0f27ed7a95555968f7a5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/fb82d4fd0f47a9d6fa0cc23a7880b7c57ffe03da"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/fb82d4fd0f47a9d6fa0cc23a7880b7c57ffe03da"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}