)]}'
{"id":"openstack%2Fpython-troveclient~380887","triplet_id":"openstack%2Fpython-troveclient~master~Ie2631ce6d5f1756fe520850be0e0d304f41ba760","project":"openstack/python-troveclient","branch":"master","topic":"assert_not_none_fix","hashtags":[],"change_id":"Ie2631ce6d5f1756fe520850be0e0d304f41ba760","subject":"Using assertIsNotNone() instead of assertNotEqual(None)","status":"MERGED","created":"2016-10-03 02:35:23.000000000","updated":"2016-10-04 15:13:01.000000000","submitted":"2016-10-04 15:13:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"55242a0658ae1ae978fb2b0bc285b9228475834d","_number":380887,"virtual_id_number":380887,"owner":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":2,"date":"2016-10-04 15:13:01.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"recommended":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"all":[{"value":1,"date":"2016-10-03 14:34:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":2,"date":"2016-10-04 12:36:21.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-10-04 14:10:32.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-10-04 14:10:32.000000000","_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-03 14:34:13.000000000","updated_by":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"reviewer":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"state":"REVIEWER"},{"updated":"2016-10-04 12:36:21.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-10-04 14:10:32.000000000","updated_by":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"reviewer":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"state":"REVIEWER"},{"updated":"2016-10-04 15:13:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d53c50491896145bc531d6680020a039aab2d7bd","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-10-03 02:35:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"964419e999b5067248c9b4b11d5bd6ba882b84a4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-03 02:47:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/87/380887/1/check/gate-python-troveclient-docs-ubuntu-xenial/865af53//doc/build/html/ : SUCCESS in 4m 15s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pep8-ubuntu-xenial/10a6785/ : SUCCESS in 1m 57s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python27-ubuntu-xenial/ae30bd9/ : SUCCESS in 2m 02s\n- gate-python-troveclient-python34 http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python34/3f46255/ : SUCCESS in 3m 33s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python35-nv/8a65b3b/ : SUCCESS in 2m 30s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pypy/81f7941/ : FAILURE in 2m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/87/380887/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/e288e00/ : FAILURE in 11m 26s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/87/380887/1/check/gate-trove-functional-dsvm-mysql/5b468b8/ : FAILURE in 10m 32s","accounts_in_message":[],"_revision_number":1},{"id":"17d50bda8f2c998c553264fdf773f021a3ec9c10","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-10-03 02:49:13.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"50ad9e05fff6da27c13fc012dc1b122c1f78b787","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-03 03:00:44.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/87/380887/1/check/gate-python-troveclient-docs-ubuntu-xenial/56996c9//doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pep8-ubuntu-xenial/32101da/ : SUCCESS in 2m 48s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python27-ubuntu-xenial/256ce08/ : SUCCESS in 3m 07s\n- gate-python-troveclient-python34 http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python34/1f0e1cd/ : SUCCESS in 2m 07s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python35-nv/8b027b4/ : SUCCESS in 3m 30s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pypy/e0dd7e3/ : FAILURE in 2m 55s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/87/380887/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/523d7ca/ : FAILURE in 11m 20s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/87/380887/1/check/gate-trove-functional-dsvm-mysql/47778db/ : FAILURE in 10m 57s","accounts_in_message":[],"_revision_number":1},{"id":"3313d9fa2c6e13011b668886e855fd4f091a2b0e","author":{"_account_id":14576,"name":"Petr Malik","email":"pmalik@tesora.com","username":"pmalik"},"date":"2016-10-03 14:34:13.000000000","message":"Patch Set 1: Code-Review+1\n\nJust wondering whether we should be maintaining the compat client at all... As far as I understand it was just a backup copy of an old CLI version. It has been used by integration tests only (which should really be using the real client instead).","accounts_in_message":[],"_revision_number":1},{"id":"8eddd691b275d4e80f3450728ef3b4f3cb6f36d3","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-10-04 01:09:57.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"67fa15e20b05e595c7a479902f450355339b5e2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 02:07:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/87/380887/1/check/gate-python-troveclient-docs-ubuntu-xenial/1dd826a//doc/build/html/ : SUCCESS in 2m 53s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pep8-ubuntu-xenial/3b98609/ : SUCCESS in 1m 56s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python27-ubuntu-xenial/298cf2d/ : SUCCESS in 2m 08s\n- gate-python-troveclient-python34 http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python34/ccc830b/ : SUCCESS in 3m 22s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-python35-nv/e10456e/ : SUCCESS in 2m 29s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/87/380887/1/check/gate-python-troveclient-pypy/3abc32c/ : FAILURE in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/87/380887/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/c76cdcf/ : SUCCESS in 42m 18s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/87/380887/1/check/gate-trove-functional-dsvm-mysql/bb4766d/ : SUCCESS in 57m 37s","accounts_in_message":[],"_revision_number":1},{"id":"a2d00ddeca9ad50573a21ea45f2b2efd6208f9c4","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-10-04 12:36:21.000000000","message":"Patch Set 1: Code-Review+2\n\nwhile I agree with petr, I\u0027d rather merge this and get it off the queue","accounts_in_message":[],"_revision_number":1},{"id":"53e58f597c7ba8b1fec1694708ecec73f306bb32","author":{"_account_id":10295,"name":"mariam john","email":"mariamj@us.ibm.com","username":"mariamj"},"date":"2016-10-04 14:10:32.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"079851de298df51325bc49a353809aafafb8089b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 14:10:43.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"fd673b543ed665fc008dcd62144551b6402fec59","date":"2016-10-04 15:13:01.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"e976cda96e459f753d82f2a41007e788bf0db943","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-04 15:13:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/87/380887/1/gate/gate-python-troveclient-docs-ubuntu-xenial/3242001//doc/build/html/ : SUCCESS in 6m 18s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/87/380887/1/gate/gate-python-troveclient-pep8-ubuntu-xenial/f251639/ : SUCCESS in 2m 12s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/87/380887/1/gate/gate-python-troveclient-python27-ubuntu-xenial/421c0f5/ : SUCCESS in 2m 48s\n- gate-python-troveclient-python34 http://logs.openstack.org/87/380887/1/gate/gate-python-troveclient-python34/1569570/ : SUCCESS in 2m 29s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/87/380887/1/gate/gate-tempest-dsvm-neutron-src-python-troveclient/cfb55e1/ : SUCCESS in 55m 42s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/87/380887/1/gate/gate-trove-functional-dsvm-mysql/1fed970/ : SUCCESS in 1h 01m 44s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"71b0ff69fa4983b6d04ce7a53858e42093fb3630","revisions":{"71b0ff69fa4983b6d04ce7a53858e42093fb3630":{"kind":"REWORK","_number":1,"created":"2016-10-03 02:35:23.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/87/380887/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/87/380887/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/87/380887/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/87/380887/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/87/380887/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/87/380887/1"}}},"commit":{"parents":[{"commit":"c22d37b51cfe812b37562a8560e8ed6387fbc748","subject":"Merge \"Add a new command in the readme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c22d37b51cfe812b37562a8560e8ed6387fbc748"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-10-03 02:32:16.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-10-03 02:33:04.000000000","tz":420},"subject":"Using assertIsNotNone() instead of assertNotEqual(None)","message":"Using assertIsNotNone() instead of assertNotEqual(None)\n\nFollowing OpenStack Style Guidelines[1]:\n[H203] Unit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNotNone(...) is preferred\nover assertNotEqual(None, ...) and assertIsNot(None, ...)\n\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\nChange-Id: Ie2631ce6d5f1756fe520850be0e0d304f41ba760\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/71b0ff69fa4983b6d04ce7a53858e42093fb3630"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/71b0ff69fa4983b6d04ce7a53858e42093fb3630"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}