)]}'
{"id":"openstack%2Fpython-troveclient~383995","triplet_id":"openstack%2Fpython-troveclient~master~Icbade7dd4c7d231ae65fd4f8de673b484bab721c","project":"openstack/python-troveclient","branch":"master","topic":"avoid-use","hashtags":[],"change_id":"Icbade7dd4c7d231ae65fd4f8de673b484bab721c","subject":"Avoid use xx\u003d[]  for parameter in function","status":"MERGED","created":"2016-10-08 02:25:52.000000000","updated":"2016-11-01 23:05:44.000000000","submitted":"2016-11-01 23:05:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc1db3b557dcfd0234ee27788ab2ff7b4a943b78","_number":383995,"virtual_id_number":383995,"owner":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":2,"date":"2016-11-01 23:05:44.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":2,"date":"2016-10-22 11:36:50.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":2,"date":"2016-10-30 14:48:42.000000000","_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":1,"date":"2016-10-21 15:09:01.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":2,"date":"2016-11-01 21:51:46.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":1,"date":"2016-11-01 21:51:46.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"value":0,"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-10-21 15:09:01.000000000","updated_by":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"reviewer":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"state":"REVIEWER"},{"updated":"2016-10-22 11:36:50.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2016-10-30 14:48:42.000000000","updated_by":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"reviewer":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"state":"REVIEWER"},{"updated":"2016-11-01 21:51:46.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2016-11-01 23:05:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"efb92ed62485a425df0574f86398251bde680042","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-08 02:25:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"58d3cd89e6c21a5fceb3f1b8d1eb13b8c2a91fc4","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-08 02:26:53.000000000","message":"Patch Set 1:\n\nmy mistake, the last time，only correct the constructor, didn\u0027t change ordinary function...","accounts_in_message":[],"_revision_number":1},{"id":"266dd1ff3e5d2cd7d8736025c8c71497eccba828","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-08 03:26:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/95/383995/1/check/gate-python-troveclient-docs-ubuntu-xenial/7c4380c//doc/build/html/ : SUCCESS in 4m 35s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-pep8-ubuntu-xenial/ba04b23/ : SUCCESS in 1m 57s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python27-ubuntu-xenial/919d87d/ : SUCCESS in 2m 03s\n- gate-python-troveclient-python34 http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python34/b186463/ : SUCCESS in 2m 09s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python35-nv/77fcb9c/ : SUCCESS in 2m 30s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-pypy/c0bc071/ : FAILURE in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/95/383995/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/b900a29/ : SUCCESS in 53m 55s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/95/383995/1/check/gate-trove-functional-dsvm-mysql/0cd6d32/ : SUCCESS in 1h 00m 00s","accounts_in_message":[],"_revision_number":1},{"id":"801d161d3d9d32b6d71f92fa6cb276960841e6b5","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-13 08:24:03.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"d70c31b3d3c96f867eafd1be61ce7fb3bbeb99b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-13 09:22:20.000000000","message":"Patch Set 1:\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/95/383995/1/check/gate-python-troveclient-docs-ubuntu-xenial/fc9d139//doc/build/html/ : SUCCESS in 3m 13s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-pep8-ubuntu-xenial/62c388e/ : SUCCESS in 2m 58s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python27-ubuntu-xenial/9deb7ac/ : SUCCESS in 2m 13s\n- gate-python-troveclient-python34 http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python34/ffe101e/ : SUCCESS in 2m 21s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-python35-nv/79bad25/ : SUCCESS in 2m 51s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/95/383995/1/check/gate-python-troveclient-pypy/52ee74b/ : FAILURE in 2m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/95/383995/1/check/gate-tempest-dsvm-neutron-src-python-troveclient/3c1306c/ : SUCCESS in 42m 27s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/95/383995/1/check/gate-trove-functional-dsvm-mysql/fd7ff46/ : SUCCESS in 58m 04s","accounts_in_message":[],"_revision_number":1},{"id":"b1e8b10f82fd601668ada8dcec67ed1c62f2f890","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2016-10-19 02:08:46.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"b7c78aedf08f644b4e38fbd192ef3ab719870269","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-10-19 03:07:55.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/95/383995/2/check/gate-python-troveclient-docs-ubuntu-xenial/e6617d4//doc/build/html/ : SUCCESS in 2m 57s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/95/383995/2/check/gate-python-troveclient-pep8-ubuntu-xenial/a2c24e4/ : SUCCESS in 2m 00s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/95/383995/2/check/gate-python-troveclient-python27-ubuntu-xenial/53aa675/ : SUCCESS in 2m 58s\n- gate-python-troveclient-python34 http://logs.openstack.org/95/383995/2/check/gate-python-troveclient-python34/3315406/ : SUCCESS in 2m 13s\n- gate-python-troveclient-python35-nv http://logs.openstack.org/95/383995/2/check/gate-python-troveclient-python35-nv/133808a/ : SUCCESS in 2m 42s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/95/383995/2/check/gate-python-troveclient-pypy/af8a1c0/ : FAILURE in 4m 58s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/95/383995/2/check/gate-tempest-dsvm-neutron-src-python-troveclient/b1a4db4/ : SUCCESS in 43m 05s\n- gate-trove-legacy-functional-dsvm-mysql http://logs.openstack.org/95/383995/2/check/gate-trove-legacy-functional-dsvm-mysql/992236e/ : SUCCESS in 58m 19s","accounts_in_message":[],"_revision_number":2},{"id":"1d33c01c8b8503f21ece6e24db6b8ad1b243cfca","author":{"_account_id":15321,"name":"Matthew Van Dijk","email":"mvandijk@tesora.com","username":"mvandijk"},"date":"2016-10-21 15:09:01.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"d215e51dbd1f03b0786032819814ef672ab98ff5","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2016-10-22 11:36:50.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"cde7f5a0724187bef08b8bc04764edfc2c741c19","author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"date":"2016-10-30 14:48:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"720fbd831d5d890ef10769db265e3b067a397195","author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"date":"2016-11-01 21:51:46.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nGood find! Thanks Jian.","accounts_in_message":[],"_revision_number":2},{"id":"d13d36fb8ba8cbfbc257d06a506a7d3ae199db08","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-01 21:51:56.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"96e7f020cf79bd7eee3bc5ae2a036046ed8a219e","date":"2016-11-01 23:05:44.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"822de4c194fc69c6f090cb01f4efa8f4ce9b11c7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-01 23:05:44.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/95/383995/2/gate/gate-python-troveclient-docs-ubuntu-xenial/109b83e//doc/build/html/ : SUCCESS in 2m 41s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/95/383995/2/gate/gate-python-troveclient-pep8-ubuntu-xenial/4e8f14b/ : SUCCESS in 1m 38s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/95/383995/2/gate/gate-python-troveclient-python27-ubuntu-xenial/580144a/ : SUCCESS in 2m 25s\n- gate-python-troveclient-python34 http://logs.openstack.org/95/383995/2/gate/gate-python-troveclient-python34/fc9f2a7/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-troveclient http://logs.openstack.org/95/383995/2/gate/gate-tempest-dsvm-neutron-src-python-troveclient/e76d8ef/ : SUCCESS in 41m 36s\n- gate-trove-functional-dsvm-mysql http://logs.openstack.org/95/383995/2/gate/gate-trove-functional-dsvm-mysql/766363b/ : SUCCESS in 58m 17s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"91e098e0ea46a7674f9d0fb6e4734675c658f444","revisions":{"ce4b63f804f04f44c0dabf2118acd20c6f3afc1d":{"kind":"REWORK","_number":1,"created":"2016-10-08 02:25:52.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/95/383995/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/95/383995/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/1"}}},"commit":{"parents":[{"commit":"ac88477948880cf4a64fbd55e26758aa35d06fc6","subject":"Merge \"Avoid use xx\u003d[]  for parameter initial value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ac88477948880cf4a64fbd55e26758aa35d06fc6"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-10-08 02:23:48.000000000","tz":-420},"committer":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-10-08 02:23:48.000000000","tz":-420},"subject":"Avoid use xx\u003d[]  for parameter in function","message":"Avoid use xx\u003d[]  for parameter in function\n\nUse xx \u003d [] for the parameter for function, this parameter will\nonly be initialized at the first call, this is should be avoided.\nBetter choice is to set the initial value to None, then the initialization\ntime use xx\u003d xx or []\n\nmore information:http://effbot.org/zone/default-values.htm\n\nChange-Id: Icbade7dd4c7d231ae65fd4f8de673b484bab721c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ce4b63f804f04f44c0dabf2118acd20c6f3afc1d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ce4b63f804f04f44c0dabf2118acd20c6f3afc1d"}]},"branch":"refs/heads/master"},"91e098e0ea46a7674f9d0fb6e4734675c658f444":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2016-10-19 02:08:46.000000000","uploader":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"ref":"refs/changes/95/383995/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/95/383995/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/95/383995/2"}}},"commit":{"parents":[{"commit":"a06ad17715d06ad95d52430e489929d9d956adc6","subject":"Merge \"Enable release notes translation\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/a06ad17715d06ad95d52430e489929d9d956adc6"}]}],"author":{"name":"jiansong","email":"jian.song@easystack.cn","date":"2016-10-08 02:23:48.000000000","tz":-420},"committer":{"name":"jian.song","email":"jian.song@easystack.cn","date":"2016-10-19 02:08:46.000000000","tz":0},"subject":"Avoid use xx\u003d[]  for parameter in function","message":"Avoid use xx\u003d[]  for parameter in function\n\nUse xx \u003d [] for the parameter for function, this parameter will\nonly be initialized at the first call, this is should be avoided.\nBetter choice is to set the initial value to None, then the initialization\ntime use xx\u003d xx or []\n\nmore information:http://effbot.org/zone/default-values.htm\n\nChange-Id: Icbade7dd4c7d231ae65fd4f8de673b484bab721c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/91e098e0ea46a7674f9d0fb6e4734675c658f444"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/91e098e0ea46a7674f9d0fb6e4734675c658f444"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}