)]}'
{"id":"openstack%2Fpython-troveclient~430592","triplet_id":"openstack%2Fpython-troveclient~master~I644c8af33f8c14b1e72ef51026ded87144550d9c","project":"openstack/python-troveclient","branch":"master","topic":"six.iteritems","hashtags":[],"change_id":"I644c8af33f8c14b1e72ef51026ded87144550d9c","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-02-08 06:58:02.000000000","updated":"2017-11-06 20:12:23.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9102970f5e2ddae6f000bed6690a8759d7aee119","_number":430592,"virtual_id_number":430592,"owner":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-02-08 08:25:26.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-03-09 08:47:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-08 08:25:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-03-09 08:47:02.000000000","updated_by":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"reviewer":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"state":"REVIEWER"}],"messages":[{"id":"ae9258217c098cea5ec9700219acf32d1006f982","author":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"date":"2017-02-08 06:58:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d776ca0774cb3ed29c89f9fe2608e2796dd3ac4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-08 08:25:26.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/92/430592/1/check/gate-python-troveclient-docs-ubuntu-xenial/30c3c1d//doc/build/html/ : SUCCESS in 3m 16s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/92/430592/1/check/gate-python-troveclient-pep8-ubuntu-xenial/f8e2dc8/ : SUCCESS in 2m 28s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/92/430592/1/check/gate-python-troveclient-python27-ubuntu-xenial/ade0f16/ : SUCCESS in 2m 05s\n- gate-python-troveclient-python35 http://logs.openstack.org/92/430592/1/check/gate-python-troveclient-python35/191489f/ : SUCCESS in 3m 06s\n- gate-python-troveclient-pypy http://logs.openstack.org/92/430592/1/check/gate-python-troveclient-pypy/e7c54f3/ : FAILURE in 2m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/92/430592/1/check/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/f9321a6/ : SUCCESS in 1h 26m 20s\n- check-osc-plugins http://logs.openstack.org/92/430592/1/check/check-osc-plugins/e09c316/ : SUCCESS in 5m 26s (non-voting)\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/92/430592/1/check/gate-trove-functional-dsvm-mysql-ubuntu-xenial/4514fb0/ : SUCCESS in 57m 11s","accounts_in_message":[],"_revision_number":1},{"id":"aa0b7ac3721e039dd6ba36a29afe0d9cc90376c5","author":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"date":"2017-03-09 08:47:02.000000000","message":"Patch Set 1: Code-Review-1\n\nI made a similar change in the trove... Please add the relevant hacking rule check this change","accounts_in_message":[],"_revision_number":1},{"id":"b74052ebf17672da5637acbf18e9d0863eb3dbcc","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-06 20:12:23.000000000","message":"Abandoned\n\nAbandoning because of the -1 review and no updates from the author in 8 months.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"985c892c132a97bde19f9c3efc3417199b1215b6","revisions":{"985c892c132a97bde19f9c3efc3417199b1215b6":{"kind":"REWORK","_number":1,"created":"2017-02-08 06:58:02.000000000","uploader":{"_account_id":12736,"name":"Xuepeng Ji","email":"ji.xuepeng@zte.com.cn","username":"jixuepeng"},"ref":"refs/changes/92/430592/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/92/430592/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/92/430592/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/92/430592/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/92/430592/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/92/430592/1"}}},"commit":{"parents":[{"commit":"9cb3f4fc70897687350c9bca66e112eb6a5c9d91","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/9cb3f4fc70897687350c9bca66e112eb6a5c9d91"}]}],"author":{"name":"ji-xuepeng","email":"ji.xuepeng@zte.com.cn","date":"2017-02-08 08:57:53.000000000","tz":480},"committer":{"name":"ji-xuepeng","email":"ji.xuepeng@zte.com.cn","date":"2017-02-08 09:00:33.000000000","tz":480},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1.As mentioned in [1], we should avoid using\nsix.iteritems to achieve iterators. We can\nuse dict.items instead, as it will return\niterators in PY3 as well. And dict.items/keys\nwill more readable. 2.In py2, the performance\nabout list should be negligible, see the link [2].\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: I644c8af33f8c14b1e72ef51026ded87144550d9c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/985c892c132a97bde19f9c3efc3417199b1215b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/985c892c132a97bde19f9c3efc3417199b1215b6"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}