)]}'
{"id":"openstack%2Fpython-troveclient~474097","triplet_id":"openstack%2Fpython-troveclient~master~I9bbb5d020bda237472f1edc85eab45460d5b5fb2","project":"openstack/python-troveclient","branch":"master","topic":"assertFalse","hashtags":[],"change_id":"I9bbb5d020bda237472f1edc85eab45460d5b5fb2","subject":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"","status":"NEW","created":"2017-06-14 07:57:33.000000000","updated":"2017-11-08 17:37:22.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c10e0aa18f5a3e33bdb1ec9c06f1af67376cd83f","_number":474097,"virtual_id_number":474097,"owner":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"date":"2017-06-15 02:25:02.000000000","_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":1,"date":"2017-06-15 01:44:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":1,"date":"2017-11-05 21:17:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"disliked":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},{"value":2,"date":"2017-11-03 18:54:24.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-11-08 17:37:15.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"all":[{"date":"2017-09-27 01:48:04.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},{"value":1,"date":"2017-11-03 18:54:24.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-15 01:44:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-09-27 01:48:04.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2017-11-03 18:54:24.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2017-11-05 21:17:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2017-11-08 17:37:15.000000000","updated_by":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"reviewer":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"state":"REVIEWER"}],"messages":[{"id":"fcb328c8e0b8f33b9d913619b80401049a2f55e1","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-14 07:57:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7bd5842f6056135ea040d30ff98382be3fdb01f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 10:07:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/97/474097/1/check/gate-python-troveclient-docs-ubuntu-xenial/559963d//doc/build/html/ : SUCCESS in 3m 42s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/97/474097/1/check/gate-python-troveclient-pep8-ubuntu-xenial/ab13f37/ : FAILURE in 3m 52s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/97/474097/1/check/gate-python-troveclient-python27-ubuntu-xenial/4d9363c/ : SUCCESS in 2m 58s\n- gate-python-troveclient-python35 http://logs.openstack.org/97/474097/1/check/gate-python-troveclient-python35/9ae08b1/ : SUCCESS in 3m 31s\n- gate-python-troveclient-pypy http://logs.openstack.org/97/474097/1/check/gate-python-troveclient-pypy/5a12887/ : SUCCESS in 4m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/97/474097/1/check/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/6d050cd/ : SUCCESS in 1h 15m 30s\n- check-osc-plugins http://logs.openstack.org/97/474097/1/check/check-osc-plugins/f2673c8/ : SUCCESS in 4m 21s (non-voting)\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/97/474097/1/check/gate-trove-functional-dsvm-mysql-ubuntu-xenial/433ecf6/ : SUCCESS in 2h 09m 05s","accounts_in_message":[],"_revision_number":1},{"id":"e97f74ed5987a3f934683cde5d4cadf5b02be546","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2017-06-14 12:58:51.000000000","message":"Patch Set 1: Code-Review-1 Workflow-1\n\nThree things:\n\n- not without a hacking rule\n- not before you get it to pass pep8\n- not before all occurrences in the project are fixed.","accounts_in_message":[],"_revision_number":1},{"id":"0f795458e6f1dfd4efb5602f4c445619fbf02044","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-14 13:30:29.000000000","message":"Patch Set 1:\n\n\u003e Three things:\n \u003e \n \u003e - not without a hacking rule\n \u003e - not before you get it to pass pep8\n \u003e - not before all occurrences in the project are fixed.\n\nactually, pep8 is other files\u0027 mistake.\nyou can refer to it:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n2017-06-14 08:01:40.574469 | pep8 runtests: commands[0] | flake8\n2017-06-14 08:01:40.576813 |   /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial$ /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8 \n2017-06-14 08:01:45.785378 | ./tools/install_venv_common.py:126:27: E128 continuation line under-indented for visual indent\n2017-06-14 08:01:45.785464 |                           action\u003d\u0027store_true\u0027,\n2017-06-14 08:01:45.785490 |                           ^\n2017-06-14 08:01:45.785529 | ./tools/install_venv_common.py:127:27: E128 continuation line under-indented for visual indent\n2017-06-14 08:01:45.785562 |                           help\u003d\"Do not inherit packages from global Python \"\n2017-06-14 08:01:45.785583 |                           ^\n2017-06-14 08:01:45.882433 | ERROR: InvocationError: \u0027/home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8\u0027","accounts_in_message":[],"_revision_number":1},{"id":"4d476d6ea3d0c988d0c8c9f4b634ef1914bc37bb","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-14 13:37:45.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9e99e3a615d75b5244be239f22bf97ad339e9ab9","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-14 13:38:54.000000000","message":"Patch Set 2:\n\n\u003e Uploaded patch set 2.\n\nadd tools/install_venv_common.py to fix pep8 error.","accounts_in_message":[],"_revision_number":2},{"id":"e8dafcc9cc9e28c11b8d3ce8c460344b30d7d5b0","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2017-06-14 13:42:09.000000000","message":"Patch Set 2: Code-Review-1 Workflow-1\n\n(1 comment)\n\nsee earlier comments.","accounts_in_message":[],"_revision_number":2},{"id":"93e34819e0d77e53585dd4957a846872e3b03d4a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-14 15:12:25.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/97/474097/2/check/gate-python-troveclient-docs-ubuntu-xenial/04b350f//doc/build/html/ : SUCCESS in 5m 10s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/97/474097/2/check/gate-python-troveclient-pep8-ubuntu-xenial/8184877/ : FAILURE in 4m 11s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/97/474097/2/check/gate-python-troveclient-python27-ubuntu-xenial/5181f56/ : SUCCESS in 2m 34s\n- gate-python-troveclient-python35 http://logs.openstack.org/97/474097/2/check/gate-python-troveclient-python35/524fbe8/ : SUCCESS in 2m 34s\n- gate-python-troveclient-pypy http://logs.openstack.org/97/474097/2/check/gate-python-troveclient-pypy/39499d1/ : SUCCESS in 3m 01s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/97/474097/2/check/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/ff217a0/ : SUCCESS in 1h 26m 46s\n- check-osc-plugins http://logs.openstack.org/97/474097/2/check/check-osc-plugins/157cd0e/ : SUCCESS in 4m 35s (non-voting)\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/97/474097/2/check/gate-trove-functional-dsvm-mysql-ubuntu-xenial/27628de/ : SUCCESS in 1h 33m 05s","accounts_in_message":[],"_revision_number":2},{"id":"75fb0867c79d67f9b4cf0fef53fe663d430ff6f4","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-15 00:30:11.000000000","message":"Patch Set 2:\n\n\u003e (1 comment)\n \u003e \n \u003e see earlier comments.\n\nI don\u0027t know why.\nBut, could you please see the comments above?\nthanks.\n\n2017-06-14 13:42:16.290413 | pep8 runtests: PYTHONHASHSEED\u003d\u00271098457600\u0027\n2017-06-14 13:42:16.290439 | pep8 runtests: commands[0] | flake8\n2017-06-14 13:42:16.292738 |   /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial$ /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8 \n2017-06-14 13:42:21.958768 | ./tools/install_venv_common.py:128:80: E501 line too long (87 \u003e 79 characters)\n2017-06-14 13:42:21.958889 |                             help\u003d\"Do not inherit packages from global Python install.\")\n2017-06-14 13:42:21.958932 |                                                                                ^\n2017-06-14 13:42:22.079473 | ERROR: InvocationError: \u0027/home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8\u0027\n2017-06-14 13:42:22.079665 | ___________________________________ summary ____________________________________\n2017-06-14 13:42:22.079698 | ERROR:   pep8: commands failed\n2017-06-14 13:42:22.092536 | + rc\u003d1","accounts_in_message":[],"_revision_number":2},{"id":"9f6cfbc7953971a0da80760a4c2fe805c2675a3f","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-15 00:31:34.000000000","message":"Patch Set 2:\n\n\u003e \u003e Three things:\n \u003e \u003e\n \u003e \u003e - not without a hacking rule\n \u003e \u003e - not before you get it to pass pep8\n \u003e \u003e - not before all occurrences in the project are fixed.\n \u003e \n \u003e actually, pep8 is other files\u0027 mistake.\n \u003e you can refer to it:\n \u003e \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n \u003e 2017-06-14 08:01:40.574469 | pep8 runtests: commands[0] | flake8\n \u003e 2017-06-14 08:01:40.576813 |   /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial$\n \u003e /home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8\n \u003e 2017-06-14 08:01:45.785378 | ./tools/install_venv_common.py:126:27:\n \u003e E128 continuation line under-indented for visual indent\n \u003e 2017-06-14 08:01:45.785464 |                          \n \u003e action\u003d\u0027store_true\u0027,\n \u003e 2017-06-14 08:01:45.785490 |                           ^\n \u003e 2017-06-14 08:01:45.785529 | ./tools/install_venv_common.py:127:27:\n \u003e E128 continuation line under-indented for visual indent\n \u003e 2017-06-14 08:01:45.785562 |                           help\u003d\"Do not\n \u003e inherit packages from global Python \"\n \u003e 2017-06-14 08:01:45.785583 |                           ^\n \u003e 2017-06-14 08:01:45.882433 | ERROR: InvocationError:\n \u003e \u0027/home/jenkins/workspace/gate-python-troveclient-pep8-ubuntu-xenial/.tox/pep8/bin/flake8\u0027\n\nfor the first time running jenkins, I never touch the tools/install_venv_common.py code, but pep8 run with error.","accounts_in_message":[],"_revision_number":2},{"id":"d0d8c1cafe30150f1eec442c63a29fcf6595e892","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-15 00:32:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"70ef3fa1d6e3846c2b8cebe5a54c30e0df55ae21","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-15 01:44:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/97/474097/3/check/gate-python-troveclient-docs-ubuntu-xenial/f08cf24//doc/build/html/ : SUCCESS in 2m 44s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/97/474097/3/check/gate-python-troveclient-pep8-ubuntu-xenial/62008aa/ : SUCCESS in 3m 50s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/97/474097/3/check/gate-python-troveclient-python27-ubuntu-xenial/805dd1c/ : SUCCESS in 2m 21s\n- gate-python-troveclient-python35 http://logs.openstack.org/97/474097/3/check/gate-python-troveclient-python35/fa1ee4b/ : SUCCESS in 3m 14s\n- gate-python-troveclient-pypy http://logs.openstack.org/97/474097/3/check/gate-python-troveclient-pypy/da76d40/ : SUCCESS in 2m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/97/474097/3/check/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/8676416/ : SUCCESS in 1h 12m 21s\n- check-osc-plugins http://logs.openstack.org/97/474097/3/check/check-osc-plugins/09fd6f2/ : SUCCESS in 3m 40s (non-voting)\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/97/474097/3/check/gate-trove-functional-dsvm-mysql-ubuntu-xenial/bde8d29/ : SUCCESS in 1h 01m 39s","accounts_in_message":[],"_revision_number":3},{"id":"52b5fa92b5332175b664485c8fe864a9a1b5715d","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2017-06-15 02:12:31.000000000","message":"Patch Set 3: Code-Review-1 Workflow-1\n\nTwo things:\n\n- not without a hacking rule\n- are these the only places in trove client where this error exists?\n\nWF -1 because there\u0027s no hacking rule.","accounts_in_message":[],"_revision_number":3},{"id":"5ed766e2f74033a00cb8e96b23ef5397a975963c","author":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"date":"2017-06-15 02:25:02.000000000","message":"Patch Set 3:\n\n\u003e Two things:\n \u003e \n \u003e - not without a hacking rule\n \u003e - are these the only places in trove client where this error\n \u003e exists?\nYes, only these places in trove client code. \n \u003e WF -1 because there\u0027s no hacking rule.\nFYI: https://review.openstack.org/#/c/471453/1/HACKING.rst\nYou\u0027re the BOSS, and ：）","accounts_in_message":[],"_revision_number":3},{"id":"e1b5bed576d8c7b6ad5bf9f4462373d887b26a80","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2017-09-27 01:48:04.000000000","message":"Patch Set 3: -Workflow -Code-Review\n\nremoving objections","accounts_in_message":[],"_revision_number":3},{"id":"e724af53e2e825bd854d1df34baa26c9b54547b7","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-03 18:11:11.000000000","message":"Patch Set 3: Code-Review+2\n\nI\u0027m not sure how a hacking rule could be written that wouldn\u0027t require some amount of exceptions to be written, possibly more than its worth to write the rule.\n\nYou could disallow all usage of assertFalse, but here may be cases where assertFalse is jus fine because the intent is to allow None and False to pass.\n\nAs such I\u0027m not sure on the need for a hacking rule, this is further strengthened by Cinder\u0027s lack of a hacking rule for this.","accounts_in_message":[],"_revision_number":3},{"id":"b2279de9f9ecccd8e66b7ec4780c67a221742ecd","author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"date":"2017-11-03 18:54:24.000000000","message":"Patch Set 3: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"7c4b3683de8b3f5617c3996c136cd1095af174f9","author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"date":"2017-11-05 19:23:54.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"0c2036a0c355dbca7c7b6d0c65b6f8b73fbc04a2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-05 21:17:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/97/474097/3/check/build-openstack-sphinx-docs/f7304de/html/ : SUCCESS in 5m 39s\n- openstack-tox-pep8 http://logs.openstack.org/97/474097/3/check/openstack-tox-pep8/9ed618c/ : SUCCESS in 4m 12s\n- openstack-tox-py27 http://logs.openstack.org/97/474097/3/check/openstack-tox-py27/88935de/ : SUCCESS in 8m 08s\n- openstack-tox-py35 http://logs.openstack.org/97/474097/3/check/openstack-tox-py35/6a16610/ : SUCCESS in 3m 59s\n- openstackclient-check-plugins http://logs.openstack.org/97/474097/3/check/openstackclient-check-plugins/eba21f3/ : SUCCESS in 7m 12s (non-voting)\n- legacy-trove-functional-dsvm-mysql http://logs.openstack.org/97/474097/3/check/legacy-trove-functional-dsvm-mysql/b8ee66a/ : SUCCESS in 1h 51m 38s\n- legacy-check-osc-plugins http://logs.openstack.org/97/474097/3/check/legacy-check-osc-plugins/0474574/ : SUCCESS in 6m 06s (non-voting)\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/97/474097/3/check/tempest-neutron-src-python-troveclient/0b5f20c/ : SUCCESS in 1h 33m 25s","accounts_in_message":[],"_revision_number":3},{"id":"07386e5ad33c6ed17c07dea4b14d5ad687fe68ff","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-06 20:40:12.000000000","message":"Patch Set 3: Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"8a37032a0dac6d10817e387d2451ab72eb3f23c8","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-07 12:14:35.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"c9bda597bde617b80bc0d0b7f2ec4bb7e878c9c4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2017-11-07 14:36:51.000000000","message":"Patch Set 3:\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/97/474097/3/check/build-openstack-sphinx-docs/78a99d1/html/ : SUCCESS in 5m 51s\n- openstack-tox-pep8 http://logs.openstack.org/97/474097/3/check/openstack-tox-pep8/0e5d209/ : SUCCESS in 4m 04s\n- openstack-tox-py27 http://logs.openstack.org/97/474097/3/check/openstack-tox-py27/c690d8a/ : SUCCESS in 4m 12s\n- openstack-tox-py35 http://logs.openstack.org/97/474097/3/check/openstack-tox-py35/d6a026f/ : SUCCESS in 5m 41s\n- openstackclient-check-plugins http://logs.openstack.org/97/474097/3/check/openstackclient-check-plugins/eb30982/ : SUCCESS in 6m 55s (non-voting)\n- legacy-trove-functional-dsvm-mysql http://logs.openstack.org/97/474097/3/check/legacy-trove-functional-dsvm-mysql/0746697/ : SUCCESS in 2h 20m 25s\n- legacy-check-osc-plugins http://logs.openstack.org/97/474097/3/check/legacy-check-osc-plugins/5272b4c/ : SUCCESS in 6m 12s (non-voting)\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/97/474097/3/check/tempest-neutron-src-python-troveclient/eeec8e1/ : SUCCESS in 1h 28m 40s","accounts_in_message":[],"_revision_number":3},{"id":"d8d989147a1046695261715476ef8ee1b5f1d7dd","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-08 17:37:15.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)\n\nThis review has a dependency on 447809 and should be rebased to not have that dependency.\n\nFurthermore, the commit message says \"Revert Using\" I think this was copied from another project as the changes being proposed to troveclient are not reverting a previous change to use assertFalse.","accounts_in_message":[],"_revision_number":3},{"id":"991c7733f7c0d8e9719cd16e986bc117056ed5f1","author":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"date":"2017-11-08 17:37:22.000000000","message":"Patch Set 3: -Workflow","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0b1f09d61bbe2b7480fe20b34d3fb869cc3ff652","revisions":{"dda4c7c7e3b42e24c1f57c401a4aa22e081006ab":{"kind":"REWORK","_number":1,"created":"2017-06-14 07:57:33.000000000","uploader":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"ref":"refs/changes/97/474097/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/97/474097/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/1"}}},"commit":{"parents":[{"commit":"952df72d608bfbaecc55b25dc25e2bd029647180","subject":"Remove log translations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/952df72d608bfbaecc55b25dc25e2bd029647180"}]}],"author":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-14 07:53:40.000000000","tz":480},"committer":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-14 07:53:40.000000000","tz":480},"subject":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"","message":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"\n\nThis is not correct,\nbecause assertEqual(False, A) is a stricter check than assertFalse(A).\nassertFalse(None) passes, but assertEqual(False, None) will fail.\nTherefore, this patch weakened our tests.\n\nChange-Id: I9bbb5d020bda237472f1edc85eab45460d5b5fb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/dda4c7c7e3b42e24c1f57c401a4aa22e081006ab"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/dda4c7c7e3b42e24c1f57c401a4aa22e081006ab"}]},"branch":"refs/heads/master"},"133396373b74d78739b593793a12723ae5417934":{"kind":"REWORK","_number":2,"created":"2017-06-14 13:37:45.000000000","uploader":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"ref":"refs/changes/97/474097/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/97/474097/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/2"}}},"commit":{"parents":[{"commit":"952df72d608bfbaecc55b25dc25e2bd029647180","subject":"Remove log translations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/952df72d608bfbaecc55b25dc25e2bd029647180"}]}],"author":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-14 07:53:40.000000000","tz":480},"committer":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-14 13:37:11.000000000","tz":480},"subject":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"","message":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"\n\nThis is not correct,\nbecause assertEqual(False, A) is a stricter check than assertFalse(A).\nassertFalse(None) passes, but assertEqual(False, None) will fail.\nTherefore, this patch weakened our tests.\n\nChange-Id: I9bbb5d020bda237472f1edc85eab45460d5b5fb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/133396373b74d78739b593793a12723ae5417934"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/133396373b74d78739b593793a12723ae5417934"}]},"branch":"refs/heads/master"},"0b1f09d61bbe2b7480fe20b34d3fb869cc3ff652":{"kind":"REWORK","_number":3,"created":"2017-06-15 00:32:15.000000000","uploader":{"_account_id":25105,"name":"indicolite","email":"indicoliteplus@gmail.com","username":"indicoliteplus"},"ref":"refs/changes/97/474097/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/97/474097/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/97/474097/3"}}},"commit":{"parents":[{"commit":"952df72d608bfbaecc55b25dc25e2bd029647180","subject":"Remove log translations","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/952df72d608bfbaecc55b25dc25e2bd029647180"}]}],"author":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-14 07:53:40.000000000","tz":480},"committer":{"name":"indicoliteplus","email":"ccyu@fiberhome.com","date":"2017-06-15 00:28:57.000000000","tz":480},"subject":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"","message":"Revert \"Using assertFalse(A) instead of assertEqual(False, A)\"\n\nThis is not correct,\nbecause assertEqual(False, A) is a stricter check than assertFalse(A).\nassertFalse(None) passes, but assertEqual(False, None) will fail.\nTherefore, this patch weakened our tests.\n\nChange-Id: I9bbb5d020bda237472f1edc85eab45460d5b5fb2\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0b1f09d61bbe2b7480fe20b34d3fb869cc3ff652"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0b1f09d61bbe2b7480fe20b34d3fb869cc3ff652"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"}},{"label":"Workflow","status":"MAY","applied_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"}},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dMAX"],"failing_atoms":["label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}