)]}'
{"id":"openstack%2Fpython-troveclient~487417","triplet_id":"openstack%2Fpython-troveclient~master~Iea77ef54585d0b3480369e9f5df629e3f46f7e3b","project":"openstack/python-troveclient","branch":"master","topic":"openstack/requirements","hashtags":[],"change_id":"Iea77ef54585d0b3480369e9f5df629e3f46f7e3b","subject":"Fix token response mock","status":"MERGED","created":"2017-07-26 13:24:23.000000000","updated":"2017-07-26 18:14:21.000000000","submitted":"2017-07-26 18:14:21.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a9826c7b390505e71ba317f1ac258c0a1ed92c92","_number":487417,"virtual_id_number":487417,"owner":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":2,"date":"2017-07-26 18:14:21.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":2,"date":"2017-07-26 16:29:34.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2017-07-26 13:57:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"all":[{"value":1,"date":"2017-07-26 16:29:34.000000000","_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-26 13:57:16.000000000","updated_by":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"reviewer":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"state":"REVIEWER"},{"updated":"2017-07-26 16:29:34.000000000","updated_by":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"reviewer":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"state":"REVIEWER"},{"updated":"2017-07-26 18:14:21.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b34d54e98aa62aaf17e7b8bc8c211a984e662060","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-07-26 13:24:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"0e58e60cb08e54cc340c3aee907f867e5ee240a1","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-07-26 13:24:33.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":1},{"id":"aaa201911ed7b417f75e3e596525790bc29e5202","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2017-07-26 13:25:40.000000000","message":"Patch Set 3: Published edit on patch set 2","accounts_in_message":[],"_revision_number":3},{"id":"c45b5fe687b48cc53a8fa8a3414c4739727f82f5","author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"date":"2017-07-26 13:57:16.000000000","message":"Patch Set 3: Code-Review+1","accounts_in_message":[],"_revision_number":3},{"id":"04e19006ca6255893d0a72f9dd10037636b0841d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 14:52:23.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/17/487417/3/check/gate-python-troveclient-docs-ubuntu-xenial/81e592c//doc/build/html/ : SUCCESS in 3m 18s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/17/487417/3/check/gate-python-troveclient-pep8-ubuntu-xenial/67af7c9/ : SUCCESS in 2m 48s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/17/487417/3/check/gate-python-troveclient-python27-ubuntu-xenial/f174c5d/ : SUCCESS in 4m 33s\n- gate-python-troveclient-python35 http://logs.openstack.org/17/487417/3/check/gate-python-troveclient-python35/c32bba5/ : SUCCESS in 4m 15s\n- gate-python-troveclient-pypy http://logs.openstack.org/17/487417/3/check/gate-python-troveclient-pypy/e5bacbd/ : SUCCESS in 5m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/17/487417/3/check/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/76204a9/ : SUCCESS in 1h 25m 24s\n- check-osc-plugins http://logs.openstack.org/17/487417/3/check/check-osc-plugins/61764a9/ : SUCCESS in 3m 55s (non-voting)\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/17/487417/3/check/gate-trove-functional-dsvm-mysql-ubuntu-xenial/6149b4a/ : SUCCESS in 1h 16m 14s","accounts_in_message":[],"_revision_number":3},{"id":"ba243aa7ff1d33e75a5867c53341ca4cc672876a","author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"date":"2017-07-26 16:29:34.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1\n\nI don\u0027t understand this change, I\u0027m not sure that the explanation I\u0027ve understood so far is complete, but I\u0027m told that this fix is benign and I see no reason to say no ...","accounts_in_message":[],"_revision_number":3},{"id":"5a513e8aef074cc355db4dce8968ce9f5f8f1ae0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 16:29:44.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"b054d6a3c98a58fa5c0d8fabbf8ec925017e87b7","date":"2017-07-26 18:14:21.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3},{"id":"1cc72a6a62ccb05f656747476f77e690f2607e26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-26 18:14:21.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-troveclient-docs-ubuntu-xenial http://docs-draft.openstack.org/17/487417/3/gate/gate-python-troveclient-docs-ubuntu-xenial/dcc99cd//doc/build/html/ : SUCCESS in 4m 18s\n- gate-python-troveclient-pep8-ubuntu-xenial http://logs.openstack.org/17/487417/3/gate/gate-python-troveclient-pep8-ubuntu-xenial/7b28064/ : SUCCESS in 3m 59s\n- gate-python-troveclient-python27-ubuntu-xenial http://logs.openstack.org/17/487417/3/gate/gate-python-troveclient-python27-ubuntu-xenial/83e47aa/ : SUCCESS in 4m 06s\n- gate-python-troveclient-python35 http://logs.openstack.org/17/487417/3/gate/gate-python-troveclient-python35/98cfee1/ : SUCCESS in 4m 35s\n- gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial http://logs.openstack.org/17/487417/3/gate/gate-tempest-dsvm-neutron-src-python-troveclient-ubuntu-xenial/4c8afc1/ : SUCCESS in 1h 43m 38s\n- gate-trove-functional-dsvm-mysql-ubuntu-xenial http://logs.openstack.org/17/487417/3/gate/gate-trove-functional-dsvm-mysql-ubuntu-xenial/1f44c15/ : SUCCESS in 59m 39s","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"47ad24a358104d41b915f25cdd5a17d915c6ee75","revisions":{"1795af7b1f08386ff27b10c4025d844a916b03ba":{"kind":"REWORK","_number":1,"created":"2017-07-26 13:24:23.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/17/487417/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/17/487417/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/1"}}},"commit":{"parents":[{"commit":"82335ad6d5ed6b2a1f8b7f3c07133dee4350569d","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/82335ad6d5ed6b2a1f8b7f3c07133dee4350569d"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:18:47.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:18:47.000000000","tz":0},"subject":"Fix token response mock","message":"Fix token response mock\n\nThe unit tests mock tokens from keystoneauth. One of the responses\nbeing returned from a mocked keystoneauth method was returning a v2.0\ntoken that didn\u0027t have the right expiration attribute of a v2.0\ntoken. This was caught by keystoneauth 3.0.1, which underwent a\nsignificant refactor and added a bunch of new functionality for\nversion discovery. Keystoneauth was expecting `expires` to be\nin the token but instead the mock was using `expires_at`, which isn\u0027t\na valid v2.0 token attribute.\n\nChange-Id: Iea77ef54585d0b3480369e9f5df629e3f46f7e3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/1795af7b1f08386ff27b10c4025d844a916b03ba"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/1795af7b1f08386ff27b10c4025d844a916b03ba"}]},"branch":"refs/heads/master"},"730194fda356811ae3fb6befac8fced97228edde":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-07-26 13:24:33.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/17/487417/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/17/487417/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/2"}}},"commit":{"parents":[{"commit":"555ba5ed690027088358288c9b0252d5a58bdc0d","subject":"Merge \"Update the trove docs to follow the docs theme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/555ba5ed690027088358288c9b0252d5a58bdc0d"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:18:47.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:24:33.000000000","tz":0},"subject":"Fix token response mock","message":"Fix token response mock\n\nThe unit tests mock tokens from keystoneauth. One of the responses\nbeing returned from a mocked keystoneauth method was returning a v2.0\ntoken that didn\u0027t have the right expiration attribute of a v2.0\ntoken. This was caught by keystoneauth 3.0.1, which underwent a\nsignificant refactor and added a bunch of new functionality for\nversion discovery. Keystoneauth was expecting `expires` to be\nin the token but instead the mock was using `expires_at`, which isn\u0027t\na valid v2.0 token attribute.\n\nChange-Id: Iea77ef54585d0b3480369e9f5df629e3f46f7e3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/730194fda356811ae3fb6befac8fced97228edde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/730194fda356811ae3fb6befac8fced97228edde"}]},"branch":"refs/heads/master"},"47ad24a358104d41b915f25cdd5a17d915c6ee75":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2017-07-26 13:25:40.000000000","uploader":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"ref":"refs/changes/17/487417/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/17/487417/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/17/487417/3"}}},"commit":{"parents":[{"commit":"555ba5ed690027088358288c9b0252d5a58bdc0d","subject":"Merge \"Update the trove docs to follow the docs theme\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/555ba5ed690027088358288c9b0252d5a58bdc0d"}]}],"author":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:18:47.000000000","tz":0},"committer":{"name":"Lance Bragstad","email":"lbragstad@gmail.com","date":"2017-07-26 13:25:38.000000000","tz":0},"subject":"Fix token response mock","message":"Fix token response mock\n\nThe unit tests mock tokens from keystoneauth. One of the responses\nbeing returned from a mocked keystoneauth method was returning a v2.0\ntoken that didn\u0027t have the right expiration attribute of a v2.0\ntoken. This was caught by keystoneauth 3.0.1, which underwent a\nsignificant refactor and added a bunch of new functionality for\nversion discovery. Keystoneauth was expecting `expires` to be\nin the token but instead the mock was using `expires_at`, which isn\u0027t\na valid v2.0 token attribute.\n\nCloses-Bug: 1706538\n\nChange-Id: Iea77ef54585d0b3480369e9f5df629e3f46f7e3b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/47ad24a358104d41b915f25cdd5a17d915c6ee75"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/47ad24a358104d41b915f25cdd5a17d915c6ee75"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}