)]}'
{"id":"openstack%2Fpython-troveclient~52794","triplet_id":"openstack%2Fpython-troveclient~master~I092db96d1b6bb31c41e6ba4c5fc9606e3f8ac087","project":"openstack/python-troveclient","branch":"master","topic":"bp/py33-support","hashtags":[],"change_id":"I092db96d1b6bb31c41e6ba4c5fc9606e3f8ac087","subject":"Include troveclient/compat/tests in testr","status":"MERGED","created":"2013-10-19 21:52:22.000000000","updated":"2013-10-23 15:40:07.000000000","submitted":"2013-10-23 15:40:07.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9c729a9dd00492154f70d51eef78b85d65fb471e","_number":52794,"virtual_id_number":52794,"owner":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":2,"date":"2013-10-23 15:40:07.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-23 15:07:47.000000000","_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},{"value":0,"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"all":[{"value":2,"date":"2013-10-23 15:36:27.000000000","_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2013-10-23 14:06:54.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},{"value":0,"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"all":[{"value":1,"date":"2013-10-23 15:36:27.000000000","_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},{"value":0,"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},{"value":0,"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-19 21:54:39.000000000","updated_by":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"reviewer":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"state":"REVIEWER"},{"updated":"2013-10-23 15:07:47.000000000","updated_by":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"reviewer":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-10-23 15:36:27.000000000","updated_by":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"reviewer":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"state":"REVIEWER"},{"updated":"2013-10-23 15:40:07.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"657403c510667a97373c29b274e83baa74544156","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2013-10-19 21:52:26.000000000","message":"Patch Set 1:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/195/ ","accounts_in_message":[],"_revision_number":1},{"id":"d7731aff229026101eabfb9f807dc335bbcd8587","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-19 21:57:38.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-troveclient-requirements http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-requirements/88ced5c : SUCCESS in 3s\n- gate-python-troveclient-pep8 http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-pep8/5ef8d49 : SUCCESS in 51s\n- gate-python-troveclient-python26 http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-python26/c1c142c : SUCCESS in 40s\n- gate-python-troveclient-python27 http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-python27/58752dc : SUCCESS in 2m 16s\n- gate-python-troveclient-python33 http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-python33/08a3da9 : FAILURE in 5m 11s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/94/52794/1/check/gate-python-troveclient-pypy/d2a5322 : SUCCESS in 1m 30s\n","accounts_in_message":[],"_revision_number":1},{"id":"7de6e316506b40976ec04083b7dc98139b2241fc","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2013-10-19 22:53:30.000000000","message":"Patch Set 1: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/195/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"4caba502fd934bd2acc107d28abb7fbf29095e1e","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2013-10-22 23:27:45.000000000","message":"Patch Set 1: (1 inline comment)\n\nlets make sure test-requirements dont show up in pypi. Thats my only concern w this","accounts_in_message":[],"_revision_number":1},{"id":"b7a0298ca7f8ee28c4e6e0e8ce6a296d219db62f","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2013-10-22 23:31:32.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nCan you build an egg for troveclient (you probably already have one, but might want to delete it and rerun python setup.py develop), and then check [1] to see if it has lxml and httplib2 in it.\n\n\n[1] python_troveclient.egg-info/requires.txt","accounts_in_message":[],"_revision_number":1},{"id":"e30a5722f258f9d1d99ff693b7652d09ccc0c04f","author":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"date":"2013-10-23 10:34:09.000000000","message":"Patch Set 1:\n\nDouble-checked, there is no lxml and httplib2 in python_troveclient.egg-info.","accounts_in_message":[],"_revision_number":1},{"id":"bc323aa1dbacc0f875a5422f3d31ec99635b3bb0","author":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"date":"2013-10-23 12:28:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5a1187ade5936aac2edc85ed9e96774003030837","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2013-10-23 12:28:45.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":2},{"id":"9e60b5978db73c11e3ca40ba224bf27634413a69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-23 12:34:03.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-troveclient-requirements http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-requirements/1d4e195 : SUCCESS in 3s\n- gate-python-troveclient-pep8 http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-pep8/f1f45d9 : SUCCESS in 2m 02s\n- gate-python-troveclient-python26 http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-python26/f832a99 : SUCCESS in 44s\n- gate-python-troveclient-python27 http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-python27/ff210a1 : SUCCESS in 1m 34s\n- gate-python-troveclient-python33 http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-python33/fb76cef : FAILURE in 5m 21s (non-voting)\n- gate-python-troveclient-pypy http://logs.openstack.org/94/52794/2/check/gate-python-troveclient-pypy/62bf7c7 : SUCCESS in 1m 29s\n","accounts_in_message":[],"_revision_number":2},{"id":"99cea78f40fc31b2b07c32263a9432d744ec62d0","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2013-10-23 14:06:54.000000000","message":"Patch Set 2:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/219/ ","accounts_in_message":[],"_revision_number":2},{"id":"31280baa8a3a9b391ba0174ee9ea3ae67e42e6c6","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2013-10-23 15:07:47.000000000","message":"Patch Set 2: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/219/ : SUCCESS","accounts_in_message":[],"_revision_number":2},{"id":"e1e57193611b60d5b9d91e1ad6e0ecf3933a61c4","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2013-10-23 15:36:27.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a07bb2a025954037ef6dca995ad96ebdd5f437ce","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-23 15:36:36.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"994ee2ebaefcc302105ed16fe4d9786a8450d289","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-23 15:40:07.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"8d9fad55312da9a5d15d04035ddaa9ee9ddda070","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-23 15:40:07.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-python-troveclient-requirements http://logs.openstack.org/94/52794/2/gate/gate-python-troveclient-requirements/d3f3b76 : SUCCESS in 3s\n- gate-python-troveclient-pep8 http://logs.openstack.org/94/52794/2/gate/gate-python-troveclient-pep8/c5ea50c : SUCCESS in 2m 02s\n- gate-python-troveclient-python26 http://logs.openstack.org/94/52794/2/gate/gate-python-troveclient-python26/6febc80 : SUCCESS in 48s\n- gate-python-troveclient-python27 http://logs.openstack.org/94/52794/2/gate/gate-python-troveclient-python27/1d757c6 : SUCCESS in 2m 06s\n- gate-python-troveclient-pypy http://logs.openstack.org/94/52794/2/gate/gate-python-troveclient-pypy/cf6709c : SUCCESS in 1m 30s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"31a6cde05289894579fad328ed104bb5bedb46c9","revisions":{"2eb9986dc4df6eeffcefbb0accab23f75f62d14d":{"kind":"REWORK","_number":1,"created":"2013-10-19 21:52:22.000000000","uploader":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"ref":"refs/changes/94/52794/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/94/52794/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/1"}}},"commit":{"parents":[{"commit":"b34aa23cbc9aab2307b6f77fb7c5f395fe07bf89","subject":"Make use of strutils.to_slug in slugify()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b34aa23cbc9aab2307b6f77fb7c5f395fe07bf89"}]}],"author":{"name":"Kui Shi","email":"skuicloud@gmail.com","date":"2013-10-19 07:46:20.000000000","tz":480},"committer":{"name":"Kui Shi","email":"skuicloud@gmail.com","date":"2013-10-19 07:46:20.000000000","tz":480},"subject":"Include troveclient/compat/tests in testr","message":"Include troveclient/compat/tests in testr\n\nAll tests should be included in testr.\n\nIn test_common.py, the testr command line will be read for parsing,\nfinally emit error message:\nrun.py: error: no such option: -t\n\nwe should mock the sys.argv in setUp().\n\nThe analysis is here\n--------------------\ntroveclient/compat/common.py: CommandsBase\n254     def _parse_options(self, parser):\n255         opts, args \u003d parser.parse_args()  \u003c-- 1. no arg is passed\n\n/usr/lib/python2.7/optparse.py\n1361     def _get_args(self, args):\n1362         if args is None:\n1363             return sys.argv[1:]  \u003c-- 3. cmdline(testr command) is read\n1364         else:\n1365             return args[:]\n\n1367     def parse_args(self, args\u003dNone, values\u003dNone):\n...\n1381         rargs \u003d self._get_args(args) \u003c-- 2. args is None\n\nClose-Bug #1241845\n\nChange-Id: I092db96d1b6bb31c41e6ba4c5fc9606e3f8ac087\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2eb9986dc4df6eeffcefbb0accab23f75f62d14d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2eb9986dc4df6eeffcefbb0accab23f75f62d14d"}]},"branch":"refs/heads/master"},"31a6cde05289894579fad328ed104bb5bedb46c9":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-10-23 12:28:39.000000000","uploader":{"_account_id":7774,"name":"Kui Shi","email":"skuicloud@gmail.com","username":"Kui"},"ref":"refs/changes/94/52794/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/94/52794/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/94/52794/2"}}},"commit":{"parents":[{"commit":"5af5d6f30dab4fd707ed589e33c16a8965d94031","subject":"Make use of strutils.to_slug in slugify()","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5af5d6f30dab4fd707ed589e33c16a8965d94031"}]}],"author":{"name":"Kui Shi","email":"skuicloud@gmail.com","date":"2013-10-19 07:46:20.000000000","tz":480},"committer":{"name":"Kui Shi","email":"skuicloud@gmail.com","date":"2013-10-22 22:53:45.000000000","tz":480},"subject":"Include troveclient/compat/tests in testr","message":"Include troveclient/compat/tests in testr\n\nAll tests should be included in testr.\n\nIn test_common.py, the testr command line will be read for parsing,\nfinally emit error message:\nrun.py: error: no such option: -t\n\nwe should mock the sys.argv in setUp().\n\nThe analysis is here\n--------------------\ntroveclient/compat/common.py: CommandsBase\n254     def _parse_options(self, parser):\n255         opts, args \u003d parser.parse_args()  \u003c-- 1. no arg is passed\n\n/usr/lib/python2.7/optparse.py\n1361     def _get_args(self, args):\n1362         if args is None:\n1363             return sys.argv[1:]  \u003c-- 3. cmdline(testr command) is read\n1364         else:\n1365             return args[:]\n\n1367     def parse_args(self, args\u003dNone, values\u003dNone):\n...\n1381         rargs \u003d self._get_args(args) \u003c-- 2. args is None\n\nClose-Bug #1241845\n\nChange-Id: I092db96d1b6bb31c41e6ba4c5fc9606e3f8ac087\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/31a6cde05289894579fad328ed104bb5bedb46c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/31a6cde05289894579fad328ed104bb5bedb46c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}