)]}'
{"troveclient/compat/cli.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"c13f0db9f427c0a249383c9d0cd37bcd70a013d0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                configuration_ref \u003d self.configuration_id"},{"line_number":65,"context_line":"            else:"},{"line_number":66,"context_line":"                string_parts \u003d []"},{"line_number":67,"context_line":"                string_parts.append(self.dbaas.client.service_url)"},{"line_number":68,"context_line":"                string_parts.append(\"/\")"},{"line_number":69,"context_line":"                string_parts.append(self.configuration_id)"},{"line_number":70,"context_line":"                configuration_ref \u003d \"\".join(string_parts)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F9gs%3D","line":67,"updated":"2013-10-24 15:32:30.000000000","message":"This seems like a lot of code to create a url in the client. Should this be handled by the API? Or just require that the user inputs a full url?","commit_id":"d939786dd179dcb9ec2118b6dd1c7bd03e71f200"},{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"c13f0db9f427c0a249383c9d0cd37bcd70a013d0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            if self.configuration_id \u003d\u003d \"\":"},{"line_number":83,"context_line":"                configuration_ref \u003d self.configuration_id"},{"line_number":84,"context_line":"            else:"},{"line_number":85,"context_line":"                string_parts \u003d []"},{"line_number":86,"context_line":"                string_parts.append(self.dbaas.client.service_url)"},{"line_number":87,"context_line":"                string_parts.append(\"/\")"},{"line_number":88,"context_line":"                string_parts.append(self.configuration_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F9h0%3D","line":85,"updated":"2013-10-24 15:32:30.000000000","message":"this seems to be identical to the create block. Maybe pull this out into a _config_ref method.","commit_id":"d939786dd179dcb9ec2118b6dd1c7bd03e71f200"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"afebe86b80fe5819a20349d7db1ca16f23455985","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        self._pretty_print(self.dbaas.configurations.get, self.id)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def list_instances(self):"},{"line_number":331,"context_line":"        \"\"\"Get details for the specified configuration\"\"\""},{"line_number":332,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":333,"context_line":"        self._pretty_list(self.dbaas.configurations.instances, self.id)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FzFM%3D","line":331,"updated":"2013-10-28 21:46:51.000000000","message":"Is that accurate? It\u0027s identical to the docstring of get().","commit_id":"5d30da47b06c1de77078421bd83329a86cbd81aa"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"15706d20348f5d98bb2ab68780ad8b5b662456e4","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        self._pretty_print(self.dbaas.configurations.get, self.id)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    def list_instances(self):"},{"line_number":331,"context_line":"        \"\"\"Get details for the specified configuration\"\"\""},{"line_number":332,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":333,"context_line":"        self._pretty_list(self.dbaas.configurations.instances, self.id)"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FwP0%3D","line":331,"in_reply_to":"AAAATn%2F%2FzFM%3D","updated":"2013-10-29 14:47:12.000000000","message":"copy pasta... good eye","commit_id":"5d30da47b06c1de77078421bd83329a86cbd81aa"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"3c5fc5afd899ed7075045b1d3b802d1e7ef3e33d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027size\u0027,"},{"line_number":47,"context_line":"        \u0027backup\u0027,"},{"line_number":48,"context_line":"        \u0027availability_zone\u0027,"},{"line_number":49,"context_line":"        \u0027configuration_id\u0027"},{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _get_configuration_ref(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2FyFg%3D","line":49,"updated":"2013-12-31 20:49:14.000000000","message":"Should you submit another patch here do us a favor and add a trailing comma would you please.","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"3c5fc5afd899ed7075045b1d3b802d1e7ef3e33d","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            if self.configuration_id \u003d\u003d \"\":"},{"line_number":56,"context_line":"                configuration_ref \u003d self.configuration_id"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                string_parts \u003d []"},{"line_number":59,"context_line":"                string_parts.append(self.dbaas.client.service_url)"},{"line_number":60,"context_line":"                string_parts.append(\"/\")"},{"line_number":61,"context_line":"                string_parts.append(self.configuration_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2FyFc%3D","line":58,"updated":"2013-12-31 20:49:14.000000000","message":"return \"/\".join([\n    self.dbaas.client.service_url,\n    self.configuration_id,\n    ])","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            if self.configuration_id \u003d\u003d \"\":"},{"line_number":56,"context_line":"                configuration_ref \u003d self.configuration_id"},{"line_number":57,"context_line":"            else:"},{"line_number":58,"context_line":"                string_parts \u003d []"},{"line_number":59,"context_line":"                string_parts.append(self.dbaas.client.service_url)"},{"line_number":60,"context_line":"                string_parts.append(\"/\")"},{"line_number":61,"context_line":"                string_parts.append(self.configuration_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fv54%3D","line":58,"in_reply_to":"AAAAT3%2F%2FyFc%3D","updated":"2014-01-08 22:48:35.000000000","message":"++","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                           self.values, self.description)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"    def update(self):"},{"line_number":346,"context_line":"        \"\"\"Update an existing configuration\"\"\""},{"line_number":347,"context_line":"        self._require(\u0027id\u0027, \u0027values\u0027)"},{"line_number":348,"context_line":"        self._pretty_print(self.dbaas.configurations.update, self.id,"},{"line_number":349,"context_line":"                           self.values, self.name, self.description)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fv2s%3D","line":346,"updated":"2014-01-08 22:48:35.000000000","message":"same comment as edit?","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                           self.values, self.name, self.description)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"    def edit(self):"},{"line_number":352,"context_line":"        \"\"\"Update an existing configuration\"\"\""},{"line_number":353,"context_line":"        self._require(\u0027id\u0027, \u0027values\u0027)"},{"line_number":354,"context_line":"        self._pretty_print(self.dbaas.configurations.edit, self.id,"},{"line_number":355,"context_line":"                           self.values)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fv2k%3D","line":352,"updated":"2014-01-08 22:48:35.000000000","message":"same comment as edit?","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"}],"troveclient/compat/xml.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"3c5fc5afd899ed7075045b1d3b802d1e7ef3e33d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"    \"configuration-parameter\": {"},{"line_number":67,"context_line":"        \"max\": int,"},{"line_number":68,"context_line":"        \"min\": int,"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":"}"},{"line_number":71,"context_line":"TYPE_MAP[\"flavors\"] \u003d TYPE_MAP[\"flavor\"]"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAT3%2F%2FyFY%3D","line":69,"updated":"2013-12-31 20:49:14.000000000","message":"Would you mind adding a comma here too please?","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"77710e6022c6530a0945fb4d5c502b0ffb117d7b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    \"backups\": [[]],"},{"line_number":39,"context_line":"    \"datastores\": [[]],"},{"line_number":40,"context_line":"    \"datastore_versions\": [[]],"},{"line_number":41,"context_line":"    \"configuration-parameters\": [[]],"},{"line_number":42,"context_line":"}"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fj4M%3D","line":41,"updated":"2014-01-11 06:16:25.000000000","message":"should be an underscore vs. a hyphen? (see the precedent above)","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"77710e6022c6530a0945fb4d5c502b0ffb117d7b","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        \"to_port\": int,"},{"line_number":80,"context_line":"    },"},{"line_number":81,"context_line":"    \"quotas\": IntDict,"},{"line_number":82,"context_line":"    \"configuration-parameter\": {"},{"line_number":83,"context_line":"        \"max\": int,"},{"line_number":84,"context_line":"        \"min\": int,"},{"line_number":85,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fj4I%3D","line":82,"updated":"2014-01-11 06:16:25.000000000","message":"should be an underscore vs. a hyphen? (see the precedent above)","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"}],"troveclient/tests/test_configurations.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b2398462627e362a49a1e50c2deaf564ff001785","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    def test___repr__(self):"},{"line_number":25,"context_line":"        self.configuration.name \u003d \"config-1\""},{"line_number":26,"context_line":"        self.assertEqual(\u0027\u003cConfiguration: config-1\u003e\u0027,"},{"line_number":27,"context_line":"                         self.configuration.__repr__())"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ConfigurationsTest(TestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2Fj%2Fw%3D","line":27,"updated":"2013-11-01 09:55:27.000000000","message":"It would be better to store test___repr__ test in class below, because, i suppose, there is no super-custom configuration in setUp, tearDown methods, and they are looks familiar with setUp/tearDown methods of ConfigurationsTest","commit_id":"7e495732df43ce810120b7727e04f7745998646f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"55eabda2e12aa7142e0eb14cd20a8da94e345e0b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import json"},{"line_number":2,"context_line":"from testtools import TestCase"},{"line_number":3,"context_line":"from mock import Mock"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAATn%2F89Qs%3D","line":1,"updated":"2013-12-18 12:11:25.000000000","message":"could you please add license header","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"import json"},{"line_number":2,"context_line":"from testtools import TestCase"},{"line_number":3,"context_line":"from mock import Mock"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fv1Q%3D","line":1,"in_reply_to":"AAAATn%2F89Qs%3D","updated":"2014-01-08 22:48:35.000000000","message":"++","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"77710e6022c6530a0945fb4d5c502b0ffb117d7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2013 Rackspace Hosting"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fj4E%3D","line":2,"updated":"2014-01-11 06:16:25.000000000","message":"this is a new file, shouldn\u0027t it be 2014?","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e273081adab2bb3f86475116f7d785012cf75a2f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":2,"context_line":"# Copyright 2013 Rackspace Hosting"},{"line_number":3,"context_line":"# All Rights Reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fcs8%3D","line":2,"in_reply_to":"AAAAUH%2F%2Fj4E%3D","updated":"2014-01-20 22:21:26.000000000","message":"just showing the dating on this feature... :-P","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"}],"troveclient/v1/client.py":[{"author":{"_account_id":1925,"name":"Vipul Sabhaya","email":"vipuls@gmail.com","username":"vipuls"},"change_message_id":"d8334f6046ae07da8411081c8d4f73e175b4a8fc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        self.datastores \u003d Datastores(self)"},{"line_number":71,"context_line":"        self.datastore_versions \u003d DatastoreVersions(self)"},{"line_number":72,"context_line":"        self.configurations \u003d Configurations(self)"},{"line_number":73,"context_line":"        self.configurations_parameters \u003d ConfigurationParameters(self)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        #self.hosts \u003d Hosts(self)"},{"line_number":76,"context_line":"        #self.quota \u003d Quotas(self)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fus0%3D","line":73,"updated":"2014-01-09 04:24:09.000000000","message":"configuration_parameters","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"}],"troveclient/v1/instances.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b2398462627e362a49a1e50c2deaf564ff001785","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            \"instance\": {"},{"line_number":90,"context_line":"            }"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        if configuration_ref is not None:"},{"line_number":93,"context_line":"            body[\"instance\"][\"configuration_ref\"] \u003d configuration_ref"},{"line_number":94,"context_line":"        if instance_name is not None:"},{"line_number":95,"context_line":"            body[\"instance\"][\"name\"] \u003d instance_name"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2Fj%2FM%3D","line":92,"updated":"2013-11-01 09:55:27.000000000","message":"it would be better to use i\"if configuration_ref:\"","commit_id":"7e495732df43ce810120b7727e04f7745998646f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b2398462627e362a49a1e50c2deaf564ff001785","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            }"},{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        if configuration_ref is not None:"},{"line_number":93,"context_line":"            body[\"instance\"][\"configuration_ref\"] \u003d configuration_ref"},{"line_number":94,"context_line":"        if instance_name is not None:"},{"line_number":95,"context_line":"            body[\"instance\"][\"name\"] \u003d instance_name"},{"line_number":96,"context_line":"        url \u003d \"/instances/%s\" % instance_id"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2Fj%2B8%3D","line":93,"updated":"2013-11-01 09:55:27.000000000","message":"please, could you substitude this calls with built-in python dict methods","commit_id":"7e495732df43ce810120b7727e04f7745998646f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b2398462627e362a49a1e50c2deaf564ff001785","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        }"},{"line_number":92,"context_line":"        if configuration_ref is not None:"},{"line_number":93,"context_line":"            body[\"instance\"][\"configuration_ref\"] \u003d configuration_ref"},{"line_number":94,"context_line":"        if instance_name is not None:"},{"line_number":95,"context_line":"            body[\"instance\"][\"name\"] \u003d instance_name"},{"line_number":96,"context_line":"        url \u003d \"/instances/%s\" % instance_id"},{"line_number":97,"context_line":"        resp, body \u003d self.api.client.put(url, body\u003dbody)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2Fj%2FI%3D","line":94,"updated":"2013-11-01 09:55:27.000000000","message":"same","commit_id":"7e495732df43ce810120b7727e04f7745998646f"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"b2398462627e362a49a1e50c2deaf564ff001785","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        if configuration_ref is not None:"},{"line_number":93,"context_line":"            body[\"instance\"][\"configuration_ref\"] \u003d configuration_ref"},{"line_number":94,"context_line":"        if instance_name is not None:"},{"line_number":95,"context_line":"            body[\"instance\"][\"name\"] \u003d instance_name"},{"line_number":96,"context_line":"        url \u003d \"/instances/%s\" % instance_id"},{"line_number":97,"context_line":"        resp, body \u003d self.api.client.put(url, body\u003dbody)"},{"line_number":98,"context_line":"        check_for_exceptions(resp, body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAATn%2F%2Fj%2B4%3D","line":95,"updated":"2013-11-01 09:55:27.000000000","message":"same with built-in\u0027s","commit_id":"7e495732df43ce810120b7727e04f7745998646f"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def modify(self, instance_id, instance_name\u003dNone, configuration\u003dNone):"},{"line_number":94,"context_line":"        # TODO(pdmars): make sure empty instance body doesn\u0027t do anything"},{"line_number":95,"context_line":"        body \u003d {"},{"line_number":96,"context_line":"            \"instance\": {"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FvzQ%3D","line":93,"updated":"2014-01-08 22:48:35.000000000","message":"Shouldnt there be some check here to require at least one of those?","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"}],"troveclient/v1/shell.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"ae70cfbafec82c0f070876db4584447045fb369d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"           metavar\u003d\u0027\u003cflavor_id\u003e\u0027,"},{"line_number":181,"context_line":"           help\u003d\u0027Flavor of the instance\u0027)"},{"line_number":182,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":183,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":184,"context_line":"    \"\"\"Resizes the flavor of an instance.\"\"\""},{"line_number":185,"context_line":"    cs.instances.resize_flavor(args.instance, args.flavor_id)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F9Ak%3D","line":183,"updated":"2013-10-23 18:32:50.000000000","message":"There\u0027s another do_resize_flavor defined on 197, what\u0027s up with that?","commit_id":"0615ff1c617d6d061bae3dcf59440871a4404a61"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6d295fd0c15d697f3bad68bc5af36089f82a6e5c","unresolved":false,"context_lines":[{"line_number":180,"context_line":"           metavar\u003d\u0027\u003cflavor_id\u003e\u0027,"},{"line_number":181,"context_line":"           help\u003d\u0027Flavor of the instance\u0027)"},{"line_number":182,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":183,"context_line":"def do_resize_flavor(cs, args):"},{"line_number":184,"context_line":"    \"\"\"Resizes the flavor of an instance.\"\"\""},{"line_number":185,"context_line":"    cs.instances.resize_flavor(args.instance, args.flavor_id)"},{"line_number":186,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATX%2F%2F8f4%3D","line":183,"in_reply_to":"AAAATX%2F%2F9Ak%3D","updated":"2013-10-23 20:37:26.000000000","message":"hmmm weird... thanks for that catch","commit_id":"0615ff1c617d6d061bae3dcf59440871a4404a61"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":261,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":262,"context_line":"           type\u003dstr,"},{"line_number":263,"context_line":"           help\u003d\u0027UUID of the instance\u0027)"},{"line_number":264,"context_line":"def do_default_configuration(cs, args):"},{"line_number":265,"context_line":"    \"\"\"Gets the instance\u0027s default configuration\"\"\""},{"line_number":266,"context_line":"    configs \u003d cs.instances.configuration(args.instance)"},{"line_number":267,"context_line":"    utils.print_dict(configs._info[\u0027configuration\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2FvzM%3D","line":264,"updated":"2014-01-08 22:48:35.000000000","message":"the cli call default_configuration seems a bit of an odd name. but i dont have a better opinion so unless someone else does, it can stay :)","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":624,"context_line":"           help\u003d\u0027Datastore version assigned to the Configuration Group.\u0027)"},{"line_number":625,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":626,"context_line":"           default\u003dNone,"},{"line_number":627,"context_line":"           help\u003d\u0027An optional description for the configuration Group.\u0027)"},{"line_number":628,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":629,"context_line":"def do_configuration_create(cs, args):"},{"line_number":630,"context_line":"    \"\"\"Creates a configuration group.\"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fvys%3D","line":627,"updated":"2014-01-08 22:48:35.000000000","message":"caps on Configuration","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"74045e778f0ecf2e78bf811cdc5cd4e4fcb23f04","unresolved":false,"context_lines":[{"line_number":627,"context_line":"           help\u003d\u0027An optional description for the configuration Group.\u0027)"},{"line_number":628,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":629,"context_line":"def do_configuration_create(cs, args):"},{"line_number":630,"context_line":"    \"\"\"Creates a configuration group.\"\"\""},{"line_number":631,"context_line":"    config_grp \u003d cs.configurations.create("},{"line_number":632,"context_line":"        args.name,"},{"line_number":633,"context_line":"        args.values,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F%2Fvyk%3D","line":630,"updated":"2014-01-08 22:48:35.000000000","message":"caps on Configuration.\n\nCan u go thru them and make sure you are consistent? i dont care about it being caps or not (id kinda prefer lowecase), just the same across the comments hehe","commit_id":"f327c458d8f4d325d63e546833f329cf67c0c1fa"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"77710e6022c6530a0945fb4d5c502b0ffb117d7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Rackspace Hosting"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fjzc%3D","line":1,"updated":"2014-01-11 06:16:25.000000000","message":"after spending a couple of hours with all of the configuration-group patches, here are my suggestions:\n\n\n********* FROM *********\n\nconfiguration-create\n                    Creates a configuration group.\nconfiguration-delete\n                    Delete the configuration group.\nconfiguration-edit\n                    Upsert the details of a configuration group.\nconfiguration-get-parameter\n                    Get details of a configuration parameter.\nconfiguration-instance-list\n                    Shows details of a configuration group.\nconfiguration-list\n                    Lists all configuration groups.\nconfiguration-list-parameters\n                    Shows details of a configuration group.\nconfiguration-show\n                    Shows details of a configuration group.\nconfiguration-update\n                    Updates the details of a configuration group.\n...\ndefault-configuration\n                    Gets the instance\u0027s default configuration\nmodify\n                    Modifies the instance\n\n\n********* TO *********\n\nconfiguration-attach\n                    Attaches a configuration group to an instance.\nconfiguration-create\n                    Creates a configuration group.\nconfiguration-default\n                    Shows the default configuration of an instance.\nconfiguration-delete\n                    Deletes a configuration group.\nconfiguration-detach\n                    Detaches a configuration group from an instance.\nconfiguration-parameter-show\n                    Shows details of a configuration parameter.\nconfiguration-parameter-list\n                    Lists available parameters for a configuration group.\nconfiguration-patch\n                    Patches a configuration group.\nconfiguration-instances\n                    Lists all instances associated with a configuration group.\nconfiguration-list\n                    Lists all configuration groups.\nconfiguration-show\n                    Shows details of a configuration group.\nconfiguration-update\n                    Updates a configuration group.\n\n\n\n********* NOTES *********\n\n\u003e \"edit\" to \"patch\" because it\u0027s not clear the difference between an\nedit and an update (using traditional definitions). i believe that\n\"patch\" is a better fit given that its indicative of the http method\nand almost always insinuates in-line changes vs purge-replace.\n\n\u003e \"get-parameter\" and \"list-parameters\" to \"parameter-show\" and\n\"parameter-list\" to logically group on the object (the parameter),\nuse \"show\" vs. \"get\", and to support a natural extension for the\nmanagement api if need be (e.g. \"configuration-parameter-add\",\n\"configuration-parameter-update\", etc.)\n\n\u003e removed accidental copy/paste help text content, and updated the content for other commands to make the results more obvious.\n\n\u003e removed \"modify\" and replaced it with \"attach\" and \"detach\".\nthe behavior of the modify action is not very straightforward\n(\"trove modify \u003cuuid\u003e\" is the command to detach a configuration\ngroup, meaning the absence of a value is the hint to drop it!).\nthe granularity of \"modify\" is too large, it becomes a slippery\nslope as to what can and should be supported in the operation.\nalternatives to the term(s) attach/detach are apply/unapply,\ncommit/uncommit, activate/deactivate, push/pop, etc.\n\n\u003e the only non-minor functional change here is the removal of\n\"modify\", and the addition of \"attach\" and \"detach\", which would\ninvolve re-writing /#/c/53168/18/trove/instance/service.py\u0027s generic\nupdate() to instead be two granular operations.\n\n\u003e pending a consensus on the above changes, i have additional\nsuggestions for content changes on the subcommand help text.","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e1fddeed87ec494b24ef974f073aca4ef3b63a43","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Rackspace Hosting"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2FdYk%3D","line":1,"in_reply_to":"AAAAUH%2F%2Fjzc%3D","updated":"2014-01-13 17:21:56.000000000","message":"Thanks for these suggestions. \n\nTo me it sounds much more clear about what operation you want to do in regards to the modify cmd. It also makes all the new configuration cli cmds related. I dont see any reason that this should not be changed to the suggestions.","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"77710e6022c6530a0945fb4d5c502b0ffb117d7b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"@utils.arg(\u0027--configuration\u0027,"},{"line_number":170,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":171,"context_line":"           default\u003dNone,"},{"line_number":172,"context_line":"           help\u003d\u0027The configuration id to apply to the instance\u0027)"},{"line_number":173,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":174,"context_line":"def do_create(cs, args):"},{"line_number":175,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2Fjz4%3D","line":172,"updated":"2014-01-11 06:16:25.000000000","message":"change to: \"UUID of the configuration group to apply to the instance\"\n\nreason: datastore and backup (above) use the term UUID over ID.","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ac3a5bde4658df0c4321e4b1e18ca3ce2a522b5b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"@utils.arg(\u0027--configuration\u0027,"},{"line_number":170,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":171,"context_line":"           default\u003dNone,"},{"line_number":172,"context_line":"           help\u003d\u0027The configuration id to apply to the instance\u0027)"},{"line_number":173,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":174,"context_line":"def do_create(cs, args):"},{"line_number":175,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2FjpI%3D","line":172,"in_reply_to":"AAAAUH%2F%2Fjz4%3D","updated":"2014-01-11 08:23:25.000000000","message":"amending the above to: \"UUID of the configuration group to attach to the instance\".\n\nnote: using \"attach\" vs. \"apply\" because apply might raise questions of a parameter merge vs. purge-replace.","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"8eaecd278987b5bafcb9a6cb96edc7a45ee1cbad","unresolved":false,"context_lines":[{"line_number":243,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":244,"context_line":"           type\u003dstr,"},{"line_number":245,"context_line":"           help\u003d\u0027UUID of the instance\u0027)"},{"line_number":246,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":247,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":248,"context_line":"           default\u003dNone,"},{"line_number":249,"context_line":"           help\u003d\u0027Name to assign to the instance\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2FjuE%3D","line":246,"updated":"2014-01-11 07:18:50.000000000","message":"although above i\u0027m advocating for \"modify\" to go away completely, it\u0027s worthwhile to note that --name here does nothing (because the api doesn\u0027t ever use it, see #/c/53168/18/trove/instance/service.py)","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"e1fddeed87ec494b24ef974f073aca4ef3b63a43","unresolved":false,"context_lines":[{"line_number":243,"context_line":"           metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":244,"context_line":"           type\u003dstr,"},{"line_number":245,"context_line":"           help\u003d\u0027UUID of the instance\u0027)"},{"line_number":246,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":247,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":248,"context_line":"           default\u003dNone,"},{"line_number":249,"context_line":"           help\u003d\u0027Name to assign to the instance\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2FdZg%3D","line":246,"in_reply_to":"AAAAUH%2F%2FjuE%3D","updated":"2014-01-13 17:21:56.000000000","message":"This will go away as did the ability to change the name in the service.","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"ac3a5bde4658df0c4321e4b1e18ca3ce2a522b5b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"@utils.arg(\u0027--configuration\u0027,"},{"line_number":251,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":252,"context_line":"           default\u003dNone,"},{"line_number":253,"context_line":"           help\u003d\u0027Configuration to assign to the instance\u0027)"},{"line_number":254,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":255,"context_line":"def do_modify(cs, args):"},{"line_number":256,"context_line":"    \"\"\"Modifies the instance\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUH%2F%2FjpQ%3D","line":253,"updated":"2014-01-11 08:23:25.000000000","message":"even though i\u0027m advocating for \"modify\" to go away completely, it\u0027s worth noting that the ID is required here (the help text is ambiguous, users could assume name might work).\n\nshould be something like: \"UUID of the configuration group to attach to the instance\"","commit_id":"f0e8d1f23ec3611715cefa684b1a7a9821f12561"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"da65ad1fce0b82432f1b3d4a36b851cc6db95092","unresolved":false,"context_lines":[{"line_number":177,"context_line":"@utils.arg(\u0027--configuration\u0027,"},{"line_number":178,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":179,"context_line":"           default\u003dNone,"},{"line_number":180,"context_line":"           help\u003d\u0027The configuration id to apply to the instance\u0027)"},{"line_number":181,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":182,"context_line":"def do_create(cs, args):"},{"line_number":183,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BBCc%3D","line":180,"updated":"2014-01-30 23:28:06.000000000","message":"change to \"UUID of the configuration group to attach to the instance\"\n\nnote: using \"attach\" vs. \"apply\" because apply might raise questions of a parameter merge vs. purge-replace (plus, the action is configuration-attach)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"6324e5f4e39b21ec810eb02f6ba4ec7f238a4d82","unresolved":false,"context_lines":[{"line_number":177,"context_line":"@utils.arg(\u0027--configuration\u0027,"},{"line_number":178,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":179,"context_line":"           default\u003dNone,"},{"line_number":180,"context_line":"           help\u003d\u0027The configuration id to apply to the instance\u0027)"},{"line_number":181,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":182,"context_line":"def do_create(cs, args):"},{"line_number":183,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BAKo%3D","line":180,"in_reply_to":"AAAAUH%2F%2BBCc%3D","updated":"2014-01-31 04:58:15.000000000","message":"yeah keep the same nomenclature.","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":628,"context_line":"           help\u003d\u0027Dictionary of the values to set.\u0027)"},{"line_number":629,"context_line":"@utils.arg(\u0027--datastore\u0027, metavar\u003d\u0027\u003cdatastore\u003e\u0027,"},{"line_number":630,"context_line":"           help\u003d\u0027Datastore assigned to the configuration group.\u0027)"},{"line_number":631,"context_line":"@utils.arg(\u0027--datastore-version\u0027, metavar\u003d\u0027\u003cdatastore-version\u003e\u0027,"},{"line_number":632,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":633,"context_line":"@utils.arg(\u0027--description\u0027, metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":634,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA7c%3D","line":631,"updated":"2014-01-30 23:45:51.000000000","message":"should be --datastore_version, not --datastore-version (that\u0027s the established pattern thus far in the cli)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":677,"context_line":"@utils.arg(\u0027datastore\u0027,"},{"line_number":678,"context_line":"           metavar\u003d\u0027\u003cdatastore\u003e\u0027,"},{"line_number":679,"context_line":"           help\u003d\u0027Datastore name or UUID to list configuration parameters for.\u0027)"},{"line_number":680,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":681,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":682,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":683,"context_line":"@utils.arg(\u0027parameter\u0027, metavar\u003d\u0027\u003cparameter\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA7I%3D","line":680,"updated":"2014-01-30 23:45:51.000000000","message":"should be datastore_version, not version (to align with the conventions you\u0027ve set in other commands)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":694,"context_line":"@utils.arg(\u0027datastore\u0027,"},{"line_number":695,"context_line":"           metavar\u003d\u0027\u003cdatastore\u003e\u0027,"},{"line_number":696,"context_line":"           help\u003d\u0027Datastore name or UUID to list configuration parameters for.\u0027)"},{"line_number":697,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":698,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":699,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":700,"context_line":"@utils.service_type(\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA64%3D","line":697,"updated":"2014-01-30 23:45:51.000000000","message":"should be datastore_version, not version (to align with the conventions you\u0027ve set in other commands)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                              \u0027restart_required\u0027])"},{"line_number":707,"context_line":""},{"line_number":708,"context_line":""},{"line_number":709,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":710,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":711,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":712,"context_line":"@utils.arg(\u0027parameter\u0027, metavar\u003d\u0027\u003cparameter\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA6o%3D","line":709,"updated":"2014-01-30 23:45:51.000000000","message":"should be datastore_version, not version (to align with the conventions you\u0027ve set in other commands)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"da65ad1fce0b82432f1b3d4a36b851cc6db95092","unresolved":false,"context_lines":[{"line_number":708,"context_line":""},{"line_number":709,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":710,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":711,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":712,"context_line":"@utils.arg(\u0027parameter\u0027, metavar\u003d\u0027\u003cparameter\u003e\u0027,"},{"line_number":713,"context_line":"           help\u003d\u0027Name of the configuration parameter.\u0027)"},{"line_number":714,"context_line":"@utils.service_type(\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BBEE%3D","line":711,"updated":"2014-01-30 23:28:06.000000000","message":"should say \"Datastore version UUID assigned to the configuration group.\" because this particular operation requires the UUID (whereas do_configuration_parameter_show accepts either the name or the uuid)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":720,"context_line":"    _print_instance(param)"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":""},{"line_number":723,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":724,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":725,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":726,"context_line":"@utils.service_type(\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA6k%3D","line":723,"updated":"2014-01-30 23:45:51.000000000","message":"should be datastore_version, not version (to align with the conventions you\u0027ve set in other commands)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"da65ad1fce0b82432f1b3d4a36b851cc6db95092","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"@utils.arg(\u0027version\u0027,"},{"line_number":724,"context_line":"           metavar\u003d\u0027\u003cversion\u003e\u0027,"},{"line_number":725,"context_line":"           help\u003d\u0027Datastore version assigned to the configuration group.\u0027)"},{"line_number":726,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":727,"context_line":"def do_configuration_parameter_version_list(cs, args):"},{"line_number":728,"context_line":"    \"\"\"Lists available parameters for a configuration group.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BBDg%3D","line":725,"updated":"2014-01-30 23:28:06.000000000","message":"should say \"Datastore version UUID assigned to the configuration group.\" because this particular operation requires the UUID (whereas do_configuration_parameter_list accepts either the name or the uuid)","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cb1a516158b843268c1c003ae110411aada72383","unresolved":false,"context_lines":[{"line_number":763,"context_line":"           help\u003d\u0027ID of the configuration group.\u0027)"},{"line_number":764,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":765,"context_line":"def do_configuration_show(cs, args):"},{"line_number":766,"context_line":"    \"\"\"Shows deatils of a configuration group.\"\"\""},{"line_number":767,"context_line":"    config_grp \u003d cs.configurations.get(args.configuration_group)"},{"line_number":768,"context_line":"    _print_instance(config_grp)"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUH%2F%2BA6Y%3D","line":766,"updated":"2014-01-30 23:45:51.000000000","message":"\"deatils\" should be \"details\".","commit_id":"59efdcb02ec2c07bc7a5b04cc308f9244270f3d9"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cffd2d63501f80482c7821229a096b338ad5710b","unresolved":false,"context_lines":[{"line_number":681,"context_line":"                \u0027 datastore_version is provided.\u0027)"},{"line_number":682,"context_line":"@utils.arg(\u0027datastore_version\u0027,"},{"line_number":683,"context_line":"           metavar\u003d\u0027\u003cdatastore_version\u003e\u0027,"},{"line_number":684,"context_line":"           help\u003d\u0027Datastore version UUID assigned to the configuration group.\u0027)"},{"line_number":685,"context_line":"@utils.arg(\u0027parameter\u0027, metavar\u003d\u0027\u003cparameter\u003e\u0027,"},{"line_number":686,"context_line":"           help\u003d\u0027Name of the configuration parameter.\u0027)"},{"line_number":687,"context_line":"@utils.service_type(\u0027database\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F97jA%3D","line":684,"updated":"2014-01-31 23:10:33.000000000","message":"should be \"Datastore version name or uuid assigned to the configuration group\".\n\nhere\u0027s why: the version name can be used if --datastore is also provided, otherwise it has to be the uuid. so in the datastore_version description it should remain agnostic, and that\u0027s why the optional --datastore argument explains that if the uuid of the version is provided, the --datastore argument is optional.","commit_id":"53d6831d813c09e704759dbb00502e0cf707ac0c"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"cffd2d63501f80482c7821229a096b338ad5710b","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                \u0027 datastore_version is provided.\u0027)"},{"line_number":707,"context_line":"@utils.arg(\u0027datastore_version\u0027,"},{"line_number":708,"context_line":"           metavar\u003d\u0027\u003cdatastore_version\u003e\u0027,"},{"line_number":709,"context_line":"           help\u003d\u0027Datastore version UUID assigned to the configuration group.\u0027)"},{"line_number":710,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":711,"context_line":"def do_configuration_parameter_list(cs, args):"},{"line_number":712,"context_line":"    \"\"\"Lists available parameters for a configuration group.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAAUH%2F97jE%3D","line":709,"updated":"2014-01-31 23:10:33.000000000","message":"should be \"Datastore version name or uuid assigned to the configuration group\".\n\nhere\u0027s why: the version name can be used if --datastore is also provided, otherwise it has to be the uuid. so in the datastore_version description it should remain agnostic, and that\u0027s why the optional --datastore argument explains that if the uuid of the version is provided, the --datastore argument is optional.","commit_id":"53d6831d813c09e704759dbb00502e0cf707ac0c"}]}