)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":10,"context_line":"project for the resize-instance command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The trove command resize-instance is now:"},{"line_number":13,"context_line":"    openstack database resize instance"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_199c800c","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":38},"updated":"2018-01-17 01:27:10.000000000","message":"add bp message","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"288a524b0267a7a96b6ff9105e225f3c029caae7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"project for the resize-instance command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The trove command resize-instance is now:"},{"line_number":13,"context_line":"    openstack database resize instance"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_7c69f2f6","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":38},"in_reply_to":"7f96bb07_199c800c","updated":"2018-01-17 02:24:43.000000000","message":"And the new comamnd is not correct, should be \"openstack database resize\" according the patch.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"change_message_id":"af35383d2863f6561955802ceaebaf4862d5e55c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"project for the resize-instance command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The trove command resize-instance is now:"},{"line_number":13,"context_line":"    openstack database resize instance"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f96bb07_d74f9868","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":38},"in_reply_to":"7f96bb07_7c69f2f6","updated":"2018-01-18 02:43:32.000000000","message":"Firstly thanks for your reviewing, actually, database resize could be resize instance with new flavor or resize the volume size of the instance. This patch is  for resizing instance with new flavor, like this: openstack database resize instance \u003cinstance-id\u003e \u003cflavor-id\u003e","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"8c7bb33672e10ad30eca44faf38743ab18c680c8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"project for the resize-instance command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The trove command resize-instance is now:"},{"line_number":13,"context_line":"    openstack database resize instance"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe"},{"line_number":16,"context_line":"Partially-Implements: blueprint trove-support-in-python-openstackclient"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_fa65dbb5","line":13,"range":{"start_line":13,"start_character":30,"end_line":13,"end_character":38},"updated":"2018-01-18 03:11:15.000000000","message":"Since you use database_instance_resize in setup.cfg. This should be openstack database instance resize.","commit_id":"35212d5aa10e278be0b66eab8a7984898bdb606a"}],"releasenotes/notes/add-resize-instance-to-osc-affe8a2a31a6b017.yaml":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"8c7bb33672e10ad30eca44faf38743ab18c680c8","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The command ``trove resize-instance`` is now available to use in"},{"line_number":5,"context_line":"    the python-openstackclient CLI as ``openstack database resize instance``."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7f96bb07_1a6c479a","line":5,"range":{"start_line":5,"start_character":74,"end_line":5,"end_character":77},"updated":"2018-01-18 03:11:15.000000000","message":"The same.","commit_id":"35212d5aa10e278be0b66eab8a7984898bdb606a"}],"setup.cfg":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    database_instance_resize \u003d troveclient.osc.v1.database_instances:ResizeDatabaseInstanceFlavor"},{"line_number":58,"context_line":"    database_instance_delete \u003d troveclient.osc.v1.database_instances:DeleteDatabaseInstance"},{"line_number":59,"context_line":"    database_instance_list \u003d troveclient.osc.v1.database_instances:ListDatabaseInstances"},{"line_number":60,"context_line":"    database_instance_reset_status \u003d troveclient.osc.v1.database_instances:ResetDatabaseInstanceStatus"},{"line_number":61,"context_line":"    database_instance_show \u003d troveclient.osc.v1.database_instances:ShowDatabaseInstance"},{"line_number":62,"context_line":"    database_limit_list \u003d troveclient.osc.v1.database_limits:ListDatabaseLimits"},{"line_number":63,"context_line":"    database_root_disable \u003d troveclient.osc.v1.database_root:DisableDatabaseRoot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"7f96bb07_99c65068","line":60,"range":{"start_line":60,"start_character":4,"end_line":60,"end_character":34},"updated":"2018-01-17 01:27:10.000000000","message":"put instance_resize between instance_reset_status and instance_show","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"}],"troveclient/osc/v1/database_instances.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"7c5f9c3f429ed368ca100a31b0230e0a8c1f71a9","unresolved":false,"context_lines":[{"line_number":394,"context_line":"    _description \u003d _(\"Resize an instance with a new flavor\")"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"    def get_parser(self, prog_name):"},{"line_number":397,"context_line":"        parser \u003d super(ResizeDatabaseInstanceFlavor, self).get_parser("},{"line_number":398,"context_line":"                                                               prog_name"},{"line_number":399,"context_line":"                                                           )"},{"line_number":400,"context_line":"        parser.add_argument("},{"line_number":401,"context_line":"            \u0027instance\u0027,"},{"line_number":402,"context_line":"            metavar\u003d\u0027\u003cinstance\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_8fda4c75","line":399,"range":{"start_line":397,"start_character":59,"end_line":399,"end_character":60},"updated":"2018-01-18 08:57:21.000000000","message":"PEP8 check failed for this.","commit_id":"0a216f38dd5b5492603a6380ec60638d80c21e4a"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"7c5f9c3f429ed368ca100a31b0230e0a8c1f71a9","unresolved":false,"context_lines":[{"line_number":414,"context_line":"    def take_action(self, parsed_args):"},{"line_number":415,"context_line":"        db_instances \u003d self.app.client_manager.database.instances"},{"line_number":416,"context_line":"        db_flavor \u003d self.app.client_manager.database.flavors"},{"line_number":417,"context_line":"        try:"},{"line_number":418,"context_line":"            instance \u003d osc_utils.find_resource(db_instances,"},{"line_number":419,"context_line":"                                               parsed_args.instance)"},{"line_number":420,"context_line":"        except Exception as e:"},{"line_number":421,"context_line":"            msg \u003d (_(\"No instance with a name or ID of \u0027%s\u0027 exists\")"},{"line_number":422,"context_line":"                   % instance)"},{"line_number":423,"context_line":"            raise exceptions.ComandError(msg)"},{"line_number":424,"context_line":"        try:"},{"line_number":425,"context_line":"            flavor \u003d osc_utils.find_resource(db_flavor,"},{"line_number":426,"context_line":"                                             parsed_args.flavor_id)"},{"line_number":427,"context_line":"        except Exception as e:"},{"line_number":428,"context_line":"            msg \u003d (_(\"No flavor with a name or ID of \u0027%s\u0027 exists\")"},{"line_number":429,"context_line":"                   % flavor)"},{"line_number":430,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":431,"context_line":"        db_instances.resize_instance(instance, flavor)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f96bb07_af3f0885","line":430,"range":{"start_line":417,"start_character":0,"end_line":430,"end_character":46},"updated":"2018-01-18 08:57:21.000000000","message":"Not neccessary to catch exceptions here, osc_utils.find_resource will take care of this.","commit_id":"0a216f38dd5b5492603a6380ec60638d80c21e4a"}],"troveclient/osc/v1/database_resize.py":[{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from troveclient.il8n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ResizeDatabaseInstanceFlavor(command.ShowOne):"},{"line_number":23,"context_line":"    "},{"line_number":24,"context_line":"    _description \u003d _(\"Resize an instance with a new flavor\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_79f6e465","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":52},"updated":"2018-01-17 01:27:10.000000000","message":"command.Command","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"288a524b0267a7a96b6ff9105e225f3c029caae7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from troveclient.il8n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ResizeDatabaseInstanceFlavor(command.ShowOne):"},{"line_number":23,"context_line":"    "},{"line_number":24,"context_line":"    _description \u003d _(\"Resize an instance with a new flavor\")"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_8f191e7b","line":22,"range":{"start_line":22,"start_character":50,"end_line":22,"end_character":52},"in_reply_to":"7f96bb07_79f6e465","updated":"2018-01-17 02:24:43.000000000","message":"This class shoud be added to the existing database_instances.py according to the change in setup.cfg.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from troveclient.il8n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class ResizeDatabaseInstanceFlavor(command.ShowOne):"},{"line_number":23,"context_line":"    "},{"line_number":24,"context_line":"    _description \u003d _(\"Resize an instance with a new flavor\")"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_19fd606d","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":4},"updated":"2018-01-17 01:27:10.000000000","message":"fix this.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        parser \u003d super(ResizeDatabaseInstance, self).get_parser(prog_name)"},{"line_number":28,"context_line":"        parser.add_argument("},{"line_number":29,"context_line":"            \u0027instance\u0027,"},{"line_number":30,"context_line":"            metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":31,"context_line":"            help\u003d_(\u0027ID of the instance\u0027)"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_f96af417","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":33},"updated":"2018-01-17 01:27:10.000000000","message":"add a \"type\u003dstr\"\nhttps://github.com/openstack/python-troveclient/blob/master/troveclient/v1/shell.py#L900","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        parser.add_argument("},{"line_number":29,"context_line":"            \u0027instance\u0027,"},{"line_number":30,"context_line":"            metavar\u003d\u0027\u003cinstance\u003e\u0027,"},{"line_number":31,"context_line":"            help\u003d_(\u0027ID of the instance\u0027)"},{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027flavor_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_f9f7548a","line":31,"range":{"start_line":31,"start_character":23,"end_line":31,"end_character":25},"updated":"2018-01-17 01:27:10.000000000","message":"ID or name","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"288a524b0267a7a96b6ff9105e225f3c029caae7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        )"},{"line_number":33,"context_line":"        parser.add_argument("},{"line_number":34,"context_line":"            \u0027flavor_id\u0027,"},{"line_number":35,"context_line":"            metavar\u003d\u0027\u003cflavor\u003e\u0027,"},{"line_number":36,"context_line":"            help\u003d_(\u0027New flavor of the instance\u0027)"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_5c32f611","line":35,"updated":"2018-01-17 02:24:43.000000000","message":"Also need a \"type\u003dstr\", should follow the way troveclient goes.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":36,"context_line":"            help\u003d_(\u0027New flavor of the instance\u0027)"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":"    "},{"line_number":40,"context_line":"    def take_action(self, parsed_args):"},{"line_number":41,"context_line":"        db_instances \u003d self.app.client_manager.database.instances"},{"line_number":42,"context_line":"        instance \u003d osc_utils.find_resource(db_instances,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_39029c70","line":39,"range":{"start_line":39,"start_character":0,"end_line":39,"end_character":4},"updated":"2018-01-17 01:27:10.000000000","message":"fix this.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6f97ac4f64ab81211435af3331beb0fa2565e485","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def take_action(self, parsed_args):"},{"line_number":41,"context_line":"        db_instances \u003d self.app.client_manager.database.instances"},{"line_number":42,"context_line":"        instance \u003d osc_utils.find_resource(db_instances,"},{"line_number":43,"context_line":"                                           parsed_args.instance)"},{"line_number":44,"context_line":"        db_instances.resize_instance(instance, parsed_args.flavor_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_19cec02c","line":43,"range":{"start_line":43,"start_character":63,"end_line":43,"end_character":64},"updated":"2018-01-17 01:27:10.000000000","message":"you should add _find_flavor() to varify the flavor_id","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"}],"troveclient/tests/osc/v1/test_database_instances.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"288a524b0267a7a96b6ff9105e225f3c029caae7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        mock_find.side_effect \u003d [\u0027instance1\u0027, \u0027flavor_id\u0027]"},{"line_number":198,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, args, [])"},{"line_number":199,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":200,"context_line":"        self.instance_client.modify.assert_called_with(\u0027instance1\u0027, \u0027flavor_id\u0027)"},{"line_number":201,"context_line":"        self.assertIsNone(result)"},{"line_number":202,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_efc30288","line":200,"range":{"start_line":200,"start_character":29,"end_line":200,"end_character":35},"updated":"2018-01-17 02:24:43.000000000","message":"?: \u0027modify\u0027 is not called by this action.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"288a524b0267a7a96b6ff9105e225f3c029caae7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":200,"context_line":"        self.instance_client.modify.assert_called_with(\u0027instance1\u0027, \u0027flavor_id\u0027)"},{"line_number":201,"context_line":"        self.assertIsNone(result)"},{"line_number":202,"context_line":"        "}],"source_content_type":"text/x-python","patch_set":1,"id":"7f96bb07_cf6ac6b1","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":8},"updated":"2018-01-17 02:24:43.000000000","message":"This should be removed.","commit_id":"bdad096cbf687dcdd9af8603c27423cb0b8bf634"}]}