)]}'
{"id":"openstack%2Fpython-troveclient~534224","triplet_id":"openstack%2Fpython-troveclient~master~I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe","project":"openstack/python-troveclient","branch":"master","topic":"bp/trove-support-in-python-openstackclient","hashtags":[],"change_id":"I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe","subject":"Add resize-instance to OSC","status":"MERGED","created":"2018-01-16 10:20:46.000000000","updated":"2018-01-18 21:42:14.000000000","submitted":"2018-01-18 21:42:14.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"534224-1516311734679-eb6e561f","meta_rev_id":"098b227a113330d7156a1001102b74b7d7845dd5","_number":534224,"virtual_id_number":534224,"owner":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":2,"date":"2018-01-18 21:42:14.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":2,"date":"2018-01-18 17:34:59.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":1,"date":"2018-01-18 11:49:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":1,"date":"2018-01-18 17:34:59.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-17 15:16:24.000000000","updated_by":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"reviewer":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"state":"REVIEWER"},{"updated":"2018-01-18 09:18:57.000000000","updated_by":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"reviewer":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"state":"REVIEWER"},{"updated":"2018-01-18 11:49:26.000000000","updated_by":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"reviewer":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"state":"REVIEWER"},{"updated":"2018-01-18 17:34:59.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2018-01-18 21:42:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"41900d7cfe28d803c30762e382481d8e499740ff","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-16 10:20:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"15672d42099e44f67a90a7c86de6bec72df013de","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-16 12:45:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/534224/1/check/build-openstack-sphinx-docs/1b4676a/ : FAILURE in 6m 25s\n- openstack-tox-pep8 http://logs.openstack.org/24/534224/1/check/openstack-tox-pep8/9ed62d4/ : FAILURE in 4m 50s\n- openstack-tox-py27 http://logs.openstack.org/24/534224/1/check/openstack-tox-py27/0a1f3b6/ : FAILURE in 4m 57s\n- openstack-tox-py35 http://logs.openstack.org/24/534224/1/check/openstack-tox-py35/e42883d/ : FAILURE in 4m 20s\n- openstackclient-check-plugins http://logs.openstack.org/24/534224/1/check/openstackclient-check-plugins/b96db78/ : FAILURE in 7m 28s (non-voting)\n- legacy-trove-functional-dsvm-mysql http://logs.openstack.org/24/534224/1/check/legacy-trove-functional-dsvm-mysql/b3c7638/ : SUCCESS in 1h 57m 08s\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/24/534224/1/check/tempest-neutron-src-python-troveclient/c645385/ : SUCCESS in 1h 16m 25s","accounts_in_message":[],"_revision_number":1},{"id":"6f97ac4f64ab81211435af3331beb0fa2565e485","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-01-17 01:27:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(8 comments)\n\nhi,\n1. notice zuul check fail. Please test your code in local before git review.\n2. you should add a releasenote.\n3. put the class into database_instances.py, there doesn\u0027t need a new \"database_resize.py\"","accounts_in_message":[],"_revision_number":1},{"id":"2e0b3c391417f78ea1f4982761c698b2f36bb2a6","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-17 01:41:07.000000000","message":"Patch Set 1:\n\n\u003e (8 comments)\n \u003e \n \u003e hi,\n \u003e 1. notice zuul check fail. Please test your code in local before\n \u003e git review.\n \u003e 2. you should add a releasenote.\n \u003e 3. put the class into database_instances.py, there doesn\u0027t need a\n \u003e new \"database_resize.py\"\n\nyes, thanks for your review","accounts_in_message":[],"_revision_number":1},{"id":"288a524b0267a7a96b6ff9105e225f3c029caae7","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-17 02:24:43.000000000","message":"Patch Set 1: Code-Review-1\n\n(5 comments)\n\nSome inline comments, as zhanggang mentioned, it would be good to test the patch in local environment before pushing for review.\n\nThanks for contributing.","accounts_in_message":[],"_revision_number":1},{"id":"63fa3b0d426a484cef03160050bb0852495b04ea","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-01-17 15:16:24.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"dce2b5c9f9bb92e1952496f02788a3724d22eec8","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 02:42:16.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"af35383d2863f6561955802ceaebaf4862d5e55c","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 02:43:32.000000000","message":"Patch Set 2:\n\n(1 comment)\n\n\u003e (5 comments)\n \u003e \n \u003e Some inline comments, as zhanggang mentioned, it would be good to\n \u003e test the patch in local environment before pushing for review.\n \u003e \n \u003e Thanks for contributing.\n\nupdate","accounts_in_message":[],"_revision_number":2},{"id":"12da0713f01a3abfb947d0987187f624cba73759","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 02:43:51.000000000","message":"Patch Set 2:\n\n\u003e (8 comments)\n \u003e \n \u003e hi,\n \u003e 1. notice zuul check fail. Please test your code in local before\n \u003e git review.\n \u003e 2. you should add a releasenote.\n \u003e 3. put the class into database_instances.py, there doesn\u0027t need a\n \u003e new \"database_resize.py\"\n\nupdate","accounts_in_message":[],"_revision_number":2},{"id":"8c7bb33672e10ad30eca44faf38743ab18c680c8","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-01-18 03:11:15.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)\n\nThere are two resize command resize instance and resize volume.\nMy suggestion is use \"openstack database instance resize flavor\" and \"openstack database instance resize volume\".\nBesides, you should run the command in your local, then you will find that \"openstack database resize instance\" doesn\u0027t exist.","accounts_in_message":[],"_revision_number":2},{"id":"5129b9945ef59a011ceb0d32ed1a01af38801e53","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 04:48:06.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/534224/2/check/build-openstack-sphinx-docs/1265518/html/ : SUCCESS in 5m 43s\n- openstack-tox-pep8 http://logs.openstack.org/24/534224/2/check/openstack-tox-pep8/6a2226c/ : FAILURE in 5m 47s\n- openstack-tox-py27 http://logs.openstack.org/24/534224/2/check/openstack-tox-py27/3296b00/ : SUCCESS in 4m 22s\n- openstack-tox-py35 http://logs.openstack.org/24/534224/2/check/openstack-tox-py35/53f7c98/ : SUCCESS in 5m 19s\n- build-openstack-releasenotes http://logs.openstack.org/24/534224/2/check/build-openstack-releasenotes/1699b36/html/ : SUCCESS in 5m 09s\n- openstackclient-check-plugins http://logs.openstack.org/24/534224/2/check/openstackclient-check-plugins/6d3242f/ : SUCCESS in 6m 06s (non-voting)\n- legacy-trove-functional-dsvm-mysql http://logs.openstack.org/24/534224/2/check/legacy-trove-functional-dsvm-mysql/1943a1d/ : SUCCESS in 1h 57m 24s\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/24/534224/2/check/tempest-neutron-src-python-troveclient/ad538fa/ : SUCCESS in 1h 28m 37s","accounts_in_message":[],"_revision_number":2},{"id":"b74eabb7a01f1a36bb507859b9e9e0f3635ebf1e","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-18 05:06:47.000000000","message":"Patch Set 2: Code-Review-1\n\n\u003e (2 comments)\n \u003e \n \u003e There are two resize command resize instance and resize volume.\n \u003e My suggestion is use \"openstack database instance resize flavor\"\n \u003e and \"openstack database instance resize volume\".\n \u003e Besides, you should run the command in your local, then you will\n \u003e find that \"openstack database resize instance\" doesn\u0027t exist.\n\nAnd the pep8 check should also be done in the local dev enviornment first.","accounts_in_message":[],"_revision_number":2},{"id":"13a999239bc20c5a6571135b1e330073aa349d26","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 05:25:15.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"46ec663a921f32b99acc79359228b19a4dc16014","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-18 05:41:52.000000000","message":"Patch Set 3: Code-Review-1\n\nIn troveclient \u0027resize-instance\u0027 and \u0027resize-volume\u0027 are two commands, however they are calling methods from the same Instance manager, so it\u0027s better to build osc commands like what zhanggang mentioned: \u0027database instance resize flavor\u0027 and \u0027database instance resize volume\u0027, or to make the subcommand shorter, we could go with \u0027database instance resize\u0027 and make \u0027--flavor\u0027 and \u0027--volume\u0027 as two exclusive arguments.","accounts_in_message":[],"_revision_number":3},{"id":"e13a1cc217395e00f6228d43874bff916b3c134f","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 05:59:06.000000000","message":"Patch Set 3:\n\n\u003e In troveclient \u0027resize-instance\u0027 and \u0027resize-volume\u0027 are two\n \u003e commands, however they are calling methods from the same Instance\n \u003e manager, so it\u0027s better to build osc commands like what zhanggang\n \u003e mentioned: \u0027database instance resize flavor\u0027 and \u0027database instance\n \u003e resize volume\u0027, or to make the subcommand shorter, we could go with\n \u003e \u0027database instance resize\u0027 and make \u0027--flavor\u0027 and \u0027--volume\u0027 as\n \u003e two exclusive arguments.\n\nthanks for great reviewing. Yes, i notice that. I prefer what zhanggang metioned, and separate resize-flavor and resize-volume to two command.","accounts_in_message":[],"_revision_number":3},{"id":"0986a9f855b67f9a152d6be4fa157a426367d764","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 06:04:03.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"65cd8dc19e5ca47f0095cb3dd9ee2688e5d4d771","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 08:30:28.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/534224/4/check/build-openstack-sphinx-docs/1fa080c/html/ : SUCCESS in 7m 13s\n- openstack-tox-pep8 http://logs.openstack.org/24/534224/4/check/openstack-tox-pep8/bdd76b8/ : FAILURE in 3m 52s\n- openstack-tox-py27 http://logs.openstack.org/24/534224/4/check/openstack-tox-py27/1e93d84/ : SUCCESS in 5m 22s\n- openstack-tox-py35 http://logs.openstack.org/24/534224/4/check/openstack-tox-py35/22c51c5/ : SUCCESS in 5m 22s\n- build-openstack-releasenotes http://logs.openstack.org/24/534224/4/check/build-openstack-releasenotes/e45ff90/html/ : SUCCESS in 4m 19s\n- openstackclient-check-plugins http://logs.openstack.org/24/534224/4/check/openstackclient-check-plugins/e049397/ : SUCCESS in 9m 07s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/24/534224/4/check/trove-functional-mysql/c9e21ed/ : SUCCESS in 1h 55m 43s\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/24/534224/4/check/tempest-neutron-src-python-troveclient/6c52eec/ : SUCCESS in 1h 19m 42s","accounts_in_message":[],"_revision_number":4},{"id":"7c5f9c3f429ed368ca100a31b0230e0a8c1f71a9","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-18 08:57:21.000000000","message":"Patch Set 4: Code-Review-1\n\n(2 comments)\n\nOthers look good to me.","accounts_in_message":[],"_revision_number":4},{"id":"97059b1c1e84816aa84f62e31f2f88d481e5291a","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-01-18 09:18:57.000000000","message":"Patch Set 4: Code-Review-1\n\nrun `tox` before you commit.  For example, just test PEP8 use `tox -epep8`","accounts_in_message":[],"_revision_number":4},{"id":"1fe9bf76c1e648c56cb16c666685e996f0a8fd4b","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 09:20:49.000000000","message":"Patch Set 4:\n\n\u003e run `tox` before you commit.  For example, just test PEP8 use `tox\n \u003e -epep8`\n\ni have run pycodestyle instead of pep8 before push, maybe i need run pep8 again.","accounts_in_message":[],"_revision_number":4},{"id":"5eb1ccd25ad43da3982d61f653550e74b5d93224","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-18 09:36:11.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"37d4f0ac03da38398d4922f0804a2e3d6aeca6a7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 11:34:23.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/534224/5/check/build-openstack-sphinx-docs/954b9ac/html/ : SUCCESS in 5m 29s\n- openstack-tox-pep8 http://logs.openstack.org/24/534224/5/check/openstack-tox-pep8/7d4e6b9/ : SUCCESS in 4m 05s\n- openstack-tox-py27 http://logs.openstack.org/24/534224/5/check/openstack-tox-py27/69cf272/ : SUCCESS in 4m 28s\n- openstack-tox-py35 http://logs.openstack.org/24/534224/5/check/openstack-tox-py35/dbf09bf/ : SUCCESS in 4m 08s\n- build-openstack-releasenotes http://logs.openstack.org/24/534224/5/check/build-openstack-releasenotes/f9db09a/html/ : SUCCESS in 4m 00s\n- openstackclient-check-plugins http://logs.openstack.org/24/534224/5/check/openstackclient-check-plugins/587e7c1/ : SUCCESS in 5m 35s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/24/534224/5/check/trove-functional-mysql/21fd0e3/ : SUCCESS in 1h 49m 33s\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/24/534224/5/check/tempest-neutron-src-python-troveclient/87b627c/ : SUCCESS in 1h 50m 27s","accounts_in_message":[],"_revision_number":5},{"id":"5b2ec976022480589021563e08926800e62aede7","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-18 11:49:26.000000000","message":"Patch Set 5: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":5},{"id":"1fec5556b7bb7db20840a04323ba7afc4c419ca8","author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"date":"2018-01-18 17:34:59.000000000","message":"Patch Set 5: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"e6e7ccbc26659b105f476355e7c82eb1b8ac8cfd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 17:35:12.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"21bf862f598aad20725a48246830a7c3027c9c48","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 21:42:14.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/24/534224/5/gate/build-openstack-sphinx-docs/fb1da26/html/ : SUCCESS in 5m 15s\n- openstack-tox-pep8 http://logs.openstack.org/24/534224/5/gate/openstack-tox-pep8/0bc44e3/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/24/534224/5/gate/openstack-tox-py27/013512f/ : SUCCESS in 3m 38s\n- openstack-tox-py35 http://logs.openstack.org/24/534224/5/gate/openstack-tox-py35/380f2cd/ : SUCCESS in 3m 50s\n- build-openstack-releasenotes http://logs.openstack.org/24/534224/5/gate/build-openstack-releasenotes/6a70dc3/html/ : SUCCESS in 3m 27s\n- trove-functional-mysql http://logs.openstack.org/24/534224/5/gate/trove-functional-mysql/3dea005/ : SUCCESS in 1h 58m 21s\n- tempest-neutron-src-python-troveclient http://logs.openstack.org/24/534224/5/gate/tempest-neutron-src-python-troveclient/d0d1a9e/ : SUCCESS in 1h 32m 43s","accounts_in_message":[],"_revision_number":5},{"id":"553edf60aad87edbb548a19005d52050c51026f2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-18 21:42:14.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"3747c17e188f5cadf14786adff361fafa106e6fd","revisions":{"bdad096cbf687dcdd9af8603c27423cb0b8bf634":{"kind":"REWORK","_number":1,"created":"2018-01-16 10:20:46.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/24/534224/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/24/534224/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/1"}}},"commit":{"parents":[{"commit":"21c9085c712f34c7cdc80fc0f5f80518a07e64b6","subject":"Add root-disable to OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/21c9085c712f34c7cdc80fc0f5f80518a07e64b6"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"subject":"Add resize-instance to OSC","message":"Add resize-instance to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the resize-instance command\n\nThe trove command resize-instance is now:\n    openstack database resize instance\n\nChange-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/bdad096cbf687dcdd9af8603c27423cb0b8bf634"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/bdad096cbf687dcdd9af8603c27423cb0b8bf634"}]},"branch":"refs/heads/master"},"35212d5aa10e278be0b66eab8a7984898bdb606a":{"kind":"REWORK","_number":2,"created":"2018-01-18 02:42:16.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/24/534224/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/24/534224/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/2"}}},"commit":{"parents":[{"commit":"21c9085c712f34c7cdc80fc0f5f80518a07e64b6","subject":"Add root-disable to OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/21c9085c712f34c7cdc80fc0f5f80518a07e64b6"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-18 02:41:17.000000000","tz":-480},"subject":"Add resize-instance to OSC","message":"Add resize-instance to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the resize-instance command\n\nThe trove command resize-instance is now:\n    openstack database resize instance\n\nChange-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/35212d5aa10e278be0b66eab8a7984898bdb606a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/35212d5aa10e278be0b66eab8a7984898bdb606a"}]},"branch":"refs/heads/master"},"2ef193d3c77c1570dab363172a267e94a4f80adf":{"kind":"REWORK","_number":3,"created":"2018-01-18 05:25:15.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/24/534224/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/24/534224/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/3"}}},"commit":{"parents":[{"commit":"21c9085c712f34c7cdc80fc0f5f80518a07e64b6","subject":"Add root-disable to OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/21c9085c712f34c7cdc80fc0f5f80518a07e64b6"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-18 05:18:22.000000000","tz":-480},"subject":"Add resize-instance to OSC","message":"Add resize-instance to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the resize-instance command\n\nThe trove command resize-instance is now:\n    openstack database resize flavor\n\nChange-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2ef193d3c77c1570dab363172a267e94a4f80adf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2ef193d3c77c1570dab363172a267e94a4f80adf"}]},"branch":"refs/heads/master"},"0a216f38dd5b5492603a6380ec60638d80c21e4a":{"kind":"REWORK","_number":4,"created":"2018-01-18 06:04:03.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/24/534224/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/24/534224/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/4"}}},"commit":{"parents":[{"commit":"21c9085c712f34c7cdc80fc0f5f80518a07e64b6","subject":"Add root-disable to OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/21c9085c712f34c7cdc80fc0f5f80518a07e64b6"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-18 06:03:23.000000000","tz":-480},"subject":"Add resize-instance to OSC","message":"Add resize-instance to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the resize-instance command\n\nThe trove command resize-instance is now:\n    openstack database instance resize flavor\n\nChange-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0a216f38dd5b5492603a6380ec60638d80c21e4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0a216f38dd5b5492603a6380ec60638d80c21e4a"}]},"branch":"refs/heads/master"},"3747c17e188f5cadf14786adff361fafa106e6fd":{"kind":"REWORK","_number":5,"created":"2018-01-18 09:36:11.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/24/534224/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/24/534224/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/24/534224/5"}}},"commit":{"parents":[{"commit":"21c9085c712f34c7cdc80fc0f5f80518a07e64b6","subject":"Add root-disable to OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/21c9085c712f34c7cdc80fc0f5f80518a07e64b6"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-16 10:14:21.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-18 09:35:29.000000000","tz":-480},"subject":"Add resize-instance to OSC","message":"Add resize-instance to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the resize-instance command\n\nThe trove command resize-instance is now:\n    openstack database instance resize flavor\n\nChange-Id: I58f8a6ebf8f715c5cc67ce67a36f87d720056ffe\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3747c17e188f5cadf14786adff361fafa106e6fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3747c17e188f5cadf14786adff361fafa106e6fd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}