)]}'
{"troveclient/osc/v1/database_instances.py":[{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"bf0f882da0f7e6c79ba54d8c1171c2ffffbc9fca","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        )"},{"line_number":493,"context_line":"        parser.add_argument("},{"line_number":494,"context_line":"            \u0027--name\u0027,"},{"line_number":495,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":496,"context_line":"            type\u003dstr,"},{"line_number":497,"context_line":"            help\u003d_(\u0027ID or name of the instance.\u0027),"},{"line_number":498,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e71737a3","line":495,"range":{"start_line":495,"start_character":28,"end_line":495,"end_character":29},"updated":"2018-01-20 10:00:21.000000000","message":"Be cautious, we may add default value of here.\ndefault\u003dNone,But it\u0027s ok.","commit_id":"5da6ce61a29ad8b9532efa0c626b3927cf8bb563"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"4a56d5b4752f3400f9480154fef786fc14e50a27","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        )"},{"line_number":493,"context_line":"        parser.add_argument("},{"line_number":494,"context_line":"            \u0027--name\u0027,"},{"line_number":495,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":496,"context_line":"            type\u003dstr,"},{"line_number":497,"context_line":"            help\u003d_(\u0027ID or name of the instance.\u0027),"},{"line_number":498,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e73417fe","line":495,"range":{"start_line":495,"start_character":28,"end_line":495,"end_character":29},"in_reply_to":"7f96bb07_6751e762","updated":"2018-01-20 11:07:07.000000000","message":"\u0027default\u003dNone\u0027 added, thanks.","commit_id":"5da6ce61a29ad8b9532efa0c626b3927cf8bb563"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"fdc7c5bd71974094a6c86bdd9183e9e115932e92","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        )"},{"line_number":493,"context_line":"        parser.add_argument("},{"line_number":494,"context_line":"            \u0027--name\u0027,"},{"line_number":495,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":496,"context_line":"            type\u003dstr,"},{"line_number":497,"context_line":"            help\u003d_(\u0027ID or name of the instance.\u0027),"},{"line_number":498,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_6751e762","line":495,"range":{"start_line":495,"start_character":28,"end_line":495,"end_character":29},"in_reply_to":"7f96bb07_e71737a3","updated":"2018-01-20 10:15:05.000000000","message":"Basically when doing cli interfaces migration we should follow the same style of the original troveclient, so for arguments they should always identical to the original ones.\n\nThe arguments\u0027 default value defaults to None if not set, so we don\u0027t need to add \u0027default\u003dNone\u0027, but there\u0027re many \u0027default\u003dNone\u0027 in troveclient, maybe it\u0027s time to do some cleaning up.","commit_id":"5da6ce61a29ad8b9532efa0c626b3927cf8bb563"},{"author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"change_message_id":"bf0f882da0f7e6c79ba54d8c1171c2ffffbc9fca","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        )"},{"line_number":506,"context_line":"        parser.add_argument("},{"line_number":507,"context_line":"            \u0027--detach_replica_source\u0027,"},{"line_number":508,"context_line":"            \u0027--detach-replica-source\u0027,"},{"line_number":509,"context_line":"            dest\u003d\u0027detach_replica_source\u0027,"},{"line_number":510,"context_line":"            action\u003d\"store_true\","},{"line_number":511,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_878193c6","line":508,"range":{"start_line":508,"start_character":11,"end_line":508,"end_character":38},"updated":"2018-01-20 10:00:21.000000000","message":"Shall we remove it now?","commit_id":"5da6ce61a29ad8b9532efa0c626b3927cf8bb563"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"fdc7c5bd71974094a6c86bdd9183e9e115932e92","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        )"},{"line_number":506,"context_line":"        parser.add_argument("},{"line_number":507,"context_line":"            \u0027--detach_replica_source\u0027,"},{"line_number":508,"context_line":"            \u0027--detach-replica-source\u0027,"},{"line_number":509,"context_line":"            dest\u003d\u0027detach_replica_source\u0027,"},{"line_number":510,"context_line":"            action\u003d\"store_true\","},{"line_number":511,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_27e0bf96","line":508,"range":{"start_line":508,"start_character":11,"end_line":508,"end_character":38},"in_reply_to":"7f96bb07_878193c6","updated":"2018-01-20 10:15:05.000000000","message":"This sounds like a good idea, I don\u0027t know whether this is introduce in 2014, and anounced deprecated in 2016. If we decide to remove it, it may be better to add another patch for both osc and troveclient.","commit_id":"5da6ce61a29ad8b9532efa0c626b3927cf8bb563"}]}