)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"411d6948ea192260fde0e0d298656174faa06f65","unresolved":false,"context_lines":[{"line_number":10,"context_line":"project for the log-enable command"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The trove command log-enable is now:"},{"line_number":13,"context_line":"    openstack database log enable"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ia5bb395264946f79673970336e4c1f23857bb77d"},{"line_number":16,"context_line":"Partially-Implements: blueprint trove-support-in-python-openstackclient"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f96bb07_c23f8685","line":13,"updated":"2018-01-21 03:06:14.000000000","message":"As the command line sugguests, it may be better to create a new file troveclient/osc/v1/database_logs.py, however reusing the database_instances.py is ok, because the underlying methods are all in troveclient/v1/instances.py.","commit_id":"34dbc53ec273d612823b92c3502830422c9123d0"}],"setup.cfg":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"411d6948ea192260fde0e0d298656174faa06f65","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    database_limit_list \u003d troveclient.osc.v1.database_limits:ListDatabaseLimits"},{"line_number":69,"context_line":"    database_quota_show \u003d troveclient.osc.v1.database_quota:ShowDatabaseQuota"},{"line_number":70,"context_line":"    database_quota_update \u003d troveclient.osc.v1.database_quota:UpdateDatabaseQuota"},{"line_number":71,"context_line":"    database_log_enable \u003d troveclient.osc.v1.database_limits:EnableDatabaseInstanceLog"},{"line_number":72,"context_line":"    database_root_disable \u003d troveclient.osc.v1.database_root:DisableDatabaseRoot"},{"line_number":73,"context_line":"    database_root_enable \u003d troveclient.osc.v1.database_root:EnableDatabaseRoot"},{"line_number":74,"context_line":"    database_root_show \u003d troveclient.osc.v1.database_root:ShowDatabaseRoot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":2,"id":"7f96bb07_e244021e","line":71,"range":{"start_line":71,"start_character":45,"end_line":71,"end_character":60},"updated":"2018-01-21 03:06:14.000000000","message":"?: database_instances or (another new)database_logs ?","commit_id":"34dbc53ec273d612823b92c3502830422c9123d0"}],"troveclient/osc/v1/database_instances.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"411d6948ea192260fde0e0d298656174faa06f65","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        db_instances.upgrade(instance, parsed_args.datastore_version)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"class EnableDatabaseInstanceLog(command.Command):"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    _description \u003d _(\"Instructs Trove guest to start collecting log details.\")"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_6250f2d5","line":450,"updated":"2018-01-21 03:06:14.000000000","message":"See my other comments, as there are several commands about logs, so it may be better to add an new separate file for them, of course, adding them to database_instances should also fine.","commit_id":"34dbc53ec273d612823b92c3502830422c9123d0"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"411d6948ea192260fde0e0d298656174faa06f65","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        db_instances \u003d self.app.client_manager.database.instances"},{"line_number":472,"context_line":"        instance \u003d osc_utils.find_resource(db_instances,"},{"line_number":473,"context_line":"                                           parsed_args.instance)"},{"line_number":474,"context_line":"        db_instances.log_enable(instance, parsed_args.log_name)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"class ResizeDatabaseInstanceVolume(command.Command):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_22098adc","line":474,"updated":"2018-01-21 03:06:14.000000000","message":"As I stated in another patch related to this osc migration topic, we should almost do identical things as the original troveclient does.\n\nHere for log_enable, troveclient will first enable the log of the instance, and if succeeds, it will print the information of this log, otherwise it will raise execeptions according to how the log_enable request has been failed.\n\nThis patch does not act like the origin troveclient enable_log.","commit_id":"34dbc53ec273d612823b92c3502830422c9123d0"}]}
