)]}'
{"id":"openstack%2Fpython-troveclient~536855","triplet_id":"openstack%2Fpython-troveclient~master~Ia6a850f41e94f47abea9803aa06ee48f27e2174c","project":"openstack/python-troveclient","branch":"master","topic":"bp/trove-support-in-python-openstackclient","hashtags":[],"change_id":"Ia6a850f41e94f47abea9803aa06ee48f27e2174c","subject":"Add volume-type-list to OSC","status":"ABANDONED","created":"2018-01-23 15:03:02.000000000","updated":"2018-02-11 07:53:17.000000000","total_comment_count":15,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ff9a92cd1036e9ba056cf2c7b2f0260e2e984ce6","_number":536855,"virtual_id_number":536855,"owner":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"date":"2018-01-24 06:15:17.000000000","_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":1,"date":"2018-01-24 08:53:20.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"all":[{"value":-1,"date":"2018-01-24 12:11:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-01-24 08:53:20.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-01-24 12:11:38.000000000","updated_by":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"reviewer":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"state":"REVIEWER"}],"messages":[{"id":"826ef39544628dedf250f1ee8c16695e4049f0ca","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-23 15:03:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"91c61a56403c448fd378e83f0fe67783ef28e742","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-23 17:59:47.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/55/536855/1/check/build-openstack-sphinx-docs/20e3313/html/ : SUCCESS in 6m 31s\n- openstack-tox-pep8 http://logs.openstack.org/55/536855/1/check/openstack-tox-pep8/836f458/ : SUCCESS in 5m 03s\n- openstack-tox-py27 http://logs.openstack.org/55/536855/1/check/openstack-tox-py27/08648ea/ : SUCCESS in 8m 37s\n- openstack-tox-py35 http://logs.openstack.org/55/536855/1/check/openstack-tox-py35/60d1dbd/ : SUCCESS in 4m 21s\n- build-openstack-releasenotes http://logs.openstack.org/55/536855/1/check/build-openstack-releasenotes/62bac8e/html/ : SUCCESS in 5m 58s\n- openstackclient-check-plugins http://logs.openstack.org/55/536855/1/check/openstackclient-check-plugins/280870d/ : FAILURE in 10m 22s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/55/536855/1/check/trove-functional-mysql/a4cfa9e/ : SUCCESS in 1h 54m 54s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/55/536855/1/check/python-troveclient-tempest-neutron-src/d348715/ : SUCCESS in 1h 20m 46s","accounts_in_message":[],"_revision_number":1},{"id":"4c440688050ed67e868086d8381cefdcd8b3a55c","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-24 02:37:38.000000000","message":"Patch Set 1: Code-Review-1\n\n(6 comments)","accounts_in_message":[],"_revision_number":1},{"id":"3cccad361c40c1651ab8214b2cb2022cd6d1dc0c","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-24 06:14:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fd33f88dfffb2057d57e2f4a816ed95e7b2012e9","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-01-24 06:15:17.000000000","message":"Patch Set 2:\n\n(3 comments)\n\n\u003e (6 comments)\n\nupdate.","accounts_in_message":[],"_revision_number":2},{"id":"d1292fe504d4378ec6c862e99fe80e54b868beeb","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-01-24 08:53:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/55/536855/2/check/build-openstack-sphinx-docs/0d0d7ce/html/ : SUCCESS in 7m 18s\n- openstack-tox-pep8 http://logs.openstack.org/55/536855/2/check/openstack-tox-pep8/d5da5a4/ : SUCCESS in 5m 39s\n- openstack-tox-py27 http://logs.openstack.org/55/536855/2/check/openstack-tox-py27/9b6a562/ : SUCCESS in 6m 17s\n- openstack-tox-py35 http://logs.openstack.org/55/536855/2/check/openstack-tox-py35/809b6b5/ : SUCCESS in 6m 12s\n- build-openstack-releasenotes http://logs.openstack.org/55/536855/2/check/build-openstack-releasenotes/ca85c45/html/ : SUCCESS in 5m 19s\n- openstackclient-check-plugins http://logs.openstack.org/55/536855/2/check/openstackclient-check-plugins/975bed8/ : SUCCESS in 6m 39s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/55/536855/2/check/trove-functional-mysql/d7ffb4e/ : SUCCESS in 1h 43m 30s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/55/536855/2/check/python-troveclient-tempest-neutron-src/53d5e63/ : SUCCESS in 1h 54m 52s","accounts_in_message":[],"_revision_number":2},{"id":"5ba6a01f7eea4b28f38645bb405ab7ea4760af27","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-01-24 12:11:38.000000000","message":"Patch Set 2: Code-Review-1\n\n(6 comments)\n\nBesides all the inline comments, I found the trove volume type api is duplicated to the cinder api, so it should be deprecated.\n\nHowever when there are volume types associated to a datastore version, only these associated volume types could be used to create trove instances. So in fact only the \u0027list_datastore_version_associated_volume_types\u0027 in troveclient.v1.volume_types:VolumeTypes is needed, but this interface also exposed by trove-manage, as it\u0027s acutally an administration operation.\n\nTo conclude, I this it\u0027s not neccessary to implement volume-types related commands in the osc plugin.","accounts_in_message":[],"_revision_number":2},{"id":"843e0009ac0bdc114f5df3a3b74c93e9a63b4a91","author":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"date":"2018-02-11 07:53:17.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b04fae9e75910aaa094bcc8716f66d11f2b2a3f1","revisions":{"ef6cfb327bb0d6d70520e2d6d17beb8f7cf04af1":{"kind":"REWORK","_number":1,"created":"2018-01-23 15:03:02.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/55/536855/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/55/536855/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/1"}}},"commit":{"parents":[{"commit":"737cb6f736cd7079f0410a6d63b786232feb2207","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/737cb6f736cd7079f0410a6d63b786232feb2207"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-23 14:52:19.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-23 14:52:19.000000000","tz":-480},"subject":"Add volume-type-list to OSC","message":"Add volume-type-list to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the volume-type-list command\n\nThe trove command volume-type-list is now:\n    openstack database volume type list\n\nChange-Id: Ia6a850f41e94f47abea9803aa06ee48f27e2174c\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ef6cfb327bb0d6d70520e2d6d17beb8f7cf04af1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ef6cfb327bb0d6d70520e2d6d17beb8f7cf04af1"}]},"branch":"refs/heads/master"},"b04fae9e75910aaa094bcc8716f66d11f2b2a3f1":{"kind":"REWORK","_number":2,"created":"2018-01-24 06:14:37.000000000","uploader":{"_account_id":27577,"name":"caishan","email":"caishan1993@foxmail.com","username":"caishan"},"ref":"refs/changes/55/536855/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/55/536855/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/55/536855/2"}}},"commit":{"parents":[{"commit":"0bc788e55c046efaa6c13761453e855ae571350e","subject":"Merge \"Fix log-enable high priority error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0bc788e55c046efaa6c13761453e855ae571350e"}]}],"author":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-23 14:52:19.000000000","tz":-480},"committer":{"name":"caishan","email":"caishan1993@foxmail.com","date":"2018-01-24 06:14:05.000000000","tz":-480},"subject":"Add volume-type-list to OSC","message":"Add volume-type-list to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the volume-type-list command\n\nThe trove command volume-type-list is now:\n    openstack database volume type list\n\nChange-Id: Ia6a850f41e94f47abea9803aa06ee48f27e2174c\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b04fae9e75910aaa094bcc8716f66d11f2b2a3f1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b04fae9e75910aaa094bcc8716f66d11f2b2a3f1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}