)]}'
{"id":"openstack%2Fpython-troveclient~543922","triplet_id":"openstack%2Fpython-troveclient~master~I903a3b9565e4044c33401a6abcc47d50a5a2567f","project":"openstack/python-troveclient","branch":"master","topic":"fix-invalid-mock-in-osc-cluster-create-test","hashtags":[],"change_id":"I903a3b9565e4044c33401a6abcc47d50a5a2567f","subject":"Fix invalid mock in OSC cluster creating unittest","status":"MERGED","created":"2018-02-13 12:46:13.000000000","updated":"2018-03-01 13:18:50.000000000","submitted":"2018-03-01 13:18:50.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"543922-1519910330957-d05392ea","meta_rev_id":"3ec828b8803672b29b7df0fb767eb62504dcb830","_number":543922,"virtual_id_number":543922,"owner":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":2,"date":"2018-03-01 13:18:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":2,"date":"2018-02-28 09:15:23.000000000","_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":2,"date":"2018-03-01 11:40:13.000000000","_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"all":[{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":1,"date":"2018-03-01 11:40:13.000000000","_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"date":"2018-02-24 09:02:44.000000000","_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"reviewer":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"reviewer":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"reviewer":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"reviewer":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"state":"REVIEWER"},{"updated":"2018-02-24 09:02:44.000000000","updated_by":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"reviewer":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"state":"REVIEWER"},{"updated":"2018-02-28 09:15:23.000000000","updated_by":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"reviewer":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"state":"REVIEWER"},{"updated":"2018-03-01 11:40:13.000000000","updated_by":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"reviewer":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"state":"REVIEWER"},{"updated":"2018-03-01 13:18:50.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"a213a251480abc2215f980e87fec0d1ec10cd901","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-02-13 12:46:13.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4f1ab8bb297855f95607cd40c5e08418d8563af3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-13 14:34:10.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/22/543922/1/check/build-openstack-sphinx-docs/e0fcfac/html/ : SUCCESS in 5m 14s\n- openstack-tox-pep8 http://logs.openstack.org/22/543922/1/check/openstack-tox-pep8/f698ef7/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/22/543922/1/check/openstack-tox-py27/2fb777e/ : SUCCESS in 4m 06s\n- openstack-tox-py35 http://logs.openstack.org/22/543922/1/check/openstack-tox-py35/c66fc59/ : SUCCESS in 4m 09s\n- openstackclient-check-plugins http://logs.openstack.org/22/543922/1/check/openstackclient-check-plugins/1c5a0f3/ : SUCCESS in 5m 56s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/22/543922/1/check/trove-functional-mysql/b41117d/ : SUCCESS in 1h 46m 21s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/22/543922/1/check/python-troveclient-tempest-neutron-src/4f3356d/ : SUCCESS in 1h 18m 01s","accounts_in_message":[],"_revision_number":1},{"id":"5ced31df025dc9c8ac5edcc00a186fba6cbb095a","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-02-28 09:15:23.000000000","message":"Patch Set 1: Code-Review+2\n\nIt\u0027s my negligence. Thanks for correcting.","accounts_in_message":[],"_revision_number":1},{"id":"69ae60b56424b10f9b1893c4c738bb93fa1fe976","author":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"date":"2018-03-01 11:40:13.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2\n\nLGTM. So this patch also can remind us that there may be many mistakes in the unit tests. How to find and how to solve, may become one goal in Rocky?","accounts_in_message":[],"_revision_number":1},{"id":"0059c3ee6f7369ed755dc943319912a1e8297c1b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-01 11:40:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"66f08bbb5c8c76f78ac5171f62a532d432da8ed0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-01 13:18:50.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/22/543922/1/gate/build-openstack-sphinx-docs/1720195/html/ : SUCCESS in 5m 02s\n- openstack-tox-pep8 http://logs.openstack.org/22/543922/1/gate/openstack-tox-pep8/1cc454a/ : SUCCESS in 3m 50s\n- openstack-tox-py27 http://logs.openstack.org/22/543922/1/gate/openstack-tox-py27/4050e48/ : SUCCESS in 3m 55s\n- openstack-tox-py35 http://logs.openstack.org/22/543922/1/gate/openstack-tox-py35/fba2868/ : SUCCESS in 3m 53s\n- trove-functional-mysql http://logs.openstack.org/22/543922/1/gate/trove-functional-mysql/76aa7f8/ : SUCCESS in 1h 37m 11s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/22/543922/1/gate/python-troveclient-tempest-neutron-src/8a1df03/ : SUCCESS in 1h 12m 14s","accounts_in_message":[],"_revision_number":1},{"id":"d90cabd748d8c4c6d0c42348d88f390c5026c136","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-03-01 13:18:50.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"728d9378dc448885edf4437b77b146d32565a6e2","revisions":{"728d9378dc448885edf4437b77b146d32565a6e2":{"kind":"REWORK","_number":1,"created":"2018-02-13 12:46:13.000000000","uploader":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"ref":"refs/changes/22/543922/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/22/543922/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/22/543922/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/22/543922/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/22/543922/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/22/543922/1"}}},"commit":{"parents":[{"commit":"0b28b04ebbfaed981f4e00e69e4c7a8e0ed75395","subject":"Handle error response for webob\u003e\u003d1.6.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0b28b04ebbfaed981f4e00e69e4c7a8e0ed75395"}]}],"author":{"name":"Zhao Chao","email":"zhaochao1984@gmail.com","date":"2018-02-13 12:22:42.000000000","tz":480},"committer":{"name":"Zhao Chao","email":"zhaochao1984@gmail.com","date":"2018-02-13 12:44:09.000000000","tz":480},"subject":"Fix invalid mock in OSC cluster creating unittest","message":"Fix invalid mock in OSC cluster creating unittest\n\nAs \u0027_parse_instance_options\u0027 is imported into database_clusters, mocking\ndestination should be the database_clusters module, not the original\ntroveclient.v1.shell.\n\nThe reason this test passed before this patch is, the return value of\n\u0027_parse_instance_options\u0027 is not checked, i.e. the mock object is also\nuseless. This patch also checks how troveclient.v1.clusters.create is\ncalled to ensure \u0027_parse_instance_options\u0027 is correctly mocked.\n\nChange-Id: I903a3b9565e4044c33401a6abcc47d50a5a2567f\nSigned-off-by: Zhao Chao \u003czhaochao1984@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/728d9378dc448885edf4437b77b146d32565a6e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/728d9378dc448885edf4437b77b146d32565a6e2"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}