)]}'
{"id":"openstack%2Fpython-troveclient~546547","triplet_id":"openstack%2Fpython-troveclient~master~I8dd5396ab604013639a0b626ce3ecd3e3fad12e8","project":"openstack/python-troveclient","branch":"master","hashtags":[],"change_id":"I8dd5396ab604013639a0b626ce3ecd3e3fad12e8","subject":"Clean imports in code","status":"MERGED","created":"2018-02-21 09:35:28.000000000","updated":"2018-02-21 16:50:06.000000000","submitted":"2018-02-21 16:50:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"546547-1519231806197-3b0d49df","meta_rev_id":"19b06f459caeabe00d3081f71e8b39eb29f18029","_number":546547,"virtual_id_number":546547,"owner":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":2,"date":"2018-02-21 16:50:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"all":[{"value":2,"date":"2018-02-21 14:51:00.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"all":[{"value":1,"date":"2018-02-21 14:51:00.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-21 14:51:00.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2018-02-21 16:50:05.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"68f409d4962402a7ba15d370578e8eded763a35c","author":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"date":"2018-02-21 09:35:28.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"025bbee9ca5118240de3c3516a7043c0ce94a844","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 11:23:33.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/47/546547/1/check/build-openstack-sphinx-docs/0054421/html/ : SUCCESS in 5m 28s\n- openstack-tox-pep8 http://logs.openstack.org/47/546547/1/check/openstack-tox-pep8/537323b/ : SUCCESS in 3m 41s\n- openstack-tox-py27 http://logs.openstack.org/47/546547/1/check/openstack-tox-py27/896e740/ : SUCCESS in 4m 39s\n- openstack-tox-py35 http://logs.openstack.org/47/546547/1/check/openstack-tox-py35/af7dc3a/ : SUCCESS in 3m 57s\n- openstackclient-check-plugins http://logs.openstack.org/47/546547/1/check/openstackclient-check-plugins/62932fb/ : SUCCESS in 7m 29s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/47/546547/1/check/trove-functional-mysql/8590c27/ : SUCCESS in 1h 46m 36s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/47/546547/1/check/python-troveclient-tempest-neutron-src/c1be464/ : SUCCESS in 1h 26m 29s","accounts_in_message":[],"_revision_number":1},{"id":"e8d35d1499d6f0aa92b00534abbd609893eb9f6e","author":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"date":"2018-02-21 14:51:00.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2318ac815a4c02afa254d861fa026c39de835679","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 14:51:11.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"58183e6fa8a34d41590e2ecb53eaf112790dbe02","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 16:50:05.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/47/546547/1/gate/build-openstack-sphinx-docs/cbf3dfe/html/ : SUCCESS in 5m 14s\n- openstack-tox-pep8 http://logs.openstack.org/47/546547/1/gate/openstack-tox-pep8/9041ecc/ : SUCCESS in 7m 11s\n- openstack-tox-py27 http://logs.openstack.org/47/546547/1/gate/openstack-tox-py27/1b94116/ : SUCCESS in 3m 58s\n- openstack-tox-py35 http://logs.openstack.org/47/546547/1/gate/openstack-tox-py35/87930e5/ : SUCCESS in 3m 39s\n- trove-functional-mysql http://logs.openstack.org/47/546547/1/gate/trove-functional-mysql/25d913b/ : SUCCESS in 1h 39m 41s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/47/546547/1/gate/python-troveclient-tempest-neutron-src/d2b1971/ : SUCCESS in 1h 33m 12s","accounts_in_message":[],"_revision_number":1},{"id":"19b06f459caeabe00d3081f71e8b39eb29f18029","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-21 16:50:06.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"5757f3a1f6aaffd2ad2dfb2748b1bc4755fc15c9","revisions":{"5757f3a1f6aaffd2ad2dfb2748b1bc4755fc15c9":{"kind":"REWORK","_number":1,"created":"2018-02-21 09:35:28.000000000","uploader":{"_account_id":19853,"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","username":"phuongnh"},"ref":"refs/changes/47/546547/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/47/546547/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/546547/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/546547/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/546547/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/47/546547/1"}}},"commit":{"parents":[{"commit":"0b28b04ebbfaed981f4e00e69e4c7a8e0ed75395","subject":"Handle error response for webob\u003e\u003d1.6.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0b28b04ebbfaed981f4e00e69e4c7a8e0ed75395"}]}],"author":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-21 09:32:34.000000000","tz":420},"committer":{"name":"Nguyen Hung Phuong","email":"phuongnh@vn.fujitsu.com","date":"2018-02-21 09:33:43.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nIn some part in the code we import objects. In the Openstack style guidelines\nthey recommend to import only modules. [1]: \"Do not import objects, only modules\".\n\n[1] https://docs.openstack.org/hacking/0.10.3/\n\nChange-Id: I8dd5396ab604013639a0b626ce3ecd3e3fad12e8\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5757f3a1f6aaffd2ad2dfb2748b1bc4755fc15c9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5757f3a1f6aaffd2ad2dfb2748b1bc4755fc15c9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
