)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e914904c5e21b42aee9aaeff3e9ff14e26194730","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Denis Makogon \u003cdmakogon@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-04 13:12:04 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reduce amount of PEP8/flake8 rules"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"     - code should be pythonicaly clean,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9ss0%3D","line":7,"updated":"2013-12-07 01:45:52.000000000","message":"Nitpick, but since the number of PEP8 rules are countable, you want to use number instead of amount. So it would be:\n \"Reduce number of PEP8/flake8 rules\", or better yet\n \"Ignore fewer PEP8/flake8 rules\"","commit_id":"8ff7923275ed27deaffbe59a0b91a7fa00424504"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"e914904c5e21b42aee9aaeff3e9ff14e26194730","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Reasons:"},{"line_number":10,"context_line":"     - code should be pythonicaly clean,"},{"line_number":11,"context_line":"       that is why amount of ignored rules should reduced"},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"     - E125, F811, H102, H103, F201, H23, H302"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9sss%3D","line":11,"updated":"2013-12-07 01:45:52.000000000","message":"Nitpick, use number instead of of amount.","commit_id":"8ff7923275ed27deaffbe59a0b91a7fa00424504"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"7a06d78533836a7bd4c8221f0dc6f0886a99b50c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"       that is why amount of ignored rules should reduced"},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"     - E125, F811, H102, H103, F201, H23, H302"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf4025162244d3c2f1278b49a76ec1527a729042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9nbY%3D","line":14,"updated":"2013-12-09 17:06:49.000000000","message":"The list of changes is less than actual changes\nI see few more pep8 rules improved.\n\nPlease rectify Denis.","commit_id":"8ff7923275ed27deaffbe59a0b91a7fa00424504"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"46235f84550d0a93bf7406ec152ba251494380e7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"       that is why amount of ignored rules should reduced"},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"     - E125, F811, H102, H103, F201, H23, H302"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf4025162244d3c2f1278b49a76ec1527a729042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9nFY%3D","line":14,"in_reply_to":"AAAATn%2F9nG8%3D","updated":"2013-12-09 17:24:23.000000000","message":"If I match those changes in tox.ini\n\nthere is a difference.\n\nfew left in your commit message are F841,H301,H702,H703","commit_id":"8ff7923275ed27deaffbe59a0b91a7fa00424504"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"e60f7a04bdbb8d57f384ecdc311baf597410a420","unresolved":false,"context_lines":[{"line_number":11,"context_line":"       that is why amount of ignored rules should reduced"},{"line_number":12,"context_line":"Changes:"},{"line_number":13,"context_line":"     - E125, F811, H102, H103, F201, H23, H302"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ibf4025162244d3c2f1278b49a76ec1527a729042"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F9nG8%3D","line":14,"in_reply_to":"AAAATn%2F9nbY%3D","updated":"2013-12-09 17:17:37.000000000","message":"Which ?","commit_id":"8ff7923275ed27deaffbe59a0b91a7fa00424504"}],"docs/source/conf.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack Foundation"},{"line_number":4,"context_line":"# Copyright 2013 Rackspace Hosting"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYW8%3D","line":1,"updated":"2013-11-26 17:37:53.000000000","message":"There was a discussion about nixing vim modelines from source, but I don\u0027t remember which way that discussion went.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"tox.ini":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[flake8]"},{"line_number":35,"context_line":"ignore \u003d F401,F403,F821,H202,H306,H401,H402,H403,H404"},{"line_number":36,"context_line":"show-source \u003d True"},{"line_number":37,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,.idea"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BYXc%3D","line":37,"updated":"2013-11-26 17:37:53.000000000","message":"Hiding your ideas, eh","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"d9c0767d78e03c09daa49d1e1ba0f9becebf7463","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[flake8]"},{"line_number":35,"context_line":"ignore \u003d F401,F403,F821,H202,H306,H401,H402,H403,H404"},{"line_number":36,"context_line":"show-source \u003d True"},{"line_number":37,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,.idea"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BFhM%3D","line":37,"in_reply_to":"AAAATn%2F%2BYJs%3D","updated":"2013-12-02 18:19:16.000000000","message":"do not add this. You should create your own global config for flake8 and remove the .idea, then is gone for all your projects :)\n\nhttp://flake8.readthedocs.org/en/latest/config.html","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8c094efec31518d47ec6e7690e02d1d314daaf6a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"[flake8]"},{"line_number":35,"context_line":"ignore \u003d F401,F403,F821,H202,H306,H401,H402,H403,H404"},{"line_number":36,"context_line":"show-source \u003d True"},{"line_number":37,"context_line":"exclude\u003d.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,.idea"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAATn%2F%2BYJs%3D","line":37,"in_reply_to":"AAAATn%2F%2BYXc%3D","updated":"2013-11-26 18:27:29.000000000","message":"yup ;)","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/client.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"d9c0767d78e03c09daa49d1e1ba0f9becebf7463","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    import urllib.parse as urlparse"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"try:"},{"line_number":35,"context_line":"    import eventlet as sleepy"},{"line_number":36,"context_line":"except ImportError:"},{"line_number":37,"context_line":"    import time as sleepy"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BFg0%3D","line":35,"updated":"2013-12-02 18:19:16.000000000","message":"plz change sleepy to sleep_lib","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/compat/cli.py":[{"author":{"_account_id":6268,"name":"Robert Myers","email":"myer0052@gmail.com","username":"rmyers"},"change_message_id":"41c1479892e4f3691234ad6679fcd7c384b1af2b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def delete(self):"},{"line_number":65,"context_line":"        \"\"\"Delete the specified instance\"\"\""},{"line_number":66,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":67,"context_line":"        print (self.dbaas.instances.delete(self.id))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get(self):"},{"line_number":70,"context_line":"        \"\"\"Get details for the specified instance\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYkw%3D","line":67,"updated":"2013-11-26 17:01:53.000000000","message":"isn\u0027t these suppose to be print(blah) with no space? Calling the print as a function.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b0080158e9f2cac83f86896283470126fb2cc189","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def delete(self):"},{"line_number":65,"context_line":"        \"\"\"Delete the specified instance\"\"\""},{"line_number":66,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":67,"context_line":"        print (self.dbaas.instances.delete(self.id))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get(self):"},{"line_number":70,"context_line":"        \"\"\"Get details for the specified instance\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BX7c%3D","line":67,"in_reply_to":"AAAATn%2F%2BYhc%3D","updated":"2013-12-02 19:14:00.000000000","message":"Denis: What Robert is saying is that:\n\nprint(self.dbaas.instances.delete(self.id))  is preferred (stylistically) to \n\nprint (self.dbaas.instances.delete(self.id))\n\n(notice that there shouldn\u0027t be a space between a function name and its arguments.)\n\nCan you please change this when you get a chance? Thanks!","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"d9c0767d78e03c09daa49d1e1ba0f9becebf7463","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def delete(self):"},{"line_number":65,"context_line":"        \"\"\"Delete the specified instance\"\"\""},{"line_number":66,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":67,"context_line":"        print (self.dbaas.instances.delete(self.id))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get(self):"},{"line_number":70,"context_line":"        \"\"\"Get details for the specified instance\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BFfc%3D","line":67,"in_reply_to":"AAAATn%2F%2BYhc%3D","updated":"2013-12-02 18:19:16.000000000","message":"I would prefer we just dont check the compat/ library code. i dont want to update this code at all. We should discuss this at the meeting. im -2\u0027ing until then.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5a7e74c4f490307e1dbd1e71b56c63c7d783a8b5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def delete(self):"},{"line_number":65,"context_line":"        \"\"\"Delete the specified instance\"\"\""},{"line_number":66,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":67,"context_line":"        print (self.dbaas.instances.delete(self.id))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def get(self):"},{"line_number":70,"context_line":"        \"\"\"Get details for the specified instance\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYhc%3D","line":67,"in_reply_to":"AAAATn%2F%2BYkw%3D","updated":"2013-11-26 18:26:21.000000000","message":"Gate was failing here, Py3 incompability. Please take a look at Jenkins output for Patchset #1","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/compat/client.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                 service_type\u003d\u0027database\u0027, service_name\u003dNone,"},{"line_number":297,"context_line":"                 service_url\u003dNone, insecure\u003dFalse, auth_strategy\u003d\u0027keystone\u0027,"},{"line_number":298,"context_line":"                 region_name\u003dNone, client_cls\u003dTroveHTTPClient):"},{"line_number":299,"context_line":"        from troveclient.compat import versions"},{"line_number":300,"context_line":"        from troveclient.v1 import databases"},{"line_number":301,"context_line":"        from troveclient.v1 import flavors"},{"line_number":302,"context_line":"        from troveclient.v1 import instances"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYZQ%3D","line":299,"updated":"2013-11-26 17:37:53.000000000","message":"Wouldn\u0027t hurt us to sort these.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b0080158e9f2cac83f86896283470126fb2cc189","unresolved":false,"context_lines":[{"line_number":311,"context_line":"        from troveclient.v1 import storage"},{"line_number":312,"context_line":"        from troveclient.v1 import management"},{"line_number":313,"context_line":"        from troveclient.v1 import accounts"},{"line_number":314,"context_line":"        from troveclient.v1 import diagnostics"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        self.client \u003d client_cls(username, api_key, tenant, auth_url,"},{"line_number":317,"context_line":"                                 service_type\u003dservice_type,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BX6g%3D","line":314,"updated":"2013-12-02 19:14:00.000000000","message":"Please sort imports.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                                 insecure\u003dinsecure,"},{"line_number":321,"context_line":"                                 auth_strategy\u003dauth_strategy,"},{"line_number":322,"context_line":"                                 region_name\u003dregion_name)"},{"line_number":323,"context_line":"        self.versions \u003d versions.Versions(self)"},{"line_number":324,"context_line":"        self.databases \u003d databases.Databases(self)"},{"line_number":325,"context_line":"        self.flavors \u003d flavors.Flavors(self)"},{"line_number":326,"context_line":"        self.instances \u003d instances.Instances(self)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYYY%3D","line":323,"updated":"2013-11-26 17:37:53.000000000","message":"We should probably sort these soon, too.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/compat/mcli.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _pretty_print(info):"},{"line_number":42,"context_line":"    print (json.dumps(info, sort_keys\u003dTrue, indent\u003d4))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class HostCommands(common.AuthedCommandsBase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYZY%3D","line":42,"updated":"2013-11-26 17:37:53.000000000","message":"Like Robert said, this is ambiguous and looks like `\u003cprint-statement\u003e (\u003ctuple\u003e)` when I think we should be pushing for `\u003cprint-function\u003e(\u003cparameters\u003e)`","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"b0080158e9f2cac83f86896283470126fb2cc189","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _pretty_print(info):"},{"line_number":42,"context_line":"    print (json.dumps(info, sort_keys\u003dTrue, indent\u003d4))"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class HostCommands(common.AuthedCommandsBase):"},{"line_number":46,"context_line":"    \"\"\"Commands to list info on hosts\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BX58%3D","line":43,"updated":"2013-12-02 19:14:00.000000000","message":"Same comment about print statement.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/compat/tests/test_common.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                return [\"item1\"]"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"            def __len__(self):"},{"line_number":265,"context_line":"                return self.count"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        ret \u003d MockIterable()"},{"line_number":268,"context_line":"        func \u003d mock.Mock(return_value\u003dret)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYb8%3D","line":265,"updated":"2013-11-26 17:37:53.000000000","message":"nice","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}],"troveclient/v1/client.py":[{"author":{"_account_id":1375,"name":"Ed Cranford","email":"ed.cranford@gmail.com","username":"ed--cranford"},"change_message_id":"b40a17041f2ef5a8b9d594b4c09faec8229be030","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from troveclient import client as trove_client"},{"line_number":20,"context_line":"from troveclient.v1 import databases"},{"line_number":21,"context_line":"from troveclient.v1 import flavors"},{"line_number":22,"context_line":"from troveclient.v1 import instances"},{"line_number":23,"context_line":"from troveclient.v1 import limits"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BYdw%3D","line":20,"updated":"2013-11-26 17:37:53.000000000","message":"We should alphabetize these some time soon.","commit_id":"0e49ca1f8c28ae06da6059ff22f871fcb6205453"}]}
