)]}'
{"id":"openstack%2Fpython-troveclient~560373","triplet_id":"openstack%2Fpython-troveclient~master~Ib16578de1520163e9b9bc6894a079e8f0fcef37b","project":"openstack/python-troveclient","branch":"master","topic":"bp/trove-support-in-python-openstackclient","hashtags":[],"change_id":"Ib16578de1520163e9b9bc6894a079e8f0fcef37b","subject":"Add cluster-modules to OSC","status":"MERGED","created":"2018-04-11 11:27:45.000000000","updated":"2018-06-20 09:03:17.000000000","submitted":"2018-06-20 09:03:17.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"560373-1529485397444-39dde6cf","meta_rev_id":"3c1cfadbe773df71da1c148abc3e08a2dd34cab7","_number":560373,"virtual_id_number":560373,"owner":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":2,"date":"2018-06-20 09:03:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"all":[{"value":2,"date":"2018-06-20 06:59:26.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":2,"date":"2018-06-20 06:44:27.000000000","_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"all":[{"value":1,"date":"2018-06-20 06:59:34.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-20 06:44:27.000000000","updated_by":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"reviewer":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"state":"REVIEWER"},{"updated":"2018-06-20 06:59:34.000000000","updated_by":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"reviewer":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"state":"REVIEWER"},{"updated":"2018-06-20 09:03:17.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d5216d4de4a86da7678b077fe972b54aa968cddc","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-04-11 11:27:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ac811bc8b5f31157da319f23d294a580cf593b83","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-04-11 12:49:29.000000000","message":"Patch Set 1:\n\nDue to I don\u0027t have test environment for master. So I don\u0027t know if this patch is right. Can anyone offer help to provide \u0027trove cluster-module\u0027 returned json?","accounts_in_message":[],"_revision_number":1},{"id":"de581e35f7debc9631d159c58d070e715c40e562","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-04-11 13:16:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/1/check/build-openstack-sphinx-docs/8555e4c/html/ : SUCCESS in 5m 35s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/1/check/openstack-tox-pep8/6e605d2/ : SUCCESS in 4m 36s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/1/check/openstack-tox-py27/3531dc6/ : SUCCESS in 4m 26s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/1/check/openstack-tox-py35/4d0763a/ : SUCCESS in 4m 22s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/1/check/build-openstack-releasenotes/cb3cd71/html/ : SUCCESS in 4m 09s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/1/check/openstackclient-check-plugins/22a194a/ : SUCCESS in 8m 07s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/1/check/trove-functional-mysql/766fb26/ : SUCCESS in 1h 45m 51s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/1/check/python-troveclient-tempest-neutron-src/b93f818/ : SUCCESS in 1h 26m 06s","accounts_in_message":[],"_revision_number":1},{"id":"31ed93d82c81c27ad47d0310cf6bcbbc6e7bc8eb","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-04-17 07:27:52.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)\n\nThanks for working on this.\n\n \u003e Due to I don\u0027t have test environment for master. So I don\u0027t know if\n \u003e this patch is right. Can anyone offer help to provide \u0027trove\n \u003e cluster-module\u0027 returned json?\n\n\u0027trove cluster-module\u0027 actually makes calls to \u0027/v1.0/\u003ctenant_id\u003e/instances/\u003cinstance_id\u003e/modules\u0027, I added a sample API response as an inline comment.","accounts_in_message":[],"_revision_number":1},{"id":"f3e96ca24a5de8638ef7325db31ee3e1d10ea0cd","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-05-09 13:27:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"07edcf2addefc681d6ade027548458fe1666508f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-09 15:31:40.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/2/check/build-openstack-sphinx-docs/e4deee0/html/ : SUCCESS in 5m 02s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/2/check/openstack-tox-pep8/da708fb/ : SUCCESS in 3m 46s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/2/check/openstack-tox-py27/bc8e0c5/ : FAILURE in 4m 16s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/2/check/openstack-tox-py35/5f88171/ : FAILURE in 4m 09s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/2/check/build-openstack-releasenotes/9abeafc/html/ : SUCCESS in 3m 07s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/2/check/openstackclient-check-plugins/a94c72c/ : FAILURE in 5m 56s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/2/check/trove-functional-mysql/9d98797/ : FAILURE in 1h 58m 33s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/2/check/python-troveclient-tempest-neutron-src/4975f3c/ : SUCCESS in 1h 40m 40s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/2/check/openstack-tox-lower-constraints/b534167/ : FAILURE in 4m 40s","accounts_in_message":[],"_revision_number":2},{"id":"fc79dadd9e5f9755df33641e8890ca1fbeba7d02","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-04 11:42:44.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"5d8c92a6ad3d7d18cec4d8037135b73a144157e2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-04 13:25:01.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/3/check/build-openstack-sphinx-docs/36c0f47/html/ : SUCCESS in 5m 24s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/3/check/openstack-tox-pep8/c382382/ : SUCCESS in 4m 19s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/3/check/openstack-tox-py27/8e0a00e/ : SUCCESS in 4m 24s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/3/check/openstack-tox-py35/4114625/ : SUCCESS in 4m 05s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/3/check/build-openstack-releasenotes/886f67f/html/ : SUCCESS in 3m 19s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/3/check/openstackclient-check-plugins/e94b000/ : SUCCESS in 6m 55s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/3/check/trove-functional-mysql/d517a56/ : FAILURE in 33m 12s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/3/check/python-troveclient-tempest-neutron-src/546fb88/ : SUCCESS in 1h 36m 31s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/3/check/openstack-tox-lower-constraints/cf27144/ : SUCCESS in 4m 10s","accounts_in_message":[],"_revision_number":3},{"id":"359fe36832f7ce4cd92b3baeee295b56f27ea5f7","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-05 00:54:50.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"e9270c7981973b5480bdf407ed0d7fd1340c4e2d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 02:20:51.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/3/check/build-openstack-sphinx-docs/82a22ce/html/ : SUCCESS in 5m 08s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/3/check/openstack-tox-pep8/ca0eb14/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/3/check/openstack-tox-py27/08e2c0d/ : SUCCESS in 3m 58s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/3/check/openstack-tox-py35/4e1d534/ : SUCCESS in 3m 55s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/3/check/build-openstack-releasenotes/33de68e/html/ : SUCCESS in 3m 14s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/3/check/openstackclient-check-plugins/d2464ca/ : SUCCESS in 5m 55s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/3/check/trove-functional-mysql/facd368/ : FAILURE in 36m 50s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/3/check/python-troveclient-tempest-neutron-src/a7cce0c/ : SUCCESS in 1h 24m 19s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/3/check/openstack-tox-lower-constraints/60281a0/ : SUCCESS in 3m 56s","accounts_in_message":[],"_revision_number":3},{"id":"18f2439a8ba18f27b8a9590f6a95dcb3280e6794","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-05 07:27:34.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"f2e2a4034cee8f9aef8a22169bf1dd52a01c9919","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-06-05 08:39:36.000000000","message":"Patch Set 3:\n\n\u003e recheck\n\nThe failure of trove-functional-mysql is not relevant, something changed in DIB(diskimage-builder) and creating trove images will fail, we\u0027ll have to fix that first, :(","accounts_in_message":[],"_revision_number":3},{"id":"f284f773368a7274f1059222b05065ce48ef3447","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-05 08:52:30.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/3/check/build-openstack-sphinx-docs/df51fe9/html/ : SUCCESS in 6m 24s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/3/check/openstack-tox-pep8/3f9f9f1/ : SUCCESS in 4m 09s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/3/check/openstack-tox-py27/eb54d32/ : SUCCESS in 4m 23s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/3/check/openstack-tox-py35/1194bd5/ : SUCCESS in 4m 23s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/3/check/build-openstack-releasenotes/a1ea62a/html/ : SUCCESS in 4m 19s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/3/check/openstackclient-check-plugins/62bf7ae/ : SUCCESS in 6m 54s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/3/check/trove-functional-mysql/b924104/ : FAILURE in 36m 48s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/3/check/python-troveclient-tempest-neutron-src/1a815e9/ : SUCCESS in 1h 23m 01s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/3/check/openstack-tox-lower-constraints/5ef9d30/ : SUCCESS in 5m 24s","accounts_in_message":[],"_revision_number":3},{"id":"8c1f5a812d711aa8e5c334e73fda054032767854","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-06 10:00:05.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"4b8ccd18f64352535f33c7437c12906907dcd4e7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-06 11:57:31.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/3/check/build-openstack-sphinx-docs/a689ec6/html/ : SUCCESS in 6m 06s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/3/check/openstack-tox-pep8/1bcf13f/ : SUCCESS in 4m 47s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/3/check/openstack-tox-py27/341be3e/ : SUCCESS in 4m 52s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/3/check/openstack-tox-py35/d43483d/ : SUCCESS in 4m 56s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/3/check/build-openstack-releasenotes/5d10119/html/ : SUCCESS in 4m 17s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/3/check/openstackclient-check-plugins/abcfafc/ : SUCCESS in 7m 30s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/3/check/trove-functional-mysql/e1d5df8/ : FAILURE in 33m 17s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/3/check/python-troveclient-tempest-neutron-src/bcb599a/ : SUCCESS in 1h 47m 12s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/3/check/openstack-tox-lower-constraints/79e89e4/ : SUCCESS in 4m 54s","accounts_in_message":[],"_revision_number":3},{"id":"4c1cc9eb5a312543755641c6083e34606634f688","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-13 11:16:59.000000000","message":"Patch Set 3:\n\nrecheck","accounts_in_message":[],"_revision_number":3},{"id":"4582b08b435083118f238156c72a6cbdfa377970","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-13 13:49:59.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/3/check/build-openstack-sphinx-docs/8646a29/html/ : SUCCESS in 6m 11s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/3/check/openstack-tox-pep8/fb62cee/ : SUCCESS in 4m 49s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/3/check/openstack-tox-py27/aa9fbf8/ : SUCCESS in 5m 18s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/3/check/openstack-tox-py35/b889088/ : SUCCESS in 6m 15s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/3/check/build-openstack-releasenotes/0c49d5e/html/ : SUCCESS in 4m 07s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/3/check/openstackclient-check-plugins/9eb1b07/ : SUCCESS in 6m 32s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/3/check/trove-functional-mysql/8fd7531/ : SUCCESS in 2h 13m 05s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/3/check/python-troveclient-tempest-neutron-src/af70ae9/ : SUCCESS in 1h 29m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/3/check/openstack-tox-lower-constraints/fb928a7/ : SUCCESS in 5m 54s","accounts_in_message":[],"_revision_number":3},{"id":"f615144e2b2d67852e08fe12014890f8d2f46a9b","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-06-15 15:08:16.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)\n\nThe main part of this change looks good to me, thanks. However the fake functions used for UT could be improved, please see my inline comments.","accounts_in_message":[],"_revision_number":3},{"id":"0a9693eb91f4597e472eeb462c1c9e8c01ec4380","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-16 15:22:11.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"8128ca0add1450f21564fbec75f318ab669cb75e","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-16 15:29:37.000000000","message":"Patch Set 4:\n\n\u003e (2 comments)\n \u003e \n \u003e The main part of this change looks good to me, thanks. However the\n \u003e fake functions used for UT could be improved, please see my inline\n \u003e comments.\n\ngreat advice, really thanks","accounts_in_message":[],"_revision_number":4},{"id":"0e9d7089e883d3e1685a12aabecd6ace0dd1bcd9","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-16 17:39:29.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/4/check/build-openstack-sphinx-docs/759591b/html/ : SUCCESS in 4m 50s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/4/check/openstack-tox-pep8/369848c/ : SUCCESS in 4m 01s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/4/check/openstack-tox-py27/d21f1ce/ : SUCCESS in 4m 58s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/4/check/openstack-tox-py35/fa4233d/ : SUCCESS in 4m 05s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/4/check/build-openstack-releasenotes/96b4fd9/html/ : SUCCESS in 3m 35s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/4/check/openstackclient-check-plugins/2cb3c80/ : SUCCESS in 6m 31s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/4/check/trove-functional-mysql/068476c/ : SUCCESS in 2h 11m 48s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/4/check/python-troveclient-tempest-neutron-src/091185e/ : SUCCESS in 1h 47m 53s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/4/check/openstack-tox-lower-constraints/6a8e370/ : SUCCESS in 4m 01s","accounts_in_message":[],"_revision_number":4},{"id":"45c4798f689eeff1432955662ece24ec58558d85","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-06-17 13:50:23.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"cf8e0c605c776f7050cb67d53fca02a6ae53bf0a","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-19 03:20:15.000000000","message":"Patch Set 4:\n\n(1 comment)\n\nLGTM， just find something seems wrong out of this patch.","accounts_in_message":[],"_revision_number":4},{"id":"57852eb676d90ab5cf7a1579878c135b1e4ab2f8","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-19 03:27:02.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"f29367e8222227607f0092dab10a11e53898cd3f","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-06-20 04:27:50.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"22b872f7d150417ba8e2dcdd3257b8d4fa535b52","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-20 06:36:24.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/5/check/build-openstack-sphinx-docs/83b3678/html/ : SUCCESS in 3m 48s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/5/check/openstack-tox-pep8/677437a/ : SUCCESS in 3m 45s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/5/check/openstack-tox-py27/dcaba87/ : SUCCESS in 4m 01s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/5/check/openstack-tox-py35/a75fdfc/ : SUCCESS in 3m 56s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/5/check/build-openstack-releasenotes/def0e2e/html/ : SUCCESS in 2m 58s\n- openstackclient-check-plugins http://logs.openstack.org/73/560373/5/check/openstackclient-check-plugins/b45444b/ : SUCCESS in 5m 47s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/73/560373/5/check/trove-functional-mysql/38af0a4/ : SUCCESS in 2h 07m 21s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/5/check/python-troveclient-tempest-neutron-src/999f6ce/ : SUCCESS in 2h 06m 22s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/5/check/openstack-tox-lower-constraints/31caa24/ : SUCCESS in 3m 52s","accounts_in_message":[],"_revision_number":5},{"id":"0890334b544cff66f6387d564f8fdb3eeb754c8f","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-06-20 06:44:27.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)\n\nLGTM, thanks.","accounts_in_message":[],"_revision_number":5},{"id":"71849e3f9f077256cd5c11c469945c9369b0457a","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-20 06:59:26.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"6d2cbd7eb5f93838ca286c87f42f255d4aeec289","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-06-20 06:59:34.000000000","message":"Patch Set 5: Workflow+1","accounts_in_message":[],"_revision_number":5},{"id":"7e6bd9b15f40a1b3799b7105a3553375281e2f34","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-20 06:59:47.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"f8a80acb287c475b2ff2780a6474fee0db967903","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-20 09:03:17.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/73/560373/5/gate/build-openstack-sphinx-docs/0571037/html/ : SUCCESS in 5m 21s\n- openstack-tox-pep8 http://logs.openstack.org/73/560373/5/gate/openstack-tox-pep8/eba1944/ : SUCCESS in 4m 14s\n- openstack-tox-py27 http://logs.openstack.org/73/560373/5/gate/openstack-tox-py27/84fc8d7/ : SUCCESS in 4m 43s\n- openstack-tox-py35 http://logs.openstack.org/73/560373/5/gate/openstack-tox-py35/9f49231/ : SUCCESS in 5m 32s\n- build-openstack-releasenotes http://logs.openstack.org/73/560373/5/gate/build-openstack-releasenotes/4997576/html/ : SUCCESS in 4m 31s\n- trove-functional-mysql http://logs.openstack.org/73/560373/5/gate/trove-functional-mysql/4ca99b8/ : SUCCESS in 2h 02m 02s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/73/560373/5/gate/python-troveclient-tempest-neutron-src/b05bd9f/ : SUCCESS in 1h 27m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/73/560373/5/gate/openstack-tox-lower-constraints/016b4c8/ : SUCCESS in 4m 13s","accounts_in_message":[],"_revision_number":5},{"id":"a1f10d0569e5d20999d9c1b5e33b3baf57b5119d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-20 09:03:17.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"bca0410100ee9d924a942517a96c16de42bd2334","revisions":{"a8c57a212da8db6ec74635932a8e7cb68be15789":{"kind":"REWORK","_number":1,"created":"2018-04-11 11:27:45.000000000","uploader":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"ref":"refs/changes/73/560373/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/560373/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/1"}}},"commit":{"parents":[{"commit":"0e6c017c6d1d049d7d26c3c143ca5f7dff8c6233","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0e6c017c6d1d049d7d26c3c143ca5f7dff8c6233"}]}],"author":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"committer":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"subject":"Add cluster-modules to OSC","message":"Add cluster-modules to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the cluster-modules command.\n\nThe trove command cluster-modules is now:\n    openstack database cluster modules\n\nChange-Id: Ib16578de1520163e9b9bc6894a079e8f0fcef37b\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/a8c57a212da8db6ec74635932a8e7cb68be15789"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/a8c57a212da8db6ec74635932a8e7cb68be15789"}]},"branch":"refs/heads/master"},"2095e3a8e5f210ff95e046dc8ff332022318d55d":{"kind":"REWORK","_number":2,"created":"2018-05-09 13:27:25.000000000","uploader":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"ref":"refs/changes/73/560373/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/560373/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/2"}}},"commit":{"parents":[{"commit":"3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee","subject":"Follow the new PTI for document build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee"}]}],"author":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"committer":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-05-08 01:03:50.000000000","tz":480},"subject":"Add cluster-modules to OSC","message":"Add cluster-modules to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the cluster-modules command.\n\nThe trove command cluster-modules is now:\n    openstack database cluster modules\n\nChange-Id: Ib16578de1520163e9b9bc6894a079e8f0fcef37b\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2095e3a8e5f210ff95e046dc8ff332022318d55d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2095e3a8e5f210ff95e046dc8ff332022318d55d"}]},"branch":"refs/heads/master"},"a6d27d6ecef359d95d2848d8fbf6c7fe787b8ca8":{"kind":"REWORK","_number":3,"created":"2018-06-04 11:42:44.000000000","uploader":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"ref":"refs/changes/73/560373/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/560373/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/3"}}},"commit":{"parents":[{"commit":"3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee","subject":"Follow the new PTI for document build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee"}]}],"author":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"committer":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-06-01 01:39:13.000000000","tz":480},"subject":"Add cluster-modules to OSC","message":"Add cluster-modules to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the cluster-modules command.\n\nThe trove command cluster-modules is now:\n    openstack database cluster modules\n\nChange-Id: Ib16578de1520163e9b9bc6894a079e8f0fcef37b\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/a6d27d6ecef359d95d2848d8fbf6c7fe787b8ca8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/a6d27d6ecef359d95d2848d8fbf6c7fe787b8ca8"}]},"branch":"refs/heads/master"},"3e2af3d68dc218767e9b050668d8ad9d575b4737":{"kind":"REWORK","_number":4,"created":"2018-06-16 15:22:11.000000000","uploader":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"ref":"refs/changes/73/560373/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/560373/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/4"}}},"commit":{"parents":[{"commit":"3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee","subject":"Follow the new PTI for document build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee"}]}],"author":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"committer":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-06-16 15:20:05.000000000","tz":480},"subject":"Add cluster-modules to OSC","message":"Add cluster-modules to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the cluster-modules command.\n\nThe trove command cluster-modules is now:\n    openstack database cluster modules\n\nChange-Id: Ib16578de1520163e9b9bc6894a079e8f0fcef37b\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3e2af3d68dc218767e9b050668d8ad9d575b4737"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3e2af3d68dc218767e9b050668d8ad9d575b4737"}]},"branch":"refs/heads/master"},"bca0410100ee9d924a942517a96c16de42bd2334":{"kind":"REWORK","_number":5,"created":"2018-06-20 04:27:50.000000000","uploader":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"ref":"refs/changes/73/560373/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/560373/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/560373/5"}}},"commit":{"parents":[{"commit":"3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee","subject":"Follow the new PTI for document build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/3c70f8f69ebbe0bd1f83cfeb84a1c79b0f01a8ee"}]}],"author":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-04-11 11:26:20.000000000","tz":480},"committer":{"name":"wangyao","email":"wangyao@cmss.chinamobile.com","date":"2018-06-20 04:25:06.000000000","tz":480},"subject":"Add cluster-modules to OSC","message":"Add cluster-modules to OSC\n\nThis change adds database support to the python-openstackclient\nproject for the cluster-modules command.\n\nThe trove command cluster-modules is now:\n    openstack database cluster modules\n\nChange-Id: Ib16578de1520163e9b9bc6894a079e8f0fcef37b\nPartially-Implements: blueprint trove-support-in-python-openstackclient\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/bca0410100ee9d924a942517a96c16de42bd2334"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/bca0410100ee9d924a942517a96c16de42bd2334"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}