)]}'
{"id":"openstack%2Fpython-troveclient~579155","triplet_id":"openstack%2Fpython-troveclient~master~If53f0f4c313a699a4036838ab6035fffa931931b","project":"openstack/python-troveclient","branch":"master","hashtags":[],"change_id":"If53f0f4c313a699a4036838ab6035fffa931931b","subject":"Replace \u0027raise StopIteration\u0027 with \u0027return\u0027","status":"MERGED","created":"2018-06-29 13:28:37.000000000","updated":"2018-07-16 18:33:57.000000000","submitted":"2018-07-16 18:33:56.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"579155-1531766037075-52129652","meta_rev_id":"ed2275d174a65944b6119ff098aa851011c70c6d","_number":579155,"virtual_id_number":579155,"owner":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":2,"date":"2018-07-16 18:33:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":2,"date":"2018-07-16 15:37:50.000000000","_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":2,"date":"2018-07-16 12:13:06.000000000","_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"all":[{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":1,"date":"2018-07-16 15:37:50.000000000","_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"date":"2018-07-16 12:14:54.000000000","_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-16 12:13:06.000000000","updated_by":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"reviewer":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"reviewer":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"reviewer":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"reviewer":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"reviewer":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"reviewer":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"state":"REVIEWER"},{"updated":"2018-07-16 12:14:54.000000000","updated_by":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"reviewer":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"state":"REVIEWER"},{"updated":"2018-07-16 15:37:50.000000000","updated_by":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"reviewer":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"state":"REVIEWER"},{"updated":"2018-07-16 18:33:56.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"024108dd48458585edb24bb32f0afdbc5d623bca","author":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"date":"2018-06-29 13:28:37.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe8b3ffcce1a571d909fa2a584c9131c63f7406c","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-29 16:04:10.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- build-openstack-sphinx-docs http://logs.openstack.org/55/579155/1/check/build-openstack-sphinx-docs/7e01477/html/ : SUCCESS in 4m 39s\n- openstack-tox-pep8 http://logs.openstack.org/55/579155/1/check/openstack-tox-pep8/5990262/ : SUCCESS in 5m 08s\n- openstack-tox-py27 http://logs.openstack.org/55/579155/1/check/openstack-tox-py27/f25c2ba/ : FAILURE in 5m 09s\n- openstack-tox-py35 http://logs.openstack.org/55/579155/1/check/openstack-tox-py35/606c5a3/ : SUCCESS in 7m 13s\n- openstackclient-check-plugins http://logs.openstack.org/55/579155/1/check/openstackclient-check-plugins/9fcd454/ : SUCCESS in 7m 51s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/55/579155/1/check/trove-functional-mysql/bbbf34f/ : SUCCESS in 2h 12m 04s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/55/579155/1/check/python-troveclient-tempest-neutron-src/51ad0b9/ : SUCCESS in 1h 28m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/579155/1/check/openstack-tox-lower-constraints/9256d1e/ : SUCCESS in 5m 01s","accounts_in_message":[],"_revision_number":1},{"id":"5b2b8bf11341b58436a4326d44cddc17e61fbafe","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-12 09:20:56.000000000","message":"Patch Set 1:\n\nopenstack-tox-py27 failed by incorrectly mocking of the builtin open method, and is not related to this patch.","accounts_in_message":[],"_revision_number":1},{"id":"45729e6904b621a3988956979456c4bd39c5267a","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-12 09:21:04.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"8d3e65d1698c5e8a2762225e9a15b373596a3592","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 12:41:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/55/579155/1/check/build-openstack-sphinx-docs/f6ecfd8/html/ : SUCCESS in 5m 23s\n- openstack-tox-pep8 http://logs.openstack.org/55/579155/1/check/openstack-tox-pep8/0b04e2b/ : SUCCESS in 5m 13s\n- openstack-tox-py27 http://logs.openstack.org/55/579155/1/check/openstack-tox-py27/0afb280/ : SUCCESS in 4m 16s\n- openstack-tox-py35 http://logs.openstack.org/55/579155/1/check/openstack-tox-py35/5bf0261/ : SUCCESS in 6m 25s\n- openstackclient-check-plugins http://logs.openstack.org/55/579155/1/check/openstackclient-check-plugins/e35c9b9/ : SUCCESS in 7m 09s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/55/579155/1/check/trove-functional-mysql/fc79daa/ : SUCCESS in 2h 15m 47s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/55/579155/1/check/python-troveclient-tempest-neutron-src/50ff2de/ : SUCCESS in 1h 29m 12s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/579155/1/check/openstack-tox-lower-constraints/7359de2/ : SUCCESS in 6m 32s","accounts_in_message":[],"_revision_number":1},{"id":"776fd7de988950eb1cb8abdab982f494f61b58de","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-16 12:13:06.000000000","message":"Patch Set 1: Code-Review+2\n\nLGTM, although I didn\u0027t verify it under Python 3.7, but the PEP is already proved and I also did some simple tests to verify that using \u0027return\u0027 instead of \u0027raise StopIteration\u0027 should not affect current code base, thanks.","accounts_in_message":[],"_revision_number":1},{"id":"84d1da4eb08e8de48f8546c6d2977b878766220e","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-07-16 15:37:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nThis is a good improvement according to doc, thanks.","accounts_in_message":[],"_revision_number":1},{"id":"521f1fd9c2b8fe0eb67ea41e0b9a02c874bc1a27","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 15:38:02.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"267da7a7280122589a537bbf0d33f2cf9754fcd0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 18:33:56.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/55/579155/1/gate/build-openstack-sphinx-docs/ca40eff/html/ : SUCCESS in 6m 58s\n- openstack-tox-pep8 http://logs.openstack.org/55/579155/1/gate/openstack-tox-pep8/09e592a/ : SUCCESS in 6m 16s\n- openstack-tox-py27 http://logs.openstack.org/55/579155/1/gate/openstack-tox-py27/6111408/ : SUCCESS in 5m 47s\n- openstack-tox-py35 http://logs.openstack.org/55/579155/1/gate/openstack-tox-py35/d83aa5c/ : SUCCESS in 6m 17s\n- trove-functional-mysql http://logs.openstack.org/55/579155/1/gate/trove-functional-mysql/eea1aa8/ : SUCCESS in 2h 36m 52s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/55/579155/1/gate/python-troveclient-tempest-neutron-src/a94aebf/ : SUCCESS in 1h 42m 10s\n- openstack-tox-lower-constraints http://logs.openstack.org/55/579155/1/gate/openstack-tox-lower-constraints/6289e4f/ : SUCCESS in 5m 15s","accounts_in_message":[],"_revision_number":1},{"id":"ed2275d174a65944b6119ff098aa851011c70c6d","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-16 18:33:57.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2fb1dcbe5e8c8a826e8a9567ffb49295a2402641","revisions":{"2fb1dcbe5e8c8a826e8a9567ffb49295a2402641":{"kind":"REWORK","_number":1,"created":"2018-06-29 13:28:37.000000000","uploader":{"_account_id":9712,"name":"Dougal Matthews","email":"dougal.matthews@canonical.com","username":"dougal"},"ref":"refs/changes/55/579155/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/55/579155/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/579155/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/579155/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/55/579155/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/55/579155/1"}}},"commit":{"parents":[{"commit":"9e2d282b4de0ef5e7e7dbecce70af34c2d60d5dd","subject":"Merge \"Update the troveclient\u0027s README.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/9e2d282b4de0ef5e7e7dbecce70af34c2d60d5dd"}]}],"author":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2018-06-29 13:27:21.000000000","tz":60},"committer":{"name":"Dougal Matthews","email":"dougal@redhat.com","date":"2018-06-29 13:28:27.000000000","tz":60},"subject":"Replace \u0027raise StopIteration\u0027 with \u0027return\u0027","message":"Replace \u0027raise StopIteration\u0027 with \u0027return\u0027\n\nWith PEP 479, the behaviour of StopIteration is changing. Raising it to\nstop a generator is considered incorrect and from Python 3.7 this will\ncause a RuntimeError. The PEP recommends using the return statement.\n\nMore details: https://www.python.org/dev/peps/pep-0479/#examples-of-breakage\n\nChange-Id: If53f0f4c313a699a4036838ab6035fffa931931b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2fb1dcbe5e8c8a826e8a9567ffb49295a2402641"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/2fb1dcbe5e8c8a826e8a9567ffb49295a2402641"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}