)]}'
{"id":"openstack%2Fpython-troveclient~581210","triplet_id":"openstack%2Fpython-troveclient~master~I57ea61cefd3b01b19475b0fa7e16f716eaaa14e6","project":"openstack/python-troveclient","branch":"master","topic":"fix-builtin-open-mocking","hashtags":[],"change_id":"I57ea61cefd3b01b19475b0fa7e16f716eaaa14e6","subject":"Correctly mocking builtin open in test_v1_shell","status":"MERGED","created":"2018-07-10 06:26:58.000000000","updated":"2018-07-12 07:54:47.000000000","submitted":"2018-07-12 07:54:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"581210-1531382087934-2aee0645","meta_rev_id":"7976d4a6540cce0dd00d8690c6fe67557a9d0f2f","_number":581210,"virtual_id_number":581210,"owner":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"date":"2018-07-12 06:01:17.000000000","_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":2,"date":"2018-07-12 07:54:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"all":[{"value":2,"date":"2018-07-12 05:53:02.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":2,"date":"2018-07-11 14:33:05.000000000","_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"all":[{"value":1,"date":"2018-07-12 05:53:22.000000000","_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"date":"2018-07-10 09:50:51.000000000","_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"value":0,"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"value":0,"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"value":0,"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"value":0,"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"value":0,"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"value":0,"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"value":0,"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"reviewer":{"_account_id":13562,"name":"Samuel Matzek","email":"smatzek@us.ibm.com","username":"smatzek"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"reviewer":{"_account_id":22694,"name":"jian.song","email":"jiansong19941206@gmail.com","username":"jiansong"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"reviewer":{"_account_id":22818,"name":"Manoj Kumar","email":"manoj@linux.vnet.ibm.com","username":"manojnkumar"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"reviewer":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"reviewer":{"_account_id":25113,"name":"Fan Zhang","email":"zh.f@outlook.com","username":"fanzhang"},"state":"REVIEWER"},{"updated":"2018-07-10 09:50:51.000000000","updated_by":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"reviewer":{"_account_id":26895,"name":"Luke Browning","email":"lukebrowning@us.ibm.com","username":"lukebrowning"},"state":"REVIEWER"},{"updated":"2018-07-11 14:33:05.000000000","updated_by":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"reviewer":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"state":"REVIEWER"},{"updated":"2018-07-12 05:53:22.000000000","updated_by":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"reviewer":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"state":"REVIEWER"},{"updated":"2018-07-12 07:54:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"e24686f026919577d715b7b617f92542f7b0304c","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-10 06:26:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7f9f20cba41a876a7bb088d0aec43b0d8081e372","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-10 08:30:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/10/581210/1/check/build-openstack-sphinx-docs/15a7c59/html/ : SUCCESS in 5m 19s\n- openstack-tox-pep8 http://logs.openstack.org/10/581210/1/check/openstack-tox-pep8/8497b9d/ : SUCCESS in 3m 55s\n- openstack-tox-py27 http://logs.openstack.org/10/581210/1/check/openstack-tox-py27/58ecb48/ : SUCCESS in 7m 26s\n- openstack-tox-py35 http://logs.openstack.org/10/581210/1/check/openstack-tox-py35/cccb0f5/ : SUCCESS in 5m 14s\n- openstackclient-check-plugins http://logs.openstack.org/10/581210/1/check/openstackclient-check-plugins/077981e/ : SUCCESS in 6m 15s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/10/581210/1/check/trove-functional-mysql/9c1d55a/ : SUCCESS in 1h 59m 54s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/10/581210/1/check/python-troveclient-tempest-neutron-src/3f78457/ : SUCCESS in 1h 45m 57s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/581210/1/check/openstack-tox-lower-constraints/c8d9f72/ : SUCCESS in 5m 31s","accounts_in_message":[],"_revision_number":1},{"id":"fb12c6bd74fd00985eda15e1f2d2c30301d36606","author":{"_account_id":24739,"name":"Yao Wang","email":"wangyao@cmss.chinamobile.com","username":"wangyao"},"date":"2018-07-11 14:33:05.000000000","message":"Patch Set 1: Code-Review+2\n\nit works","accounts_in_message":[],"_revision_number":1},{"id":"3398406ecd1b31ae41c6c93d4d35b3d1e07f9624","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-07-12 03:07:25.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nThanks for the updates, I learn something new about mock. The change of module_create looks good, and I have some doubt about the change of module_retrieve","accounts_in_message":[],"_revision_number":1},{"id":"08b14ada6fa963eb5b7e65c19e7bb7b549760e66","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-12 03:52:02.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"b271329a273f7f8bd509dd6e7b83a4b3e44e0688","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-07-12 05:53:02.000000000","message":"Patch Set 1: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"25cb8b2dde8bf6b29906e6bca672b4bfdf6c2ecf","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-07-12 05:53:22.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"28a312a2ebe097fb9ae9cc3033664bd0787f699f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 05:53:34.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5c1fbe0b7e7d4cc64b5803e572e3e04f699cf69c","author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"date":"2018-07-12 06:01:17.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"613c6b92eaabbd7d4fc13f52cd22a3489b47bb9b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 07:54:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"faf5eca585acbc67cec77f448167083a1b8f6f9b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-07-12 07:54:47.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/10/581210/1/gate/build-openstack-sphinx-docs/a21bd0c/html/ : SUCCESS in 4m 26s\n- openstack-tox-pep8 http://logs.openstack.org/10/581210/1/gate/openstack-tox-pep8/6ca30a2/ : SUCCESS in 5m 04s\n- openstack-tox-py27 http://logs.openstack.org/10/581210/1/gate/openstack-tox-py27/d7bcce3/ : SUCCESS in 3m 58s\n- openstack-tox-py35 http://logs.openstack.org/10/581210/1/gate/openstack-tox-py35/4fcdcc2/ : SUCCESS in 4m 48s\n- trove-functional-mysql http://logs.openstack.org/10/581210/1/gate/trove-functional-mysql/66d668e/ : SUCCESS in 2h 00m 04s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/10/581210/1/gate/python-troveclient-tempest-neutron-src/a630e15/ : SUCCESS in 1h 47m 34s\n- openstack-tox-lower-constraints http://logs.openstack.org/10/581210/1/gate/openstack-tox-lower-constraints/ccae62d/ : SUCCESS in 4m 47s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0fc7d9e33d0ec018126b57e43004e2fba4f7ebaa","revisions":{"0fc7d9e33d0ec018126b57e43004e2fba4f7ebaa":{"kind":"REWORK","_number":1,"created":"2018-07-10 06:26:58.000000000","uploader":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"ref":"refs/changes/10/581210/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/10/581210/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/581210/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/581210/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/10/581210/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/10/581210/1"}}},"commit":{"parents":[{"commit":"9e2d282b4de0ef5e7e7dbecce70af34c2d60d5dd","subject":"Merge \"Update the troveclient\u0027s README.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/9e2d282b4de0ef5e7e7dbecce70af34c2d60d5dd"}]}],"author":{"name":"Zhao Chao","email":"zhaochao1984@gmail.com","date":"2018-07-10 05:47:04.000000000","tz":480},"committer":{"name":"Zhao Chao","email":"zhaochao1984@gmail.com","date":"2018-07-10 06:26:02.000000000","tz":480},"subject":"Correctly mocking builtin open in test_v1_shell","message":"Correctly mocking builtin open in test_v1_shell\n\nThere\u0027s now a seperate module \u0027builtins\u0027 from python-future(this package\nis now installed by stestr, and stestr in required by oslotest-3.6.0),\nso under Python 2.x \u0027builtins\u0027 is also imported as a module and\n\u0027bultins.open\u0027 is mocked instead of \u0027__builtin__.open\u0027. And according to\nthe Mock document, we should always patch the object where it\u0027s looked\nup, so only necessary mocking is made in this patch.\n\nChange-Id: I57ea61cefd3b01b19475b0fa7e16f716eaaa14e6\nSigned-off-by: Zhao Chao \u003czhaochao1984@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0fc7d9e33d0ec018126b57e43004e2fba4f7ebaa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0fc7d9e33d0ec018126b57e43004e2fba4f7ebaa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}