)]}'
{"troveclient/osc/v1/database_configurations.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9dd62e45bfce26f9b78719c94da170c190c23e44","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        instance \u003d osc_utils.find_resource(db_instances,"},{"line_number":328,"context_line":"                                           parsed_args.instance)"},{"line_number":329,"context_line":"        configs \u003d db_instances.configuration(instance)"},{"line_number":330,"context_line":"        return zip(*sorted(six.iteritems(configs)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_cfe517a6","line":330,"updated":"2018-07-16 12:28:54.000000000","message":"troveclient.v1.instances.Instances.configuration returns a instance of troveclient.v1.instances.Instance, so we cannot directly use the result here, trove.v1.shell.do_configuration_default use \"configs._info[\u0027configuration\u0027]\", we could keep using that(conifgs.configuration should also be fine).","commit_id":"27d1c1d6eee82d33e4286decdd70b31d2b12a530"}],"troveclient/tests/osc/v1/test_database_configurations.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9dd62e45bfce26f9b78719c94da170c190c23e44","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def setUp(self):"},{"line_number":303,"context_line":"        super(TestConfigurationDefault, self).setUp()"},{"line_number":304,"context_line":"        self.cmd \u003d database_configurations.\\"},{"line_number":305,"context_line":"            DefaultDatabaseConfiguration(self.app, None)"},{"line_number":306,"context_line":"        self.data \u003d ("},{"line_number":307,"context_line":"            self.fake_configurations.get_default_configuration().configuration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2fbdab66","line":304,"range":{"start_line":304,"start_character":43,"end_line":304,"end_character":44},"updated":"2018-07-16 12:28:54.000000000","message":"It\u0027s better to use parentheses to break long lines.","commit_id":"27d1c1d6eee82d33e4286decdd70b31d2b12a530"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"9dd62e45bfce26f9b78719c94da170c190c23e44","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        self.cmd \u003d database_configurations.\\"},{"line_number":305,"context_line":"            DefaultDatabaseConfiguration(self.app, None)"},{"line_number":306,"context_line":"        self.data \u003d ("},{"line_number":307,"context_line":"            self.fake_configurations.get_default_configuration().configuration)"},{"line_number":308,"context_line":"        self.instance_client.configuration.return_value \u003d self.data"},{"line_number":309,"context_line":"        self.columns \u003d ("},{"line_number":310,"context_line":"            \u0027innodb_log_files_in_group\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_8f84ffb3","line":307,"range":{"start_line":307,"start_character":12,"end_line":307,"end_character":78},"updated":"2018-07-16 12:28:54.000000000","message":"This is the reason we pass this test, but in fact, self.instance_client.configuration.return_value should be an instance of troveclient.v1.instances.Instance.","commit_id":"27d1c1d6eee82d33e4286decdd70b31d2b12a530"}]}