)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a1a8d65ee6cdf192fe2622b8218cfb8b6b3eb1fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-06 09:33:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass configuration property for cluster-create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was no way to pass configuration group for"},{"line_number":10,"context_line":"cluster-create command, like in single instance deployment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_6338f7d2","line":7,"updated":"2018-08-06 11:57:13.000000000","message":"There is a commit[1] that implements configuration groups for clusters. Maybe it would be valuable to reference it in the commit message or even better - refer the blueprint that it implemented (blueprint cluster-configuration-groups).\n\n[1] https://github.com/openstack/trove/commit/9bca402ec3f651fb9017c20dc27601a548cc79e1","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"8b10797a71971dc65089c31535193c1e6b16f8d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-06 09:33:00 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Pass configuration property for cluster-create"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was no way to pass configuration group for"},{"line_number":10,"context_line":"cluster-create command, like in single instance deployment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_a3712fe3","line":7,"in_reply_to":"3f79a3b5_6338f7d2","updated":"2018-08-06 12:30:51.000000000","message":"I have added Partially implements and Depends-On headers. Thanks.","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"372224682db50e9530e86b82b521d13de6539444","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Configuration will be applied to each cluster instance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint cluster-configuration-groups"},{"line_number":18,"context_line":"Depends-On: I7c0a22c6a0287128d0c37e100589c78173fd9c1a"},{"line_number":19,"context_line":"Change-Id: Ic0840c995cbc34203c76494d7ba522f3e17141a7"},{"line_number":20,"context_line":"Signed-off-by: Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_c189c326","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"updated":"2018-08-06 13:37:46.000000000","message":"Depends-On is used to chain Zuul checking jobs, so it usually means the later commit is also under review. As I7c0a22c6a0287128d0c37e100589c78173fd9c1a was already merged, we could just refer to it inside the commit message body(e.g. the second paragraph in this commit message body).","commit_id":"8d15cf3e59c750d16386da364ed2feec1ff092ac"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"b8baa0a3c498bb2adba860837132facafdda6b7a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Configuration will be applied to each cluster instance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements: blueprint cluster-configuration-groups"},{"line_number":18,"context_line":"Depends-On: I7c0a22c6a0287128d0c37e100589c78173fd9c1a"},{"line_number":19,"context_line":"Change-Id: Ic0840c995cbc34203c76494d7ba522f3e17141a7"},{"line_number":20,"context_line":"Signed-off-by: Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f79a3b5_eca38f4e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":53},"in_reply_to":"3f79a3b5_c189c326","updated":"2018-08-06 20:17:47.000000000","message":"Thanks. Moved to message body.","commit_id":"8d15cf3e59c750d16386da364ed2feec1ff092ac"}],"troveclient/tests/test_v1_shell.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a1a8d65ee6cdf192fe2622b8218cfb8b6b3eb1fc","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def test_cluster_create_with_configuration(self):"},{"line_number":520,"context_line":"        cmd \u003d (\u0027cluster-create test-clstr2 redis 3.0 \u0027"},{"line_number":521,"context_line":"               \u0027--configuration\u003d8f19f521-e380-4d62-b564-08473d2feffb \u0027"},{"line_number":522,"context_line":"               \u0027--instance flavor\u003d2,volume\u003d1 \u0027"},{"line_number":523,"context_line":"               \u0027--instance flavor\u003d02,volume\u003d1 \u0027"},{"line_number":524,"context_line":"               \u0027--instance flavor\u003d2,volume\u003d1 \u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_906c7709","line":521,"updated":"2018-08-06 11:57:13.000000000","message":"Looking at identifiers elsewhere in the code, a shorter value would fit better. Maybe try something like:\n\n configuration \u003d \u0027config1\u0027\n\nThere is one more test with similar ID (test_cluster.py).","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"8b10797a71971dc65089c31535193c1e6b16f8d9","unresolved":false,"context_lines":[{"line_number":518,"context_line":""},{"line_number":519,"context_line":"    def test_cluster_create_with_configuration(self):"},{"line_number":520,"context_line":"        cmd \u003d (\u0027cluster-create test-clstr2 redis 3.0 \u0027"},{"line_number":521,"context_line":"               \u0027--configuration\u003d8f19f521-e380-4d62-b564-08473d2feffb \u0027"},{"line_number":522,"context_line":"               \u0027--instance flavor\u003d2,volume\u003d1 \u0027"},{"line_number":523,"context_line":"               \u0027--instance flavor\u003d02,volume\u003d1 \u0027"},{"line_number":524,"context_line":"               \u0027--instance flavor\u003d2,volume\u003d1 \u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_237d1fb1","line":521,"in_reply_to":"3f79a3b5_906c7709","updated":"2018-08-06 12:30:51.000000000","message":"Done","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"e810037b2ede1e946432a4b2dbba63ec2dafffd5","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                ],"},{"line_number":559,"context_line":"                \u0027datastore\u0027: {\u0027version\u0027: \u00274.0\u0027, \u0027type\u0027: \u0027mongodb\u0027},"},{"line_number":560,"context_line":"                \u0027name\u0027: \u0027test-clstr3\u0027,"},{"line_number":561,"context_line":"                \u0027configuration\u0027: \u0027config01\u0027,"},{"line_number":562,"context_line":"                \u0027extended_properties\u0027: {\u0027num_mongos\u0027: \u00273\u0027}}})"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_cluster_create_with_nic_az(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_7f695c23","line":561,"range":{"start_line":561,"start_character":16,"end_line":561,"end_character":17},"updated":"2018-08-07 02:38:31.000000000","message":"You didn\u0027t pass --configuration in cmd, this line should be removed.","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"1776b9c3a291e71baa4150abb579af4907b94bc9","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                ],"},{"line_number":559,"context_line":"                \u0027datastore\u0027: {\u0027version\u0027: \u00274.0\u0027, \u0027type\u0027: \u0027mongodb\u0027},"},{"line_number":560,"context_line":"                \u0027name\u0027: \u0027test-clstr3\u0027,"},{"line_number":561,"context_line":"                \u0027configuration\u0027: \u0027config01\u0027,"},{"line_number":562,"context_line":"                \u0027extended_properties\u0027: {\u0027num_mongos\u0027: \u00273\u0027}}})"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_cluster_create_with_nic_az(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9376a806","line":561,"range":{"start_line":561,"start_character":16,"end_line":561,"end_character":17},"in_reply_to":"3f79a3b5_6269c3bc","updated":"2018-08-07 13:32:13.000000000","message":"Done","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"1776b9c3a291e71baa4150abb579af4907b94bc9","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                ],"},{"line_number":559,"context_line":"                \u0027datastore\u0027: {\u0027version\u0027: \u00274.0\u0027, \u0027type\u0027: \u0027mongodb\u0027},"},{"line_number":560,"context_line":"                \u0027name\u0027: \u0027test-clstr3\u0027,"},{"line_number":561,"context_line":"                \u0027configuration\u0027: \u0027config01\u0027,"},{"line_number":562,"context_line":"                \u0027extended_properties\u0027: {\u0027num_mongos\u0027: \u00273\u0027}}})"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_cluster_create_with_nic_az(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f3691c25","line":561,"range":{"start_line":561,"start_character":16,"end_line":561,"end_character":17},"in_reply_to":"3f79a3b5_7f695c23","updated":"2018-08-07 13:32:13.000000000","message":"Done","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"e2765b24df2e8f837d72badebd604405c7c04f96","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                ],"},{"line_number":559,"context_line":"                \u0027datastore\u0027: {\u0027version\u0027: \u00274.0\u0027, \u0027type\u0027: \u0027mongodb\u0027},"},{"line_number":560,"context_line":"                \u0027name\u0027: \u0027test-clstr3\u0027,"},{"line_number":561,"context_line":"                \u0027configuration\u0027: \u0027config01\u0027,"},{"line_number":562,"context_line":"                \u0027extended_properties\u0027: {\u0027num_mongos\u0027: \u00273\u0027}}})"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"    def test_cluster_create_with_nic_az(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_6269c3bc","line":561,"range":{"start_line":561,"start_character":16,"end_line":561,"end_character":17},"in_reply_to":"3f79a3b5_7f695c23","updated":"2018-08-07 03:37:23.000000000","message":"Yes, this line should be removed, this also failed the py27/py35 unittest and lower-constraints checking jobs. a new case of \u0027test_cluster_create_with_configuration\u0027 should be sufficient.","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"}],"troveclient/v1/clusters.py":[{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"e2765b24df2e8f837d72badebd604405c7c04f96","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    resource_class \u003d Cluster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, datastore, datastore_version, instances\u003dNone,"},{"line_number":40,"context_line":"               locality\u003dNone, configuration\u003dNone, extended_properties\u003dNone):"},{"line_number":41,"context_line":"        \"\"\"Create (boot) a new cluster.\"\"\""},{"line_number":42,"context_line":"        body \u003d {\"cluster\": {"},{"line_number":43,"context_line":"            \"name\": name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_2263cbde","line":40,"range":{"start_line":40,"start_character":30,"end_line":40,"end_character":50},"updated":"2018-08-07 03:37:23.000000000","message":"As the addition of extended_properties is merged before this patch, we have to append new arguments after it, i.e. moving \u0027configuration\u0027 after \u0027extended_properties\u0027.","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"1776b9c3a291e71baa4150abb579af4907b94bc9","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    resource_class \u003d Cluster"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def create(self, name, datastore, datastore_version, instances\u003dNone,"},{"line_number":40,"context_line":"               locality\u003dNone, configuration\u003dNone, extended_properties\u003dNone):"},{"line_number":41,"context_line":"        \"\"\"Create (boot) a new cluster.\"\"\""},{"line_number":42,"context_line":"        body \u003d {\"cluster\": {"},{"line_number":43,"context_line":"            \"name\": name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_934f88bc","line":40,"range":{"start_line":40,"start_character":30,"end_line":40,"end_character":50},"in_reply_to":"3f79a3b5_2263cbde","updated":"2018-08-07 13:32:13.000000000","message":"Done","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"},{"author":{"_account_id":13157,"name":"Zhao Chao","email":"zhaochao1984@gmail.com","username":"zhaochao"},"change_message_id":"e2765b24df2e8f837d72badebd604405c7c04f96","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            body[\"cluster\"][\"instances\"] \u003d instances"},{"line_number":52,"context_line":"        if locality:"},{"line_number":53,"context_line":"            body[\"cluster\"][\"locality\"] \u003d locality"},{"line_number":54,"context_line":"        if configuration:"},{"line_number":55,"context_line":"            body[\"cluster\"][\"configuration\"] \u003d configuration"},{"line_number":56,"context_line":"        if extended_properties:"},{"line_number":57,"context_line":"            body[\"cluster\"][\"extended_properties\"] \u003d extended_properties"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_426047cf","line":55,"range":{"start_line":54,"start_character":0,"end_line":55,"end_character":60},"updated":"2018-08-07 03:37:23.000000000","message":"The same as the ordering of arguments.","commit_id":"c6e0d567138bab06a8092333b09e77a23e3578c2"}],"troveclient/v1/shell.py":[{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a1a8d65ee6cdf192fe2622b8218cfb8b6b3eb1fc","unresolved":false,"context_lines":[{"line_number":883,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":884,"context_line":"           type\u003dstr,"},{"line_number":885,"context_line":"           default\u003dNone,"},{"line_number":886,"context_line":"           help\u003d_(\u0027ID of the configuration reference to attach.\u0027))"},{"line_number":887,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":888,"context_line":"def do_cluster_create(cs, args):"},{"line_number":889,"context_line":"    \"\"\"Creates a new cluster.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_903a37e5","line":886,"updated":"2018-08-06 11:57:13.000000000","message":"Consider reusing help message from instance API:\n\n ID of the configuration group to attach to the cluster.","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"8b10797a71971dc65089c31535193c1e6b16f8d9","unresolved":false,"context_lines":[{"line_number":883,"context_line":"           metavar\u003d\u0027\u003cconfiguration\u003e\u0027,"},{"line_number":884,"context_line":"           type\u003dstr,"},{"line_number":885,"context_line":"           default\u003dNone,"},{"line_number":886,"context_line":"           help\u003d_(\u0027ID of the configuration reference to attach.\u0027))"},{"line_number":887,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":888,"context_line":"def do_cluster_create(cs, args):"},{"line_number":889,"context_line":"    \"\"\"Creates a new cluster.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c34b0b85","line":886,"in_reply_to":"3f79a3b5_903a37e5","updated":"2018-08-06 12:30:51.000000000","message":"Done","commit_id":"e0a21f961b454daa739f05c4735138ea2c2255fc"}]}