)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"eb18287226f4f2d2c54ba99f8fe78c2a1caf7721","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-15 16:20:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to osc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_3a2252ba","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":42},"updated":"2018-08-15 17:59:20.000000000","message":"Uppercase or OpenStackClient.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"1eb0504a6787e9dcc13346f857fb6e949ff9d44d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-15 16:20:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to osc"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_25af8e2a","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":42},"in_reply_to":"3f79a3b5_3a2252ba","updated":"2018-08-16 01:59:34.000000000","message":"Done","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"eb18287226f4f2d2c54ba99f8fe78c2a1caf7721","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"},{"line_number":11,"context_line":"to osc, user can pass configuration and extended_properties during"},{"line_number":12,"context_line":"\"openstack database cluster create\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.openstack.org/#/c/583125/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_fa27fac5","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":6},"updated":"2018-08-15 17:59:20.000000000","message":"ditto.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"1eb0504a6787e9dcc13346f857fb6e949ff9d44d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"},{"line_number":11,"context_line":"to osc, user can pass configuration and extended_properties during"},{"line_number":12,"context_line":"\"openstack database cluster create\"."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] https://review.openstack.org/#/c/583125/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_c5a9fa23","line":11,"range":{"start_line":11,"start_character":3,"end_line":11,"end_character":6},"in_reply_to":"3f79a3b5_fa27fac5","updated":"2018-08-16 01:59:34.000000000","message":"Done","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"7ba32c911098d84cbf1c6d08d965286ee373971b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-16 09:56:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to OSC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3202150d","line":7,"updated":"2018-08-20 21:29:02.000000000","message":"What would you say for a more specific commit message eg:\n\n \"Add configuration and extended properties to cluster OSC\"","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"6ba46981e7ecda8e69d810589ea0cd7fa126478e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-16 09:56:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to OSC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_635f5ae5","line":7,"in_reply_to":"3f79a3b5_146ee295","updated":"2018-08-21 09:17:44.000000000","message":"Right, proposed message is too long. What about:\n\n \"Update cluster create parameters in OSC\"\n\nAt least let\u0027s try to emphasize that the change applies to cluster create API.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"d54ee6cb0d01b78f04ba97a502ac07ab6a3b0bde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-16 09:56:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to OSC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_146ee295","line":7,"in_reply_to":"3f79a3b5_3202150d","updated":"2018-08-21 02:35:10.000000000","message":"The example message exceed the limit of length. Consider the limitation,  I change to \"Sync two parameters of cluster-create to OSC\", just specify the two parameters  in the description below, what do you think.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"a9534473c4c032191946f8da27ace3909b7c8128","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-16 09:56:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to OSC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_cef2129b","line":7,"in_reply_to":"3f79a3b5_4bffd466","updated":"2018-08-21 11:53:30.000000000","message":"Sorry, I was looking at the previous patch set. Current message is OK.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6dab917f0d2cc5c44e9b9076fd46c7d8f3c8910a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanggang \u003czhanggang@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-08-16 09:56:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Sync two instance create parameters to OSC"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The previous patches have add configuration and extended_properties"},{"line_number":10,"context_line":"to \"trove cluster-create\"[1][2], this commit add the two paramenters"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_4bffd466","line":7,"in_reply_to":"3f79a3b5_635f5ae5","updated":"2018-08-21 11:37:53.000000000","message":"Well, I\u0027m not sure if you noticed that I have changed the commit message in patch set 3.\nI think  \"Sync two parameters of cluster-create to OSC\" has emphasize the change is applied to cluster create of OSC.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"}],"troveclient/osc/v1/database_clusters.py":[{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"eb18287226f4f2d2c54ba99f8fe78c2a1caf7721","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def take_action(self, parsed_args):"},{"line_number":186,"context_line":"        database \u003d self.app.client_manager.database"},{"line_number":187,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":188,"context_line":"        extended_properties \u003d {}"},{"line_number":189,"context_line":"        if parsed_args.extended_properties:"},{"line_number":190,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":191,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":192,"context_line":"                                       parsed_args.extended_properties"},{"line_number":193,"context_line":"                                       .split(\",\")]])"},{"line_number":194,"context_line":"        cluster \u003d database.clusters.create("},{"line_number":195,"context_line":"            parsed_args.name,"},{"line_number":196,"context_line":"            parsed_args.datastore,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1a8bd6c2","line":193,"range":{"start_line":188,"start_character":0,"end_line":193,"end_character":53},"updated":"2018-08-15 17:59:20.000000000","message":"We could move this logic to separate method.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"394c75a39b477f655a2fad772cd04393b8a3f13a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def take_action(self, parsed_args):"},{"line_number":186,"context_line":"        database \u003d self.app.client_manager.database"},{"line_number":187,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":188,"context_line":"        extended_properties \u003d {}"},{"line_number":189,"context_line":"        if parsed_args.extended_properties:"},{"line_number":190,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":191,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":192,"context_line":"                                       parsed_args.extended_properties"},{"line_number":193,"context_line":"                                       .split(\",\")]])"},{"line_number":194,"context_line":"        cluster \u003d database.clusters.create("},{"line_number":195,"context_line":"            parsed_args.name,"},{"line_number":196,"context_line":"            parsed_args.datastore,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_dc430f3e","line":193,"range":{"start_line":188,"start_character":0,"end_line":193,"end_character":53},"in_reply_to":"3f79a3b5_058b72c2","updated":"2018-08-16 07:38:04.000000000","message":"Right. I don\u0027t have strong opinion on this.\nLet\u0027s leave it as it.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"1eb0504a6787e9dcc13346f857fb6e949ff9d44d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def take_action(self, parsed_args):"},{"line_number":186,"context_line":"        database \u003d self.app.client_manager.database"},{"line_number":187,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":188,"context_line":"        extended_properties \u003d {}"},{"line_number":189,"context_line":"        if parsed_args.extended_properties:"},{"line_number":190,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":191,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":192,"context_line":"                                       parsed_args.extended_properties"},{"line_number":193,"context_line":"                                       .split(\",\")]])"},{"line_number":194,"context_line":"        cluster \u003d database.clusters.create("},{"line_number":195,"context_line":"            parsed_args.name,"},{"line_number":196,"context_line":"            parsed_args.datastore,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_058b72c2","line":193,"range":{"start_line":188,"start_character":0,"end_line":193,"end_character":53},"in_reply_to":"3f79a3b5_1a8bd6c2","updated":"2018-08-16 01:59:34.000000000","message":"Thanks review. \nAbout this， I have some different considerations. First, this logic is very simple actually, we could even make this within one line if we haven\u0027t a limitation of line length. Second, I think your consideration is move this to a method and reuse the method in here and troveclient/v1/shell.py, but consider the first point, I don\u0027t think it\u0027s worth to import the method and pass a args object to.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"7ba32c911098d84cbf1c6d08d965286ee373971b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from troveclient.v1.shell import INSTANCE_METAVAR"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def set_attributes_for_print_detail(cluster):"},{"line_number":29,"context_line":"    info \u003d cluster._info.copy()"},{"line_number":30,"context_line":"    if hasattr(cluster, \u0027datastore\u0027):"},{"line_number":31,"context_line":"        info[\u0027datastore\u0027] \u003d cluster.datastore[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1280398b","line":28,"updated":"2018-08-20 21:29:02.000000000","message":"By the way we could add configuration ID to cluster details.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"d54ee6cb0d01b78f04ba97a502ac07ab6a3b0bde","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from troveclient.v1.shell import INSTANCE_METAVAR"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def set_attributes_for_print_detail(cluster):"},{"line_number":29,"context_line":"    info \u003d cluster._info.copy()"},{"line_number":30,"context_line":"    if hasattr(cluster, \u0027datastore\u0027):"},{"line_number":31,"context_line":"        info[\u0027datastore\u0027] \u003d cluster.datastore[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_542a1a2c","line":28,"in_reply_to":"3f79a3b5_1280398b","updated":"2018-08-21 02:35:10.000000000","message":"Currently, the output of some other commands like cluster-show, cluster-list(both trove command and OSC command) also lack the configuration parameters. \nBesides, the output also lack of fields like \"locality\". \n\nMaybe we could consider the output of some cluster-related commands as a new patch.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"6ba46981e7ecda8e69d810589ea0cd7fa126478e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from troveclient.v1.shell import INSTANCE_METAVAR"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"def set_attributes_for_print_detail(cluster):"},{"line_number":29,"context_line":"    info \u003d cluster._info.copy()"},{"line_number":30,"context_line":"    if hasattr(cluster, \u0027datastore\u0027):"},{"line_number":31,"context_line":"        info[\u0027datastore\u0027] \u003d cluster.datastore[\u0027type\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_c398ae76","line":28,"in_reply_to":"3f79a3b5_542a1a2c","updated":"2018-08-21 09:17:44.000000000","message":"Good point. Let\u0027s extend cluster details in separate change.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"7ba32c911098d84cbf1c6d08d965286ee373971b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                   \u0027Choose one of %(choices)s.\u0027),"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--extended_properties\u0027,"},{"line_number":172,"context_line":"            metavar\u003dEXT_PROPS_METAVAR,"},{"line_number":173,"context_line":"            default\u003dNone,"},{"line_number":174,"context_line":"            help\u003dEXT_PROPS_HELP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d2ef2185","line":171,"updated":"2018-08-20 21:29:02.000000000","message":"According to global OpenStack CLI guidelines [1] long command options should be delimited by hyphen \u0027-\u0027 instead of \u0027_\u0027 underscore:\n\n\u003e All long options names begin with two dashes (--) and use a single dash (-) internally between words (--like-this). Underscores (_) are not used in option names.\n\nThere is a strong inconsistency in applying this convention within the project.\n\n[1] https://docs.openstack.org/python-openstackclient/latest/cli/commands.html","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"6ba46981e7ecda8e69d810589ea0cd7fa126478e","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                   \u0027Choose one of %(choices)s.\u0027),"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--extended_properties\u0027,"},{"line_number":172,"context_line":"            metavar\u003dEXT_PROPS_METAVAR,"},{"line_number":173,"context_line":"            default\u003dNone,"},{"line_number":174,"context_line":"            help\u003dEXT_PROPS_HELP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_085a454f","line":171,"in_reply_to":"3f79a3b5_94a3d2b1","updated":"2018-08-21 09:17:44.000000000","message":"Definitely, we should follow global CLI guideline on this.\n\nIf you could improve the convention in other places as a separate change, it would significantly improve the quality of our client. That would be really great.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"d54ee6cb0d01b78f04ba97a502ac07ab6a3b0bde","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                   \u0027Choose one of %(choices)s.\u0027),"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--extended_properties\u0027,"},{"line_number":172,"context_line":"            metavar\u003dEXT_PROPS_METAVAR,"},{"line_number":173,"context_line":"            default\u003dNone,"},{"line_number":174,"context_line":"            help\u003dEXT_PROPS_HELP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_94a3d2b1","line":171,"in_reply_to":"3f79a3b5_d2ef2185","updated":"2018-08-21 02:35:10.000000000","message":"Good catch, thanks.\nI check the current trove OSC commands, some parameters have the same problems \nlike \"--datastore_version\", \"--include_clustered\". About \"include_clustered\", \nit accept two format--\"--include_clustered\" and \"--include-clustered\", \nthe help messages says \" --include-clustered may be deprecated in the future, retaining just --include_clustered.\", \nwhich is contradict with the docs say. But I think the doc is more official, \nso I\u0027d like to  fix the extended properties in this patch and fix the others as a new patch.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"7ba32c911098d84cbf1c6d08d965286ee373971b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":188,"context_line":"        extended_properties \u003d {}"},{"line_number":189,"context_line":"        if parsed_args.extended_properties:"},{"line_number":190,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":191,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":192,"context_line":"                                       parsed_args.extended_properties"},{"line_number":193,"context_line":"                                       .split(\",\")]])"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_2d72ba4a","line":190,"updated":"2018-08-20 21:29:02.000000000","message":"One thought about future refactoring: we could reuse _strip_option function from v1/shell module. It is ready to re-use except that error messages are focused on instance API.","commit_id":"862124a805f276cc30ce533785ae7ee6847d315a"},{"author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"change_message_id":"6ba46981e7ecda8e69d810589ea0cd7fa126478e","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":189,"context_line":"        extended_properties \u003d {}"},{"line_number":190,"context_line":"        if parsed_args.extended_properties:"},{"line_number":191,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":192,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":193,"context_line":"                                       parsed_args.extended_properties"},{"line_number":194,"context_line":"                                       .split(\",\")]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_556f71c4","line":191,"updated":"2018-08-21 09:17:44.000000000","message":"I support Marcin\u0027s position that this logic could be elevated to a separate function. The logic, although it can be implemented as one-liner, is not trivial because it contains a nested loop and multiple splits.\n\nConsider moving the logic to a function, for example \"parse_extended_properties\", put it in module v1/shell, and then import in the same way as importing the \"_parse_instance_options\" function.\n\nI don\u0027t find importing functions from the v1/shell module to be the best approach, but it is the right solution at the moment to avoid violating the DRY principle. Some day we can think of transferring common methods from v1/shell to another module, eg v1/common or v1/helpers.","commit_id":"1d1cec562f8170c4a6f58d402406752e3dc69b81"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"6dab917f0d2cc5c44e9b9076fd46c7d8f3c8910a","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        instances \u003d _parse_instance_options(database, parsed_args.instances)"},{"line_number":189,"context_line":"        extended_properties \u003d {}"},{"line_number":190,"context_line":"        if parsed_args.extended_properties:"},{"line_number":191,"context_line":"            extended_properties \u003d dict([(k, v) for (k, v) in"},{"line_number":192,"context_line":"                                       [kv.strip().split(\"\u003d\") for kv in"},{"line_number":193,"context_line":"                                       parsed_args.extended_properties"},{"line_number":194,"context_line":"                                       .split(\",\")]])"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_ebdee0d8","line":191,"in_reply_to":"3f79a3b5_556f71c4","updated":"2018-08-21 11:37:53.000000000","message":"I think you\u0027ve convinced me with the last words. Will put the code into a separate method for future possibly improvement.","commit_id":"1d1cec562f8170c4a6f58d402406752e3dc69b81"}],"troveclient/tests/osc/v1/test_database_clusters.py":[{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"eb18287226f4f2d2c54ba99f8fe78c2a1caf7721","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        args \u003d [\u0027test-name\u0027, \u0027vertica\u0027, \u00277.1\u0027,"},{"line_number":146,"context_line":"                \u0027--instance\u0027, instances[0],"},{"line_number":147,"context_line":"                \u0027--instance\u0027, instances[1],"},{"line_number":148,"context_line":"                \u0027--extended_properties\u0027, \u0027foo_properties\u003d3\u0027,"},{"line_number":149,"context_line":"                \u0027--configuration\u0027, \u0027config01\u0027]"},{"line_number":150,"context_line":"        verifylist \u003d ["},{"line_number":151,"context_line":"            (\u0027name\u0027, \u0027test-name\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9aba86be","line":148,"range":{"start_line":148,"start_character":42,"end_line":148,"end_character":58},"updated":"2018-08-15 17:59:20.000000000","message":"It would be better to use variable here instead of string literal, and initialize it just before parsed_extended_properties dict. Similar to instances and parsed_instances.\n\nIt will to kept in place all properties-related values.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"1eb0504a6787e9dcc13346f857fb6e949ff9d44d","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        args \u003d [\u0027test-name\u0027, \u0027vertica\u0027, \u00277.1\u0027,"},{"line_number":146,"context_line":"                \u0027--instance\u0027, instances[0],"},{"line_number":147,"context_line":"                \u0027--instance\u0027, instances[1],"},{"line_number":148,"context_line":"                \u0027--extended_properties\u0027, \u0027foo_properties\u003d3\u0027,"},{"line_number":149,"context_line":"                \u0027--configuration\u0027, \u0027config01\u0027]"},{"line_number":150,"context_line":"        verifylist \u003d ["},{"line_number":151,"context_line":"            (\u0027name\u0027, \u0027test-name\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_85c0e2e2","line":148,"range":{"start_line":148,"start_character":42,"end_line":148,"end_character":58},"in_reply_to":"3f79a3b5_9aba86be","updated":"2018-08-16 01:59:34.000000000","message":"Done","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"change_message_id":"eb18287226f4f2d2c54ba99f8fe78c2a1caf7721","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            (\u0027datastore\u0027, \u0027vertica\u0027),"},{"line_number":153,"context_line":"            (\u0027datastore_version\u0027, \u00277.1\u0027),"},{"line_number":154,"context_line":"            (\u0027instances\u0027, instances),"},{"line_number":155,"context_line":"            (\u0027extended_properties\u0027, \u0027foo_properties\u003d3\u0027),"},{"line_number":156,"context_line":"            (\u0027configuration\u0027, \u0027config01\u0027),"},{"line_number":157,"context_line":"        ]"},{"line_number":158,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, args, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1afc366e","line":155,"range":{"start_line":155,"start_character":37,"end_line":155,"end_character":53},"updated":"2018-08-15 17:59:20.000000000","message":"ditto.","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"},{"author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"change_message_id":"1eb0504a6787e9dcc13346f857fb6e949ff9d44d","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            (\u0027datastore\u0027, \u0027vertica\u0027),"},{"line_number":153,"context_line":"            (\u0027datastore_version\u0027, \u00277.1\u0027),"},{"line_number":154,"context_line":"            (\u0027instances\u0027, instances),"},{"line_number":155,"context_line":"            (\u0027extended_properties\u0027, \u0027foo_properties\u003d3\u0027),"},{"line_number":156,"context_line":"            (\u0027configuration\u0027, \u0027config01\u0027),"},{"line_number":157,"context_line":"        ]"},{"line_number":158,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, args, verifylist)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a5c39eec","line":155,"range":{"start_line":155,"start_character":37,"end_line":155,"end_character":53},"in_reply_to":"3f79a3b5_1afc366e","updated":"2018-08-16 01:59:34.000000000","message":"Done","commit_id":"4c5610521a1b83b15a6d59d87a5731a01cf844a9"}]}
