)]}'
{"id":"openstack%2Fpython-troveclient~597447","triplet_id":"openstack%2Fpython-troveclient~master~I70b42a1988b2f1110c9ad946246fe5b03c76080c","project":"openstack/python-troveclient","branch":"master","topic":"follow-openstack-cli-command-format","hashtags":[],"change_id":"I70b42a1988b2f1110c9ad946246fe5b03c76080c","subject":"Follow the OpenStackClient options names format","status":"NEW","created":"2018-08-29 10:50:57.000000000","updated":"2018-09-20 12:10:36.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"79816f6e331e2428c3decf215d0d2db644763355","_number":597447,"virtual_id_number":597447,"owner":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},{"value":1,"date":"2018-08-29 13:20:35.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"all":[{"value":-1,"date":"2018-09-20 12:10:36.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-08-29 13:20:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2018-09-20 12:10:36.000000000","updated_by":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"reviewer":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"state":"REVIEWER"}],"messages":[{"id":"e3d93a92cc5d2dea7c7655e3042b5ac1746ee3c5","author":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"date":"2018-08-29 10:50:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1e1c3b752526db0d25124aeb96f71ece2f4d814b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-08-29 13:20:35.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- build-openstack-sphinx-docs http://logs.openstack.org/47/597447/1/check/build-openstack-sphinx-docs/1a3ac51/html/ : SUCCESS in 4m 27s\n- openstack-tox-pep8 http://logs.openstack.org/47/597447/1/check/openstack-tox-pep8/a9f7b52/ : SUCCESS in 3m 47s\n- openstack-tox-py27 http://logs.openstack.org/47/597447/1/check/openstack-tox-py27/764a8c3/ : SUCCESS in 4m 48s\n- openstack-tox-py35 http://logs.openstack.org/47/597447/1/check/openstack-tox-py35/1f565f5/ : SUCCESS in 4m 30s\n- openstackclient-check-plugins http://logs.openstack.org/47/597447/1/check/openstackclient-check-plugins/37bacf2/ : SUCCESS in 5m 22s (non-voting)\n- trove-functional-mysql http://logs.openstack.org/47/597447/1/check/trove-functional-mysql/6022d4c/ : SUCCESS in 2h 23m 56s\n- python-troveclient-tempest-neutron-src http://logs.openstack.org/47/597447/1/check/python-troveclient-tempest-neutron-src/32ff59d/ : SUCCESS in 1h 59m 50s\n- openstack-tox-lower-constraints http://logs.openstack.org/47/597447/1/check/openstack-tox-lower-constraints/1961efd/ : SUCCESS in 4m 56s","accounts_in_message":[],"_revision_number":1},{"id":"66078e7df8cff6444b04fe2accf8f0d86a151783","author":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"},"date":"2018-09-20 12:10:36.000000000","message":"Patch Set 1: Code-Review-1\n\nThank you for working on this.\n\nIn my opinion we should be more careful with this change since people are using Trove CLI out there and may be surprised if we suddenly reformat multiple options at once without warning.\n\nTo make things right we should follow a deprecation cycle, however, couldn\u0027t find any global guidance on this in OpenStack documentation except [1]. Deprecation changes introduced in Cinder [2] and Nova [3][4] clients may be treated as potential reference.\n\nThis is what I propose for current release as a bare minimum:\n\n1. Keep both options with hyphens and with underscores (in places they occurred).\n2. Add deprecation warning in help messages for each reformatted option, e.g.\n\n \"--include_clustered will be deprecated in the future, retaining just --include-clustered\"\n\n3. List all deprecated options in release notes.\n\nBesides, it would be appropriate to print warning when deprecated options is used. Don\u0027t have idea about how this could be implemented since argparse doesn\u0027t support deprecations natively. Found [3-5] as starting point.\n\nIn the subsequent release we will remove deprecated options.\n\n[1] https://docs.openstack.org/python-novaclient/latest/reference/deprecation-policy.html\n[2] https://github.com/openstack/python-cinderclient/commit/a331f06df0158fff28162eabc765f164855afcee\n[3] https://github.com/openstack/python-novaclient/commit/3a762401245de8c2941ea41d6168c17ddd30aacd#diff-605f69d42c31b38095700b22171fbd6a\n[4] https://github.com/openstack/python-novaclient/blob/2e6ef0c45a6ada10440eb0ce87df74bf7070c1e4/novaclient/shell.py#L57\n[5] https://github.com/openstack/osc-lib/blob/master/osc_lib/command/command.py#L50","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0229bc6b41d199409e511ab9d2342957bb0e61f7","revisions":{"0229bc6b41d199409e511ab9d2342957bb0e61f7":{"kind":"REWORK","_number":1,"created":"2018-08-29 10:50:57.000000000","uploader":{"_account_id":22608,"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","username":"zhanggang"},"ref":"refs/changes/47/597447/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/47/597447/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/597447/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/597447/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/47/597447/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/47/597447/1"}}},"commit":{"parents":[{"commit":"80ecbbc3379d30bc91b2a2f06fc4fbaf84ab6a3f","subject":"Merge \"Update reno for stable/rocky\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/80ecbbc3379d30bc91b2a2f06fc4fbaf84ab6a3f"}]}],"author":{"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","date":"2018-08-29 10:47:44.000000000","tz":480},"committer":{"name":"zhanggang","email":"zhanggang@cmss.chinamobile.com","date":"2018-08-29 10:47:44.000000000","tz":480},"subject":"Follow the OpenStackClient options names format","message":"Follow the OpenStackClient options names format\n\nAccording to global OpenStack CLI guidelines [1], all long options names\nbegin with two dashes (--) and use a single dash (-) internally between\nwords (--like-this). Underscores (_) are not used in option names.\n\n[1] https://docs.openstack.org/python-openstackclient/latest/cli/commands.html\n\nChange-Id: I70b42a1988b2f1110c9ad946246fe5b03c76080c\nSigned-off-by: zhanggang \u003czhanggang@cmss.chinamobile.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0229bc6b41d199409e511ab9d2342957bb0e61f7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/0229bc6b41d199409e511ab9d2342957bb0e61f7"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":28695,"name":"Bartosz Zurkowski","email":"b.zurkowski@samsung.com","username":"b.zurkowski"}},{"label":"Workflow","status":"MAY"},{"label":"Backport-Candidate","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Backport-Candidate","description":"Backport candidate status","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}