)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"deefe6d508ef55f4f095401844b309507a0ce2b3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Shestakov \u003cashestakov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 23:28:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support of neutron NICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug: #1257838"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F86bE%3D","line":7,"updated":"2013-12-18 21:34:29.000000000","message":"poor commit description.\nwould be nice to see:\n1. Problem/Reasons\n2. Changes (full description)","commit_id":"d1be5e421ecd9a3d48ec758b4cbefbdab614e5ea"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"3a8f70897f328df8d1b36918166ac2c4a362a9e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Andrey Shestakov \u003cashestakov@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-12-18 23:28:30 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support of neutron NICs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug: #1257838"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F80%2F4%3D","line":7,"in_reply_to":"AAAATn%2F86bE%3D","updated":"2013-12-19 20:58:30.000000000","message":"It doesnt need an exact format, please see this page for better examles.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"d1be5e421ecd9a3d48ec758b4cbefbdab614e5ea"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"8a3c4c9d5ada982388388208c1e3905694872280","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Syntax to specify \u0027--nic\u0027 parameter is same as in novaclient."},{"line_number":14,"context_line":"--nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,port-id\u003dport-uuid\u003e"},{"line_number":15,"context_line":"This parameter can be specified multiple times, to attach multiple network interfaces to instance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug: #1257838"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2FEag%3D","line":15,"updated":"2014-01-17 18:57:06.000000000","message":"Please wrap lines at 72 characters for commit messages.\nRefer to: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"8c01244ede01b2e32ece4a0354c221c6eaf763be","unresolved":false,"context_lines":[{"line_number":14,"context_line":"--nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,port-id\u003dport-uuid\u003e"},{"line_number":15,"context_line":"This parameter can be specified multiple times, to attach multiple network interfaces to instance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug: #1257838"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I76fb0d99512b1ee70441c924835a900ba0b7acd1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAT3%2F%2F8qk%3D","line":17,"updated":"2013-12-26 14:11:42.000000000","message":"Closes-Bug","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"8a3c4c9d5ada982388388208c1e3905694872280","unresolved":false,"context_lines":[{"line_number":14,"context_line":"--nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,port-id\u003dport-uuid\u003e"},{"line_number":15,"context_line":"This parameter can be specified multiple times, to attach multiple network interfaces to instance."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug: #1257838"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I76fb0d99512b1ee70441c924835a900ba0b7acd1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAUH%2F%2FEbI%3D","line":17,"updated":"2014-01-17 18:57:06.000000000","message":"Yes, please use \"Closes-Bug\" as outlined at https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"}],"troveclient/tests/test_instances.py":[{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"8a3c4c9d5ada982388388208c1e3905694872280","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return path, body, inst"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.instances._create \u003d mock.Mock(side_effect\u003dside_effect_func)"},{"line_number":92,"context_line":"        nics \u003d [{\u0027net-id\u0027: \u0027000\u0027}]"},{"line_number":93,"context_line":"        p, b, i \u003d self.instances.create(\"test-name\", 103, \"test-volume\","},{"line_number":94,"context_line":"                                        [\u0027db1\u0027, \u0027db2\u0027], [\u0027u1\u0027, \u0027u2\u0027],"},{"line_number":95,"context_line":"                                        datastore\u003d\"datastore\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FEZ0%3D","line":92,"updated":"2014-01-17 18:57:06.000000000","message":"Should we add a test for the new optional parameters we are introducing as well?\n(v4-fixed-ip, and port-id)","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"67854e30ea63bcbe8fcb2349ef31341f120d7363","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            return path, body, inst"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        self.instances._create \u003d mock.Mock(side_effect\u003dside_effect_func)"},{"line_number":92,"context_line":"        nics \u003d [{\u0027net-id\u0027: \u0027000\u0027}]"},{"line_number":93,"context_line":"        p, b, i \u003d self.instances.create(\"test-name\", 103, \"test-volume\","},{"line_number":94,"context_line":"                                        [\u0027db1\u0027, \u0027db2\u0027], [\u0027u1\u0027, \u0027u2\u0027],"},{"line_number":95,"context_line":"                                        datastore\u003d\"datastore\","}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FESY%3D","line":92,"in_reply_to":"AAAAUH%2F%2FEZ0%3D","updated":"2014-01-17 19:04:33.000000000","message":"i think doesnt matter, in this test we just asserts NICs object in Server object. no sense to test content of NICs. it passes to nova as is.","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"}],"troveclient/v1/shell.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"bbc62954dfa1b55522581b224b6ea6f6c30cbcd1","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if not nic_info[\u0027net-id\u0027] and not nic_info[\u0027port-id\u0027]:"},{"line_number":210,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        nics.append(nic_info)"},{"line_number":213,"context_line":"    instance \u003d cs.instances.create(args.name,"},{"line_number":214,"context_line":"                                   args.flavor_id,"},{"line_number":215,"context_line":"                                   volume\u003dvolume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F9UaA%3D","line":212,"updated":"2013-12-12 17:47:08.000000000","message":"https://gist.github.com/hub-cap/7932241\n\nI think this could be cleaned up a bit","commit_id":"e3b6889ebb90e397b83f4ff5be32de662ade5ac4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"15d44530e8974d35ff8c20e8371c7300d5c97742","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        if not nic_info[\u0027net-id\u0027] and not nic_info[\u0027port-id\u0027]:"},{"line_number":210,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        nics.append(nic_info)"},{"line_number":213,"context_line":"    instance \u003d cs.instances.create(args.name,"},{"line_number":214,"context_line":"                                   args.flavor_id,"},{"line_number":215,"context_line":"                                   volume\u003dvolume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F89Vk%3D","line":212,"in_reply_to":"AAAATn%2F9UaA%3D","updated":"2013-12-18 12:09:00.000000000","message":"dict(...) is too slow","commit_id":"e3b6889ebb90e397b83f4ff5be32de662ade5ac4"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"deefe6d508ef55f4f095401844b309507a0ce2b3","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                   \"form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":195,"context_line":"                   \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""},{"line_number":196,"context_line":"                   \"specified.\" % nic_str)"},{"line_number":197,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\")[:2] for z in"},{"line_number":198,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":199,"context_line":"        if not nic_info.get(\u0027net-id\u0027) and not nic_info.get(\u0027port-id\u0027):"},{"line_number":200,"context_line":"            raise exceptions.CommandError(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F86aw%3D","line":197,"updated":"2013-12-18 21:34:29.000000000","message":"dict() is to slow, do we really need it here?\nprevious solution was not bad at all.","commit_id":"d1be5e421ecd9a3d48ec758b4cbefbdab614e5ea"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"3a8f70897f328df8d1b36918166ac2c4a362a9e0","unresolved":false,"context_lines":[{"line_number":194,"context_line":"                   \"form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":195,"context_line":"                   \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""},{"line_number":196,"context_line":"                   \"specified.\" % nic_str)"},{"line_number":197,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\")[:2] for z in"},{"line_number":198,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":199,"context_line":"        if not nic_info.get(\u0027net-id\u0027) and not nic_info.get(\u0027port-id\u0027):"},{"line_number":200,"context_line":"            raise exceptions.CommandError(err_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F81AI%3D","line":197,"in_reply_to":"AAAATn%2F86aw%3D","updated":"2013-12-19 20:58:30.000000000","message":"denis please define slow. We are talking about a dict of up to 3 tuples. i doubt you would notice a \"speedup\"","commit_id":"d1be5e421ecd9a3d48ec758b4cbefbdab614e5ea"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"f1acdba86e237bef5be361710e48876d8e92cd42","unresolved":false,"context_lines":[{"line_number":190,"context_line":"             [z.split(\u0027:\u0027)[:2] for z in args.users]]"},{"line_number":191,"context_line":"    nics \u003d []"},{"line_number":192,"context_line":"    for nic_str in args.nics:"},{"line_number":193,"context_line":"        err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of the \""},{"line_number":194,"context_line":"                   \"form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":195,"context_line":"                   \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""},{"line_number":196,"context_line":"                   \"specified.\" % nic_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2Bsbo%3D","line":193,"updated":"2014-01-23 03:49:24.000000000","message":"Why do we build this string before we use it? Seems like we dont need it here but instead _in_ the if stmt.","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"},{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"f1acdba86e237bef5be361710e48876d8e92cd42","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                   \"specified.\" % nic_str)"},{"line_number":197,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\")[:2] for z in"},{"line_number":198,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":199,"context_line":"        if not nic_info.get(\u0027net-id\u0027) and not nic_info.get(\u0027port-id\u0027):"},{"line_number":200,"context_line":"            raise exceptions.CommandError(err_msg)"},{"line_number":201,"context_line":"        nics.append(nic_info)"},{"line_number":202,"context_line":"    instance \u003d cs.instances.create(args.name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2BsbE%3D","line":199,"updated":"2014-01-23 03:49:24.000000000","message":"this is not easy to read. it me, itd be easier to say if ! (X or Y), then good, otherwise fail. I mean its the same, but to most programmers brains they can injest ! (X or Y) vs (!X and !Y).","commit_id":"1d15fb27c5b3261b79d88fe345497c325fdb12d2"},{"author":{"_account_id":694,"name":"Tim Simpson","email":"tim.simpson@rackspace.com","username":"tim-simpson"},"change_message_id":"e93d50e2ad43b10ab99cddc5ff6fd671a79cbb6b","unresolved":false,"context_lines":[{"line_number":198,"context_line":"             [z.split(\u0027:\u0027)[:2] for z in args.users]]"},{"line_number":199,"context_line":"    nics \u003d []"},{"line_number":200,"context_line":"    for nic_str in args.nics:"},{"line_number":201,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\")[:2] for z in"},{"line_number":202,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":203,"context_line":"        if not (nic_info.get(\u0027net-id\u0027) or nic_info.get(\u0027port-id\u0027)):"},{"line_number":204,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BN5w%3D","line":201,"updated":"2014-01-28 23:55:25.000000000","message":"Change \u0027z.split(\"\u003d\")[:2]\u0027 to \u0027z.split(\"\u003d\", 1)\u0027. Currently if the value was something like \"a\u003d2\u003d3\" the expression would change it to the tuple \"a\", \"2\" instead of \"a\", \"2\u003d3\".\n\nIf the user shouldn\u0027t be allowed to use equals twice they should see an error message.","commit_id":"5c5a5c2c5daab853878c5fb589f2fd0e7f864ccb"}]}