)]}'
{"troveclient/v1/shell.py":[{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"8e9d858e566378da63c3a3f7e340af3686d0d7bf","unresolved":false,"context_lines":[{"line_number":114,"context_line":"def do_show(cs, args):"},{"line_number":115,"context_line":"    \"\"\"Show details of an instance.\"\"\""},{"line_number":116,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":117,"context_line":"    instance._info[\u0027flavor\u0027] \u003d instance.flavor[\u0027id\u0027]"},{"line_number":118,"context_line":"    if hasattr(instance, \u0027ip\u0027):"},{"line_number":119,"context_line":"        instance._info[\u0027ip\u0027] \u003d \u0027, \u0027.join(instance.ip)"},{"line_number":120,"context_line":"    _print_instance(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FhQc%3D","line":117,"updated":"2014-01-12 23:22:00.000000000","message":"this changes:\n\n    |       status      |                ACTIVE                |\n    |      updated      |         2014-01-12T22:17:20          |\n    |       volume      |                  1                   |\n    +-------------------+--------------------------------------+\n\nto:\n\n    |       status      |                ACTIVE                |\n    |      updated      |         2014-01-12T22:17:20          |\n    |       volume      |     {u\u0027used\u0027: 0.13, u\u0027size\u0027: 1}      |\n    +-------------------+--------------------------------------+\n\ndicts should be avoided in trove-show, and considering that \u0027volume\u0027\nhas been around for quite some time, the better option is:\n\n    |       status      |                ACTIVE                |\n    |      updated      |         2014-01-12T22:17:20          |\n    |       volume      |                  1                   |\n    |    volume_used    |                 0.13                 |\n    +-------------------+--------------------------------------+","commit_id":"b2988eda0175e4bb132aa13d1730436a956d45e2"},{"author":{"_account_id":7806,"name":"Sushil Kumar","email":"skm.net@gmail.com","username":"sushilkm"},"change_message_id":"47e9d5eb1decc95a0e7081de8ed9feb3d616054d","unresolved":false,"context_lines":[{"line_number":114,"context_line":"def do_show(cs, args):"},{"line_number":115,"context_line":"    \"\"\"Show details of an instance.\"\"\""},{"line_number":116,"context_line":"    instance \u003d _find_instance(cs, args.instance)"},{"line_number":117,"context_line":"    instance._info[\u0027flavor\u0027] \u003d instance.flavor[\u0027id\u0027]"},{"line_number":118,"context_line":"    if hasattr(instance, \u0027ip\u0027):"},{"line_number":119,"context_line":"        instance._info[\u0027ip\u0027] \u003d \u0027, \u0027.join(instance.ip)"},{"line_number":120,"context_line":"    _print_instance(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FgnY%3D","line":117,"in_reply_to":"AAAAUH%2F%2FhQc%3D","updated":"2014-01-13 06:38:05.000000000","message":"agreed and updated.","commit_id":"b2988eda0175e4bb132aa13d1730436a956d45e2"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"b21eea8afa834256b8903e4b458d4fa4cfcc0d12","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    instance._info[\u0027flavor\u0027] \u003d instance.flavor[\u0027id\u0027]"},{"line_number":118,"context_line":"    if hasattr(instance, \u0027volume\u0027):"},{"line_number":119,"context_line":"        instance._info[\u0027volume\u0027] \u003d instance.volume[\u0027size\u0027]"},{"line_number":120,"context_line":"        instance._info[\u0027volume_used\u0027] \u003d instance.volume[\u0027used\u0027]"},{"line_number":121,"context_line":"    if hasattr(instance, \u0027ip\u0027):"},{"line_number":122,"context_line":"        instance._info[\u0027ip\u0027] \u003d \u0027, \u0027.join(instance.ip)"},{"line_number":123,"context_line":"    _print_instance(instance)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FgnQ%3D","line":120,"updated":"2014-01-13 06:38:19.000000000","message":"volume[\u0027used\u0027] is not guaranteed to exist (example: if status is BUILD). you need to conditionally check for it.","commit_id":"2b21b0c921865320aa76f9733890e05291639670"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"604b7e38d84c9a5b6a32695f5e1483c808d96a84","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    instance._info[\u0027flavor\u0027] \u003d instance.flavor[\u0027id\u0027]"},{"line_number":118,"context_line":"    if hasattr(instance, \u0027volume\u0027):"},{"line_number":119,"context_line":"        instance._info[\u0027volume\u0027] \u003d instance.volume[\u0027size\u0027]"},{"line_number":120,"context_line":"        instance._info[\u0027volume_used\u0027] \u003d instance.volume.get(\u0027used\u0027, 0)"},{"line_number":121,"context_line":"    if hasattr(instance, \u0027ip\u0027):"},{"line_number":122,"context_line":"        instance._info[\u0027ip\u0027] \u003d \u0027, \u0027.join(instance.ip)"},{"line_number":123,"context_line":"    _print_instance(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FgI8%3D","line":120,"updated":"2014-01-13 09:19:03.000000000","message":"Instead of reporting a volume_used of 0 when the key doesn\u0027t exist, let\u0027s not report it at all.","commit_id":"729eb738399b8ac99bca5d06c4cb092e36a725bb"},{"author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"change_message_id":"5e648ee5387229c22e924a0a256e5269f91b9e80","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    instance._info[\u0027flavor\u0027] \u003d instance.flavor[\u0027id\u0027]"},{"line_number":118,"context_line":"    if hasattr(instance, \u0027volume\u0027):"},{"line_number":119,"context_line":"        instance._info[\u0027volume\u0027] \u003d instance.volume[\u0027size\u0027]"},{"line_number":120,"context_line":"        instance._info[\u0027volume_used\u0027] \u003d instance.volume.get(\u0027used\u0027, 0)"},{"line_number":121,"context_line":"    if hasattr(instance, \u0027ip\u0027):"},{"line_number":122,"context_line":"        instance._info[\u0027ip\u0027] \u003d \u0027, \u0027.join(instance.ip)"},{"line_number":123,"context_line":"    _print_instance(instance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FgIY%3D","line":120,"in_reply_to":"AAAAUH%2F%2FgI8%3D","updated":"2014-01-13 09:20:38.000000000","message":"agreed.","commit_id":"729eb738399b8ac99bca5d06c4cb092e36a725bb"}]}