)]}'
{"id":"openstack%2Fpython-troveclient~686373","triplet_id":"openstack%2Fpython-troveclient~stable%2Fstein~If85dff57afe110991553d510c6af4468a6781f64","project":"openstack/python-troveclient","branch":"stable/stein","topic":"python3-first-stable/stein","hashtags":[],"change_id":"If85dff57afe110991553d510c6af4468a6781f64","subject":"Add python3 compatibility for guest logs features","status":"MERGED","created":"2019-10-03 10:17:45.000000000","updated":"2019-10-03 21:08:48.000000000","submitted":"2019-10-03 21:06:43.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"686373-1570136803863-34c20870","meta_rev_id":"eb2eca1d40d429d8ab3edc35e4b66a655e0ee76a","_number":686373,"virtual_id_number":686373,"owner":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2019-10-03 21:06:43.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"all":[{"value":2,"date":"2019-10-03 20:56:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"all":[{"value":1,"date":"2019-10-03 20:56:47.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"date":"2019-10-03 19:07:56.000000000","_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-10-03 19:07:56.000000000","updated_by":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"reviewer":{"_account_id":28671,"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","username":"m.piwowarczy"},"state":"REVIEWER"},{"updated":"2019-10-03 21:06:43.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d08a614b4ade71ed3b19bcf0b6d01605832a020e","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-10-03 10:17:45.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"ba7bb831a46a3a2f43126f0cd86aafc0476fa7fb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 11:06:44.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f694b99245614915924184a81d065401 : SUCCESS in 3m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a8b9a9d2a39642d4827f6cdaee299de3 : SUCCESS in 2m 35s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/d9558e2378054cd794fa4c0dcc5021f5 : SUCCESS in 3m 17s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8b2305b026524c2a807759c2bc2f363f : SUCCESS in 3m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/66d53dea7e7f41b8abe2f893a06513b5 : SUCCESS in 3m 20s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/d32cbceb5ebd41118a923bf4b69d5688 : FAILURE in 5m 06s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91882d49fff64d3f861133c91de14c2a : SUCCESS in 4m 58s\n- python-troveclient-tempest-neutron-src https://zuul.opendev.org/t/openstack/build/6537ea67d7ff41f2ba4e19a9919fd5d9 : FAILURE in 32m 06s\n- trove-functional-mysql https://zuul.opendev.org/t/openstack/build/a42738bc2a6544c2b82b769e7b9647f9 : FAILURE in 38m 00s","accounts_in_message":[],"_revision_number":1},{"id":"292f533fb2687504747aac427f4f261edc8acff3","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-10-03 19:07:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e941717abe23d450a1892f0978c14ea35e0b83ab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 19:16:45.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0b05b9a759e3407291570e6c90f80d25 : SUCCESS in 3m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c06fa1859be442aea1e5bcf0328c7002 : SUCCESS in 2m 28s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f9d748e333ae47f68aa6c9f6d8c3fbfd : SUCCESS in 2m 52s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/8a72d90f2b4b4ec085d8d4c38a0293a5 : SUCCESS in 2m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5f30d6e519df43209a13c2b566605f1c : SUCCESS in 3m 17s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/f84b05a892b946efb0ade946b5e74046 : FAILURE in 3m 54s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0f9a2dafcd7f4c8baa0598f6dd7ea9b0 : SUCCESS in 3m 26s","accounts_in_message":[],"_revision_number":2},{"id":"7d6ba4baa87fb4cf267fb1afee781df0b030a53d","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2019-10-03 20:56:47.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"80905bcef8e598d3f41bdd6693bbe45a40d58eb7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 20:57:00.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"6d5ec38bb0eb994ff80e980987c65e1758b58a7f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 21:06:43.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e2186d17df494ee7b5264378decce945 : SUCCESS in 3m 26s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9164f67d99b54ffe938db8886f6aad47 : SUCCESS in 3m 18s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/3b2bbd6ff69741a1857ef9c82049764b : SUCCESS in 4m 05s\n- openstack-tox-py35 https://zuul.opendev.org/t/openstack/build/7b52d06f017640f482a33ada5bbb1baf : SUCCESS in 3m 47s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0fa9c2bdf85142f2b25e6fb1c1d26bc1 : SUCCESS in 2m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9daf691630334729928b8d0e6293d229 : SUCCESS in 3m 33s","accounts_in_message":[],"_revision_number":2},{"id":"df5c76ae93c70382d8a0cd88bc5d90364d6d5453","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 21:06:43.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"207ab3908992afb802ccb18799a4abf9e404e966","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-10-03 21:08:48.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9e7cf2ffb5f745328f8a2b64e96b9c91 : SUCCESS in 49s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c3d667971d7c48cd6e069851252e494962fc251a","revisions":{"8b85c9c6ab78731c10bd10dec9f339eb9c2af2af":{"kind":"REWORK","_number":1,"created":"2019-10-03 10:17:45.000000000","uploader":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"ref":"refs/changes/73/686373/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/686373/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/1"}}},"commit":{"parents":[{"commit":"7ac06f0e4b9cc540fdb9959be76e43e9c6bfe5df","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/7ac06f0e4b9cc540fdb9959be76e43e9c6bfe5df"}]}],"author":{"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","date":"2018-10-27 18:27:54.000000000","tz":120},"committer":{"name":"Lingxian Kong","email":"anlin.kong@gmail.com","date":"2019-10-03 10:17:45.000000000","tz":0},"subject":"Add python3 compatibility for guest logs features","message":"Add python3 compatibility for guest logs features\n\nDuring working with python3-first goals, I have notticed the\nlog_generator and log_save methods was non compliance with python3.\n\nThis is what doesn\u0027t appears in integration tests because we execute\nonly trove-functional-mysql job which doesn\u0027t covers guest-log tests.\n\nIn separate change I will extend zull definition by scenario tests to\navoid similar issues in future.\n\nChange-Id: If85dff57afe110991553d510c6af4468a6781f64\nSigned-off-by: Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e\n(cherry picked from commit dfba4159b8153dca0d237eff990d827dc3fc6321)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/8b85c9c6ab78731c10bd10dec9f339eb9c2af2af"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/8b85c9c6ab78731c10bd10dec9f339eb9c2af2af"}]},"branch":"refs/heads/stable/stein"},"c3d667971d7c48cd6e069851252e494962fc251a":{"kind":"REWORK","_number":2,"created":"2019-10-03 19:07:56.000000000","uploader":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"ref":"refs/changes/73/686373/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/73/686373/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/73/686373/2"}}},"commit":{"parents":[{"commit":"7ac06f0e4b9cc540fdb9959be76e43e9c6bfe5df","subject":"OpenDev Migration Patch","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/7ac06f0e4b9cc540fdb9959be76e43e9c6bfe5df"}]}],"author":{"name":"Marcin Piwowarczyk","email":"m.piwowarczy@samsung.com","date":"2018-10-27 18:27:54.000000000","tz":120},"committer":{"name":"Lingxian Kong","email":"anlin.kong@gmail.com","date":"2019-10-03 19:07:26.000000000","tz":780},"subject":"Add python3 compatibility for guest logs features","message":"Add python3 compatibility for guest logs features\n\nDuring working with python3-first goals, I have notticed the\nlog_generator and log_save methods was non compliance with python3.\n\nThis is what doesn\u0027t appears in integration tests because we execute\nonly trove-functional-mysql job which doesn\u0027t covers guest-log tests.\n\nIn separate change I will extend zull definition by scenario tests to\navoid similar issues in future.\n\nChange-Id: If85dff57afe110991553d510c6af4468a6781f64\nSigned-off-by: Marcin Piwowarczyk \u003cm.piwowarczy@samsung.com\u003e\n(cherry picked from commit dfba4159b8153dca0d237eff990d827dc3fc6321)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c3d667971d7c48cd6e069851252e494962fc251a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c3d667971d7c48cd6e069851252e494962fc251a"}]},"branch":"refs/heads/stable/stein"}},"requirements":[],"submit_records":[],"submit_requirements":[]}