)]}'
{"id":"openstack%2Fpython-troveclient~735768","triplet_id":"openstack%2Fpython-troveclient~master~I36a5d084e9e19294f6fe08fbde301107548c4177","project":"openstack/python-troveclient","branch":"master","hashtags":[],"change_id":"I36a5d084e9e19294f6fe08fbde301107548c4177","subject":"Fix save \u0026 tail log wrong type","status":"ABANDONED","created":"2020-06-16 04:26:46.000000000","updated":"2021-11-12 09:40:40.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"6308beefaac26001f38b89187505dd0fbd342f30","_number":735768,"virtual_id_number":735768,"owner":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-16 04:36:06.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-06-23 11:50:47.000000000","_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"date":"2020-07-09 23:43:34.000000000","_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-16 04:36:06.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-07-09 23:43:34.000000000","updated_by":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"reviewer":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"state":"REVIEWER"}],"messages":[{"id":"e844577dc72bb6a364cec23e305586ba2441d26f","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2020-06-16 04:26:46.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8175eb84cdab1f203ae9016bef67d81314820c1e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-16 04:36:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/442f565ef5b949eea84f2bfd52a44fc6 : SUCCESS in 3m 55s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/21b3f97c60014a949cec9eb905861742 : SUCCESS in 3m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0a38998539d94dcebf2dbe6d5f96f8fe : SUCCESS in 3m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/28a8a6da5816432599e7a99724072a09 : SUCCESS in 3m 56s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/4d2a516013d24d3a8f2aec38c46dc52b : FAILURE in 2m 21s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/31782cef94094267a18b6ac466cf2323 : SUCCESS in 3m 41s","accounts_in_message":[],"_revision_number":1},{"id":"f8b3991b18a8f370b14a4d86153ec1e5d8f2bf15","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-06-17 08:35:36.000000000","message":"Patch Set 1:\n\nHi I didn\u0027t see error when doing log save, see https://pasteboard.co/JdtIIEH.png","accounts_in_message":[],"_revision_number":1},{"id":"14e4586d4baeb8ed9a4e25f36fe4c90933ac9ca4","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2020-06-17 09:08:07.000000000","message":"Patch Set 1:\n\nAre you using python-troveclient? I\u0027m testing with python3-troveclient","accounts_in_message":[],"_revision_number":1},{"id":"722d97e11f049a4792f56a4091b717751a6e4345","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-06-23 10:13:14.000000000","message":"Patch Set 1:\n\n\u003e Are you using python-troveclient? I\u0027m testing with\n \u003e python3-troveclient\n\nI was installing python-troveclient by running \u0027python3.7 -m pip install python-troveclient\u0027, why are you testing python3-troveclient?","accounts_in_message":[],"_revision_number":1},{"id":"faa81217d628df35f3270c79d173e03718e4fbe3","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2020-06-23 11:02:22.000000000","message":"Patch Set 1:\n\nI\u0027m following the docs install python-troveclient by apt-get install. I saw debian have python3-troveclient package, so i install it.","accounts_in_message":[],"_revision_number":1},{"id":"6f0eb7dae1ede77c01af70202e0a0dc7e1ddfb70","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-06-23 11:08:19.000000000","message":"Patch Set 1:\n\n\u003e I\u0027m following the docs install python-troveclient by apt-get\n \u003e install. I saw debian have python3-troveclient package, so i\n \u003e install it.\n\nHmm...the doc needs to be fixed, to install OpenStack python lib, please always use pip (or pip3)","accounts_in_message":[],"_revision_number":1},{"id":"dbea8a5ca522a3189c3405b875dfc74eac328fd1","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2020-06-23 11:16:06.000000000","message":"Patch Set 1:\n\n\u003e \u003e I\u0027m following the docs install python-troveclient by apt-get\n \u003e \u003e install. I saw debian have python3-troveclient package, so i\n \u003e \u003e install it.\n \u003e \n \u003e Hmm...the doc needs to be fixed, to install OpenStack python lib,\n \u003e please always use pip (or pip3)\n\ni see python3-troveclient is dependence package for trove https://imgur.com/Oh0En4Z","accounts_in_message":[],"_revision_number":1},{"id":"5abf746eab5723928e31c5b49f13b97b0150bc54","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-06-23 11:38:47.000000000","message":"Patch Set 1:\n\n\u003e \u003e \u003e I\u0027m following the docs install python-troveclient by apt-get\n \u003e \u003e \u003e install. I saw debian have python3-troveclient package, so i\n \u003e \u003e \u003e install it.\n \u003e \u003e\n \u003e \u003e Hmm...the doc needs to be fixed, to install OpenStack python lib,\n \u003e \u003e please always use pip (or pip3)\n \u003e \n \u003e i see python3-troveclient is dependence package for trove\n \u003e https://imgur.com/Oh0En4Z\n\nI would not recommend using packages to install OpenStack services nowadays. Using container (with source code) or virtualenv instead. Because most of the packages are not up to date, e.g. new packages are made when stable branch is cut out, but they are hardly updated when the stable branch has new comments.","accounts_in_message":[],"_revision_number":1},{"id":"86da46dad248a36d66bbf02075488adcbc5aa59a","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2020-06-23 11:50:47.000000000","message":"Patch Set 1:\n\n\u003e \u003e \u003e \u003e I\u0027m following the docs install python-troveclient by apt-get\n \u003e \u003e \u003e \u003e install. I saw debian have python3-troveclient package, so i\n \u003e \u003e \u003e \u003e install it.\n \u003e \u003e \u003e\n \u003e \u003e \u003e Hmm...the doc needs to be fixed, to install OpenStack python\n \u003e lib,\n \u003e \u003e \u003e please always use pip (or pip3)\n \u003e \u003e\n \u003e \u003e i see python3-troveclient is dependence package for trove\n \u003e \u003e https://imgur.com/Oh0En4Z\n \u003e \n \u003e I would not recommend using packages to install OpenStack services\n \u003e nowadays. Using container (with source code) or virtualenv instead.\n \u003e Because most of the packages are not up to date, e.g. new packages\n \u003e are made when stable branch is cut out, but they are hardly updated\n \u003e when the stable branch has new comments.\n\nso this patch will not be merged? i think we can check type of log_obj and cover all case","accounts_in_message":[],"_revision_number":1},{"id":"fe0631b1d28c3c1adc6e40da8546af62c2b8390b","author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"date":"2020-07-09 23:43:34.000000000","message":"Patch Set 1:\n\nI would prefer we leave the current code as is, we should fix that only if we do have issues after installing via \u0027pip install python-troveclient\u0027","accounts_in_message":[],"_revision_number":1},{"id":"6308beefaac26001f38b89187505dd0fbd342f30","tag":"autogenerated:gerrit:abandon","author":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"date":"2021-11-12 09:40:40.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"239dcf6176e49d575a816f86602edd15a2f3c372","revisions":{"239dcf6176e49d575a816f86602edd15a2f3c372":{"kind":"REWORK","_number":1,"created":"2020-06-16 04:26:46.000000000","uploader":{"_account_id":31662,"name":"Cong Nguyen Thanh","email":"ntcong1705@gmail.com","username":"congnt95"},"ref":"refs/changes/68/735768/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/68/735768/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/68/735768/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/68/735768/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/68/735768/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/68/735768/1"}}},"commit":{"parents":[{"commit":"b86ff27e35054f0129022a8dca08a912132973af","subject":"Support to create datastore version","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b86ff27e35054f0129022a8dca08a912132973af"}]}],"author":{"name":"Nguyen Thanh Cong","email":"ntcong1705@gmail.com","date":"2020-06-16 04:23:14.000000000","tz":420},"committer":{"name":"Nguyen Thanh Cong","email":"ntcong1705@gmail.com","date":"2020-06-16 04:26:42.000000000","tz":420},"subject":"Fix save \u0026 tail log wrong type","message":"Fix save \u0026 tail log wrong type\n\nconvert byte to string when save \u0026 tail log\n\nChange-Id: I36a5d084e9e19294f6fe08fbde301107548c4177\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/239dcf6176e49d575a816f86602edd15a2f3c372"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/239dcf6176e49d575a816f86602edd15a2f3c372"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
