)]}'
{"id":"openstack%2Fpython-troveclient~73779","triplet_id":"openstack%2Fpython-troveclient~master~Ifbb144e26b62790d8b8ba9b5c3eea7d04844ee19","project":"openstack/python-troveclient","branch":"master","topic":"bug/1280522","hashtags":[],"change_id":"Ifbb144e26b62790d8b8ba9b5c3eea7d04844ee19","subject":"Replace assertEqual(None, *) with assertIsNone in tests","status":"MERGED","created":"2014-02-15 04:57:39.000000000","updated":"2014-03-03 09:45:19.000000000","submitted":"2014-03-03 09:45:19.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"61055ad707dd994c856e6a53047d5a5a45e883cc","_number":73779,"virtual_id_number":73779,"owner":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-03-03 09:45:19.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-02-15 05:58:45.000000000","_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-02-15 04:57:43.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":2,"date":"2014-02-27 06:41:59.000000000","_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"date":"2014-02-26 01:16:05.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},{"value":2,"date":"2014-03-03 09:34:19.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":-1,"date":"2014-02-25 15:28:56.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"date":"2014-02-27 06:41:59.000000000","_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},{"value":1,"date":"2014-03-03 09:34:19.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-02-15 05:58:45.000000000","updated_by":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"reviewer":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-02-25 15:28:56.000000000","updated_by":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"reviewer":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"state":"REVIEWER"},{"updated":"2014-02-27 06:41:59.000000000","updated_by":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"reviewer":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"state":"REVIEWER"},{"updated":"2014-03-03 09:34:19.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2014-03-03 09:45:19.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4da554e4d84223a92b3519738ecac07060faa9af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-15 04:57:39.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"b3cee736c34bb1b70426b5ea4acca711f9df0fee","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-02-15 04:57:43.000000000","message":"Patch Set 1:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/432/ ","accounts_in_message":[],"_revision_number":1},{"id":"83bc521c62ee2dbe97df8938dcc6a146471e3d86","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-15 05:03:24.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pep8/f054a4c : SUCCESS in 50s\n- gate-python-troveclient-python26 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python26/abdd3e1 : SUCCESS in 1m 58s\n- gate-python-troveclient-python27 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python27/d8cf3ce : SUCCESS in 1m 38s\n- gate-python-troveclient-python33 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python33/cc5befe : SUCCESS in 5m 42s\n- gate-python-troveclient-pypy http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pypy/070061c : FAILURE in 1m 51s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"c6539a7e929fa7bdacbc310a2f2cd2b958be1307","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-02-15 05:58:45.000000000","message":"Patch Set 1: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/432/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"efc144019839e7692c53876829262675e42c200d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 15:28:56.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f2c7e71d0632f45a53ba7185dd207a3d266d7eb1","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-02-25 15:28:56.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nNo need to update tests with such change. This is not the improvement or critical fix.\nSince testtools doesn\u0027t drop assertEqual method, tests should not be changed.","accounts_in_message":[],"_revision_number":1},{"id":"e255234da84e1fad04a62b601d16f0aaea164538","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-02-25 15:42:55.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pep8/fc18c7e : SUCCESS in 2m 00s\n- gate-python-troveclient-python26 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python26/3c73a58 : SUCCESS in 2m 21s\n- gate-python-troveclient-python27 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python27/3a1a34c : SUCCESS in 2m 38s\n- gate-python-troveclient-python33 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python33/8175f05 : SUCCESS in 3m 44s\n- gate-python-troveclient-pypy http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pypy/ec2b57a : FAILURE in 1m 47s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"0649cea56bf9ec0e644dcacf8c1a0e4068bd7d99","author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"date":"2014-02-26 01:16:05.000000000","message":"Patch Set 1:\n\nUse assertIsNone to improve the readability of the code.\nSome projects have fixed in bug 1280522.","accounts_in_message":[],"_revision_number":1},{"id":"73ef860a349a14f782607bc219c69dec710361a6","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-02-26 06:19:45.000000000","message":"Patch Set 1:\n\nUnfortunately, \"some projects\" doesn\u0027t mean \"all\". \nIt doesn\u0027t increase readability, it\u0027s only another type of asserts.\nAs i said before, it\u0027s not the improvement, it\u0027s not the critical fix, it\u0027s not the \"reduction of deprecated asserts\". It\u0027s only another type of assert, that has same effect as current assert.","accounts_in_message":[],"_revision_number":1},{"id":"5547a2da4137b90e41b1e2b811b4a585b59110e4","author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"date":"2014-02-27 06:41:59.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nthis has been merged in nova and cinder in the past (https://review.openstack.org/#/c/73502/, https://review.openstack.org/#/c/73777/), so it seems reasonable.","accounts_in_message":[],"_revision_number":1},{"id":"8114d28bea7c0feacabd9ba5a446d6c1a8fd860b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 09:34:19.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"23716c79e295ebfa508a935bd5a77935c8667980","author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"date":"2014-03-03 09:34:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1d86c4741eaf3be4f22e9cd36f85c6d22f6978dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 09:40:27.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"f88c4876c808f01129140d8e08c771d4344c4d5a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 09:40:27.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pep8/b636a25 : SUCCESS in 1m 56s\n- gate-python-troveclient-python26 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python26/8fc33f4 : SUCCESS in 1m 42s\n- gate-python-troveclient-python27 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python27/a3baf3d : SUCCESS in 2m 06s\n- gate-python-troveclient-python33 http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-python33/9255751 : SUCCESS in 4m 37s\n- gate-python-troveclient-pypy http://logs.openstack.org/79/73779/1/check/gate-python-troveclient-pypy/bbaf9cf : FAILURE in 2m 27s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"0ec74f412dc36849196b7d0b64608250e268ff51","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 09:45:19.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- gate-python-troveclient-pep8 http://logs.openstack.org/79/73779/1/gate/gate-python-troveclient-pep8/86b4dfd : SUCCESS in 1m 43s\n- gate-python-troveclient-python26 http://logs.openstack.org/79/73779/1/gate/gate-python-troveclient-python26/7336e56 : SUCCESS in 1m 37s\n- gate-python-troveclient-python27 http://logs.openstack.org/79/73779/1/gate/gate-python-troveclient-python27/b4908c7 : SUCCESS in 2m 13s\n- gate-python-troveclient-python33 http://logs.openstack.org/79/73779/1/gate/gate-python-troveclient-python33/aed28f0 : SUCCESS in 4m 50s\n- gate-python-troveclient-pypy http://logs.openstack.org/79/73779/1/gate/gate-python-troveclient-pypy/712257a : FAILURE in 1m 44s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"c7fc340a9dbe29bf56841a3ab122407cc113f439","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-03 09:45:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ae837cf05789f600fe1451d32447c24fc5c65473","revisions":{"ae837cf05789f600fe1451d32447c24fc5c65473":{"kind":"REWORK","_number":1,"created":"2014-02-15 04:57:39.000000000","uploader":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"ref":"refs/changes/79/73779/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/79/73779/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/79/73779/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/79/73779/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/79/73779/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/79/73779/1"}}},"commit":{"parents":[{"commit":"5fd715da78762c936566ea6e9dde5c1282b63f34","subject":"Merge \"Remove copyright from empty files\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5fd715da78762c936566ea6e9dde5c1282b63f34"}]}],"author":{"name":"llg8212","email":"lilinguo@huawei.com","date":"2014-02-15 04:56:54.000000000","tz":480},"committer":{"name":"llg8212","email":"lilinguo@huawei.com","date":"2014-02-15 04:56:54.000000000","tz":480},"subject":"Replace assertEqual(None, *) with assertIsNone in tests","message":"Replace assertEqual(None, *) with assertIsNone in tests\n\nReplace assertEqual(None, *) with assertIsNone in tests to have\nmore clear messages in case of failure.\n\nChange-Id: Ifbb144e26b62790d8b8ba9b5c3eea7d04844ee19\nCloses-Bug:#1280522\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ae837cf05789f600fe1451d32447c24fc5c65473"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/ae837cf05789f600fe1451d32447c24fc5c65473"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}