)]}'
{"id":"openstack%2Fpython-troveclient~84115","triplet_id":"openstack%2Fpython-troveclient~master~Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6","project":"openstack/python-troveclient","branch":"master","topic":"(detached","hashtags":[],"change_id":"Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6","subject":"Fix create call for security group rules","status":"MERGED","created":"2014-03-31 12:17:59.000000000","updated":"2014-04-02 03:47:30.000000000","submitted":"2014-04-02 03:47:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f2236fd9b7a627e87087553431f900f4715e6399","_number":84115,"virtual_id_number":84115,"owner":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-04-02 03:47:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":1,"date":"2014-04-02 03:21:49.000000000","_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2014-04-02 02:10:03.000000000","_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"date":"2014-04-02 01:54:07.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":2,"date":"2014-04-02 02:05:56.000000000","_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-04-02 02:10:03.000000000","_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"date":"2014-04-02 02:05:56.000000000","_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"date":"2014-04-02 01:54:03.000000000","_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"value":0,"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"value":0,"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"value":0,"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"value":0,"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}],"values":{"-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-04-02 01:54:03.000000000","updated_by":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"reviewer":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"state":"REVIEWER"},{"updated":"2014-04-02 02:05:56.000000000","updated_by":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"reviewer":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"state":"REVIEWER"},{"updated":"2014-04-02 02:10:03.000000000","updated_by":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"reviewer":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"state":"REVIEWER"},{"updated":"2014-04-02 03:21:49.000000000","updated_by":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"reviewer":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2014-04-02 03:47:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"dc30176cdfbcad7ad387fce2f4739290071a7e2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 12:18:00.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9f07552fd2f96344496c3d12b334929f9f997d46","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-03-31 12:18:03.000000000","message":"Patch Set 1:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/505/ ","accounts_in_message":[],"_revision_number":1},{"id":"18d0d26f25cb5e2b47c7cd418e837c0dd7992521","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-03-31 13:25:23.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-grenade-dsvm http://logs.openstack.org/15/84115/1/check/check-grenade-dsvm/b8473d6 : SUCCESS in 41m 31s\n- check-tempest-dsvm-full http://logs.openstack.org/15/84115/1/check/check-tempest-dsvm-full/7806fb1 : FAILURE in 1h 02m 43s\n- check-tempest-dsvm-neutron http://logs.openstack.org/15/84115/1/check/check-tempest-dsvm-neutron/36c4168 : SUCCESS in 55m 50s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/15/84115/1/check/check-tempest-dsvm-neutron-heat-slow/a6e1583 : SUCCESS in 24m 29s\n- gate-python-troveclient-pep8 http://logs.openstack.org/15/84115/1/check/gate-python-troveclient-pep8/60dbc66 : SUCCESS in 57s\n- gate-python-troveclient-python26 http://logs.openstack.org/15/84115/1/check/gate-python-troveclient-python26/4455add : FAILURE in 1m 10s\n- gate-python-troveclient-python27 http://logs.openstack.org/15/84115/1/check/gate-python-troveclient-python27/4d9d84d : FAILURE in 1m 35s\n- gate-python-troveclient-python33 http://logs.openstack.org/15/84115/1/check/gate-python-troveclient-python33/1628493 : FAILURE in 3m 18s\n- gate-python-troveclient-pypy http://logs.openstack.org/15/84115/1/check/gate-python-troveclient-pypy/431f57f : FAILURE in 1m 08s (non-voting)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"aacca7d1fe948e37016dccaf5da628fc73914b97","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-03-31 13:45:47.000000000","message":"Patch Set 1: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/505/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"43d836e64d17687beb6f33c6443d6451b678487a","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-03-31 15:05:42.000000000","message":"Patch Set 1:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-python-troveclient-pypy: https://bugs.launchpad.net/bugs/1290562\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1290562\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":1},{"id":"a8388fd23894f2c81a7b78337277ff1b5e10f116","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-04-01 09:36:56.000000000","message":"Patch Set 1:\n\nrecheck bug 1290562","accounts_in_message":[],"_revision_number":1},{"id":"f5dc1c9e342f7ada06c4670ecf6e721c09f64004","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 09:36:57.000000000","message":"Patch Set 1: No score\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"46fe105280e2d47b5db96492febd2ea8fa7cda7d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 10:00:21.000000000","message":"Patch Set 2:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"fbc8c6e7823ff95c0d11f0236ac7d9f7ffea2965","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-04-01 10:00:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"50f0ca4327d0c2fe2dc4ffaf0ced1275b634009c","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-01 10:00:25.000000000","message":"Patch Set 2:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/511/ ","accounts_in_message":[],"_revision_number":2},{"id":"3fe79720d76a414d9491baaa9a50832718ca9672","author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"date":"2014-04-01 10:01:44.000000000","message":"Patch Set 1: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"821baffd9b2b6be1fb01565dba0c4c559a8924c2","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-04-01 10:37:13.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"e64280fa122657c6d643160ca3b4c48398f441ed","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 10:37:14.000000000","message":"Patch Set 3:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"ea9bb01f8926a29d1a26a68574771c1a8f8cd4fc","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-01 10:37:17.000000000","message":"Patch Set 3:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/512/ ","accounts_in_message":[],"_revision_number":3},{"id":"b2ce1b69352176c09aff3753974106e30b9a29e3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 11:30:32.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- check-grenade-dsvm http://logs.openstack.org/15/84115/3/check/check-grenade-dsvm/321de2c : SUCCESS in 51m 34s\n- check-tempest-dsvm-full http://logs.openstack.org/15/84115/3/check/check-tempest-dsvm-full/8729361 : SUCCESS in 41m 04s\n- check-tempest-dsvm-neutron http://logs.openstack.org/15/84115/3/check/check-tempest-dsvm-neutron/6ffd5c6 : SUCCESS in 51m 22s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/15/84115/3/check/check-tempest-dsvm-neutron-heat-slow/4484c13 : SUCCESS in 26m 15s\n- gate-python-troveclient-pep8 http://logs.openstack.org/15/84115/3/check/gate-python-troveclient-pep8/6d63a8d : SUCCESS in 44s\n- gate-python-troveclient-python26 http://logs.openstack.org/15/84115/3/check/gate-python-troveclient-python26/56e5889 : FAILURE in 59s\n- gate-python-troveclient-python27 http://logs.openstack.org/15/84115/3/check/gate-python-troveclient-python27/45f6e91 : FAILURE in 50s\n- gate-python-troveclient-python33 http://logs.openstack.org/15/84115/3/check/gate-python-troveclient-python33/901aaab : FAILURE in 3m 21s\n- gate-python-troveclient-pypy http://logs.openstack.org/15/84115/3/check/gate-python-troveclient-pypy/0b74a80 : FAILURE in 1m 20s (non-voting)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"b70a47ab9f10135c09c216d5a10bd31d5f77df6f","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2014-04-01 11:31:02.000000000","message":"Patch Set 3:\n\nI noticed jenkins failed, I think you hit bug(s):\n\n- gate-python-troveclient-pypy: https://bugs.launchpad.net/bugs/1290562\n\nWe don\u0027t automatically recheck or reverify, so please consider\ndoing that manually if someone hasn\u0027t already. For a code review\nwhich is not yet approved, you can recheck by leaving a code\nreview comment with just the text:\n\n    recheck bug 1290562\nFor bug details see: http://status.openstack.org/elastic-recheck/","accounts_in_message":[],"_revision_number":3},{"id":"b2949f10630079a90abf296873d6f5a851a4a56c","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-04-01 11:40:35.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b8ab0f2711afedcf752eccd72ca5516b8784cf9a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 11:40:37.000000000","message":"Patch Set 4:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":4},{"id":"290ee49a1378fbbd81d86ee808fb3d9f2e26d748","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-01 12:40:22.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- check-grenade-dsvm http://logs.openstack.org/15/84115/4/check/check-grenade-dsvm/0cfcc9b : SUCCESS in 37m 43s\n- check-tempest-dsvm-full http://logs.openstack.org/15/84115/4/check/check-tempest-dsvm-full/6bd9e4e : SUCCESS in 59m 06s\n- check-tempest-dsvm-neutron http://logs.openstack.org/15/84115/4/check/check-tempest-dsvm-neutron/06028cc : SUCCESS in 52m 03s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/15/84115/4/check/check-tempest-dsvm-neutron-heat-slow/0341889 : SUCCESS in 23m 16s\n- gate-python-troveclient-pep8 http://logs.openstack.org/15/84115/4/check/gate-python-troveclient-pep8/fdde3ea : SUCCESS in 44s\n- gate-python-troveclient-python26 http://logs.openstack.org/15/84115/4/check/gate-python-troveclient-python26/1d2c3ec : SUCCESS in 59s\n- gate-python-troveclient-python27 http://logs.openstack.org/15/84115/4/check/gate-python-troveclient-python27/f5e5809 : SUCCESS in 50s\n- gate-python-troveclient-python33 http://logs.openstack.org/15/84115/4/check/gate-python-troveclient-python33/6fbe7cb : SUCCESS in 3m 14s\n- gate-python-troveclient-pypy http://logs.openstack.org/15/84115/4/check/gate-python-troveclient-pypy/64aca6b : FAILURE in 1m 20s (non-voting)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"c102f19e9fbd6407e535b574b63aadfeed61cd04","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-01 14:08:05.000000000","message":"Patch Set 4:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/513/ ","accounts_in_message":[],"_revision_number":4},{"id":"9ed06e3ae569eef560a0da810ddc2d1e5f47c0e0","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-01 15:35:49.000000000","message":"Patch Set 4: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/513/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"00b1e7428984efb90535d17bde9144d37d067714","author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"date":"2014-04-01 18:09:48.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t merge this\n\ndoes not explain in the commit msg the change in expectations/behavior. anyone not intimately familiar with trove will ask \"so if i do a create for security_group_rule, but i can\u0027t provide protocol or port ranges, then what happens?\"","accounts_in_message":[],"_revision_number":4},{"id":"4c7ad4d26c0c03486f7e826bb526c8cf09c2a811","author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"date":"2014-04-01 19:29:24.000000000","message":"Patch Set 4:\n\n@Auston. Would this one be more appropriate?\n\nFix create call for the security group rules\n\nReasons:\n\n - create call expects extra unused attributes like protocol,\n   from/to ports, that are being ignored by the Trove in favor\n   of the datastore-specific ports(mentioned in config file) values;\n - create call only requires security group id and valid CIDR.\n\nChanges:\n\n - removing extra attributes from the create call:\n    - protocol;\n    - from port;\n    - to port.\n  In favor of datastore-specific ports, mentioned inside the \n  Trove configuration files.","accounts_in_message":[],"_revision_number":4},{"id":"0bd09a0b9b2ff728c9b07003d3d5e2a86ba6a3e6","author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"date":"2014-04-02 01:54:03.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"fb231a7de09ba3f24d02f0335fca024aa86b7f24","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 01:54:04.000000000","message":"Patch Set 5:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"d81db06be87b359b09374f3f4d87c2342f57809a","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-02 01:54:07.000000000","message":"Patch Set 5:\n\nBuild Started https://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/515/ ","accounts_in_message":[],"_revision_number":5},{"id":"93a5eb67b39d67bc79e16f3805f0699430655f91","author":{"_account_id":8214,"name":"Auston McReynolds","email":"amcreynolds@ebaysf.com","username":"amcreynolds"},"date":"2014-04-02 02:05:56.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"6816982200e2841ba543319aa577b4172042f539","author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"date":"2014-04-02 02:10:03.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"e6165a966c1b6b73027ad48225a9dda4c8e8181c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 02:47:07.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"ca01f4d70e50b0d0dd15963a5245023645a153e5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 02:47:07.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- check-grenade-dsvm http://logs.openstack.org/15/84115/5/check/check-grenade-dsvm/3089545 : SUCCESS in 38m 19s\n- check-tempest-dsvm-full http://logs.openstack.org/15/84115/5/check/check-tempest-dsvm-full/f5beebf : SUCCESS in 51m 30s\n- check-tempest-dsvm-neutron http://logs.openstack.org/15/84115/5/check/check-tempest-dsvm-neutron/306b3dc : SUCCESS in 52m 59s\n- check-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/15/84115/5/check/check-tempest-dsvm-neutron-heat-slow/991743e : SUCCESS in 25m 07s\n- gate-python-troveclient-pep8 http://logs.openstack.org/15/84115/5/check/gate-python-troveclient-pep8/10ea935 : SUCCESS in 47s\n- gate-python-troveclient-python26 http://logs.openstack.org/15/84115/5/check/gate-python-troveclient-python26/b263e48 : SUCCESS in 59s\n- gate-python-troveclient-python27 http://logs.openstack.org/15/84115/5/check/gate-python-troveclient-python27/48e543b : SUCCESS in 49s\n- gate-python-troveclient-python33 http://logs.openstack.org/15/84115/5/check/gate-python-troveclient-python33/a7e4076 : SUCCESS in 3m 44s\n- gate-python-troveclient-pypy http://logs.openstack.org/15/84115/5/check/gate-python-troveclient-pypy/0919342 : FAILURE in 1m 12s (non-voting)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"7e02597cc3b40eb904cd6c5f772462e5db31ad73","author":{"_account_id":7092,"name":"Deprecated Trove CI","email":"reddwarf-jenkins@googlegroups.com","username":"reddwarf","tags":["SERVICE_USER"]},"date":"2014-04-02 03:21:49.000000000","message":"Patch Set 5: Works for me\n\nBuild Successful \n\nhttps://rdjenkins.dyndns.org/job/Python-TroveClient-Gate/515/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"d7c87d71440c663bc388af0b04a22058f7fbd67c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 03:47:30.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- gate-grenade-dsvm http://logs.openstack.org/15/84115/5/gate/gate-grenade-dsvm/a158e1e : SUCCESS in 36m 59s\n- gate-tempest-dsvm-full http://logs.openstack.org/15/84115/5/gate/gate-tempest-dsvm-full/2536d43 : SUCCESS in 51m 02s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/15/84115/5/gate/gate-tempest-dsvm-neutron/7820e72 : SUCCESS in 59m 31s\n- gate-tempest-dsvm-neutron-heat-slow http://logs.openstack.org/15/84115/5/gate/gate-tempest-dsvm-neutron-heat-slow/0725186 : SUCCESS in 24m 13s\n- gate-python-troveclient-pep8 http://logs.openstack.org/15/84115/5/gate/gate-python-troveclient-pep8/b0a095d : SUCCESS in 46s\n- gate-python-troveclient-python26 http://logs.openstack.org/15/84115/5/gate/gate-python-troveclient-python26/42647e3 : SUCCESS in 1m 05s\n- gate-python-troveclient-python27 http://logs.openstack.org/15/84115/5/gate/gate-python-troveclient-python27/2ec58db : SUCCESS in 33s\n- gate-python-troveclient-python33 http://logs.openstack.org/15/84115/5/gate/gate-python-troveclient-python33/7eff0f7 : SUCCESS in 3m 33s\n- gate-python-troveclient-pypy http://logs.openstack.org/15/84115/5/gate/gate-python-troveclient-pypy/ed6c311 : FAILURE in 1m 45s (non-voting)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"43373466b0347a2b12299b4c5f6b42c370fd110f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-04-02 03:47:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"b9507417fe7d40a7023d85131a73e56b87390672","revisions":{"c51fcdecdcb09cded8a149279b08f4523764444d":{"kind":"REWORK","_number":1,"created":"2014-03-31 12:17:59.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/15/84115/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/15/84115/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/1"}}},"commit":{"parents":[{"commit":"5b713c009bfa783fbfcc0e693e73c9d637e677f3","subject":"Merge \"Get rid of XML related trove client bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5b713c009bfa783fbfcc0e693e73c9d637e677f3"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 11:13:30.000000000","tz":180},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 12:17:57.000000000","tz":180},"subject":"Fix create call for security group rules","message":"Fix create call for security group rules\n\nReasons:\n - create call expect extra unused attributes.\n\nChanges:\n - updating security group rule create shell command.\n\nChange-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6\nCloses-Bug: #1298749\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c51fcdecdcb09cded8a149279b08f4523764444d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/c51fcdecdcb09cded8a149279b08f4523764444d"}]},"branch":"refs/heads/master"},"870b269152545a7453f5807a32e1ba775fb47156":{"kind":"REWORK","_number":2,"created":"2014-04-01 10:00:21.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/15/84115/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/15/84115/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/2"}}},"commit":{"parents":[{"commit":"5b713c009bfa783fbfcc0e693e73c9d637e677f3","subject":"Merge \"Get rid of XML related trove client bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5b713c009bfa783fbfcc0e693e73c9d637e677f3"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 11:13:30.000000000","tz":180},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-04-01 10:00:05.000000000","tz":180},"subject":"Fix create call for security group rules","message":"Fix create call for security group rules\n\nReasons:\n - create call expect extra unused attributes.\n\nChanges:\n - updating security group rule create shell command.\n\nChange-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6\nCloses-Bug: #1298749\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/870b269152545a7453f5807a32e1ba775fb47156"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/870b269152545a7453f5807a32e1ba775fb47156"}]},"branch":"refs/heads/master"},"268280e16e5487d4a3520c053cabd87ffa174dd3":{"kind":"REWORK","_number":3,"created":"2014-04-01 10:37:13.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/15/84115/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/15/84115/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/3"}}},"commit":{"parents":[{"commit":"5b713c009bfa783fbfcc0e693e73c9d637e677f3","subject":"Merge \"Get rid of XML related trove client bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5b713c009bfa783fbfcc0e693e73c9d637e677f3"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 11:13:30.000000000","tz":180},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-04-01 10:37:02.000000000","tz":180},"subject":"Fix create call for security group rules","message":"Fix create call for security group rules\n\nReasons:\n - create call expect extra unused attributes.\n\nChanges:\n - updating security group rule create shell command.\n\nChange-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6\nCloses-Bug: #1298749\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/268280e16e5487d4a3520c053cabd87ffa174dd3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/268280e16e5487d4a3520c053cabd87ffa174dd3"}]},"branch":"refs/heads/master"},"4f7bd65c4473bc54e8b01c398f4f1ac3d6dcb009":{"kind":"REWORK","_number":4,"created":"2014-04-01 11:40:35.000000000","uploader":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"ref":"refs/changes/15/84115/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/15/84115/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/4"}}},"commit":{"parents":[{"commit":"5b713c009bfa783fbfcc0e693e73c9d637e677f3","subject":"Merge \"Get rid of XML related trove client bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5b713c009bfa783fbfcc0e693e73c9d637e677f3"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 11:13:30.000000000","tz":180},"committer":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-04-01 11:40:21.000000000","tz":180},"subject":"Fix create call for security group rules","message":"Fix create call for security group rules\n\nReasons:\n - create call expect extra unused attributes.\n\nChanges:\n - updating security group rule create shell command.\n\nChange-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6\nCloses-Bug: #1298749\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/4f7bd65c4473bc54e8b01c398f4f1ac3d6dcb009"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/4f7bd65c4473bc54e8b01c398f4f1ac3d6dcb009"}]},"branch":"refs/heads/master"},"b9507417fe7d40a7023d85131a73e56b87390672":{"kind":"REWORK","_number":5,"created":"2014-04-02 01:54:03.000000000","uploader":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"ref":"refs/changes/15/84115/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-troveclient","ref":"refs/changes/15/84115/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-troveclient refs/changes/15/84115/5"}}},"commit":{"parents":[{"commit":"5b713c009bfa783fbfcc0e693e73c9d637e677f3","subject":"Merge \"Get rid of XML related trove client bindings\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/5b713c009bfa783fbfcc0e693e73c9d637e677f3"}]}],"author":{"name":"Denis Makogon","email":"dmakogon@mirantis.com","date":"2014-03-31 11:13:30.000000000","tz":180},"committer":{"name":"Nikhil Manchanda","email":"SlickNik@gmail.com","date":"2014-04-02 01:51:19.000000000","tz":-420},"subject":"Fix create call for security group rules","message":"Fix create call for security group rules\n\nReasons:\n - The security group rule create call was expecting\n   from_port, to_port, and protocol as arguments, but\n   the Trove API was ignoring these since it picks these\n   up from the respective datastore confs.\n\nChanges:\n - Removing the extra arguments from the security-group-rule\n   create command:\n   - from_port\n   - to_port\n   - protocol\n\nNote that even though the user was able to specify the ports\nfor the rule these were _never_ being honored since these\nwere being picked up from the respective config files.\n\nUsage before change:\n - trove secgroup-add-rule \u003csecurity_group\u003e \u003cprotocol\u003e\n                           \u003cfrom_port\u003e \u003cto_port\u003e \u003ccidr\u003e\n\nUsage after change:\n - trove secgroup-add-rule \u003csecurity_group\u003e \u003ccidr\u003e\n\nChange-Id: Ic1440f735b6cf2b8b4f29c5ab9f48bcb427ca9e6\nCloses-Bug: #1298749\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b9507417fe7d40a7023d85131a73e56b87390672"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-troveclient/commit/b9507417fe7d40a7023d85131a73e56b87390672"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}