)]}'
{"troveclient/base.py":[{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"32c943fcd2401dfefa310ea12c227ca3cd5641c1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.api \u003d api"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _paginated(self, url, response_key, limit\u003dNone, marker\u003dNone,"},{"line_number":64,"context_line":"                   query_strings\u003d{}):"},{"line_number":65,"context_line":"        url \u003d common.append_query_strings(url, limit\u003dlimit, marker\u003dmarker,"},{"line_number":66,"context_line":"                                          **query_strings)"},{"line_number":67,"context_line":"        resp, body \u003d self.api.client.get(url)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bad4c104_29bab5e1","line":64,"updated":"2014-04-29 04:41:15.000000000","message":"There is a known issue with setting default params to empty dictionaries.\n\nhttp://stackoverflow.com/questions/3887079/why-does-initializing-a-variable-via-a-python-default-variable-keep-state-across\n\nI believe you want to do something like this:\n\ndef ( .....  query_strings\u003dNone):\n\n....\n\nif query_strings \u003d\u003d None:\n   query_strings \u003d {}\n....\n\nend","commit_id":"8bcb95c600e5d67e81c799db6b8b27dbcb6229e9"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"27faf5fbaaf2063ec68c1976cd5ebcab73634964","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.api \u003d api"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def _paginated(self, url, response_key, limit\u003dNone, marker\u003dNone,"},{"line_number":64,"context_line":"                   query_strings\u003d{}):"},{"line_number":65,"context_line":"        url \u003d common.append_query_strings(url, limit\u003dlimit, marker\u003dmarker,"},{"line_number":66,"context_line":"                                          **query_strings)"},{"line_number":67,"context_line":"        resp, body \u003d self.api.client.get(url)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bad4c104_87bb96c3","line":64,"in_reply_to":"bad4c104_29bab5e1","updated":"2014-04-29 17:26:16.000000000","message":"Great observation. Ill make that change","commit_id":"8bcb95c600e5d67e81c799db6b8b27dbcb6229e9"}],"troveclient/tests/test_common.py":[{"author":{"_account_id":4240,"name":"Craig Vyvial","email":"cp16net@gmail.com","username":"cp16net"},"change_message_id":"1bf0e3159feb0b68be2894494ec8b56a82cd3a3b","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        result \u003d common.append_query_strings(url, limit\u003dlimit, marker\u003dmarker)"},{"line_number":44,"context_line":"        self.assertTrue(result.startswith(url + \u0027?\u0027))"},{"line_number":45,"context_line":"        self.assertIn(limit, result)"},{"line_number":46,"context_line":"        self.assertIn(marker, result)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        opts \u003d {}"},{"line_number":49,"context_line":"        self.assertEqual(url, common.append_query_strings("}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_3f0c7194","line":46,"updated":"2014-05-22 05:11:24.000000000","message":"can you make the above 2 asserts a little more verbose.\n\n    self.assertIn(\"marker\u003d%s\" % marker, result)\n\nalso add a count of \u0027\u0026\u0027s?\n\n    self.assert(result.count(\u0027\u0026\u0027), 1)","commit_id":"cf04d85d94530d12b561cf1fcad679f785c3d096"}],"troveclient/v1/shell.py":[{"author":{"_account_id":9746,"name":"Doug Shelley","email":"dougshelley66@gmail.com","username":"dougshelley"},"change_message_id":"a62ab0094d69ff108a45e04ea1f9904c98ad27b7","unresolved":false,"context_lines":[{"line_number":334,"context_line":"           help\u003d\u0027Return up to N number of the most recent backups.\u0027)"},{"line_number":335,"context_line":"@utils.arg(\u0027--datastore\u0027, metavar\u003d\u0027\u003cdatastore\u003e\u0027,"},{"line_number":336,"context_line":"           default\u003dNone,"},{"line_number":337,"context_line":"           help\u003d\u0027Name or UUID of the datastore to list backups for.\u0027)"},{"line_number":338,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":339,"context_line":"def do_backup_list(cs, args):"},{"line_number":340,"context_line":"    \"\"\"Lists available backups.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_b57240e1","line":337,"range":{"start_line":337,"start_character":22,"end_line":337,"end_character":24},"updated":"2014-05-29 00:25:09.000000000","message":"I believe we\u0027ve decided to use \"ID\" instead of \"UUID\" - see https://review.openstack.org/#/c/92189/","commit_id":"65ded44cd0104c0a92d2d248c736421c01a1bb20"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"cf3dfd23bef1f030f404c2ae1920eaf607ec10fa","unresolved":false,"context_lines":[{"line_number":334,"context_line":"           help\u003d\u0027Return up to N number of the most recent backups.\u0027)"},{"line_number":335,"context_line":"@utils.arg(\u0027--datastore\u0027, metavar\u003d\u0027\u003cdatastore\u003e\u0027,"},{"line_number":336,"context_line":"           default\u003dNone,"},{"line_number":337,"context_line":"           help\u003d\u0027Name or UUID of the datastore to list backups for.\u0027)"},{"line_number":338,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":339,"context_line":"def do_backup_list(cs, args):"},{"line_number":340,"context_line":"    \"\"\"Lists available backups.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_0d7bddf5","line":337,"range":{"start_line":337,"start_character":22,"end_line":337,"end_character":24},"in_reply_to":"3ae8d1ca_b57240e1","updated":"2014-05-29 13:04:15.000000000","message":"Agreed","commit_id":"65ded44cd0104c0a92d2d248c736421c01a1bb20"}]}