)]}'
{"troveclient/v1/shell.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"9f7333a4afae18e30ba069c545c8963a65557a6c","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for nic_str in args.nics:"},{"line_number":214,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\", 1)[:2] for z in"},{"line_number":215,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":216,"context_line":"        if bool(nic_info.get(\u0027net-id\u0027)) \u003d\u003d bool(nic_info.get(\u0027port-id\u0027)):"},{"line_number":217,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""},{"line_number":218,"context_line":"                       \"the form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":219,"context_line":"                       \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_0c488d2c","line":216,"updated":"2014-04-29 16:52:03.000000000","message":"your change allows one to specify neither of the two values, bool(...) would be False in either case.\n\nif what you are after is to ensure that both are not specified but at least one is specified, you may want \n\nif not xor(bool(nic_info.get(\u0027net-id\u0027)), bool(nic_info.get(\u0027port-id\u0027))):\n...","commit_id":"0f229d4a4137ba045615364deda840f509d3b46a"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"3951631e0b10f62e969205fa82d1367f7d4648d2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for nic_str in args.nics:"},{"line_number":214,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\", 1)[:2] for z in"},{"line_number":215,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":216,"context_line":"        if bool(nic_info.get(\u0027net-id\u0027)) \u003d\u003d bool(nic_info.get(\u0027port-id\u0027)):"},{"line_number":217,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""},{"line_number":218,"context_line":"                       \"the form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":219,"context_line":"                       \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_a7589afb","line":216,"in_reply_to":"bad4c104_0c488d2c","updated":"2014-04-29 17:21:28.000000000","message":"Yes, bool would be False, so False \u003d\u003d False would be True and the error will be triggered - and the test case proves it. In fact in Python\n\nxor(A, B)\n\nis the same as \n\nbool(A) !\u003d bool(B)\n\nso \"not xor\" is \"bool(A) \u003d\u003d bool(B)\"","commit_id":"0f229d4a4137ba045615364deda840f509d3b46a"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"d3b96c18a96d8ab0e94ebea4cc8ddf9571a23943","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for nic_str in args.nics:"},{"line_number":214,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\", 1)[:2] for z in"},{"line_number":215,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":216,"context_line":"        if bool(nic_info.get(\u0027net-id\u0027)) \u003d\u003d bool(nic_info.get(\u0027port-id\u0027)):"},{"line_number":217,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""},{"line_number":218,"context_line":"                       \"the form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":219,"context_line":"                       \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_67885223","line":216,"in_reply_to":"bad4c104_a7589afb","updated":"2014-04-29 17:24:26.000000000","message":"yes, you are correct.","commit_id":"0f229d4a4137ba045615364deda840f509d3b46a"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"dd7333ba8b7a9317e1dba30d0abb24e0b70df4e5","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for nic_str in args.nics:"},{"line_number":214,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\", 1)[:2] for z in"},{"line_number":215,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":216,"context_line":"        if bool(nic_info.get(\u0027net-id\u0027)) \u003d\u003d bool(nic_info.get(\u0027port-id\u0027)):"},{"line_number":217,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""},{"line_number":218,"context_line":"                       \"the form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":219,"context_line":"                       \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_531a2d18","line":216,"updated":"2014-04-30 17:30:17.000000000","message":"Just to nikpick but perhaps there is no need to convert to bool. You can do: \nif nic_info.get(\u0027net-id\u0027) and nic_info.get(\u0027port-id\u0027):","commit_id":"b03152810dfe9b4b881b8789a82c8521e8cb372f"},{"author":{"_account_id":5390,"name":"Steve Leon","username":"steve-leon","inactive":true},"change_message_id":"22f7b9c8350cd038f4244e09da39afa1cd133e6e","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    for nic_str in args.nics:"},{"line_number":214,"context_line":"        nic_info \u003d dict([(k, v) for (k, v) in [z.split(\"\u003d\", 1)[:2] for z in"},{"line_number":215,"context_line":"                                               nic_str.split(\",\")]])"},{"line_number":216,"context_line":"        if bool(nic_info.get(\u0027net-id\u0027)) \u003d\u003d bool(nic_info.get(\u0027port-id\u0027)):"},{"line_number":217,"context_line":"            err_msg \u003d (\"Invalid nic argument \u0027%s\u0027. Nic arguments must be of \""},{"line_number":218,"context_line":"                       \"the form --nic \u003cnet-id\u003dnet-uuid,v4-fixed-ip\u003dip-addr,\""},{"line_number":219,"context_line":"                       \"port-id\u003dport-uuid\u003e, with at minimum net-id or port-id \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_93ee758a","line":216,"in_reply_to":"9ad9bd40_531a2d18","updated":"2014-04-30 17:40:57.000000000","message":"Let me take this back. Amrith correctly pointed out that my observation was invalid. Ill +1","commit_id":"b03152810dfe9b4b881b8789a82c8521e8cb372f"}]}