)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a9766168eefd91619deac7875696b67ec622eaad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow users the ability to update the instance name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related to bp update-instance-name"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"This review provides a new update call which uses the PATCH api"},{"line_number":12,"context_line":"call to update instance name and configuration reference."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7adec928_ea0fcc2c","line":9,"updated":"2014-05-07 21:08:44.000000000","message":"Please follow https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes\n\n\nFirst comes commit title, then commit message body then comes\n\n Implements: blueprint update-instance-name\n\nor\n\n Closes-Bug: #XXXXXX","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"}],"troveclient/compat/cli.py":[{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"594c3b36532abe3b905ec6950ed3052cc114496a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        self._pretty_print(self.dbaas.instances.modify, self.id,"},{"line_number":85,"context_line":"                           configuration_ref\u003dself._get_configuration_ref())"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def edit(self):"},{"line_number":88,"context_line":"        \"\"\"Edit an instance\"\"\""},{"line_number":89,"context_line":"        self._require(\u0027id\u0027)"},{"line_number":90,"context_line":"        self._pretty_print(self.dbaas.instances.edit, self.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_8c658547","line":87,"updated":"2014-05-07 22:27:55.000000000","message":"I dont think there is a need to add to compat. This is only to support legacy integration tests.","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"}],"troveclient/v1/instances.py":[{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"594c3b36532abe3b905ec6950ed3052cc114496a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":106,"context_line":"        if name is not None:"},{"line_number":107,"context_line":"            body[\"instance\"][\"name\"] \u003d name"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        url \u003d \"/instances/%s\" % instance_id"},{"line_number":110,"context_line":"        resp, body \u003d self.api.client.patch(url, body\u003dbody)"},{"line_number":111,"context_line":"        common.check_for_exceptions(resp, body, url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_4c037d0f","line":108,"updated":"2014-05-07 22:27:55.000000000","message":"What happens if neither the configuration nor the name is given? I guess i would have to see the client. But would it be better if we return an error?","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"f28bbf0357d982472afe09c20dd72115f16cd3fb","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":106,"context_line":"        if name is not None:"},{"line_number":107,"context_line":"            body[\"instance\"][\"name\"] \u003d name"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        url \u003d \"/instances/%s\" % instance_id"},{"line_number":110,"context_line":"        resp, body \u003d self.api.client.patch(url, body\u003dbody)"},{"line_number":111,"context_line":"        common.check_for_exceptions(resp, body, url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_8820fff8","line":108,"in_reply_to":"7adec928_4c037d0f","updated":"2014-05-08 13:57:24.000000000","message":"If neither are given, no change is made and 204 is returned.  It just means there is nothing to update","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"}],"troveclient/v1/shell.py":[{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"07ee0c4caa1d724b5c7d978a9df4953192e60a61","unresolved":false,"context_lines":[{"line_number":162,"context_line":"           default\u003dNone,"},{"line_number":163,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027)"},{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_af179650","line":165,"updated":"2014-05-07 21:06:35.000000000","message":"do_rename would be better, more verbose","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"01a3ada48bc9ec3e1376e0581fc5f6a24300e1f4","unresolved":false,"context_lines":[{"line_number":162,"context_line":"           default\u003dNone,"},{"line_number":163,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027)"},{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_dc2c894d","line":165,"in_reply_to":"7adec928_4c2c5dac","updated":"2014-05-08 16:04:27.000000000","message":"The reason I kept it as update is to match other openstack projects cli. Any thoughts?","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"09ee579094e8d7f2e2051026b81870a57fa27446","unresolved":false,"context_lines":[{"line_number":162,"context_line":"           default\u003dNone,"},{"line_number":163,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027)"},{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_ca25b00b","line":165,"in_reply_to":"7adec928_af179650","updated":"2014-05-07 21:33:53.000000000","message":"we can change configuration change as well using this call","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":11316,"name":"Steve Leon","email":"kokhang@gmail.com","username":"kokhang"},"change_message_id":"594c3b36532abe3b905ec6950ed3052cc114496a","unresolved":false,"context_lines":[{"line_number":162,"context_line":"           default\u003dNone,"},{"line_number":163,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027)"},{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_4c2c5dac","line":165,"in_reply_to":"7adec928_ca25b00b","updated":"2014-05-07 22:27:55.000000000","message":"why not do_edit to match the command name?","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":4463,"name":"iccha-sethi","email":"iccha.sethi@rackspace.com","username":"iccha-sethi"},"change_message_id":"fd203e4f33dd0936789fe36aedbe7ec791b92e8c","unresolved":false,"context_lines":[{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"@utils.arg(\u0027name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7adec928_7ce4550d","line":167,"updated":"2014-05-08 16:05:50.000000000","message":"And the reason this fn is edit is because there already exists a PUT call with update fn in the api, so to avoid confusion.","commit_id":"9c13b744c8f870b5c01d35706b6af5fbd2daa6ad"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"5061e1ecf46befbff7b881f10e68d5bdccc5b8b8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"           default\u003dNone,"},{"line_number":163,"context_line":"           help\u003d\u0027ID of the configuration reference to attach.\u0027)"},{"line_number":164,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":165,"context_line":"def do_update(cs, args):"},{"line_number":166,"context_line":"    \"\"\"Updates an instance name or configuration.\"\"\""},{"line_number":167,"context_line":"    cs.instances.edit(args.instance, args.configuration, args.name)"},{"line_number":168,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5adbc538_cc915754","line":165,"range":{"start_line":165,"start_character":4,"end_line":165,"end_character":13},"updated":"2014-05-24 13:50:26.000000000","message":"i guess it should be named as do_instance_update","commit_id":"84de6ee1a0eff940aa770bcbf0c802424da21e85"}]}
