)]}'
{"troveclient/v1/instances.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bac6ee92a1afbf9092cb9237ee56f1f4e98aa8cc","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            print(\"slave_of \u003d %s\" % slave_of)"},{"line_number":78,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self._create(\"/instances\", body, \"instance\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_0bd05752","line":77,"updated":"2014-06-09 16:42:52.000000000","message":"This looks like a debug statement that wasn\u0027t removed?","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"fc2c6b0f63f9d7a37ec4d9487715240c17c410a2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            print(\"slave_of \u003d %s\" % slave_of)"},{"line_number":78,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self._create(\"/instances\", body, \"instance\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_133c0993","line":77,"in_reply_to":"1ae5cdf2_0bd05752","updated":"2014-06-09 17:10:58.000000000","message":"Done","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bac6ee92a1afbf9092cb9237ee56f1f4e98aa8cc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            print(\"slave_of \u003d %s\" % slave_of)"},{"line_number":78,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_b0bd0b05","line":78,"updated":"2014-06-09 16:42:52.000000000","message":"Should this be [\"slaveOf\"] or [\"slave_of\"] ?  I see there are both styles in the body, not sure which one is the \u0027correct\u0027 one...","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"fc2c6b0f63f9d7a37ec4d9487715240c17c410a2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            print(\"slave_of \u003d %s\" % slave_of)"},{"line_number":78,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_335825fa","line":78,"in_reply_to":"1ae5cdf2_b0bd0b05","updated":"2014-06-09 17:10:58.000000000","message":"Not sure - it does seem inconsistent. I\u0027m leaving \u0027slaveOf\u0027 for now, but curious what others think here.","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":5293,"name":"Nikhil","email":"SlickNik@gmail.com","username":"slicknik"},"change_message_id":"9b31c8c87f4ef5715864ed3a3bff4028e87e211f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_34f1d46a","line":77,"updated":"2014-06-10 08:03:53.000000000","message":"Any specific reason we\u0027re using slaveOf (i.e. camel case) here, instead of slave_of (underscore) which you use in other places (and which seems more standard, taking a quick glance around)?","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"aac858f9dd55b0da68d3e86ac7daf572cbd83eb6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_51602d35","line":77,"in_reply_to":"1ae5cdf2_34f1d46a","updated":"2014-06-10 10:01:48.000000000","message":"+1","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"c841cb7b2b0b6af9dc7cb46305ce76519c9d7a5f","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            body[\"instance\"][\"slaveOf\"] \u003d slave_of"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_f84836ce","line":77,"in_reply_to":"1ae5cdf2_34f1d46a","updated":"2014-06-10 12:23:54.000000000","message":"It seemed like we were using camelCase in REST bodies by convention, e.g. the \u0027flavorRef\u0027 vs \u0027flavor_id\u0027 above. \n\nBut I don\u0027t have a strong opinion either way and slave_of seems more consistent so will change it in both change sets.","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"f23336da89ea278a1b303a1913ad52379c426104","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            body[\"instance\"][\"slave_of\"] \u003d slave_of"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_97e2a0ff","line":77,"updated":"2014-06-10 12:47:47.000000000","message":"it does seem we use \u0027_\u0027 more, but flavorRef is used a lot too (that\u0027s the only camelcase I found).  That said, it good to standardize on something - I\u0027m good with \u0027_\u0027 too.","commit_id":"258b47b2a06915d17079a57a4243a8141ee50d71"},{"author":{"_account_id":6162,"name":"Dan Nguyen","email":"dan.nguyens.mail@gmail.com","username":"daniel-a-nguyen"},"change_message_id":"b3259c9eb5ba2b09090f49583a5a8afd2e014b0c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        if configuration:"},{"line_number":75,"context_line":"            body[\"instance\"][\"configuration\"] \u003d configuration"},{"line_number":76,"context_line":"        if slave_of:"},{"line_number":77,"context_line":"            body[\"instance\"][\"slave_of\"] \u003d slave_of"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        return self._create(\"/instances\", body, \"instance\")"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_0a649a47","line":77,"in_reply_to":"1ae5cdf2_97e2a0ff","updated":"2014-06-10 17:51:21.000000000","message":"Yeah I think flavorRef was the odd one :)","commit_id":"258b47b2a06915d17079a57a4243a8141ee50d71"}],"troveclient/v1/shell.py":[{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"bac6ee92a1afbf9092cb9237ee56f1f4e98aa8cc","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027Existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_70f8e3c4","line":224,"updated":"2014-06-09 16:42:52.000000000","message":"Maybe change to \u0027ID of existing ...\u0027 since all the other commands reference the ID.  Plus I\u0027ll bet it doesn\u0027t work with the name. ;)","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"fc2c6b0f63f9d7a37ec4d9487715240c17c410a2","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027Existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ae5cdf2_7371cd76","line":224,"in_reply_to":"1ae5cdf2_70f8e3c4","updated":"2014-06-09 17:10:58.000000000","message":"Agreed, done.","commit_id":"d58be19a8b87c78ce2910919c0e0c23eb296376b"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"a8944468ffd96d16a45be62e23f79aafa8964f04","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_b34d15c7","line":224,"updated":"2014-06-09 17:17:15.000000000","message":"Would it be better to use:\nID of existing master instance to replicate from\n?","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":8415,"name":"Denis M.","email":"lildee1991@gmail.com","username":"dmakogon"},"change_message_id":"aac858f9dd55b0da68d3e86ac7daf572cbd83eb6","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_31e00196","line":224,"in_reply_to":"1ae5cdf2_44ede98a","updated":"2014-06-10 10:01:48.000000000","message":"Help comment should be short i guess. What if\nhelp\u003d\u0027ID of existing instance to replicate from\u0027 ?","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"055fc5f28d5e88cbe617fed5443603d449deddd8","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_44ede98a","line":224,"in_reply_to":"1ae5cdf2_938579af","updated":"2014-06-09 18:38:17.000000000","message":"How about this?\n           help\u003d\u0027ID of existing instance from which to replicate. \u0027\n\t\t\u0027This instance will become a master (if it is not \u0027\n\t\t\u0027already) and the newly created instance a slave.\u0027)","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"a167673a7195edec0113a5aba71befd48745897c","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of existing instance from which to replicate.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ae5cdf2_938579af","line":224,"in_reply_to":"1ae5cdf2_b34d15c7","updated":"2014-06-09 18:26:57.000000000","message":"Yeah, I was considering that... \n\nMy rationale for not saying \u0027existing master\u0027 is that it implies something special about the instance -- that it is already a master. However you can point to any instance; and it is the action of adding the first slave that makes it a master.\n\nI\u0027m open to suggestions here, though.","commit_id":"7ffe2c0ed9719e0e91ed192713850fdcaed96ccf"},{"author":{"_account_id":9749,"name":"Greg Lucas","email":"greg@glucas.net","username":"glucas"},"change_message_id":"ea2134093730374d63aa6f52d73c9a60011b598f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of an existing instance to replicate from.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_9777003b","line":224,"updated":"2014-06-10 12:47:44.000000000","message":"Denis: I change the doc string as well. It is less grammatically correct but agree it is a bit clearer.","commit_id":"258b47b2a06915d17079a57a4243a8141ee50d71"},{"author":{"_account_id":10215,"name":"Peter Stachowski","email":"peter@tesora.com","username":"peterstac"},"change_message_id":"f23336da89ea278a1b303a1913ad52379c426104","unresolved":false,"context_lines":[{"line_number":221,"context_line":"@utils.arg(\u0027--slave_of\u0027,"},{"line_number":222,"context_line":"           metavar\u003d\u0027\u003cmaster_id\u003e\u0027,"},{"line_number":223,"context_line":"           default\u003dNone,"},{"line_number":224,"context_line":"           help\u003d\u0027ID of an existing instance to replicate from.\u0027)"},{"line_number":225,"context_line":"@utils.service_type(\u0027database\u0027)"},{"line_number":226,"context_line":"def do_create(cs, args):"},{"line_number":227,"context_line":"    \"\"\"Creates a new instance.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_777c3421","line":224,"updated":"2014-06-10 12:47:47.000000000","message":"I don\u0027t think there\u0027s any rule saying help should be short (in fact I would argue that more verbose help is often better).  But if it gets the idea across, then short is fine.  This works for me","commit_id":"258b47b2a06915d17079a57a4243a8141ee50d71"}]}